David Miller [mailto:da...@davemloft.net] > Sent: Saturday, January 04, 2014 9:38 AM > To: Hayeswang > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-...@vger.kernel.org > Subject: Re: [PATCH net-next] r8152: fix the wrong return value > > From: Hayes Wang <hayesw...@realtek.com> > Date: Fri, 3 Jan 2014 11:21:56 +0800 > > > The return value should be the boolean value, not the error code. > > > > Signed-off-by: Hayes Wang <hayesw...@realtek.com> > > Spotted-by: Dan Carpenter <dan.carpen...@oracle.com> > > Applied, but I agree with others that it's more canonical to have the > function return either an error code, or zero for success, rather than > a boolean.
Thanks. I would find if there is suitable error code. Best Regards, Hayes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
