Re: [PATCH] Fix the race between the fget() and close()

2013-08-30 Thread Al Viro
On Sat, Aug 31, 2013 at 05:53:11AM +, Liu, Chuansheng wrote: > I think I found one of possible race here(two processes P1 and P2): > P1 has the the files_struct pointer FILES1, P2 has the files_struct pointer > FILES2, > > When P1 open file, the new struct file pointer SHARE_FILE will be ins

[PATCH 2/3] driver: input: twl4030-vibra: fix missing of_node_put

2013-08-30 Thread Libo Chen
decrease node device_node refcount after task completion Signed-off-by: Libo Chen --- drivers/input/misc/twl4030-vibra.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/input/misc/twl4030-vibra.c b/drivers/input/misc/twl4030-vibra.c index 68a5f33..b8d1526 10

[PATCH 1/3] driver: input: 88pm860x-ts: fix missing of_node_put

2013-08-30 Thread Libo Chen
decrease np device_node refcount after task completion Signed-off-by: Libo Chen --- drivers/input/touchscreen/88pm860x-ts.c | 22 +++--- 1 files changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/input/touchscreen/88pm860x-ts.c b/drivers/input/touchscreen/88pm860

[PATCH 3/3] driver: input: twl6040-vibra: fix missing of_node_put

2013-08-30 Thread Libo Chen
decrease twl6040_core_node device_node refcount after task completion There are two ways to implement the function of_node_put through the marco CONFIG_OF_DYNAMIC, so it is save to call directly. Signed-off-by: Libo Chen --- drivers/input/misc/twl6040-vibra.c |3 +++ 1 files changed, 3 ins

Re: [PATCH 0/7] Drop support for Renesys H8/300 architecture

2013-08-30 Thread Geert Uytterhoeven
On Fri, Aug 30, 2013 at 9:37 PM, Guenter Roeck wrote: > On Fri, Aug 30, 2013 at 12:14:20PM -0700, Linus Torvalds wrote: >> On Fri, Aug 30, 2013 at 12:11 PM, Guenter Roeck wrote: >> > >> > I would not mind if Linus would agree to pull it right away for 3.12, >> > but that seems to be a bit on the

[PATCH 0/3] driver: input: fix missing of_node_put

2013-08-30 Thread Libo Chen
decrease np device_node refcount after task completion Libo Chen (3): driver: input: 88pm860x-ts: fix missing of_node_put driver: input: twl4030-vibra: fix missing of_node_put driver: input: twl6040-vibra: fix missing of_node_put drivers/input/misc/twl4030-vibra.c |4 +++- driver

Re: ipv4: warnings on sk_wmem_queued

2013-08-30 Thread Eric Wong
Eric Wong wrote: > I noticed these warnings on stock 3.10.9 running stress tests on > cmogstored.git (git://bogomips.org/cmogstored.git) doing standard > HTTP server stuff between lo and tmpfs: I'm still running the same test (in-place upgraded cmogstored a few times to fix some bugs), and haven'

Re: linux-next: build warning after merge of the tip tree

2013-08-30 Thread Ingo Molnar
* Andi Kleen wrote: > > > I've seen this pattern of deficient changelogs a dozen > > > times in your patches this year alone ... > > > > Ping? > > I've re-sent the patch already last week. hpa was on vacation, if he doesn't pick it up I'll apply it. > Some perf patches are also pending, the

[PATCH linux-next] Prevent a coredump with a large vm_map_count from Oopsing

2013-08-30 Thread Dan Aloni
A high setting of max_map_count, and a process core-dumping with a large enough vm_map_count could result in an NT_FILE note not being written, and the kernel crashing immediately later because it has assumed otherwise. Reproduction of the bug described here: https://lkml.org/lkml/2013/8/30/5

Re: [PATCH] btrfs: use list_for_each_entry_safe() when delete items

2013-08-30 Thread Azat Khuzhin
On Tue, Jul 30, 2013 at 7:40 AM, Miao Xie wrote: > On mon, 29 Jul 2013 11:48:32 +0400, Azat Khuzhin wrote: >> On Sat, Jul 27, 2013 at 2:12 PM, Azat Khuzhin wrote: >>> Replace list_for_each_entry() by list_for_each_entry_safe() in >>> __btrfs_close_devices() >>> >>> There is another place that del

Re: [PATCH v2 2/2] perf tools: add attr->mmap2 support

2013-08-30 Thread Ingo Molnar
* Stephane Eranian wrote: > False alarm, the changes in builtin-inject.c are in V2. Nothing more to > do. Sorry about the confusion. ok, I'll pick up the -v2 patches from Peter. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

RE: [PATCH] Fix the race between the fget() and close()

2013-08-30 Thread Liu, Chuansheng
Hello Al, > -Original Message- > From: Al Viro [mailto:v...@ftp.linux.org.uk] On Behalf Of Al Viro > Sent: Tuesday, August 27, 2013 8:49 AM > To: Liu, Chuansheng > Cc: Eric Dumazet; linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] Fix the race between the

Re: [REVIEW][PATCH 3/5] pidns: Don't have unshare(CLONE_NEWPID) imply CLONE_THREAD

2013-08-30 Thread Serge E. Hallyn
Quoting Eric W. Biederman (ebied...@xmission.com): > "Serge E. Hallyn" writes: > > > Quoting Eric W. Biederman (ebied...@xmission.com): > >> > >> I goofed when I made unshare(CLONE_NEWPID) only work in a > >> single-threaded process. There is no need for that requirement and in > >> fact I anal

Re: x86-32: Early microcode loading stumbles over disabled DYNAMIC_FTRACE

2013-08-30 Thread Steven Rostedt
On Sat, 31 Aug 2013 07:07:37 +0200 Borislav Petkov wrote: > On Fri, Aug 30, 2013 at 08:17:41PM -0400, Steven Rostedt wrote: > > On Fri, 30 Aug 2013 13:48:55 -0700 > > "H. Peter Anvin" wrote: > > > > > >> You *could* bail out of the calling address is < PAGE_OFFSET. > > > > > > Anyway... can we

Re: [PATCH 2/2] x86, apic: Disable BSP if boot cpu is AP

2013-08-30 Thread Borislav Petkov
On Thu, Aug 29, 2013 at 06:28:04PM +0900, HATAYAMA Daisuke wrote: > diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c > index 66cab35..fd969d1 100644 > --- a/arch/x86/kernel/apic/apic.c > +++ b/arch/x86/kernel/apic/apic.c > @@ -2113,13 +2113,29 @@ void disconnect_bsp_APIC(int v

[RFC][PATCH 06/18 v2] ftrace: Add rcu_unsafe_filter_functions file

2013-08-30 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" Since the RCU unsafe functions are no longer displayed by the available_filter_functions, we still need a way to see these functions in order to trace them. Create a new file that lists the functions that were declared RCU unsafe. Cc: Jiri Olsa Cc: Paul E. McKen

[RFC][PATCH 07/18 v2] ftrace: Add selftest to check if RCU unsafe functions are filtered properly

2013-08-30 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" Add a boot time start up test that has a RCU safe ftrace_ops as well as an unsafe one. Make sure the RCU safe ops can trace RCU unsafe functions while the unsafe ftrace_ops can not. Cc: Jiri Olsa Cc: Paul E. McKenney Signed-off-by: Steven Rostedt --- kernel/t

[RFC][PATCH 13/18 v2] ftrace: Disable the RCU unsafe checker when irqsoff is enabled

2013-08-30 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" The irqsoff tracer can be called during some of the RCU unsafe regions. The proble is that some of the internal calls that it makes may also be traced. For example, it uses spin locks. But if the spin lock gets traced and the RCU unsafe checker runs, it will trigg

[RFC][PATCH 11/18 v2] ftrace: Adde infrastructure to stop RCU unsafe checker from checking

2013-08-30 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" This is a light weight way to keep the rcu checker from checking RCU safety. It adds a ftrace_unsafe_rcu_checker_disable/enable() that increments or decrements a counter respectively. When the counter is set, the RCU unsafe checker callback does not run the tests

[RFC][PATCH 01/18 v2] ftrace: Add hash list to save RCU unsafe functions

2013-08-30 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" Some ftrace function tracing callbacks use RCU (perf), thus if it gets called from tracing a function outside of the RCU tracking, like in entering or leaving NO_HZ idle/userspace, the RCU read locks in the callback are useless. As normal function tracing does no

[RFC][PATCH 04/18 v2] ftrace: Add test for ops against unsafe RCU functions in callback

2013-08-30 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" When more than one ftrace_ops is registered, the list function is is used to call all registered functions. It uses the filter and notrace hashes from the ftrace_ops to determine if the corresponding callback should be called or not. Currently, it does not take i

[RFC][PATCH 03/18 v2] ftrace: Set ftrace internal function tracing RCU safe

2013-08-30 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" Since none of the internal ftrace function tracing uses RCU in their callbacks, it is OK to set the global_ops (the one that they all use) to RCU safe. Cc: Jiri Olsa Cc: Paul E. McKenney Signed-off-by: Steven Rostedt --- kernel/trace/ftrace.c |4 +++- 1 f

[RFC][PATCH 09/18 v2] ftrace: Fix a slight race in modifying what function callback gets traced

2013-08-30 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" There's a slight race when going from a list function to a non list function. That is, when only one callback is registered to the function tracer, it gets called directly by the mcount trampoline. But if this function has filters, it may be called by the wrong fu

[RFC][PATCH 08/18 v2] ftrace/rcu: Do not trace debug_lockdep_rcu_enabled()

2013-08-30 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" The function debug_lockdep_rcu_enabled() is part of the RCU lockdep debugging, and is called very frequently. I found that if I enable a lot of debugging and run the function graph tracer, this function can cause a live lock of the system. We don't usually trace

[RFC][PATCH 10/18 v2] ftrace: Create a RCU unsafe checker

2013-08-30 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" Knowing what functions are not safe to be traced by callbacks that use RCU read locks, is not easy to figure out. By adding a function tracer callback that is set as a non RCU safe callback that also uses rcu_read_lock() and enables PROVE_RCU, it can be used to fi

[RFC][PATCH 18/18 v2] ftrace/sched: Mark functions that are RCU unsafe

2013-08-30 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" Some callbacks of the function tracer use rcu_read_lock(). This means that there's places that can not be traced because RCU is not tracking the CPU for various reasons (like NO_HZ_FULL and coming back from userspace). Thes functions need to be marked so that cal

[RFC][PATCH 14/18 v2] ftrace/lockdep: Have the RCU lockdep splat show what function triggered

2013-08-30 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" When the RCU lockdep splat hits because of the unsafe RCU checker, the backtrace does not always show the culprit. But the culprit was passed to the unsafe RCU checker. Save the ip of the function being traced in a per_cpu variable, and when the RCU lockdep detec

[RFC][PATCH 15/18 v2] ftrace/rcu: Mark functions that are RCU unsafe

2013-08-30 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" Some callbacks of the function tracer use rcu_read_lock(). This means that there's places that can not be traced because RCU is not tracking the CPU for various reasons (like NO_HZ_FULL and coming back from userspace). Thes functions need to be marked so that cal

[RFC][PATCH 17/18 v2] ftrace/cpuidle/x86: Mark functions that are RCU unsafe

2013-08-30 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" Some callbacks of the function tracer use rcu_read_lock(). This means that there's places that can not be traced because RCU is not tracking the CPU for various reasons (like NO_HZ_FULL and coming back from userspace). Thes functions need to be marked so that cal

[RFC][PATCH 02/18 v2] ftrace: Do not set ftrace records for unsafe RCU when not allowed

2013-08-30 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" For the ftrace_ops that use RCU read locks, and can not be called by unsafe RCU functions (those outside of RCU tracking), have them not update the RCU unsafe function records when they are being registered or unregistered. The ftrace function records store a cou

[RFC][PATCH 05/18 v2] ftrace: Do not display non safe RCU functions in available_filter_functions

2013-08-30 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" As available_filter_functions file displays functions that are generally available for tracing, do not show the ones that are RCU unsafe. Otherwise it may be confusing for perf users to see these functions in this file but not be able to trace them. Cc: Jiri Olsa

[RFC][PATCH 16/18 v2] rcu/irq/x86: Mark functions that are RCU unsafe

2013-08-30 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" Some callbacks of the function tracer use rcu_read_lock(). This means that there's places that can not be traced because RCU is not tracking the CPU for various reasons (like NO_HZ_FULL and coming back from userspace). Thes functions need to be marked so that cal

[RFC][PATCH 00/18 v2] ftrace/rcu: Handle unsafe RCU functions and ftrace callbacks

2013-08-30 Thread Steven Rostedt
This is my final draft of the patches. I'm starting to run them through my formal tests now. They may change depending on the outcome of the tests. I'm also a bit tired, and I added the change logs last. Thus I may need to go back and fix the change logs up too. But the code was done when I was ra

[RFC][PATCH 12/18 v2] ftrace: Disable RCU unsafe checker when function graph is enabled

2013-08-30 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" Having the RCU unsafe checker running when function graph is enabled can cause a live lock. That's because the RCU unsafe checker enables full lockdep debugging on RCU which does a lot of interal calls that may be traced by the function graph tacer. This adds quit

Re: x86-32: Early microcode loading stumbles over disabled DYNAMIC_FTRACE

2013-08-30 Thread Borislav Petkov
On Fri, Aug 30, 2013 at 08:17:41PM -0400, Steven Rostedt wrote: > On Fri, 30 Aug 2013 13:48:55 -0700 > "H. Peter Anvin" wrote: > > > >> You *could* bail out of the calling address is < PAGE_OFFSET. > > > > Anyway... can we add this to the static tracing code? It is two > > instructions and is o

Re: [PATCH] Documentation/memory-barriers: fix a error that mistakes a CPU notion in Section Transitivity

2013-08-30 Thread Zhan Jianyu
Hi, Rob, thanks reviewing and I'm sorry for my careless writing. I resend the revised patch below: --- The memory-barriers document may has an error in Section TRANSITIVITY. For transitivity, see an example below, given that * CPU 2's load from X follows CPU 1's store to X, * CPU 2's load fr

Re: [PATCH] bcache: Fix a shrinker deadlock

2013-08-30 Thread Jens Axboe
On Fri, Aug 30 2013, Kent Overstreet wrote: > GFP_NOIO means we could be getting called recursively - mca_alloc() -> > mca_data_alloc() - definitely can't use mutex_lock(bucket_lock) then. > Whoops. Kent, can you provide and updated repo with the pending patches? There's been some churn here latel

Re: [PATCH] Documentation/memory-barriers: fix a error that mistakes a CPU notion in Section Transitivity

2013-08-30 Thread Rob Landley
On 08/27/2013 05:34:22 AM, larmbr wrote: The memory-barriers document may has a error in Section TRANSITIVITY. For transitivity, see a example below, given that * CPU 2's load from X follows CPU 1's store to X, and CPU 2's load from Y preceds CPU 3's store to Y. I'd prefer somebody with a b

[GIT PULL -v2] target fixes for v3.11

2013-08-30 Thread Nicholas A. Bellinger
Hi Linus, Here is a -v2 PULL request for the current set of target-pending fixes for v3.11. These fixes have not hit mainline yet, so I'm resending them now to be sure they hit v3.11 before the merge window opens. Please let me know if you have any concerns with the series. The original PULL re

Re: 3.11-rc7:BUG: soft lockup

2013-08-30 Thread Hillf Danton
On Fri, Aug 30, 2013 at 8:18 PM, Cong Wang wrote: > Cc'ing netdev > > On Fri, Aug 30, 2013 at 4:20 PM, Baoquan He wrote: >> Hi, >> >> I tried the 3.11.0-rc7+ on x86_64, and after bootup, the soft lockup bug >> happened. >> >> [ 48.895000] BUG: soft lockup - CPU#1 stuck for 22s! [ebtables:444] >

[PATCH-v5 3/6] vhost/scsi: Convert to per-cpu ida_alloc + ida_free command map

2013-08-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch changes vhost/scsi to use transport_init_session_tags() pre-allocation logic for per-cpu session tag pooling with internal ida_alloc() + ida_free() calls based upon the saved se_cmd->map_tag id. FIXME: Make transport_init_session_tags() number of tags setup co

[PATCH-v5 4/6] vhost/scsi: Add pre-allocation for tv_cmd SGL + upages memory

2013-08-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds support for pre-allocation of per tv_cmd descriptor scatterlist + user-space page pointer memory using se_sess->sess_cmd_map within tcm_vhost_make_nexus() code. This includes sanity checks within vhost_scsi_map_to_sgl() to reject I/O that exceeds these in

[PATCH-v5 0/6] target/vhost/iscsi: Add per-cpu ida tag pre-allocation for v3.12

2013-08-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi folks, This is an updated -v5 series for adding tag pre-allocation support of target fabric descriptor memory, utilizing Kent's latest per-cpu ida bits and incorporates akpm's last round of feedback. The full -v5 changelog is included below. The first patch is a sta

[PATCH-v5 5/6] iscsi/iser-target: Convert to command priv_size usage

2013-08-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This command converts iscsi/isert-target to use allocations based on iscsit_transport->priv_size within iscsit_allocate_cmd(), instead of using an embedded isert_cmd->iscsi_cmd. This includes removing iscsit_transport->alloc_cmd() usage, along with updating isert-target

[PATCH-v5 1/6] idr: Percpu ida

2013-08-30 Thread Nicholas A. Bellinger
From: Kent Overstreet Percpu frontend for allocating ids. With percpu allocation (that works), it's impossible to guarantee it will always be possible to allocate all nr_tags - typically, some will be stuck on a remote percpu freelist where the current job can't get to them. We do guarantee that

[PATCH-v5 6/6] iscsi-target: Convert to per-cpu ida_alloc + ida_free command map

2013-08-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch changes iscsi-target to use transport_alloc_session_tags() pre-allocation logic for per-cpu session tag pooling with internal ida_alloc() + ida_free() calls based upon the saved se_cmd->map_tag id. This includes tag pool setup based upon per NodeACL queue_dept

[PATCH-v5 2/6] target: Add transport_init_session_tags using per-cpu ida

2013-08-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds lib/idr.c based transport_init_session_tags() logic that allows fabric drivers to setup a per-cpu se_sess->sess_tag_pool and associated se_sess->sess_cmd_map for basic tagged pre-allocation of fabric descriptor sized memory. v5 changes: - Convert to per

Re: [PATCH v7 1/4] spinlock: A new lockref structure for lockless update of refcount

2013-08-30 Thread George Spelvin
Just noticing that you are adding several functions that return a boolean value as an int. And a "gotref" local variable. Is that just not wanting to bother with thse newfangled C99 innovations, or do you dislike the "bool" type for some reason? Even if it doesn't change the code in the slightes

Re: [PATCH] percpu ida: Switch to cpumask_t, add some comments

2013-08-30 Thread Nicholas A. Bellinger
On Wed, 2013-08-28 at 14:36 -0700, Andrew Morton wrote: > On Wed, 28 Aug 2013 14:23:58 -0700 Kent Overstreet wrote: > > > > I found things to be quite the opposite - it took 5 minutes of staring, > > > head-scratching, double-checking and penny-dropping before I was > > > confident that the newly

Re: [PATCH v7 1/4] spinlock: A new lockref structure for lockless update of refcount

2013-08-30 Thread Al Viro
On Sat, Aug 31, 2013 at 03:35:16AM +0100, Al Viro wrote: > Aha... OK, I see what's going on. We end up with shm_mnt *not* marked > as long-living vfsmount, even though it lives forever. See if the > following helps; if it does (and I very much expect it to), we want to > put it in -stable. As

Re: [PATCH v7 1/4] spinlock: A new lockref structure for lockless update of refcount

2013-08-30 Thread Al Viro
On Fri, Aug 30, 2013 at 10:02:36PM -0400, Waiman Long wrote: > I slapped in the code segment, and the following was logged: > > [ 340.871590] type = tmpfs > [ 340.871712] [] __fput+0x23d/0x270 > [ 340.871715] [] fput+0x9/0x10 > [ 340.871719] [] task_work_run+0xb1/0xe0 > [ 340.871724]

Re: [PATCH] i40e: Fix 32 bit shift compilation warnings

2013-08-30 Thread Jeff Kirsher
On Fri, 2013-08-30 at 18:47 -0700, Joe Perches wrote: > When dma_addr_t is a 32 bit value, >> 32 emits compiler warnings > Use ((addr>>16) >>16) to avoid this. > > I presume the macro should actually use the kernel.h > macro upper_32_bits() eventually. > > Signed-off-by: Joe Perches > --- > dri

Re: [PATCH 0/4] i40e: Neatening and object size reductions

2013-08-30 Thread Jeff Kirsher
On Fri, 2013-08-30 at 16:06 -0700, Joe Perches wrote: > Just some potential cleanings... > > Joe Perches (4): > i40e: Whitespace cleaning > i40e: Add and use pf_ > i40e: pf_ remove "%s: " ... __func__ > i40e: Convert pf_ macros to functions Thanks Joe, I will add these to my queue. sign

Re: [PATCH v7 1/4] spinlock: A new lockref structure for lockless update of refcount

2013-08-30 Thread Waiman Long
On 08/30/2013 04:48 PM, Al Viro wrote: On Fri, Aug 30, 2013 at 04:35:49PM -0400, Waiman Long wrote: The AIM7 test was run on a set of 16 ramdisk formated with ext3 filesystem with the following mount options: barrier=0,async,noatime,nodiratime. Maybe that is a factor. I would be really surpris

Re: [PATCH] scsi disk: Use its own buffer for the vpd request

2013-08-30 Thread Greg KH
On Fri, Aug 30, 2013 at 11:01:56AM +0100, Nix wrote: > On 1 Aug 2013, Bernd Schubert said: > > > Once I noticed that scsi_get_vpd_page() works fine from other function > > calls and that it is not 0x89, but already 0x0 that fails fixing it became > > easy. > > > > Nix, any chance you could verify

[PATCH] i40e: Fix 32 bit shift compilation warnings

2013-08-30 Thread Joe Perches
When dma_addr_t is a 32 bit value, >> 32 emits compiler warnings Use ((addr>>16) >>16) to avoid this. I presume the macro should actually use the kernel.h macro upper_32_bits() eventually. Signed-off-by: Joe Perches --- drivers/net/ethernet/intel/i40e/i40e_hmc.h | 2 +- drivers/net/ethernet/in

[PATCH] irq/of: Fix comment typo for irq_of_parse_and_map

2013-08-30 Thread Yijing Wang
Fix trivial comment typo for irq_of_parse_and_map(). Signed-off-by: Yijing Wang --- drivers/of/irq.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/of/irq.c b/drivers/of/irq.c index 1264923..1752988 100644 --- a/drivers/of/irq.c +++ b/drivers/of/irq.c @@ -28,7

Re: [PATCH v2] ARM: dts: add AM33XX EDMA support

2013-08-30 Thread Joel Fernandes
Hi Benoit, On 08/26/2013 03:36 AM, Benoit Cousson wrote: > - minus all the TI emails which are not working anymore :-( > > I've just sent my previous email too soon... > > Now the patch is different :-) I'll take that one. Unfortunately this patch is still missing from your latest pull request:

Re: [PATCH] [BUGFIX] crash/ioapic: Prevent crash_kexec() from deadlocking of ioapic_lock

2013-08-30 Thread Eric W. Biederman
Don Zickus writes: > On Tue, Aug 27, 2013 at 12:41:51PM +0900, Yoshihiro YUNOMAE wrote: >> Hi Don, >> >> Sorry for the late reply. >> >> (2013/08/22 22:11), Don Zickus wrote: >> >On Thu, Aug 22, 2013 at 05:38:07PM +0900, Yoshihiro YUNOMAE wrote: >> >>>So, I agree with Eric, let's remove the dis

Re: [PATCH] power: rx51_battery: Replace hardcoded channels values.

2013-08-30 Thread Anton Vorontsov
> This issue was introduced in commit: > power: rx51_battery: Replace hardcoded channels values. > > Original code use channel as argument which was shifted by one in function. > After mentioned commit argument is already shifted so we need to get index > back. > > Signed-off-by: Marek Belisko

Re: [PATCH 4/4] mm/arch: use NUMA_NODE

2013-08-30 Thread Jianguo Wu
Cc linux...@kvack.org On 2013/8/30 10:06, Jianguo Wu wrote: > Use more appropriate NUMA_NO_NODE instead of -1 in some archs' module_alloc() > > Signed-off-by: Jianguo Wu > --- > arch/arm/kernel/module.c|2 +- > arch/arm64/kernel/module.c |2 +- > arch/mips/kernel/module.c |2

Re: kernel deadlock

2013-08-30 Thread Stephen Boyd
On 08/30/13 16:10, John Stultz wrote: > On 08/30/2013 04:04 PM, Gerlando Falauto wrote: >> Hi, >> >> sorry, it took me a while to narrow it down... >> >> On 08/30/2013 01:45 AM, John Stultz wrote: >>> On 08/29/2013 01:56 PM, Falauto, Gerlando wrote: Hi everyone, I ran into the deadlo

Re: do_div() silently truncates "base" to 32bit

2013-08-30 Thread Anatol Pomozov
Hi, Joe On Fri, Aug 30, 2013 at 4:28 PM, Joe Perches wrote: > On Fri, 2013-08-30 at 15:48 -0700, Randy Dunlap wrote: >> On 08/30/13 15:14, Anatol Pomozov wrote: >> > But another question still remains: why compiler does not warn that >> > size truncation happens? How to prevent bugs like CFQ one

linux-next: Tree for Aug 30

2013-08-30 Thread Stephen Rothwell
Hi all, Sorry for the late announcement - I wrote a draft and then forgot to send it. Changes since 20130829: The sound tree gained a conflict against the drm tree. The driver-core tree gained a conflict against the pm tree. The dma-mapping tree gained a conflict against the kvm-ppc tree. The

Re: mutex warning in cpufreq + RFC patch

2013-08-30 Thread Rafael J. Wysocki
On Saturday, August 31, 2013 02:55:57 AM Rafael J. Wysocki wrote: > On Friday, August 30, 2013 05:36:41 PM Stephen Boyd wrote: > > On 08/29, Viresh Kumar wrote: > > > On 28 August 2013 22:22, Stephen Boyd wrote: > > > > > > > > I've applied these patches on top of v3.10 > > > > > > > > f51e1eb63d9

Re: mutex warning in cpufreq + RFC patch

2013-08-30 Thread Rafael J. Wysocki
On Friday, August 30, 2013 05:36:41 PM Stephen Boyd wrote: > On 08/29, Viresh Kumar wrote: > > On 28 August 2013 22:22, Stephen Boyd wrote: > > > > > > I've applied these patches on top of v3.10 > > > > > > f51e1eb63d9c28cec188337ee656a13be6980cfd (cpufreq: Fix cpufreq regression > > > after susp

Re: [PATCH 3/3] PM / hibernate / memory hotplug: Rework mutual exclusion

2013-08-30 Thread Rafael J. Wysocki
On Friday, August 30, 2013 06:35:12 PM Toshi Kani wrote: > On Sat, 2013-08-31 at 02:39 +0200, Rafael J. Wysocki wrote: > > On Friday, August 30, 2013 06:23:19 PM Toshi Kani wrote: > > > On Thu, 2013-08-29 at 23:18 +0200, Rafael J. Wysocki wrote: > > > > From: Rafael J. Wysocki > > > > > > > > Sin

Re: mutex warning in cpufreq + RFC patch

2013-08-30 Thread Stephen Boyd
On 08/29, Viresh Kumar wrote: > On 28 August 2013 22:22, Stephen Boyd wrote: > > > > I've applied these patches on top of v3.10 > > > > f51e1eb63d9c28cec188337ee656a13be6980cfd (cpufreq: Fix cpufreq regression > > after suspend/resume > > aae760ed21cd690fe8a6db9f3a177ad55d7e12ab (cpufreq: Revert

Re: [PATCH 3/3] PM / hibernate / memory hotplug: Rework mutual exclusion

2013-08-30 Thread Toshi Kani
On Sat, 2013-08-31 at 02:39 +0200, Rafael J. Wysocki wrote: > On Friday, August 30, 2013 06:23:19 PM Toshi Kani wrote: > > On Thu, 2013-08-29 at 23:18 +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > Since all of the memory hotplug operations have to be carried out > > >

Re: [PATCH 15/16] Add EFI stub for ARM

2013-08-30 Thread Roy Franz
On Fri, Aug 30, 2013 at 7:36 AM, Grant Likely wrote: > On Fri, 9 Aug 2013 16:26:16 -0700, Roy Franz wrote: >> This patch adds EFI stub support for the ARM Linux kernel. The EFI stub >> operations similarly to the x86 stub: it is a shim between the EFI firmware >> and the normal zImage entry poi

[REVIEW][PATCH] pidns: Fix hang in zap_pid_ns_processes by sending a potentially extra wakeup

2013-08-30 Thread Eric W. Biederman
Serge Hallyn writes: > Since commit af4b8a83add95ef40716401395b44a1b579965f4 it's been > possible to get into a situation where a pidns reaper is > , reparented to host pid 1, but never reaped. How to > reproduce this is documented at > > https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/11685

Re: [PATCH 3/3] PM / hibernate / memory hotplug: Rework mutual exclusion

2013-08-30 Thread Rafael J. Wysocki
On Friday, August 30, 2013 06:23:19 PM Toshi Kani wrote: > On Thu, 2013-08-29 at 23:18 +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Since all of the memory hotplug operations have to be carried out > > under device_hotplug_lock, they won't need to acquire pm_mutex if > > de

Re: [PATCH 3/3] PM / hibernate / memory hotplug: Rework mutual exclusion

2013-08-30 Thread Toshi Kani
On Thu, 2013-08-29 at 23:18 +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Since all of the memory hotplug operations have to be carried out > under device_hotplug_lock, they won't need to acquire pm_mutex if > device_hotplug_lock is held around hibernation. > > For this reason, m

Re: [PATCH 1/3] ACPI / scan: Change ordering of locks for device hotplug

2013-08-30 Thread Toshi Kani
On Thu, 2013-08-29 at 23:15 +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Change the ordering of device hotplug locks in scan.c so that > acpi_scan_lock is always acquired after device_hotplug_lock. > > This will make it possible to use device_hotplug_lock around some > code path

Re: x86-32: Early microcode loading stumbles over disabled DYNAMIC_FTRACE

2013-08-30 Thread Steven Rostedt
On Fri, 30 Aug 2013 13:48:55 -0700 "H. Peter Anvin" wrote: > >> You *could* bail out of the calling address is < PAGE_OFFSET. > > Anyway... can we add this to the static tracing code? It is two > instructions and is only needed on x86-32. For performance, use dynamic. Sure, do you want to add

Re: [PATCH v2 1/4] hotplug, x86: Fix online state in cpu0 debug interface

2013-08-30 Thread Rafael J. Wysocki
Hi Peter, Any objections here? On Thursday, August 29, 2013 06:22:06 PM Toshi Kani wrote: > _debug_hotplug_cpu() is a debug interface that puts cpu0 offline during > boot-up when CONFIG_DEBUG_HOTPLUG_CPU0 is set. After cpu0 is put offline > in this interface, however, /sys/devices/system/cpu/cpu

Re: [PATCH v3] dma: add driver for R-Car HPB-DMAC

2013-08-30 Thread Sergei Shtylyov
Hello. On 08/25/2013 12:33 AM, Sergei Shtylyov wrote: From: Max Filippov Add support for HPB-DMAC found in Renesas R-Car SoCs, using 'shdma-base' DMA driver framework. Based on the original patch by Phil Edworthy . Signed-off-by: Max Filippov [Sergei: removed useless #include, sorted

Please add git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git branch h8300-remove to linux-next

2013-08-30 Thread Guenter Roeck
Hi Stephen, Please add the h8300-remove branch of git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git to linux-next. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [git pull] drm fixes

2013-08-30 Thread Dave Airlie
On Sat, Aug 31, 2013 at 9:18 AM, Linus Torvalds wrote: > On Thu, Aug 29, 2013 at 4:08 PM, Dave Airlie wrote: >> >> ssh://people.freedesktop.org/~airlied/linux drm-fixes > > Please people! When you post ssh addresses, always remember to also > post your user name and password or private key with

[PATCH v2 6/8] Drop MAINTAINERS entry for H8/300

2013-08-30 Thread Guenter Roeck
The architecture is gone. Cc: Yoshinori Sato Acked-by: Greg Kroah-Hartman Signed-off-by: Guenter Roeck --- MAINTAINERS |8 1 file changed, 8 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8197fbd..62e513e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8482,14 +8482,6 @

[PATCH v2 5/8] watchdog: Drop references to H8300 architecture

2013-08-30 Thread Guenter Roeck
Architecture is gone. Cc: Yoshinori Sato Acked-by: Greg Kroah-Hartman Acked-by: Wim Van Sebroeck Signed-off-by: Guenter Roeck --- drivers/watchdog/Kconfig |2 -- drivers/watchdog/Makefile |2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog

[PATCH v2 8/8] fs/minix: Drop dependency on H8300

2013-08-30 Thread Guenter Roeck
The H8/300 architecture is gone. Drop dependencies on it. Cc: Yoshinori Sato Acked-by: Greg Kroah-Hartman Signed-off-by: Guenter Roeck --- fs/minix/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/minix/Kconfig b/fs/minix/Kconfig index 6624684..f2a0cfc 100644 -

[PATCH v2 7/8] Drop remaining references to H8/300 architecture

2013-08-30 Thread Guenter Roeck
With the architecture gone, any references to it are no longer needed. Cc: Yoshinori Sato Acked-by: Greg Kroah-Hartman Signed-off-by: Guenter Roeck --- include/uapi/linux/audit.h |1 - include/uapi/linux/elf-em.h |1 - 2 files changed, 2 deletions(-) diff --git a/include/uapi/linux/a

[PATCH v2 4/8] net/ethernet: Drop H8/300 Ethernet driver

2013-08-30 Thread Guenter Roeck
Architecture is gone, so this driver is no longer needed. Cc: Yoshinori Sato Acked-by: Greg Kroah-Hartman Acked-by: David S. Miller Signed-off-by: Guenter Roeck --- drivers/net/Space.c |3 +- drivers/net/ethernet/8390/Kconfig|7 - drivers/net/ethernet/8390/Makefil

[PATCH v2 3/8] net/ethernet: smsc9194: Drop conditional code for H8/300

2013-08-30 Thread Guenter Roeck
With the H8/300 architecture gone, this code is no longer necessary. Cc: Yoshinori Sato Acked-by: Greg Kroah-Hartman Acked-by: David S. Miller Signed-off-by: Guenter Roeck --- drivers/net/ethernet/smsc/smc9194.c | 24 1 file changed, 24 deletions(-) diff --git a/dr

[PATCH v2 0/8] Drop support for Renesas H8/300 architecture

2013-08-30 Thread Guenter Roeck
H8/300 has been dead for several years, the kernel for it has not compiled for ages, and recent versions of gcc for it are broken. It is time to drop support for it. Yes, I understand it is not that simple to drop an architecture, and it may need some discussion, but someone has to put a stake int

[PATCH v2 2/8] ide: Drop H8/300 driver

2013-08-30 Thread Guenter Roeck
Architecture is gone, so there is no need to keep its ide driver around. Cc: Yoshinori Sato Acked-by: Greg Kroah-Hartman Acked-by: David S. Miller Signed-off-by: Guenter Roeck --- drivers/ide/Kconfig |7 --- drivers/ide/Makefile|2 - drivers/ide/ide-h8300.c | 109

Re: [REVIEW][PATCH 3/5] pidns: Don't have unshare(CLONE_NEWPID) imply CLONE_THREAD

2013-08-30 Thread Eric W. Biederman
"Serge E. Hallyn" writes: > Quoting Eric W. Biederman (ebied...@xmission.com): >> >> I goofed when I made unshare(CLONE_NEWPID) only work in a >> single-threaded process. There is no need for that requirement and in >> fact I analyzied things right for setns. The hard requirement >> is for tas

Re: [PATCH 1/7] Drop support for Renesys H8/300 (h8300) architecture

2013-08-30 Thread Guenter Roeck
On 08/30/2013 04:01 PM, Sergei Shtylyov wrote: Hello. On 08/30/2013 08:40 PM, Guenter Roeck wrote: Subject typo: it's Renesas, not Renesys, according to the MAINTAINERS entry. Yes, I noticed. Will be fixed in the next version. Guenter -- To unsubscribe from this list: send the line "uns

Re: [PATCH V2 10/10] Add option to automatically enforce module signatures when in Secure Boot mode

2013-08-30 Thread Josh Boyer
On Fri, Aug 30, 2013 at 01:46:30PM -0700, H. Peter Anvin wrote: > On 08/29/2013 11:37 AM, Josh Boyer wrote: > >>setup_efi_pci(boot_params); > >> diff --git a/arch/x86/include/uapi/asm/bootparam.h > >> b/arch/x86/include/uapi/asm/bootparam.h > >> index c15ddaf..d35da96 100644 > >> --- a/arch/x8

Re: do_div() silently truncates "base" to 32bit

2013-08-30 Thread Joe Perches
On Fri, 2013-08-30 at 15:48 -0700, Randy Dunlap wrote: > On 08/30/13 15:14, Anatol Pomozov wrote: > > But another question still remains: why compiler does not warn that > > size truncation happens? How to prevent bugs like CFQ one in the > > future? Should we add a compile-time assert to do_div()

Re: [git pull] drm fixes

2013-08-30 Thread Linus Torvalds
On Thu, Aug 29, 2013 at 4:08 PM, Dave Airlie wrote: > > ssh://people.freedesktop.org/~airlied/linux drm-fixes Please people! When you post ssh addresses, always remember to also post your user name and password or private key with the pull request. Ok? Linus -- To unsubscribe

Re: [PATCH 12/16] Fix types in EFI calls to match EFI function definitions.

2013-08-30 Thread Roy Franz
On Fri, Aug 30, 2013 at 4:14 PM, Grant Likely wrote: > On Sat, Aug 31, 2013 at 12:12 AM, Roy Franz wrote: >> On Fri, Aug 30, 2013 at 6:39 AM, Grant Likely >> wrote: >>> I think you need some description in the commit text about why the type >>> of chunksize is changing. It's not clear why you'r

Re: [PATCH 12/16] Fix types in EFI calls to match EFI function definitions.

2013-08-30 Thread Grant Likely
On Sat, Aug 31, 2013 at 12:12 AM, Roy Franz wrote: > On Fri, Aug 30, 2013 at 6:39 AM, Grant Likely > wrote: >> I think you need some description in the commit text about why the type >> of chunksize is changing. It's not clear why you're making this change. >> It is a bug fix? > > The type was c

Re: [PATCH 12/16] Fix types in EFI calls to match EFI function definitions.

2013-08-30 Thread Roy Franz
On Fri, Aug 30, 2013 at 6:39 AM, Grant Likely wrote: > On Fri, 9 Aug 2013 16:26:13 -0700, Roy Franz wrote: >> EFI calls can made directly on ARM, so the function pointers >> are directly invoked. This allows types to be checked at >> compile time, so here we ensure that the parameters match >>

Re: kernel deadlock

2013-08-30 Thread John Stultz
On 08/30/2013 04:04 PM, Gerlando Falauto wrote: > Hi, > > sorry, it took me a while to narrow it down... > > On 08/30/2013 01:45 AM, John Stultz wrote: >> On 08/29/2013 01:56 PM, Falauto, Gerlando wrote: >>> Hi everyone, >>> >>> I ran into the deadlock situation reported at the bottom. >>> Actually

[PATCH 4/4] i40e: Convert pf_ macros to functions

2013-08-30 Thread Joe Perches
Reduces object size ~10KB by removing "%s: ", __func__ and using the %pf extension and __builtin_return_address(0) to emit the function name. $ size drivers/net/ethernet/intel/i40e/built-in.o* textdata bss dec hex filename 166271 36043 50032 252346 3d9ba drivers/net/eth

[PATCH 0/4] i40e: Neatening and object size reductions

2013-08-30 Thread Joe Perches
Just some potential cleanings... Joe Perches (4): i40e: Whitespace cleaning i40e: Add and use pf_ i40e: pf_ remove "%s: " ... __func__ i40e: Convert pf_ macros to functions drivers/net/ethernet/intel/i40e/i40e.h | 149 +-- drivers/net/ethernet/intel/i40e/i40e_common.c |

RE: [PATCH] pstore/ram: (really) fix undefined usage of rounddown_pow_of_two

2013-08-30 Thread Luck, Tony
>> Previous attempt to fix was b042e47491ba5f487601b5141a3f1d8582304170 >> >> Suggested use of is_power_of_2() was bogus because is_power_of_2(0) is >> false (documented behaviour). >> >> Signed-off-by: Maxime Bizon > > Yes, excellent point. :) > > Acked-by: Kees Cook Applied. Thanks. -Tony --

Re: kernel deadlock

2013-08-30 Thread Gerlando Falauto
Hi, sorry, it took me a while to narrow it down... On 08/30/2013 01:45 AM, John Stultz wrote: On 08/29/2013 01:56 PM, Falauto, Gerlando wrote: Hi everyone, I ran into the deadlock situation reported at the bottom. Actually, on my latest 3.10 kernel for some reason I don't get the report (the

  1   2   3   4   5   6   >