Re: [PATCH 4/5] x86_64 EFI support -v3: EFI framebuffer driver

2007-08-02 Thread Huang, Ying
On Wed, 2007-08-01 at 13:55 +0800, Antonino A. Daplas wrote: > On Tue, 2007-07-31 at 11:13 +0800, Huang, Ying wrote: > > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#in

Re: [linux-usb-devel] [PATCH] USB BIOS early handoff only when the we the driver is configured

2007-08-02 Thread David Engraf
Greg KH schrieb: > On Thu, Aug 02, 2007 at 10:32:21AM -0400, Alan Stern wrote: > >> On Thu, 2 Aug 2007, David Engraf wrote: >> >> >>> This would be solution too, but what if someone uses the uhci controller >>> and don't want the >>> ehci. So a single Kconfig flag wouldn't be enough, we hav

per bdi dirty balancing (was Re: kupdate weirdness)

2007-08-02 Thread Miklos Szeredi
(cc restored) > > > There were heaps of problems in there and it is surprising how few people > > > were hitting them. Ordered-mode journalling filesystems will fix it all > > > up > > > behind the scenes, of course. > > > > > > I just have a bad feeling about that code - list_heads are the wro

Re: [patch] add kdump_after_notifier

2007-08-02 Thread Keith Owens
Andrew Morton (on Thu, 2 Aug 2007 23:25:02 -0700) wrote: >On Fri, 03 Aug 2007 14:05:47 +1000 Keith Owens <[EMAIL PROTECTED]> wrote: Switching to [EMAIL PROTECTED], I just resigned from SGI. >> I have pretty well given up on RAS code in the Linux kernel. Everybody >> has different ideas, there is

Re: SD still better than CFS for 3d ?(was Re: 2.6.23-rc1)

2007-08-02 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > do you have any filesystem that is not reiserfs? If yes, could you, as > a test, check whether file activities on _that_ file system still > cause these lags, or is the lag purely connected to the reiser3 > filesystem? i still have little debug info

Re: [patch] add kdump_after_notifier

2007-08-02 Thread Andrew Morton
On Fri, 03 Aug 2007 14:05:47 +1000 Keith Owens <[EMAIL PROTECTED]> wrote: > I have pretty well given up on RAS code in the Linux kernel. Everybody > has different ideas, there is no overall plan and little interest from > Linus in getting RAS tools into the kernel. We are just thrashing. Lots o

Re: eurotechwdt will cause reboot

2007-08-02 Thread Wim Van Sebroeck
Hi Dave, > Hi, > News: 2.6.23-rc1-mm1 will reboot with eurotechwdt, but 2.6.23-rc1-mm2 > will not. do you need the config files? > > I will concentrate on this problem as well. Any hints how to debug? Yes: make a diff file between the two versions and see what has changed. If something changed o

Re: [linux-usb-devel] [PATCH] USB: Only enable autosuspend by default on certain device classes

2007-08-02 Thread David Brownell
On Thursday 02 August 2007, Matthew Garrett wrote: > The main > concern I have is that kernel developers just don't tend to be the sort > of people that use webcams, printers or scanners, so we're relying on > normal users to go to the effort of reporting that their device has > stopped working

Re: [linux-usb-devel] [PATCH] USB: Only enable autosuspend by default on certain device classes

2007-08-02 Thread David Brownell
On Thursday 02 August 2007, Alan Stern wrote: > Also, building something this sweeping into a kernel driver feels like > a mistake.  It ought to be more easily configurable from userspace, say > via a sysfs file. Yeah, I could have sworn there was extensive discussion over the creation of a sysfs

[patch] genirq: fix simple and fasteoi irq handlers

2007-08-02 Thread Jarek Poplawski
On Thu, Aug 02, 2007 at 10:11:26PM +0200, Ingo Molnar wrote: > > * Gabriel C <[EMAIL PROTECTED]> wrote: > > > I get a warning on each boot now with this patch .. > > > > [ 63.686613] WARNING: at kernel/irq/resend.c:70 check_irq_resend() ... > we are still trying to figure out what happens with

[GIT PULL] More sh updates for 2.6.23-rc2

2007-08-02 Thread Paul Mundt
Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/lethal/sh-2.6.23.git Which contains: David McCullough (1): sh: update snapgear defconfig. Magnus Damm (3): sh: update r2d defconfig sh: fix cf support on r2d boards sh: fix defconfigs for sh7751r board

Re: [rfc] balance-on-fork NUMA placement

2007-08-02 Thread Christoph Lameter
On Fri, 3 Aug 2007, Nick Piggin wrote: > Well what's wrong with it? It seems to use memory policies for exactly > what they are intended (aside from it being kernel directed...). Sure I think you could do it with some effort. They were primarily designed for user space. Lots of little side issue

Re: Distributed storage.

2007-08-02 Thread Manu Abraham
On 7/31/07, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > TODO list currently includes following main items: > * redundancy algorithm (drop me a request of your own, but it is highly > unlikley that Reed-Solomon based will ever be used - it is too slow > for distributed RAID, I

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Carlo Florendo
Guennadi Liakhovetski wrote: On Thu, 2 Aug 2007, Randy Dunlap wrote: C99 spec that Al referred you to (available for around US$18 as a pdf) says in 6.7.8, para. 14 (where Al said): "An array of character type may be initialized by a character string literal, optionally enclosed in braces. Suc

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Carlo Florendo
Guennadi Liakhovetski wrote: On Thu, 2 Aug 2007, Robert Hancock wrote: Because 5 characters will not fit in a 4 character array, even without the null terminator. On Fri, 3 Aug 2007, Stefan Richter wrote: How should gcc know whether you actually wanted that char foo[len] to contain a \0 as

Re: CFS review

2007-08-02 Thread Willy Tarreau
On Thu, Aug 02, 2007 at 09:31:19PM -0700, Arjan van de Ven wrote: > On Fri, 2007-08-03 at 06:18 +0200, Willy Tarreau wrote: > > On Thu, Aug 02, 2007 at 08:57:47PM -0700, Arjan van de Ven wrote: > > > On Thu, 2007-08-02 at 22:04 -0500, Matt Mackall wrote: > > > > On Wed, Aug 01, 2007 at 01:22:29PM +

Re: renaming kernel devices [was: VIA EPIA EK: strange eth dev numbering]

2007-08-02 Thread david
On Thu, 2 Aug 2007, Ondrej Zajicek wrote: On Thu, Aug 02, 2007 at 01:47:23PM +0200, Jan Engelhardt wrote: It does not rename ethX to the "next free" one, but to a _persistent_ one. If it were a "next free" thing, then removing a card would shuffle all your eth around again (and invalidate your

Re: CFS review

2007-08-02 Thread Matt Mackall
On Thu, Aug 02, 2007 at 08:57:47PM -0700, Arjan van de Ven wrote: > On Thu, 2007-08-02 at 22:04 -0500, Matt Mackall wrote: > > On Wed, Aug 01, 2007 at 01:22:29PM +0200, Ingo Molnar wrote: > > > > > > * Roman Zippel <[EMAIL PROTECTED]> wrote: > > > > > > > [...] e.g. in this example there are thre

Re: CFS review

2007-08-02 Thread Arjan van de Ven
On Fri, 2007-08-03 at 06:18 +0200, Willy Tarreau wrote: > On Thu, Aug 02, 2007 at 08:57:47PM -0700, Arjan van de Ven wrote: > > On Thu, 2007-08-02 at 22:04 -0500, Matt Mackall wrote: > > > On Wed, Aug 01, 2007 at 01:22:29PM +0200, Ingo Molnar wrote: > > > > > > > > * Roman Zippel <[EMAIL PROTECTED

Re: blackfin toolchain and build issues

2007-08-02 Thread Sam Ravnborg
On Fri, Aug 03, 2007 at 10:18:01AM +0800, Bryan Wu wrote: > > I will check this on my side ASAP. But the git-tree did not merge my > "fs.h" header file patch, how could it compiled passed like this? > I just inserted "#include in mm.h as a temporary workaround. I also had to deselect a few driv

Re: CFS review

2007-08-02 Thread Willy Tarreau
On Thu, Aug 02, 2007 at 08:57:47PM -0700, Arjan van de Ven wrote: > On Thu, 2007-08-02 at 22:04 -0500, Matt Mackall wrote: > > On Wed, Aug 01, 2007 at 01:22:29PM +0200, Ingo Molnar wrote: > > > > > > * Roman Zippel <[EMAIL PROTECTED]> wrote: > > > > > > > [...] e.g. in this example there are thre

Re: Distributed storage.

2007-08-02 Thread Mike Snitzer
On 7/31/07, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > Hi. > > I'm pleased to announce first release of the distributed storage > subsystem, which allows to form a storage on top of remote and local > nodes, which in turn can be exported to another storage as a node to > form tree-like storages.

[RFC] Handling kernel stack overflows

2007-08-02 Thread Keith Owens
First a bit of background for people who are not familiar with kernel stack constructs. * Every process has a dedicated kernel stack. In this context, 'process' includes user space processes and threads, plus those processes that only exist inside the kernel (e.g. kswapd, xfslogd). * When a

Re: [patch] add kdump_after_notifier

2007-08-02 Thread Keith Owens
Vivek Goyal (on Thu, 2 Aug 2007 16:58:52 +0530) wrote: >On Wed, Aug 01, 2007 at 04:00:48AM -0600, Eric W. Biederman wrote: >> Takenori Nagano <[EMAIL PROTECTED]> writes: >> >> >> No. The problem with your patch is that it doesn't have a code >> >> impact. We need to see who is using this and why

Re: CFS review

2007-08-02 Thread Arjan van de Ven
On Thu, 2007-08-02 at 22:04 -0500, Matt Mackall wrote: > On Wed, Aug 01, 2007 at 01:22:29PM +0200, Ingo Molnar wrote: > > > > * Roman Zippel <[EMAIL PROTECTED]> wrote: > > > > > [...] e.g. in this example there are three tasks that run only for > > > about 1ms every 3ms, but they get far more ti

Re: [NFSD OOPS] 2.6.23-rc1-git10

2007-08-02 Thread Neil Brown
On Thursday August 2, [EMAIL PROTECTED] wrote: > Hi, > > Got the following oopsen just now from 2.6.23-rc1-git10 on a 2 > processor Opteron with 2GB RAM. System is running 64bit Fedora Core 6. > > nfsd is exporting directories from a XFS filesystem on top a software > RAID 5 array comprising 3 x

Re: [linux-pm] Re: Hibernation considerations

2007-08-02 Thread david
On Wed, 1 Aug 2007, Pavel Machek wrote: Hi! Do we have to block module loading? No. Registering new drivers is okay, registering new devices is bad. Of course, some modules do want to register a new device in their init method. I don't know what we should do about them. Force the regist

Re: 2.6.22-rc1-mm1 huge pages VM freeze (maybe?)

2007-08-02 Thread Nish Aravamudan
On 8/1/07, Zan Lynx <[EMAIL PROTECTED]> wrote: > On Wed, 2007-08-01 at 08:52 -0700, Nish Aravamudan wrote: > > On 7/31/07, Zan Lynx <[EMAIL PROTECTED]> wrote: > > > On Tue, 2007-07-31 at 15:02 -0700, Randy Dunlap wrote: > > > > On Tue, 31 Jul 2007 15:44:21 -0600 Zan Lynx wrote: > > > > > > > > > I

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread WANG Cong
On Fri, Aug 03, 2007 at 08:47:56AM +0530, Satyam Sharma wrote: > > >On Thu, 2 Aug 2007, Jan Engelhardt wrote: > >> On Aug 2 2007 21:55, Guennadi Liakhovetski wrote: >> > [...] >> > >> >struct { >> >char c[4]; >> >int i; >> >} t; >> >t.i = 0x12345678; >> >strc

Re: [PATCH] retrieve VBE EDID/DDC info independent of used video mode

2007-08-02 Thread Antonino A. Daplas
On Thu, 2007-08-02 at 22:33 -0400, Daniel Drake wrote: > Antonino A. Daplas wrote: > > How about this patch? > > > > Tony > > --- > > > > Subject: video setup: Fix VBE DDC reading > > > > Add memory operand constraint and write-only modifier to the inline > > assembly to effect the writing of th

Re: [rfc] balance-on-fork NUMA placement

2007-08-02 Thread Nick Piggin
On Thu, Aug 02, 2007 at 06:34:04PM -0700, Christoph Lameter wrote: > On Fri, 3 Aug 2007, Nick Piggin wrote: > > > Yeah it only gets set if the parent is initially using a default policy > > at this stage (and then is restored afterwards of course). > > Uggh. Looks like more hackery ahead. I think

Re: eurotechwdt will cause reboot

2007-08-02 Thread Dave Young
>On 8/3/07, Dave Young <[EMAIL PROTECTED]> wrote: > >On 8/1/07, Dave Young <[EMAIL PROTECTED]> wrote: > > >On 8/1/07, Wim Van Sebroeck <[EMAIL PROTECTED]> wrote: > > > Hi Dave, > > > > > > > config eurotechwdt to yes will cause system silent reboot. Is it right > > > > behaviour or a bug? > > > > >

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Satyam Sharma
On Thu, 2 Aug 2007, Jan Engelhardt wrote: > On Aug 2 2007 21:55, Guennadi Liakhovetski wrote: > > [...] > > > > struct { > > char c[4]; > > int i; > > } t; > > t.i = 0x12345678; > > strcpy(t.c, c); > > > >and t.i is silently corrupted. Just wanted to ask i

Re: CFS review

2007-08-02 Thread Matt Mackall
On Wed, Aug 01, 2007 at 01:22:29PM +0200, Ingo Molnar wrote: > > * Roman Zippel <[EMAIL PROTECTED]> wrote: > > > [...] e.g. in this example there are three tasks that run only for > > about 1ms every 3ms, but they get far more time than should have > > gotten fairly: > > > > 4544 roman 20

Re: [NFS] rpc.mountd crashes when extensively using netgroups

2007-08-02 Thread Neil Brown
On Thursday August 2, [EMAIL PROTECTED] wrote: > > I started having a look at this today. The original patches that I > proposed to clean up the rmtab a few months ago also eliminated this > comma-delimited string. Neil had valid objections to it at the time, > but if we switched to using the IP a

2.6.23-rc1-mm2 + cpufreq patch -- inconsistent {in-hardirq-W} -> {hardirq-on-W} usage.

2007-08-02 Thread Miles Lane
I am running Ubuntu Gutsy with latest updates. When I run "/etc/init.d/networking stop" with my custom kernel, I get: = [ INFO: inconsistent lock state ] 2.6.23-rc1-mm2 #21 - inconsistent {in-hardirq-W} -> {hardirq-on-W} usage. ifconf

[NFSD OOPS] 2.6.23-rc1-git10

2007-08-02 Thread Andrew Clayton
Hi, Got the following oopsen just now from 2.6.23-rc1-git10 on a 2 processor Opteron with 2GB RAM. System is running 64bit Fedora Core 6. nfsd is exporting directories from a XFS filesystem on top a software RAID 5 array comprising 3 x 250GB SATA disks using the sata_sil driver. Amongst other th

Re: [linux-usb-devel] [PATCH] USB: Only enable autosuspend by default on certain device classes

2007-08-02 Thread Alan Stern
On Fri, 3 Aug 2007, Matthew Garrett wrote: > On Thu, Aug 02, 2007 at 06:15:05PM -0700, Greg KH wrote: > > > Well, if you do this, then you can pretty much delete the whole quirk > > table we have, right? > > At the moment, yes. > > > And personally, I want to do better than Windows XP when it c

[PATCH] mtd: Makefile fix (was Re: [PATCH] mtdsuper: licensce = GPL)

2007-08-02 Thread Satyam Sharma
Hi, On Thu, 2 Aug 2007, Rafał Bilski wrote: > [...] > CC drivers/mtd/chips/chipreg.mod.o > LD [M] drivers/mtd/chips/chipreg.ko > CC drivers/mtd/devices/block2mtd.mod.o > LD [M] drivers/mtd/devices/block2mtd.ko > CC drivers/mtd/mtd_blkdevs.mod.o > LD [M] drivers/mtd/mtd_bl

Re: [PATCH] retrieve VBE EDID/DDC info independent of used video mode

2007-08-02 Thread Daniel Drake
Antonino A. Daplas wrote: How about this patch? Tony --- Subject: video setup: Fix VBE DDC reading Add memory operand constraint and write-only modifier to the inline assembly to effect the writing of the EDID block to boot_params.edid_info. Thanks, this patch works in that Linux now report

Re: rpc.mountd crashes when extensively using netgroups

2007-08-02 Thread Satyam Sharma
Hi, On Thu, 2 Aug 2007, Stefan Walter wrote: > Steve Dickson wrote: > > Stefan Walter wrote: > >> > >> We do this on a much larger scale though. The bug we ran into is > >> in line 96 in utils/mountd/auth.c. The strcpy can corrupt > >> memory when it copies the string returned by client_compose(

Re: blackfin toolchain and build issues

2007-08-02 Thread Bryan Wu
On Thu, 2007-08-02 at 21:44 +0200, Sam Ravnborg wrote: > > > > > Oh, do you need use blackfin toolchain? Actually, it is very simple to > > setup it on your machine. > > please get the latest binary toolchain here: > > http://blackfin.uclinux.org/gf/download/frsrelease/344/3180/blackfin-toolchain-

Re: eurotechwdt will cause reboot

2007-08-02 Thread Dave Young
>On 8/1/07, Dave Young <[EMAIL PROTECTED]> wrote: > >On 8/1/07, Wim Van Sebroeck <[EMAIL PROTECTED]> wrote: > > Hi Dave, > > > > > config eurotechwdt to yes will cause system silent reboot. Is it right > > > behaviour or a bug? > > > > I think this might be a bug. I'll look at the code and will ask

patch usb-u132-hcd.c-fix-a-warning-when-config_pm-n.patch added to gregkh-2.6 tree

2007-08-02 Thread gregkh
This is a note to let you know that I've just added the patch titled Subject: USB: u132-hcd.c - Fix a warning when CONFIG_PM=n to my gregkh-2.6 tree. Its filename is usb-u132-hcd.c-fix-a-warning-when-config_pm-n.patch This tree can be found at http://www.kernel.org/pub/linux/ke

Re: [PATCH] USB: Only enable autosuspend by default on certain device classes

2007-08-02 Thread Matthew Garrett
On Thu, Aug 02, 2007 at 06:15:05PM -0700, Greg KH wrote: > Well, if you do this, then you can pretty much delete the whole quirk > table we have, right? At the moment, yes. > And personally, I want to do better than Windows XP when it comes to > power management. This patch is only going to sus

Re: [rfc] balance-on-fork NUMA placement

2007-08-02 Thread Christoph Lameter
On Fri, 3 Aug 2007, Nick Piggin wrote: > Yeah it only gets set if the parent is initially using a default policy > at this stage (and then is restored afterwards of course). Uggh. Looks like more hackery ahead. I think this cannot be done in the desired clean way until we have some revving of th

Problem with USB Gadget Filesystem

2007-08-02 Thread Park Sangsu
Hi, everyone. Now I'm developing USB Mass Storage App with GadgetFS(drivers/usb/gadget/inode.c). (linux kernel version is 2.6.17. We ported it to arm(s5c7329). The target board is now FPGA board. USB chip is 3884-0 DWC USB 2.0 HS OTG of Synopsys.) But, when plug in USB to Desktop PC(Win xp pro), ke

Re: [rfc] balance-on-fork NUMA placement

2007-08-02 Thread Nick Piggin
On Thu, Aug 02, 2007 at 06:02:56PM -0700, Christoph Lameter wrote: > On Fri, 3 Aug 2007, Nick Piggin wrote: > > > > Ok. So MPOL_BIND on a single node. We would have to save the current > > > memory policy on the stack and then restore it later. Then you would need > > > a special call anyways. >

Re: [PATCH] USB: Only enable autosuspend by default on certain device classes

2007-08-02 Thread Greg KH
On Fri, Aug 03, 2007 at 12:56:13AM +0100, Matthew Garrett wrote: > We're seeing a large number of problems with devices not appreciating > USB autosuspend, especially printers and scanners. According to > http://www.microsoft.com/whdc/system/bus/USB/USBFAQ_intro.mspx only a > subset of drivers s

Re: [rfc] balance-on-fork NUMA placement

2007-08-02 Thread Christoph Lameter
On Fri, 3 Aug 2007, Nick Piggin wrote: > > Ok. So MPOL_BIND on a single node. We would have to save the current > > memory policy on the stack and then restore it later. Then you would need > > a special call anyways. > > Well the memory policy will already be set to MPOL_BIND at this point. >

Re: [rfc] balance-on-fork NUMA placement

2007-08-02 Thread Nick Piggin
On Thu, Aug 02, 2007 at 05:52:28PM -0700, Christoph Lameter wrote: > On Fri, 3 Aug 2007, Nick Piggin wrote: > > > > Add a (slow) kmalloc_policy? Strict Object round robin for interleave > > > right? It probably needs its own RR counter otherwise it disturbs the per > > > task page RR. > > > > I

Re: [rfc] balance-on-fork NUMA placement

2007-08-02 Thread Christoph Lameter
On Fri, 3 Aug 2007, Nick Piggin wrote: > > Add a (slow) kmalloc_policy? Strict Object round robin for interleave > > right? It probably needs its own RR counter otherwise it disturbs the per > > task page RR. > > I guess interleave could be nice for other things, but for this, I > just want MPO

Re: [PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach())

2007-08-02 Thread Christoph Lameter
Mempools do not want to wait if there is an allocation failure. Its like GFP_THISNODE in that we want a failure. I had to add a if (NUMA_BUILD && (gfp_mask & GFP_THISNODE) == GFP_THISNODE) goto nopage; in page_alloc.c to make GFP_THISNODE fail. Maybe add a GFP_FAIL and check fo

Re: [rfc] balance-on-fork NUMA placement

2007-08-02 Thread Nick Piggin
On Thu, Aug 02, 2007 at 12:58:13PM -0700, Christoph Lameter wrote: > On Thu, 2 Aug 2007, Nick Piggin wrote: > > > > It does in the sense that slabs are allocated following policies. If you > > > want to place individual objects then you need to use kmalloc_node(). > > > > Is there no way to plac

Re: [PATCH] 2.6.23-rc1-mm1 - fix missing numa_zonelist_order sysctl

2007-08-02 Thread KAMEZAWA Hiroyuki
On Thu, 02 Aug 2007 11:07:38 -0400 Lee Schermerhorn <[EMAIL PROTECTED]> wrote: > Of course, I don't have any idea of what is a "reasonable amount". > Guess I could look at non-movable zone memory usage in a system at > typical or peak load to get an idea. Anyone have any data in this > regard? >

Re: [rfc] balance-on-fork NUMA placement

2007-08-02 Thread Nick Piggin
On Thu, Aug 02, 2007 at 11:33:39AM -0700, Martin Bligh wrote: > Nick Piggin wrote: > >On Wed, Aug 01, 2007 at 03:52:11PM -0700, Martin Bligh wrote: > >>>And so forth. Initial forks will balance. If the children refuse to > >>>die, forks will continue to balance. If the parent starts seeing short

Re: [2.6 patch] mm/migrate.c: cleanups

2007-08-02 Thread KAMEZAWA Hiroyuki
On Thu, 2 Aug 2007 11:43:21 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: > On Thu, 2 Aug 2007, Yasunori Goto wrote: > > > But, this patch is the cause of compile error of memory unplug code of > > 2.6.23-rc1-mm2. It uses putback_lru_pages(). > > Don't make it static please... :-( >

Re: lmbench ctxsw regression with CFS

2007-08-02 Thread Nick Piggin
On Thu, Aug 02, 2007 at 05:44:47PM +0200, Ingo Molnar wrote: > > * Nick Piggin <[EMAIL PROTECTED]> wrote: > > > > > > One thing to check out is whether the lmbench numbers are > > > > > "correct". Especially on SMP systems, the lmbench numbers are > > > > > actually *best* when the two processe

Re: [ck] Re: ck vs. cfs : realtime audio performance

2007-08-02 Thread Carlo Florendo
Martin Steigerwald wrote: Am Donnerstag 02 August 2007 schrieb Martin Steigerwald: The tone I see on responses to posts that are CCed to LKML in my perception often is just completely and utterly awfully unfriendly. And often those responses actual include factual inaccuracies and preliminary a

Re: REGRESSION: serial_cs broken by 8250 changes

2007-08-02 Thread Yinghai Lu
Andrew Morton wrote: On Thu, 02 Aug 2007 16:24:42 -0700 Yinghai Lu <[EMAIL PROTECTED]> wrote: Daniel Ritz wrote: commit 18a8bd949d6adb311ea816125ff65050df1f3f6e breaks serial_cs badly with an oops, completely killing PCMCIA. register_console() now calls console->early_setup(). which in case o

[PATCH] USB: Only enable autosuspend by default on certain device classes

2007-08-02 Thread Matthew Garrett
We're seeing a large number of problems with devices not appreciating USB autosuspend, especially printers and scanners. According to http://www.microsoft.com/whdc/system/bus/USB/USBFAQ_intro.mspx only a subset of drivers support it in Windows XP, meaning that most devices are probably untested

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Jakub Jelinek
On Thu, Aug 02, 2007 at 09:55:51PM +0200, Guennadi Liakhovetski wrote: > I've run across the following gcc "feature": > > char c[4] = "01234"; > > gcc emits a nice warning > > warning: initializer-string for array of chars is too long > > But do a > > char c[4] = "0123"; > > and -

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Rene Herman
On 08/03/2007 01:26 AM, Guennadi Liakhovetski wrote: On Thu, 2 Aug 2007, Randy Dunlap wrote: C99 spec that Al referred you to (available for around US$18 as a pdf) says in 6.7.8, para. 14 (where Al said): "An array of character type may be initialized by a character string literal, optionall

Re: REGRESSION: serial_cs broken by 8250 changes

2007-08-02 Thread Andrew Morton
On Thu, 02 Aug 2007 16:24:42 -0700 Yinghai Lu <[EMAIL PROTECTED]> wrote: > Daniel Ritz wrote: > > commit 18a8bd949d6adb311ea816125ff65050df1f3f6e breaks serial_cs badly > > with an oops, completely killing PCMCIA. > > > > register_console() now calls console->early_setup(). which in case of > > 8

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Guennadi Liakhovetski
On Fri, 3 Aug 2007, Al Viro wrote: > It doesn't change the fact that use of c[4] or strlen(c) or strcpy(..., c) > means nasal demon country for you. Haha, funny. You, certainly, may think whatever you want, I'm anyway greatful to you and to all the rest for the trouble you took to find THE quot

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Stefan Richter
Al Viro wrote: > On Fri, Aug 03, 2007 at 12:51:16AM +0200, Guennadi Liakhovetski wrote: >> On Fri, 3 Aug 2007, Stefan Richter wrote: >> >>> Guennadi Liakhovetski wrote: with char c[4] = "012345"; the compiler warns, but actually allocates a 6-byte long array... >>> Off-t

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Guennadi Liakhovetski
On Thu, 2 Aug 2007, Randy Dunlap wrote: > C99 spec that Al referred you to (available for around US$18 as a pdf) > says in 6.7.8, para. 14 (where Al said): > > "An array of character type may be initialized by a character string literal, > optionally > enclosed in braces. Successive characters o

Re: [PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach())

2007-08-02 Thread Jesper Juhl
On 03/08/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Fri, 3 Aug 2007 01:10:02 +0200 > "Jesper Juhl" <[EMAIL PROTECTED]> wrote: > > > > > So, where do we go from here? > > > > > > Where I said ;) Add a new __GFP_ flag which suppresses the warning, add > > > that flag to known-to-be-OK callsite

Re: CFS review

2007-08-02 Thread Roman Zippel
Hi, On Wed, 1 Aug 2007, Linus Torvalds wrote: > So I think it would be entirely appropriate to > > - do something that *approximates* microseconds. > >Using microseconds instead of nanoseconds would likely allow us to do >32-bit arithmetic in more areas, without any real overflow. Th

Re: REGRESSION: serial_cs broken by 8250 changes

2007-08-02 Thread Yinghai Lu
Daniel Ritz wrote: commit 18a8bd949d6adb311ea816125ff65050df1f3f6e breaks serial_cs badly with an oops, completely killing PCMCIA. register_console() now calls console->early_setup(). which in case of 8250.c (the only user anyway) is serial8250_console_early_setup() which is __init, calling 8250

Re: [PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach())

2007-08-02 Thread Andrew Morton
On Fri, 3 Aug 2007 01:10:02 +0200 "Jesper Juhl" <[EMAIL PROTECTED]> wrote: > > > So, where do we go from here? > > > > Where I said ;) Add a new __GFP_ flag which suppresses the warning, add > > that flag to known-to-be-OK callsites, such as mempool_alloc(). > > > Ok, I'll try to play around with

Re: REGRESSION: serial_cs broken by 8250 changes

2007-08-02 Thread Andrew Morton
On Fri, 3 Aug 2007 01:06:32 +0200 Daniel Ritz <[EMAIL PROTECTED]> wrote: > commit 18a8bd949d6adb311ea816125ff65050df1f3f6e breaks serial_cs badly > with an oops, completely killing PCMCIA. > > register_console() now calls console->early_setup(). which in case of > 8250.c (the only user anyway) is

Re: 2.6.23-rc1-git3 init failure

2007-08-02 Thread Sid Boyce
Michal Piotrowski wrote: Hi Sid, On 29/07/07, Sid Boyce <[EMAIL PROTECTED]> wrote: > Boot failure on x86_64 (64X2), says it can't find init, specifically > /init. 2.6.23-rc1-git1 boots and runs successfully. I haven't tried > -git2. I shall reboot on 2.6.23-rc1-git3 tomorrow and record th

[PATCH 1/2] hysdn: convert to PCI hotplug API

2007-08-02 Thread Jeff Garzik
This patch has been committed to the 'hysdn' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git commit b025c86cba3bb9fd7218ce6e8a60f0c65b414d0c Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Thu Aug 2 18:51:14 2007 -0400 [ISDN] hysdn: convert to PCI hotplug API

[PATCH 2/2] hysdn: fix SMP brokenness

2007-08-02 Thread Jeff Garzik
This patch has been committed to the 'hysdn' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git commit 4ef2632c0fdf4598cf6a417f39514257ecbb2ba2 Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Thu Aug 2 19:08:10 2007 -0400 [ISDN] hysdn: fix SMP brokenness Si

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Al Viro
On Fri, Aug 03, 2007 at 12:51:16AM +0200, Guennadi Liakhovetski wrote: > On Fri, 3 Aug 2007, Stefan Richter wrote: > > > Guennadi Liakhovetski wrote: > > > with > > > > > > char c[4] = "012345"; > > > > > > the compiler warns, but actually allocates a 6-byte long array... > > > > Off-topic he

Re: [PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach())

2007-08-02 Thread Jesper Juhl
On 03/08/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Fri, 3 Aug 2007 00:53:44 +0200 > Jesper Juhl <[EMAIL PROTECTED]> wrote: > > > On Thursday 02 August 2007 10:20:47 Jesper Juhl wrote: > > > On 02/08/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > > [snip] > > > > y'know, we could have a debu

REGRESSION: serial_cs broken by 8250 changes

2007-08-02 Thread Daniel Ritz
commit 18a8bd949d6adb311ea816125ff65050df1f3f6e breaks serial_cs badly with an oops, completely killing PCMCIA. register_console() now calls console->early_setup(). which in case of 8250.c (the only user anyway) is serial8250_console_early_setup() which is __init, calling 8250_early.c:serial8250_f

Re: [PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach())

2007-08-02 Thread Andrew Morton
On Fri, 3 Aug 2007 00:53:44 +0200 Jesper Juhl <[EMAIL PROTECTED]> wrote: > On Thursday 02 August 2007 10:20:47 Jesper Juhl wrote: > > On 02/08/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > [snip] > > > y'know, we could have a debug option which will spit warnings if someone > > > does a !__GFP_WA

Re: scripts/mod/file2alias.c cross compile problem

2007-08-02 Thread Adrian Bunk
On Fri, Aug 03, 2007 at 08:08:20AM +1000, Rusty Russell wrote: >... > scripts/mod/file2alias is the program that reads this: although it can > be altered to parse 32-vs-64, Adrian's fix is the simplest. s/Adrian/Thomas/ > Hope that clarifies, > Rusty. cu Adrian -- "Is there not promise

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Al Viro
On Thu, Aug 02, 2007 at 03:54:34PM -0700, Randy Dunlap wrote: > > > > And, Stefan, there is a perfect way to specify a "0123" without the '\0' - > > {'0', '1', '2', '3'}. > > We are actually a bit beyond traditional K&R, fwiw. Not in that area - this behaviour is precisely what traditional K&R

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Al Viro
On Fri, Aug 03, 2007 at 12:36:40AM +0200, Guennadi Liakhovetski wrote: > On Thu, 2 Aug 2007, Robert Hancock wrote: > > > Because 5 characters will not fit in a 4 character array, even without the > > null terminator. > > On Fri, 3 Aug 2007, Stefan Richter wrote: > > > How should gcc know whether

Re: [PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach())

2007-08-02 Thread Jesper Juhl
On Thursday 02 August 2007 10:20:47 Jesper Juhl wrote: > On 02/08/07, Andrew Morton <[EMAIL PROTECTED]> wrote: [snip] > > y'know, we could have a debug option which will spit warnings if someone > > does a !__GFP_WAIT allocation while !in_atomic() (only works if > > CONFIG_PREEMPT). > > > > But ple

Re: [PATCH]: PCI Error Recovery: Symbios SCSI device driver

2007-08-02 Thread Linas Vepstas
On Thu, Jul 05, 2007 at 12:54:06PM -0600, Matthew Wilcox wrote: > On Thu, Jul 05, 2007 at 11:28:38AM -0700, Andrew Morton wrote: > > Well you've sent it a couple of times, and I've sent it in five more times > > over the past year. Once we were told "awaiting maintainer ack". > > > > This situati

Re: [RFC, PATCH] handle the multi-threaded init's exit() properly

2007-08-02 Thread Roland McGrath
This looks fine to me, though I don't know anything about the nsproxy bit. Now that choose_new_parent is one trivial line, you might go on to get rid of it and roll its one line into reparent_thread. Thanks, Roland - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Guennadi Liakhovetski
On Fri, 3 Aug 2007, Stefan Richter wrote: > Guennadi Liakhovetski wrote: > > with > > > > char c[4] = "012345"; > > > > the compiler warns, but actually allocates a 6-byte long array... > > Off-topic here, but: sizeof c / sizeof *c == 4. Don't think it is OT here - kernel depends on gcc.

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Randy Dunlap
On Fri, 3 Aug 2007 00:36:40 +0200 (CEST) Guennadi Liakhovetski wrote: > On Thu, 2 Aug 2007, Robert Hancock wrote: > > > Because 5 characters will not fit in a 4 character array, even without the > > null terminator. > > On Fri, 3 Aug 2007, Stefan Richter wrote: > > > How should gcc know whether

Re: VIA EPIA EK: strange eth dev numbering

2007-08-02 Thread Kay Sievers
On Fri, 2007-08-03 at 00:39 +0200, Jan Engelhardt wrote: > On Aug 3 2007 00:00, Kay Sievers wrote: > >On 8/2/07, Jan Engelhardt <[EMAIL PROTECTED]> wrote: > >> I know I have seen my kernel outputting "A renamed to B". Since you two > >> however wanted that information in the first place, I grepped

Re: [REGRESSION] tg3 dead after s2ram

2007-08-02 Thread Michael Chan
On Thu, 2007-08-02 at 15:06 -0700, David Miller wrote: > From: "Michael Chan" <[EMAIL PROTECTED]> > Date: Thu, 02 Aug 2007 12:10:29 -0700 > > > Alternatively, we can also fix it by calling pci_enable_device() again > > in tg3_open(). But I think it is better to just always save and restore > > in

(off-topic) Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Stefan Richter
Guennadi Liakhovetski wrote: > Robert, Stefan, I am sorry, I think, you are VERY wrong here. You meant to say "C99 is very wrong". > And, Stefan, there is a perfect way to specify a "0123" without the '\0' - > {'0', '1', '2', '3'}. C99 says char c[4] = "0123"; is a perfect way to say char c[4]

Re: ICH8 CF timeout (regression)...

2007-08-02 Thread Mark Lord
Daniel J Blueman wrote: On 02/08/07, Tejun Heo <[EMAIL PROTECTED]> wrote: Daniel J Blueman wrote: I'll grab kernel logs from the legacy ATA boot; what else can help debug this issue? No problem testing patches too. Yeap, please post the old log. Not much actually - perhaps I need to enable s

Re: VIA EPIA EK: strange eth dev numbering

2007-08-02 Thread Jan Engelhardt
On Aug 3 2007 00:00, Kay Sievers wrote: >On 8/2/07, Jan Engelhardt <[EMAIL PROTECTED]> wrote: >> I know I have seen my kernel outputting "A renamed to B". Since you two >> however wanted that information in the first place, I grepped a bit >> around, and actually found, (drumroll), that the SUSE k

Re: CFS review

2007-08-02 Thread Roman Zippel
Hi, On Thu, 2 Aug 2007, Ingo Molnar wrote: > Most importantly, CFS _already_ includes a number of measures that act > against too frequent math. So even though you can see 64-bit math code > in it, it's only rarely called if your clock has a low resolution - and > that happens all automaticall

Re: [PATCH] do_sigaction: remove now unneeded recalc_sigpending()

2007-08-02 Thread Roland McGrath
> With the recent changes, do_sigaction()->recalc_sigpending_and_wake() can > never clear TIF_SIGPENDING. Instead, it can set this flag and wake up the > thread without any reason. Harmless, but unneeded and wastes CPU. > > Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]> ACK. (We agreed months

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Guennadi Liakhovetski
On Thu, 2 Aug 2007, Robert Hancock wrote: > Because 5 characters will not fit in a 4 character array, even without the > null terminator. On Fri, 3 Aug 2007, Stefan Richter wrote: > How should gcc know whether you actually wanted that char foo[len] to > contain a \0 as last element? Robert, Ste

[PATCH] do_sigaction: remove now unneeded recalc_sigpending()

2007-08-02 Thread Oleg Nesterov
With the recent changes, do_sigaction()->recalc_sigpending_and_wake() can never clear TIF_SIGPENDING. Instead, it can set this flag and wake up the thread without any reason. Harmless, but unneeded and wastes CPU. Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]> --- t/kernel/signal.c~ 2007-08-03

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Stefan Richter
Guennadi Liakhovetski wrote: > with > > char c[4] = "012345"; > > the compiler warns, but actually allocates a 6-byte long array... Off-topic here, but: sizeof c / sizeof *c == 4. -- Stefan Richter -=-=-=== =--- ---== http://arcgraph.de/sr/ - To unsubscribe from this list: send the l

[PATCH] debugfs helper for decimal challenged

2007-08-02 Thread Robin Getz
From: Robin Getz <[EMAIL PROTECTED]> Allows debugfs helper functions to have a hex output, rather than just decimal Signed-off-by: Robin Getz <[EMAIL PROTECTED]> --- fs/debugfs/file.c | 36 include/linux/debugfs.h | 27 ++

Re: mmap behavior on out-of-space conditions

2007-08-02 Thread David Chinner
On Thu, Aug 02, 2007 at 03:06:15PM +0200, Peter Zijlstra wrote: > On Thu, 2007-08-02 at 14:41 +0200, Petr Tesarik wrote: > > Hello, > > > > while solving a different issue, my colleague Libor Pechacek found a > > problem with handling mmapped sparse files. If you mmap the hole insidea > > sparse f

Re: [PATCH] debugfs helper for decimal challenged

2007-08-02 Thread Robin Getz
On Thu 2 Aug 2007 17:09, Greg KH pondered: > On Wed, Aug 01, 2007 at 11:13:51PM -0400, Robin Getz wrote: > > From: Robin Getz <[EMAIL PROTECTED]> > > > > Allows debugfs helper functions to have a hex output, rather than just > decimal > > > > Signed-off-by: Robin Getz <[EMAIL PROTECTED]> > > --

  1   2   3   4   5   >