Re: Why kmem_cache_free occupy CPU for more than 10 seconds?

2007-04-10 Thread Pekka Enberg
On 4/11/07, Zhao Forrest <[EMAIL PROTECTED]> wrote: We're using RHEL5 with kernel version 2.6.18-8.el5. When doing a stress test on raw device for about 3-4 hours, we found the soft lockup message in dmesg. I know we're not reporting the bug on the latest kernel, but does any expert know if this

Re: [-mm3 patch]Warning fix: check the return value of kobject_add etc.

2007-04-10 Thread WANG Cong
On Wed, Apr 11, 2007 at 02:23:49PM +0800, Fengguang Wu wrote: >On Sun, Apr 01, 2007 at 02:20:46PM +0800, Cong WANG wrote: >> 2007/4/1, Andrew Morton <[EMAIL PROTECTED]>: >> > >> >Also, please always prepare patches in `patch -p1' form, as per >> >http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.

Re: [-mm3 PATCH] (Retry) Check the return value of kobject_add and etc.

2007-04-10 Thread WANG Cong
On Tue, Apr 10, 2007 at 03:18:15PM -0700, Andrew Morton wrote: >On Tue, 10 Apr 2007 22:08:29 +0800 >WANG Cong <[EMAIL PROTECTED]> wrote: > >> Since kobject_add, sysfs_create_link and sysfs_create_file are marked as >> '__must_check', we must always check their return values. >> > >Your mail cl

Re: link error : 2.6.21-rc6-mm1 for s390

2007-04-10 Thread Andrew Morton
On Tue, 10 Apr 2007 22:11:01 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > diff --git a/arch/s390/lib/Makefile b/arch/s390/lib/Makefile > index 7a44fed..59aea65 100644 > --- a/arch/s390/lib/Makefile > +++ b/arch/s390/lib/Makefile > @@ -5,6 +5,6 @@ > EXTRA_AFLAGS := -traditional > > lib

Re: [PATCH 6/13] maps#2: Move the page walker code to lib/

2007-04-10 Thread Nick Piggin
Matt Mackall wrote: Move the page walker code to lib/ This lets it get shared outside of proc/ and linked in only when needed. Still should go into mm/ If it had, you might have also noticed your pagetable walking code is completely different from how everyone else does it, and fixed that too

Re: [PATCH 0/4] hard_smp_processor_id overhaul (v.2)

2007-04-10 Thread Simon Horman
On Wed, Apr 04, 2007 at 05:51:07PM +0900, Fernando Luis Vázquez Cao wrote: > This new version (v.2) fixes generic arch i386 up build, has (hopefully) > clearer explanations, and does not break git bisect searches. > --- > With the advent of kdump, the assumption that the boot CPU when running > an

Re: [-mm3 patch]Warning fix: check the return value of kobject_add etc.

2007-04-10 Thread Fengguang Wu
On Sun, Apr 01, 2007 at 02:20:46PM +0800, Cong WANG wrote: > 2007/4/1, Andrew Morton <[EMAIL PROTECTED]>: > > > >Also, please always prepare patches in `patch -p1' form, as per > >http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt, thanks. > > > > > > Sorry. I am confused with this. Does that

Re: Doc for your Adaptive ReadAhead patch

2007-04-10 Thread Fengguang Wu
On Wed, Apr 11, 2007 at 04:44:34AM +, Jin Steve wrote: > Just like the function check_ra_success: (Does it mean: last time > RA>VM_MAX_CACHE_HIT, so next time no need readahead?) The cache hit logic is to prevent doing pointless readahead for an already cached file: the pages are already ther

[patch] uninline remove/add_parent() APIs

2007-04-10 Thread Ingo Molnar
here's a (tested) patch i did that should simplify changes done to p->children and p->sibling handling. Ingo --> Subject: [patch] uninline remove/add_parent() APIs From: Ingo Molnar <[EMAIL PROTECTED]> uninline/simplify remove/add_parent() APIs. Signed-off-by: Ingo

Why kmem_cache_free occupy CPU for more than 10 seconds?

2007-04-10 Thread Zhao Forrest
Hi, We're using RHEL5 with kernel version 2.6.18-8.el5. When doing a stress test on raw device for about 3-4 hours, we found the soft lockup message in dmesg. I know we're not reporting the bug on the latest kernel, but does any expert know if this is the known issue in old kernel? Or why kmem_ca

Re: [PATCH 1/13] fs: convert core functions to zero_user_page

2007-04-10 Thread Nate Diller
On 4/10/07, Andrew Morton <[EMAIL PROTECTED]> wrote: On Tue, 10 Apr 2007 20:36:00 -0700 Nate Diller <[EMAIL PROTECTED]> wrote: > It's very common for file systems to need to zero part or all of a page, the > simplist way is just to use kmap_atomic() and memset(). There's actually a > library fu

Re: [QUICKLIST 1/4] Quicklists for page table pages V5

2007-04-10 Thread Benjamin Herrenschmidt
On Wed, 2007-04-11 at 15:41 +1000, Paul Mackerras wrote: > Benjamin Herrenschmidt writes: > > > > > For a 64K page size kernel, we have 3 level page tables and we use 3 > > > > caches: a PGD pages are 128 bytes (yeah, not big heh...), our pmd > > > > pages are 32K (half a page) and PTE pages are P

Re: [patch 2/8] [Intel IOMMU] Some generic search functions required to lookup device relationships.

2007-04-10 Thread Shaohua Li
On Tue, 2007-04-10 at 06:03 -0700, Greg KH wrote: > On Tue, Apr 10, 2007 at 04:11:38PM +0800, Shaohua Li wrote: > > On Mon, 2007-04-09 at 20:46 -0700, Greg KH wrote: > > > On Mon, Apr 09, 2007 at 02:55:54PM -0700, Ashok Raj wrote: > > > > +/* > > > > + * find the upstream PCIE-to-PCI bridge of a PC

[patch] Broadcom 2045

2007-04-10 Thread Jeff Hansen
Here's a patch that enables the necessary SCO work-around for the Broadcom 2045 chip, which comes in the most recent IOGear dongles. -Jeff Hansen --- "If someone's gotta do it, it might as well be me." [EMAIL PROTECTED]diff --git a

Re: [PATCH 13/13] fs: deprecate memclear_highpage_flush

2007-04-10 Thread Andrew Morton
On Tue, 10 Apr 2007 20:36:00 -0700 Nate Diller <[EMAIL PROTECTED]> wrote: > Now that all the in-tree users are converted over to zero_user_page(), > deprecate the old memclear_highpage_flush() call. > > Signed-off-by: Nate Diller <[EMAIL PROTECTED]> > > --- > > diff -urpN -X dontdiff linux-2.6.

Re: [PATCH 1/13] fs: convert core functions to zero_user_page

2007-04-10 Thread Andrew Morton
On Tue, 10 Apr 2007 20:36:00 -0700 Nate Diller <[EMAIL PROTECTED]> wrote: > It's very common for file systems to need to zero part or all of a page, the > simplist way is just to use kmap_atomic() and memset(). There's actually a > library function in include/linux/highmem.h that does exactly tha

Re: [PATCH 0/30] Use menuconfig objects

2007-04-10 Thread Robert P. J. Day
On Wed, 11 Apr 2007, Adrian Bunk wrote: > On Wed, Apr 11, 2007 at 12:09:01AM +0200, Jan Engelhardt wrote: > > > > On Apr 11 2007 00:04, Stefan Richter wrote: > > > > > >[...] I tried one of the patches > > > - with make xconfig: OK > > > - with make gconfig: OK > > > - with make menuconfig: les

Re: [QUICKLIST 1/4] Quicklists for page table pages V5

2007-04-10 Thread Paul Mackerras
Benjamin Herrenschmidt writes: > > > For a 64K page size kernel, we have 3 level page tables and we use 3 > > > caches: a PGD pages are 128 bytes (yeah, not big heh...), our pmd > > > pages are 32K (half a page) and PTE pages are PAGE_SIZE (64K). > > > > Ok so use quicklists for the PTEs and slab

Re: [PATCH] NET: [UPDATED] Multiqueue network device support implementation.

2007-04-10 Thread Patrick McHardy
Waskiewicz Jr, Peter P wrote: >>This leaks the device. You treat every single-queue device as >>having a single subqueue. If it doesn't get too ugly it would >>be nice to avoid this and only allocate the subqueue states >>for real multiqueue devices. > > > We went back and forth on this. The

Re: [KJ] remove SPIN_LOCK_UNLOCKED

2007-04-10 Thread Robert P. J. Day
On Tue, 10 Apr 2007, Matthew Wilcox wrote: > On Tue, Apr 10, 2007 at 05:45:07PM -0400, Robert P. J. Day wrote: > > that works fine if you're defining a single spinlock, but what do you > > do in cases like this: > > > > arch/sparc/lib/atomic32.c: [0 ... (ATOMIC_HASH_SIZE-1)] = > > SPIN_LOCK_

[PATCH] kthread: Don't depend on work queues

2007-04-10 Thread Eric W. Biederman
Currently there is a circular reference between work queue initialization and kthread initialization. This prevents the kernel thread infrastructure from initializing until after work queues have been initialized. For kernel threads we want something that is as close as possible to the init_tas

Re: PATCH 7/8] lguest: the block driver

2007-04-10 Thread Pekka Enberg
On 4/11/07, Rusty Russell <[EMAIL PROTECTED]> wrote: What a question! end_request() doesn't end a request! What a crazy idea! Aah, indeed, end_request() uses req->hard_cur_sectors while end_entire_request() uses req->hard_nr_sectors which I missed. On 4/11/07, Rusty Russell <[EMAIL PROTECTED

Re: 2.6.21-rc6-mm1

2007-04-10 Thread Stephane Eranian
Venki, On Tue, Apr 10, 2007 at 05:15:14PM -0700, Venki Pallipadi wrote: > > > x86-64 expects all idle handlers to enable interrupts before returning > > > from > > > idle handler. This is due to enter_idle(), exit_idle() races. Make > > > cpuidle_idle_call() confirm to this when there is no pm_id

Re: [patch] convert aio event reap to use atomic-op instead of spin_lock

2007-04-10 Thread Andrew Morton
On Tue, 10 Apr 2007 16:53:53 -0700 (PDT) [EMAIL PROTECTED] (Ken Chen) wrote: > + } while (head != cmpxchg(&ring->head, head, head + 1)); A hasty grep indicates that only 14 out of 23 architectures implement cmpxchg(). - To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: link error : 2.6.21-rc6-mm1 for s390

2007-04-10 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Tue, 10 Apr 2007 18:47:38 -0700 > attribute(weak) would give a nicer result? > > We'd also need to remove s390's EXPORT_SYMBOL(__div64_32), so s390 ends up > using lib/div64.c's EXPORT_SYMBOL(). Ok, here is the version of the fix I'll use for now: c

Re: [PATCH] h8300 trivial conversion to GENERIC_TIME

2007-04-10 Thread Andrew Morton
On Wed, 11 Apr 2007 12:35:33 +0900 Yoshinori Sato <[EMAIL PROTECTED]> wrote: > At Tue, 10 Apr 2007 16:25:00 -0700, > john stultz wrote: > > > > Here is a trivial conversion of the h8300 arch to the GENERIC_TIME > > infrastructure (h8300 does not have better then jiffies resolution, so > > there a

Re: [patch 2/8] [Intel IOMMU] Some generic search functions required to lookup device relationships.

2007-04-10 Thread Greg KH
On Wed, Apr 11, 2007 at 09:40:36AM +0800, Shaohua Li wrote: > On Tue, 2007-04-10 at 06:03 -0700, Greg KH wrote: > > On Tue, Apr 10, 2007 at 04:11:38PM +0800, Shaohua Li wrote: > > > On Mon, 2007-04-09 at 20:46 -0700, Greg KH wrote: > > > > On Mon, Apr 09, 2007 at 02:55:54PM -0700, Ashok Raj wrote:

Re: [PATCH 17/30] Use menuconfig objects - IPVS

2007-04-10 Thread Simon Horman
On Tue, Apr 10, 2007 at 11:25:59PM +0200, Jan Engelhardt wrote: > > Use menuconfigs instead of menus, so the whole menu can be disabled at > once instead of going through all options. > > Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> This seems to work fine to me. Signed-off-by: Sim

Re: is there any generic GPIO chip framework like IRQ chips?

2007-04-10 Thread David Brownell
On Tuesday 10 April 2007 4:11 pm, Paul Sokolovsky wrote: > > > /* defined by the platform using array, if/else/..., IDR, or > > whatever */ > > struct gpio_yyy *gpio_to_yyy(unsigned gpio); > >I assume by "platform" you mean CPU architecture. Nope. ARM (v4, v5, v6, etc) is a

Re: [PATCH 3/7] Containers (V8): Add generic multi-subsystem API to containers

2007-04-10 Thread Srivatsa Vaddagiri
[ Sorry abt piece meal reviews, I am sending comments as and when I spot something ] On Fri, Apr 06, 2007 at 04:32:24PM -0700, [EMAIL PROTECTED] wrote: > -void container_exit(struct task_struct *tsk) > +void container_exit(struct task_struct *tsk, int run_callbacks) > { [snip] > + /* Reassi

Re: 2.6.21-rc6-mm1 build error with mips

2007-04-10 Thread Stuart Longland
Mathieu Desnoyers wrote: > Hi Andrew, > > I get the following error when compiling 2.6.21-rc6-mm1 for MIPS : > > > > /opt/crosstool/gcc-3.4.5-glibc-2.3.6/mips-unknown-linux-gnu/bin/mips-unknown-linux-gnu-gcc > -Wp,-MD,arch/mips/sgi-ip22/.ip22-time.o.d -nostdinc -isystem > /opt/crosstool/gc

Re: [PATCH 3/7] Containers (V8): Add generic multi-subsystem API to containers

2007-04-10 Thread Srivatsa Vaddagiri
On Fri, Apr 06, 2007 at 04:32:24PM -0700, [EMAIL PROTECTED] wrote: > -int cpuset_create(struct container *cont) > +int cpuset_create(struct container_subsys *ss, struct container *cont) Minor nit: The static declaration for cpuset_create (and friends) can be re-introduced, since they won't be acce

Re: [PATCH 0/30] Use menuconfig objects

2007-04-10 Thread Al Boldi
Jan Engelhardt wrote: > On Apr 11 2007 01:12, Al Boldi wrote: > >Jan Engelhardt wrote: > >> the following patch series turns some menus into menuconfigs, so they > >> can be disabled whilst "walking" thorugh the parent menu > > > >Great, but instead of making it a simple on/off, make it tri-state t

[PATCH] make MADV_FREE lazily free memory

2007-04-10 Thread Rik van Riel
Make it possible for applications to have the kernel free memory lazily. This reduces a repeated free/malloc cycle from freeing pages and allocating them, to just marking them freeable. If the application wants to reuse them before the kernel needs the memory, not even a page fault will happen.

[PATCH 14/14 UPDATED] sysfs: kill unnecessary attribute->owner

2007-04-10 Thread Tejun Heo
sysfs is now completely out of driver/module lifetime game. After deletion, a sysfs node doesn't access anything outside sysfs proper, so there's no reason to hold onto the attribute owners. Note that often the wrong modules were accounted for as owners leading to accessing removed modules. This

Re: [PATCH 14/14] sysfs: kill unnecessary attribute->owner

2007-04-10 Thread Tejun Heo
Cornelia Huck wrote: > On Tue, 10 Apr 2007 16:17:06 +0200, > Cornelia Huck <[EMAIL PROTECTED]> wrote: > >> You missed some s390 attributes :) Yeap, I used allyesconfig on x86 to do the patch, so attrs on other archs are not there. I'll merge this patch and post the updated version. Thanks. --

Re: [QUICKLIST 1/4] Quicklists for page table pages V5

2007-04-10 Thread Benjamin Herrenschmidt
On Tue, 2007-04-10 at 21:04 -0700, Christoph Lameter wrote: > On Tue, 10 Apr 2007, Benjamin Herrenschmidt wrote: > > > On Mon, 2007-04-09 at 11:25 -0700, Christoph Lameter wrote: > > > > > Quicklists for page table pages V5 > > > > Looks interesting, but unfortunately not very useful at this poi

Re: [PATCH] [KERNEL-DOC] generate main index page when building 'htmldocs'

2007-04-10 Thread Randy Dunlap
On Wed, 11 Apr 2007 01:44:22 +0200 Borislav Petkov wrote: > Here's a patch for kernel-doc that enables the generation of a global, > TOC-like index.html > page after building 'htmldocs' > > Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> Acked-by: Randy Dunlap <[EMAIL PROTECTED]> Nice idea

Re: [PATCHSET #master] sysfs: make sysfs disconnect immediately on deletion, take 2

2007-04-10 Thread Tejun Heo
Cornelia Huck wrote: > On Mon, 9 Apr 2007 13:18:46 +0900, > Tejun Heo <[EMAIL PROTECTED]> wrote: > >> With all the patches applied, the same test used in the last take ran >> 9+hrs without any problem. > > I get the following on startup: > > = > [ BUG: bad unl

[PATCH 12/14 UPDATED] sysfs: implement sysfs_dirent active reference and immediate disconnect

2007-04-10 Thread Tejun Heo
[PATCH] sysfs: implement sysfs_dirent active reference and immediate disconnect Opening a sysfs node references its associated kobject, so userland can arbitrarily prolong lifetime of a kobject which complicates lifetime rules in drivers. This patch implements active reference and makes the assoc

Re: [PATCH 5/13] ext4: use zero_user_page

2007-04-10 Thread Andreas Dilger
On Apr 10, 2007 20:36 -0700, Nate Diller wrote: > Use zero_user_page() instead of open-coding it. > > Signed-off-by: Nate Diller <[EMAIL PROTECTED]> > To: Andrew Morton <[EMAIL PROTECTED]>, >Alexander Viro <[EMAIL PROTECTED]> >Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.

Re: [PATCH] Clean up x86 control register and MSR macros (corrected)

2007-04-10 Thread Rusty Russell
On Tue, 2007-04-10 at 10:36 -0700, H. Peter Anvin wrote: > This patch is based on Rusty's recent cleanup of the EFLAGS-related > macros; it extends the same kind of cleanup to control registers and > MSRs. Thanks hpa, this looks nice. Cheers, Rusty. - To unsubscribe from this list: send the lin

Re: [PATCH] Clean up x86 control register and MSR macros

2007-04-10 Thread Rusty Russell
On Tue, 2007-04-10 at 10:31 -0700, H. Peter Anvin wrote: > Jeremy Fitzhardinge wrote: > > > > Is having separate bit numbers and masks useful? If so, is it worth > > doing for the others? > > > > I presume it's useful, or at least *used* in the current code, since > that was there already. If

Re: [KJ] remove SPIN_LOCK_UNLOCKED

2007-04-10 Thread Milind Arun Choudhary
On 4/11/07, Matthew Wilcox <[EMAIL PROTECTED]> wrote: On Tue, Apr 10, 2007 at 05:45:07PM -0400, Robert P. J. Day wrote: > that works fine if you're defining a single spinlock, but what do you > do in cases like this: > > arch/sparc/lib/atomic32.c: [0 ... (ATOMIC_HASH_SIZE-1)] = SPIN_LOCK_UN

Re: [PATCH 3/3] reparent kernel threads to swapper

2007-04-10 Thread Eric W. Biederman
Oleg Nesterov <[EMAIL PROTECTED]> writes: > A lot of kernel threads parented to /sbin/init slow down do_wait() when > a non-detached (user-space) process exits. Change reparent_kthread() to > use init_task as a parent. Since init_task can't go away, we don't need > to put the caller on init_task.c

Re: [QUICKLIST 1/4] Quicklists for page table pages V5

2007-04-10 Thread Christoph Lameter
On Tue, 10 Apr 2007, Benjamin Herrenschmidt wrote: > On Mon, 2007-04-09 at 11:25 -0700, Christoph Lameter wrote: > > > Quicklists for page table pages V5 > > Looks interesting, but unfortunately not very useful at this point for > powerpc unless you remove the assumption that quicklists contain

Re: I give up

2007-04-10 Thread Gene Heskett
On Tuesday 10 April 2007, Phillip Susi wrote: >Gene Heskett wrote: >> YOU Tell the tar people, they are flabbergasted that linux is >> apparently the only unstable OS that tar can be run on. > >How about cygwin/windows? It has no concept of static device numbers. >And what about external usb disks

Re: I give up

2007-04-10 Thread Gene Heskett
On Tuesday 10 April 2007, H. Peter Anvin wrote: >Gene Heskett wrote: >> I haven't seen any 200GB for $55 yet, more like $129 & maybe a rebate >> at Circuit City. We don't have a Fry's around here. > >Fry's: >http:/http://shop1.outpost.com/product/4697788?site=sr:SEARCH:MAIN_RSLT_ >PG > >500 GB SAT

Re: [PATCH] Improve heuristic detecting sequential reads

2007-04-10 Thread WU Fengguang
On Tue, Apr 10, 2007 at 04:45:40PM -0700, Andrew Morton wrote: > On 11 Apr 2007 00:56:51 +0200 > Andi Kleen <[EMAIL PROTECTED]> wrote: > > > There's a much more complete patchkit for this that gets reposted > > regularly on l-k. Perhaps it would make sense to test that first? > > adaptive readahe

Re: PATCH 7/8] lguest: the block driver

2007-04-10 Thread Rusty Russell
On Tue, 2007-04-10 at 14:36 +0300, Pekka Enberg wrote: > On 4/10/07, Rusty Russell <[EMAIL PROTECTED]> wrote: > > > +/* Jens gave me this nice helper to end all chunks of a request. */ > > > +static void end_entire_request(struct request *req, int uptodate) > > > +{ > > > + if (end_that_reque

Re: [PATCH 2/3] make kernel threads invisible to /sbin/init

2007-04-10 Thread Eric W. Biederman
Oleg Nesterov <[EMAIL PROTECTED]> writes: > 1. rename reparent_to_init() to reparent_kthread() and export it > > 2. use init_pid_ns.child_reaper instead of child_reaper(current) > > 3. set ->exit_signal = -1, so init can't see us and we don't use >it to reap the task. > > 4. add reparent_kthre

Re: I give up

2007-04-10 Thread Gene Heskett
On Tuesday 10 April 2007, Jan Engelhardt wrote: >On Apr 10 2007 03:51, Gene Heskett wrote: >>On Tuesday 10 April 2007, Olaf Hering wrote: >>>On Mon, Apr 09, Dave Dillow wrote: It's not /dev he's backing up -- its /home, /usr, and others. GNU tar saves the device and inode numbers from the

Re: [PATCH] h8300 trivial conversion to GENERIC_TIME

2007-04-10 Thread Yoshinori Sato
At Tue, 10 Apr 2007 16:25:00 -0700, john stultz wrote: > > Here is a trivial conversion of the h8300 arch to the GENERIC_TIME > infrastructure (h8300 does not have better then jiffies resolution, so > there are no clocksources to add). I have not tested this at all, but it > seems pretty straight

[PATCH 8/13] ntfs: use zero_user_page

2007-04-10 Thread Nate Diller
Use zero_user_page() instead of open-coding it. Signed-off-by: Nate Diller <[EMAIL PROTECTED]> --- diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/ntfs/aops.c linux-2.6.21-rc6-mm1-test/fs/ntfs/aops.c --- linux-2.6.21-rc6-mm1/fs/ntfs/aops.c 2007-04-09 10:41:47.0 -0700 +++ linux-2.6.21-r

[PATCH 2/13] affs: use zero_user_page

2007-04-10 Thread Nate Diller
Use zero_user_page() instead of open-coding it. Signed-off-by: Nate Diller <[EMAIL PROTECTED]> --- diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/affs/file.c linux-2.6.21-rc6-mm1-test/fs/affs/file.c --- linux-2.6.21-rc6-mm1/fs/affs/file.c 2007-04-09 17:23:48.0 -0700 +++ linux-2.6.21-rc6

[PATCH 5/13] ext4: use zero_user_page

2007-04-10 Thread Nate Diller
Use zero_user_page() instead of open-coding it. Signed-off-by: Nate Diller <[EMAIL PROTECTED]> --- diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/ext4/inode.c linux-2.6.21-rc6-mm1-test/fs/ext4/inode.c --- linux-2.6.21-rc6-mm1/fs/ext4/inode.c2007-04-10 17:15:04.0 -0700 +++ lin

[PATCH 4/13] ext3: use zero_user_page

2007-04-10 Thread Nate Diller
Use zero_user_page() instead of open-coding it. Signed-off-by: Nate Diller <[EMAIL PROTECTED]> --- diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/ext3/inode.c linux-2.6.21-rc6-mm1-test/fs/ext3/inode.c --- linux-2.6.21-rc6-mm1/fs/ext3/inode.c2007-04-09 17:24:03.0 -0700 +++ lin

[PATCH 6/13] gfs2: use zero_user_page

2007-04-10 Thread Nate Diller
Use zero_user_page() instead of open-coding it. Signed-off-by: Nate Diller <[EMAIL PROTECTED]> --- diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/gfs2/bmap.c linux-2.6.21-rc6-mm1-test/fs/gfs2/bmap.c --- linux-2.6.21-rc6-mm1/fs/gfs2/bmap.c 2007-04-09 17:23:48.0 -0700 +++ linux-2.6.21-r

[PATCH 11/13] reiserfs: use zero_user_page

2007-04-10 Thread Nate Diller
Use zero_user_page() instead of open-coding it. Signed-off-by: Nate Diller <[EMAIL PROTECTED]> --- diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/reiserfs/file.c linux-2.6.21-rc6-mm1-test/fs/reiserfs/file.c --- linux-2.6.21-rc6-mm1/fs/reiserfs/file.c 2007-04-09 17:24:03.0 -0700 +

[PATCH 10/13] reiser4: use zero_user_page

2007-04-10 Thread Nate Diller
Use zero_user_page() instead of open-coding it. Also replace the (mostly) redundant zero_page() function. Signed-off-by: Nate Diller <[EMAIL PROTECTED]> --- diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/reiser4/plugin/file/cryptcompress.c linux-2.6.21-rc6-mm1-test/fs/reiser4/plugin/file/cry

[PATCH 9/13] ocfs2: use zero_user_page

2007-04-10 Thread Nate Diller
Use zero_user_page() instead of open-coding it. Signed-off-by: Nate Diller <[EMAIL PROTECTED]> --- diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/ocfs2/aops.c linux-2.6.21-rc6-mm1-test/fs/ocfs2/aops.c --- linux-2.6.21-rc6-mm1/fs/ocfs2/aops.c2007-04-09 17:24:03.0 -0700 +++ lin

[PATCH 12/13] xfs: use zero_user_page

2007-04-10 Thread Nate Diller
Use zero_user_page() instead of the newly deprecated memclear_highpage_flush(). Signed-off-by: Nate Diller <[EMAIL PROTECTED]> --- diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/xfs/linux-2.6/xfs_lrw.c linux-2.6.21-rc6-mm1-test/fs/xfs/linux-2.6/xfs_lrw.c --- linux-2.6.21-rc6-mm1/fs/xfs/linux-

[PATCH 13/13] fs: deprecate memclear_highpage_flush

2007-04-10 Thread Nate Diller
Now that all the in-tree users are converted over to zero_user_page(), deprecate the old memclear_highpage_flush() call. Signed-off-by: Nate Diller <[EMAIL PROTECTED]> --- diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/include/linux/highmem.h linux-2.6.21-rc6-mm1-test/include/linux/highmem.h --- l

[PATCH 7/13] nfs: use zero_user_page

2007-04-10 Thread Nate Diller
Use zero_user_page() instead of the newly deprecated memclear_highpage_flush(). Signed-off-by: Nate Diller <[EMAIL PROTECTED]> --- diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/nfs/read.c linux-2.6.21-rc6-mm1-test/fs/nfs/read.c --- linux-2.6.21-rc6-mm1/fs/nfs/read.c 2007-04-09 17:23:48.0

[PATCH 3/13] ecryptfs: use zero_user_page

2007-04-10 Thread Nate Diller
Use zero_user_page() instead of open-coding it. Signed-off-by: Nate Diller <[EMAIL PROTECTED]> --- diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/ecryptfs/mmap.c linux-2.6.21-rc6-mm1-test/fs/ecryptfs/mmap.c --- linux-2.6.21-rc6-mm1/fs/ecryptfs/mmap.c 2007-04-09 17:24:03.0 -0700 +++

[PATCH 1/13] fs: convert core functions to zero_user_page

2007-04-10 Thread Nate Diller
It's very common for file systems to need to zero part or all of a page, the simplist way is just to use kmap_atomic() and memset(). There's actually a library function in include/linux/highmem.h that does exactly that, but it's confusingly named memclear_highpage_flush(), which is descriptive of

Re: RAID1 "out of memory" error, was Re: 2.6.21-rc5-mm4

2007-04-10 Thread Neil Brown
On Friday April 6, [EMAIL PROTECTED] wrote: > > Looks like some damage, or maybe intolerance to on-disk damage, to RAID-1. Difference is that kzalloc(0, ) now returns NULL. Maybe it is a SLUB/SLAB difference? (So maybe it did use memory it shouldn't have before, but now it fails, which is the be

Re: [PATCH 2/3] make kernel threads invisible to /sbin/init

2007-04-10 Thread Eric W. Biederman
"Serge E. Hallyn" <[EMAIL PROTECTED]> writes: > Quoting Oleg Nesterov ([EMAIL PROTECTED]): >> 1. rename reparent_to_init() to reparent_kthread() and export it >> >> 2. use init_pid_ns.child_reaper instead of child_reaper(current) > > Each of these patches looks good to me, but this part in partic

Re: [PATCH] Only send pdeath_signal when getppid changes.

2007-04-10 Thread Albert Cahalan
On 4/10/07, Roland McGrath <[EMAIL PROTECTED]> wrote: > Does a parent death signal make most sense between separately written programs? I don't think it does. It has always seemed an utterly cockamamy feature to me, and I've never understood what actually motivated it. It's useful, but the o

Re: [patch 5/8] [Intel IOMMU] Graphics driver workarounds to provide unity map

2007-04-10 Thread Wang Zhenyu
On 2007.04.10 11:12:17 +, Andi Kleen wrote: > > > On Mon, Apr 09, 2007 at 02:55:57PM -0700, Ashok Raj wrote: > > > > Most GFX drivers don't call standard PCI DMA APIs to allocate DMA > > > > buffer, > > > > Such drivers will be broken with IOMMU enabled. To workaround this > > > > issue, > >

Re: Build error : 2.6.21-rc6-mm1 on sparc64

2007-04-10 Thread Mathieu Desnoyers
* Andrew Morton ([EMAIL PROTECTED]) wrote: > On Wed, 11 Apr 2007 11:15:39 +0900 Fernando Luis Vázquez Cao <[EMAIL > PROTECTED]> wrote: > > > The problem is that to use hard_smp_processor_id in UP kernels just > > including linux/smp.h does not suffice anymore. Now > > hard_smp_processor_id is arc

Re: [PATCH] markers-doc-update-flags-example

2007-04-10 Thread Randy Dunlap
On Tue, 10 Apr 2007 19:26:20 -0400 Mathieu Desnoyers wrote: > -- CUT - > /* probe-example.c > * > - * Loads a function at a marker call site. > + * Connects a two functions to marker call sites. s/a // > * > * (C) Copyright

Re: Build error : 2.6.21-rc6-mm1 on sparc64

2007-04-10 Thread Andrew Morton
On Wed, 11 Apr 2007 11:15:39 +0900 Fernando Luis Vázquez Cao <[EMAIL PROTECTED]> wrote: > The problem is that to use hard_smp_processor_id in UP kernels just > including linux/smp.h does not suffice anymore. Now > hard_smp_processor_id is architecture specific code and consequently > asm/smp.h sh

Re: [PATCH] Improve heuristic detecting sequential reads

2007-04-10 Thread Andrew Morton
On Tue, 10 Apr 2007 17:54:11 +0200 Jan Kara <[EMAIL PROTECTED]> wrote: > Introduce ra.offset and store in it an offset where the previous read ended. > This way > we can detect whether reads are really sequential (and thus we should not > mark the page > as accessed repeatedly) or whether they a

Re: Build error : 2.6.21-rc6-mm1 on sparc64

2007-04-10 Thread Fernando Luis Vázquez Cao
On Tue, 2007-04-10 at 18:18 -0700, Andrew Morton wrote: > On Tue, 10 Apr 2007 20:48:38 -0400 > Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > > > I get the following build error when building 2.6.21-rc6-mm1 for > > sparc64: > > > > > > /opt/crosstool/gcc-3.4.5-glibc-2.3.6/sparc64-unknown-linux

Re: [RFC, PATCH 1/3] gpiodev - API definitions

2007-04-10 Thread Paul Sokolovsky
Hello Eric, Wednesday, April 11, 2007, 3:30:45 AM, you wrote: > it looks ok, but I have several questions: > 1. why should we bind this to platform_device, what if the gpio device > is not actually a "platform_device", say, a I2C device, a SPI device or > even a USB device? Good point. That w

Re: link error : 2.6.21-rc6-mm1 for s390

2007-04-10 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Tue, 10 Apr 2007 18:47:38 -0700 > On Tue, 10 Apr 2007 18:36:29 -0700 (PDT) > David Miller <[EMAIL PROTECTED]> wrote: > > > From: Andrew Morton <[EMAIL PROTECTED]> > > Date: Tue, 10 Apr 2007 18:29:37 -0700 > > > > > git-net.patch implements generic li

RE: Build error : 2.6.21-rc6-mm1 for arm

2007-04-10 Thread Williams, Dan J
> From: Andrew Morton [mailto:[EMAIL PROTECTED] > On Tue, 10 Apr 2007 20:54:20 -0400 > Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > > > I get the following build error when compiling 2.6.21-rc6-mm1 for arm > > "footbridge" : > > > > ... > > > > make -f /home/compudj/git/linux-2.6-lttng/scripts/M

Re: link error : 2.6.21-rc6-mm1 for s390

2007-04-10 Thread Andrew Morton
On Tue, 10 Apr 2007 18:36:29 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Tue, 10 Apr 2007 18:29:37 -0700 > > > git-net.patch implements generic lib/div64.c, but s390 also has a > > private one. Presumably the appropriate fix is to remove

Re: If not readdir() then what?

2007-04-10 Thread Bernd Eckenfels
In article <[EMAIL PROTECTED]> you wrote: > Otherwise, the client would have to cache _all_ previous READDIR results > since the last opendir()/rewinddir() in order to be able to do its own > loop detection and that will obviously never scale for large directories > or for directories that change f

Re: [patch 2/8] [Intel IOMMU] Some generic search functions required to lookup device relationships.

2007-04-10 Thread Shaohua Li
On Tue, 2007-04-10 at 06:03 -0700, Greg KH wrote: > On Tue, Apr 10, 2007 at 04:11:38PM +0800, Shaohua Li wrote: > > On Mon, 2007-04-09 at 20:46 -0700, Greg KH wrote: > > > On Mon, Apr 09, 2007 at 02:55:54PM -0700, Ashok Raj wrote: > > > > +/* > > > > + * find the upstream PCIE-to-PCI bridge of a PC

Re: link error : 2.6.21-rc6-mm1 for s390

2007-04-10 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Tue, 10 Apr 2007 18:29:37 -0700 > git-net.patch implements generic lib/div64.c, but s390 also has a > private one. Presumably the appropriate fix is to remove s390's > private implementation within davem's tree. The s390 version seems to be optimized

Re: link error : 2.6.21-rc6-mm1 for s390

2007-04-10 Thread Andrew Morton
On Tue, 10 Apr 2007 20:56:16 -0400 Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > The last for today : link error of 2.6.21-rc6-mm1 for s390 : > > > > /opt/crosstool/gcc-4.1.1-glibc-2.3.6/s390-unknown-linux-gnu/bin/s390-unknown-linux-gnu-ld > -m elf_s390 -e start -o .tmp_vmlinux1 -T arch/s39

Re: Build error : 2.6.21-rc6-mm1 for arm

2007-04-10 Thread Andrew Morton
On Tue, 10 Apr 2007 20:54:20 -0400 Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > I get the following build error when compiling 2.6.21-rc6-mm1 for arm > "footbridge" : > > ... > > make -f /home/compudj/git/linux-2.6-lttng/scripts/Makefile.build obj=init > > /opt/crosstool/gcc-4.0.2-glibc-2.3.

Re: Build error : 2.6.21-rc6-mm1 on sparc64

2007-04-10 Thread Andrew Morton
On Tue, 10 Apr 2007 20:48:38 -0400 Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > I get the following build error when building 2.6.21-rc6-mm1 for > sparc64: > > > /opt/crosstool/gcc-3.4.5-glibc-2.3.6/sparc64-unknown-linux-gnu/bin/sparc64-unknown-linux-gnu-gcc > -Wp,-MD,arch/sparc64/kernel/.t

Re: Build error : 2.6.21-rc6-mm1 for ppc 405

2007-04-10 Thread Andrew Morton
On Tue, 10 Apr 2007 20:50:42 -0400 Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > Hi Andrew, > > I get the following build error when building 2.6.21-rc6-mm1 for ppc > 405: > > > /home/compudj/git/linux-2.6-lttng/arch/ppc/syslib/ppc4xx_sgdma.c: In function > 'ppc4xx_alloc_dma_handle': > /home/

Re: [ofa-general] Re: [PATCH 00 of 33] Set of ipath patches for 2.6.22

2007-04-10 Thread Robert Walsh
Roland Dreier wrote: > Is there any chance of getting a fix for the use-after-free that can > be caused by allocating something from userspace, failing to mmap the > buffer and then exiting? To see what happens, look at how > ipath_create_cq sticks a struct ipath_mmap_info into the pending m

Re: 2.6.21-rc6-mm1 build fails for m68k

2007-04-10 Thread Andrew Morton
On Tue, 10 Apr 2007 20:41:12 -0400 Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > I get the following compiler error when building 2.6.21-rc6-mm1 for > m68k: > > > > /opt/crosstool/gcc-4.1.1-glibc-2.3.6/m68k-unknown-linux-gnu/bin/m68k-unknown-linux-gnu-gcc > -Wp,-MD,arch/m68k/kernel/.asm-off

link error : 2.6.21-rc6-mm1 for s390

2007-04-10 Thread Mathieu Desnoyers
Hi Andrew, The last for today : link error of 2.6.21-rc6-mm1 for s390 : /opt/crosstool/gcc-4.1.1-glibc-2.3.6/s390-unknown-linux-gnu/bin/s390-unknown-linux-gnu-ld -m elf_s390 -e start -o .tmp_vmlinux1 -T arch/s390/kernel/vmlinux.lds arch/s390/kernel/head.o arch/s390/kernel/init_task.o init/

Build error : 2.6.21-rc6-mm1 for arm

2007-04-10 Thread Mathieu Desnoyers
Hi Andrew, I get the following build error when compiling 2.6.21-rc6-mm1 for arm "footbridge" : /bin/sh /home/compudj/git/linux-2.6-lttng/scripts/checksyscalls.sh /opt/crosstool/gcc-4.0.2-glibc-2.3.6/arm-unknown-linux-gnu/bin/arm-unknown-linux-gnu-gcc -Wp,-MD,./.missing-syscalls.d -nostdinc

Build error : 2.6.21-rc6-mm1 for ppc 405

2007-04-10 Thread Mathieu Desnoyers
Hi Andrew, I get the following build error when building 2.6.21-rc6-mm1 for ppc 405: /opt/crosstool/gcc-4.1.1-glibc-2.3.6/powerpc-405-linux-gnu/bin/powerpc-405-linux-gnu-gcc -m32 -Wp,-MD,arch/ppc/syslib/.ppc4xx_sgdma.o.d -nostdinc -isystem /opt/crosstool/gcc-4.1.1-glibc-2.3.6/powerpc-405-l

Build error : 2.6.21-rc6-mm1 on sparc64

2007-04-10 Thread Mathieu Desnoyers
Hi Andrew, I get the following build error when building 2.6.21-rc6-mm1 for sparc64: /opt/crosstool/gcc-3.4.5-glibc-2.3.6/sparc64-unknown-linux-gnu/bin/sparc64-unknown-linux-gnu-gcc -Wp,-MD,arch/sparc64/kernel/.traps.o.d -nostdinc -isystem /opt/crosstool/gcc-3.4.5-glibc-2.3.6/sparc64-unknow

Build error : 2.6.21-rc6-mm1 on sparc

2007-04-10 Thread Mathieu Desnoyers
Hi Andrew, I get the following build error on sparc : /opt/crosstool/gcc-4.1.1-glibc-2.3.6/sparc-unknown-linux-gnu/bin/sparc-unknown-linux-gnu-gcc -Wp,-MD,arch/sparc/kernel/.irq.o.d -nostdinc -isystem /opt/crosstool/gcc-4.1.1-glibc-2.3.6/sparc-unknown-linux-gnu/lib/gcc/sparc-unknown-linux-g

2.6.21-rc6-mm1 build error with mips

2007-04-10 Thread Mathieu Desnoyers
Hi Andrew, I get the following error when compiling 2.6.21-rc6-mm1 for MIPS : /opt/crosstool/gcc-3.4.5-glibc-2.3.6/mips-unknown-linux-gnu/bin/mips-unknown-linux-gnu-gcc -Wp,-MD,arch/mips/sgi-ip22/.ip22-time.o.d -nostdinc -isystem /opt/crosstool/gcc-3.4.5-glibc-2.3.6/mips-unknown-linux-gnu/

2.6.21-rc6-mm1 build fails for m68k

2007-04-10 Thread Mathieu Desnoyers
Hi Andrew, I get the following compiler error when building 2.6.21-rc6-mm1 for m68k: /opt/crosstool/gcc-4.1.1-glibc-2.3.6/m68k-unknown-linux-gnu/bin/m68k-unknown-linux-gnu-gcc -Wp,-MD,arch/m68k/kernel/.asm-offsets.s.d -nostdinc -isystem /opt/crosstool/gcc-4.1.1-glibc-2.3.6/m68k-unknown-lin

Re: [ofa-general] Re: [PATCH 00 of 33] Set of ipath patches for 2.6.22

2007-04-10 Thread Roland Dreier
> Is there any chance of getting a fix for the use-after-free that can > be caused by allocating something from userspace, failing to mmap the > buffer and then exiting? To see what happens, look at how > ipath_create_cq sticks a struct ipath_mmap_info into the pending mmap > "list" (and yes

Re: [RFC, PATCH 1/3] gpiodev - API definitions

2007-04-10 Thread Eric Miao
it looks ok, but I have several questions: 1. why should we bind this to platform_device, what if the gpio device is not actually a "platform_device", say, a I2C device, a SPI device or even a USB device? 2. I still doubt the benefit of using of a structure for a gpio, isn't a gpio number not en

Re: If not readdir() then what?

2007-04-10 Thread Trond Myklebust
On Wed, 2007-04-11 at 08:33 +1000, Neil Brown wrote: > A READDIR (aka getdents2) should take a directory handle, a cookie, > and a filename, and should return filenames and cookies. The > cookies may all be identical or may not. The filename might be used > by the filesystem, or it might

Re: 2.6.21-rc6-mm1

2007-04-10 Thread Venki Pallipadi
On Tue, Apr 10, 2007 at 07:59:29PM -0400, Adam Belay wrote: > On Tue, 2007-04-10 at 15:20 -0700, Venki Pallipadi wrote: > > On Mon, Apr 09, 2007 at 07:40:52PM +0200, Rafael J. Wysocki wrote: > > > On Monday, 9 April 2007 18:14, Pallipadi, Venkatesh wrote: > > > > > > > > >-Original Message

Re: [patch 2.6.21-rc5-git] make /proc/acpi/wakeup more useful

2007-04-10 Thread David Brownell
On Tuesday 10 April 2007 4:29 pm, David Brownell wrote: > ... the appended > patch goes on top of the previous pnpacpi patch, and should (nyet tested!) > fix another place I saw that warning. And here's a tested version. Curiouser and curiouser. I think the mapping of ACPI tables to sysfs

  1   2   3   4   5   >