Re: [PATCH] make KVM conform to sucky rdmsr interface

2007-03-21 Thread Jeremy Fitzhardinge
Rusty Russell wrote: > It was actually Jeremy's paravirt cleanup patch which changed the > calling convention of rdmsr_safe() to match rdmsr(). > Oops, my little mind hobgoblin is getting out of control... J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

Re: [PATCH] make KVM conform to sucky rdmsr interface

2007-03-21 Thread Rusty Russell
On Thu, 2007-03-22 at 09:20 +0200, Avi Kivity wrote: > My rdmsr_safe (x86_64, i386 is similar/same) is Erk. Andrew, please drop that patch, and take this one. It was actually Jeremy's paravirt cleanup patch which changed the calling convention of rdmsr_safe() to match rdmsr(). I went "oh it's t

Re: [PATCH RESEND 1/1] crypto API: RSA algorithm patch (kernel version 2.6.20.1)

2007-03-21 Thread Tasos Parisinos
On Wed, March 21, 2007 16:50, Tasos Parisinos wrote: A malicious person may want to alter code on the detachable (and unsafe) file system. Lots of stuff including the kernel will be in a trapped casing (opening, probing it, power analyzing it, heating it etc will result in system suicide an

Re: [PATCH -mm 4/4] Blackfin: on-chip Two Wire Interface I2C driver

2007-03-21 Thread Jean Delvare
Hi Mike, On Thu, 22 Mar 2007 01:39:28 -0400, Mike Frysinger wrote: > On 3/21/07, Jean Delvare <[EMAIL PROTECTED]> wrote: > > > + p_adap->class = I2C_CLASS_ALL; > > > > This pretty much voids the point of these probing classes. You should > > only select the classes matching devices which may a

Re: 2.6.21-rc4-mm1 + 4 hotfixes -- BUG: unable to handle kernel paging request at virtual address 6b6b6ceb -- EIP is at module_put+0x7/0x1f

2007-03-21 Thread Andrew Morton
On Thu, 22 Mar 2007 00:29:54 -0700 "Miles Lane" <[EMAIL PROTECTED]> wrote: > kobject :01:06.0: cleaning up > kobject firmware: cleaning up > BUG: unable to handle kernel paging request at virtual address 6b6b6ceb > printing eip: > c0137c22 > *pde = > Oops: 0002 [#1] > last sysfs file

Re: 2.6.21-rc4-mm1

2007-03-21 Thread Andrew Morton
On Wed, 21 Mar 2007 15:22:25 -0500 Matt Mackall <[EMAIL PROTECTED]> wrote: > With the latest -mm, I'm now getting this: > > Mar 21 15:06:52 cinder kernel: ipw2200: Detected Intel PRO/Wireless > 2200BG Network Connection > Mar 21 15:06:52 cinder kernel: firmware_loading_store: unexpected > value (

Re: $CHECK can't be overridden

2007-03-21 Thread Al Viro
On Thu, Mar 22, 2007 at 01:15:25AM -0400, Dave Jones wrote: > make help implies that supplying $CHECK on the command line > should override sparse as the checker used when building with C=1 > Yet, this doesn't seem to be the case. > > This would be useful for cases where for eg, sparse isn't in >

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Andrew Morton
On Thu, 22 Mar 2007 08:23:39 +0100 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > On Thursday, 22 March 2007 05:51, David Chinner wrote: > > On Wed, Mar 21, 2007 at 10:38:33PM +0100, Rafael J. Wysocki wrote: > > > > > > I think this is the XFS problem with freezable workqueues. > > > > > > Ma

RE: how can I touch softlockup watchdog on all cpus?

2007-03-21 Thread Cestonaro, Thilo \(external\)
> You didn't explain _why_ you need to sleep for such a long time, > and as you didn't give a pointer to your code, there's not > much people can do to recommend changes other than "don't do that". The code which is executed between the local_irq_disable and enable, is just a function call into ou

Re: [PATCH] Cleanup: rationalize paravirt wrappers

2007-03-21 Thread Avi Kivity
Rusty Russell wrote: +static inline unsigned long long native_read_msr(unsigned int msr, int *err) +{ + unsigned long long val; + + asm volatile("2: rdmsr ; xorl %0,%0\n" +"1:\n\t" +".section .fixup,\"ax\"\n\t" +"3: movl %3,

2.6.21-rc4-mm1 + 4 hotfixes -- BUG: unable to handle kernel paging request at virtual address 6b6b6ceb -- EIP is at module_put+0x7/0x1f

2007-03-21 Thread Miles Lane
kobject :01:06.0: cleaning up kobject firmware: cleaning up BUG: unable to handle kernel paging request at virtual address 6b6b6ceb printing eip: c0137c22 *pde = Oops: 0002 [#1] last sysfs file: devices/pci:00/:00:1e.0/:01:06.0/firmware/:01:06.0/loading Modules linked

Re: [RFC/PATCH 0/15] Pass MAP_FIXED down to get_unmapped_area

2007-03-21 Thread Nick Piggin
Benjamin Herrenschmidt wrote: !!! This is a first cut, and there are still cleanups to be done in various areas touched by that code. I also haven't done descriptions yet for the individual patches. The current get_unmapped_area code calls the f_ops->get_unmapped_area or the arch one (via the mm

Re: [PATCH] lockdep: debug_show_all_locks & debug_show_held_locks vs. debug_locks

2007-03-21 Thread Peter Zijlstra
On Thu, 2007-03-22 at 07:57 +0100, Jarek Poplawski wrote: > And here is some addition. > > [PATCH] lockdep: debug_show_all_locks & debug_show_held_locks vs. debug_locks > > lockdep's data shouldn't be used when debug_locks == 0 > because it's not updated after this, so it's more misleading > th

Re: [PATCH] lockdep: lockdep_depth vs. debug_locks Re: [2.6.20] BUG: workqueue leaked lock

2007-03-21 Thread Peter Zijlstra
On Thu, 2007-03-22 at 07:11 +0100, Jarek Poplawski wrote: > Here is some joke: > > [PATCH] lockdep: lockdep_depth vs. debug_locks > > lockdep really shouldn't be used when debug_locks == 0! This happens then lockdep reports a fatal error, at which point it will stop tracking locks and leave what

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Rafael J. Wysocki
On Thursday, 22 March 2007 05:51, David Chinner wrote: > On Wed, Mar 21, 2007 at 10:38:33PM +0100, Rafael J. Wysocki wrote: > > > > I think this is the XFS problem with freezable workqueues. > > > > Maxim, please try to apply the appended patch and see if it helps. > > > > Greetings, > > Rafael

Re: [PATCH] make KVM conform to sucky rdmsr interface

2007-03-21 Thread Avi Kivity
Rusty Russell wrote: Grrr Andi refused to take my "rdmsr64" patch which moved to a function-like interface for MSRs, dismissing it as pointless churn. paravirt_ops cleanups changed a macro to an inline and spotted this kvm bug. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r 47c6e

Re: [PATCH] lockdep: lockdep_depth vs. debug_locks Re: [2.6.20] BUG: workqueue leaked lock

2007-03-21 Thread Jarek Poplawski
On Thu, Mar 22, 2007 at 08:06:44AM +0100, Jarek Poplawski wrote: ... > This should definitely solve this problem - as it was said > a few times before lockdep stops registering locks after > a bug, so even the lock which caused the warning isn't > reported. Here lockdep found a bug in a workqueue f

Re: RSDL v0.31

2007-03-21 Thread Mike Galbraith
On Thu, 2007-03-22 at 05:49 +0100, Willy Tarreau wrote: > Mike, if you need my old scheddos, I can resend it to you as well as to > any people working on the scheduler and asking for it. Although trivial, > I'm a bit reluctant to publish it to the whole world because I suspect > that distros based

Re: [PATCH -mm 4/4] Blackfin: on-chip Two Wire Interface I2C driver

2007-03-21 Thread Mike Frysinger
On 3/22/07, Jean Delvare <[EMAIL PROTECTED]> wrote: On Wed, 21 Mar 2007 15:14:29 -0400, Mike Frysinger wrote: > On 3/21/07, Bob Copeland <[EMAIL PROTECTED]> wrote: > > > +config I2C_BLACKFIN_TWI > > > + tristate "Blackfin TWI I2C support" > > > + depends on I2C && (BF534 || BF536 || B

Re: [PATCH] lockdep: lockdep_depth vs. debug_locks Re: [2.6.20] BUG: workqueue leaked lock

2007-03-21 Thread Jarek Poplawski
On Wed, Mar 21, 2007 at 10:28:02PM -0800, Andrew Morton wrote: ... > I assume that some codepath is incrementing ->lockdep_depth even when > debug_locks==0. Isn't that wrong of it? > lockdep simply stops to update lockdep_depth just after (during) a bug or a WARN. Jarek P. - To unsubscribe from

Re: RSDL v0.31

2007-03-21 Thread Mike Galbraith
This is a rather long message, and isn't directed at anyone in particular, it's for others who may be digging into their own problems with RSDL, and for others (if any other than Con exist) who understand RSDL well enough to tell me if I'm missing something. Anyone who's not interested in RSDL's g

Re: [PATCH -mm 4/4] Blackfin: on-chip Two Wire Interface I2C driver

2007-03-21 Thread Jean Delvare
On Wed, 21 Mar 2007 15:14:29 -0400, Mike Frysinger wrote: > On 3/21/07, Bob Copeland <[EMAIL PROTECTED]> wrote: > > > +config I2C_BLACKFIN_TWI > > > + tristate "Blackfin TWI I2C support" > > > + depends on I2C && (BF534 || BF536 || BF537) > > > + help > > > + This is the T

Re: [PATCH] lockdep: lockdep_depth vs. debug_locks Re: [2.6.20] BUG: workqueue leaked lock

2007-03-21 Thread Jarek Poplawski
On Wed, Mar 21, 2007 at 10:28:02PM -0800, Andrew Morton wrote: > On Thu, 22 Mar 2007 07:11:19 +0100 Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > > > Here is some joke: > > > > [PATCH] lockdep: lockdep_depth vs. debug_locks > > > > lockdep really shouldn't be used when debug_locks == 0! > >

[PATCH] lockdep: debug_show_all_locks & debug_show_held_locks vs. debug_locks

2007-03-21 Thread Jarek Poplawski
And here is some addition. [PATCH] lockdep: debug_show_all_locks & debug_show_held_locks vs. debug_locks lockdep's data shouldn't be used when debug_locks == 0 because it's not updated after this, so it's more misleading than helpful. PS: probably lockdep's current-> fields should be reset af

Re: AIO, FIO and Threads ...

2007-03-21 Thread Jens Axboe
On Wed, Mar 21 2007, Davide Libenzi wrote: > On Wed, 21 Mar 2007, Jens Axboe wrote: > > > On Tue, Mar 20 2007, Davide Libenzi wrote: > > > > > > I was looking at Jens FIO stuff, and I decided to cook a quick patch for > > > FIO to support GUASI (Generic Userspace Asyncronous Syscall Interface):

Re: [PATCH 2/2] Replace pid_t in autofs with struct pid reference

2007-03-21 Thread Eric W. Biederman
"Serge E. Hallyn" <[EMAIL PROTECTED]> writes: > > So is the pid used for anything other than debugging? > > In any case, here is a replacement patch which sends the pid number > in the pid_namespace of the process which did the autofs4 mount. > > Still not sure whether that is actually what makes s

Re: libata - 2.6.21-rc4-git5, ata channel still badly configured

2007-03-21 Thread Tejun Heo
Lukas Hejtmanek wrote: >> Subject: ata_piix: PATA UDMA/100 configured as UDMA/33 >> References : http://lkml.org/lkml/2007/2/20/294 >> Submitter : Fabio Comolli <[EMAIL PROTECTED]> >> Status : unknown > > ata_piix :00:1f.1: version 2.10ac1 > ACPI: PCI Interrupt :00:1f.1[A] -> GSI

Re: [RFC] : Is /proc/kcore still usefull and/or maintained ?

2007-03-21 Thread Eric Dumazet
On Thu, 22 Mar 2007 02:04:50 +0200 Maxim <[EMAIL PROTECTED]> wrote: > Hi, > Yes, you are right, you have different problem that I had > > But why do you need llseek ? I dont personnaly, but tools do need llseek. > > Why not to mmap it ? > It is natural thing to do with

Re: [PATCH] lockdep: lockdep_depth vs. debug_locks Re: [2.6.20] BUG: workqueue leaked lock

2007-03-21 Thread Andrew Morton
On Thu, 22 Mar 2007 07:11:19 +0100 Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > Here is some joke: > > [PATCH] lockdep: lockdep_depth vs. debug_locks > > lockdep really shouldn't be used when debug_locks == 0! > This isn't a very good changelog. > > Reported-by: Folkert van Heusden <[EMAI

[GIT PATCH] ACPI patches for 2.6.21-rc4

2007-03-21 Thread Len Brown
Hi Linus, please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6.git release This batch includes fixes to two visible 2.6.21 regressions -- the immediate suspend wakeup, and the the acpi_serialize deadlock. The later is a revert that touches a lot of code, but sh

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-21 Thread Dave Jones
On Thu, Mar 22, 2007 at 06:53:06AM +0100, Willy Tarreau wrote: > At most, they will ask their distro vendor for continued support of the > feature (which there will be in the same minor release), and if vendors' > feedback show there is enough demand, then we will just have to delay the > remo

[PATCH] lockdep: lockdep_depth vs. debug_locks Re: [2.6.20] BUG: workqueue leaked lock

2007-03-21 Thread Jarek Poplawski
Here is some joke: [PATCH] lockdep: lockdep_depth vs. debug_locks lockdep really shouldn't be used when debug_locks == 0! Reported-by: Folkert van Heusden <[EMAIL PROTECTED]> Inspired-by: Oleg Nesterov <[EMAIL PROTECTED]> Signed-off-by: Jarek Poplawski <[EMAIL PROTECTED]> --- diff -Nurp 2.6.

[RFC/PATCH 13/15] get_unmapped_area handles MAP_FIXED in /dev/mem (nommu)

2007-03-21 Thread Benjamin Herrenschmidt
This also fixes a bug, I think, it used to return a pgoff (pfn) instead of an address. (To split ?) Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- drivers/char/mem.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) Index: linux-cell/drivers/char/mem.c

[RFC/PATCH 12/15] get_unmapped_area handles MAP_FIXED in ffb DRM

2007-03-21 Thread Benjamin Herrenschmidt
Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- drivers/char/drm/ffb_drv.c |6 ++ 1 file changed, 6 insertions(+) Index: linux-cell/drivers/char/drm/ffb_drv.c === --- linux-cell.orig/drivers/char/drm/ffb_drv.c

[RFC/PATCH 10/15] get_unmapped_area handles MAP_FIXED in hugetlbfs

2007-03-21 Thread Benjamin Herrenschmidt
Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- fs/hugetlbfs/inode.c |6 ++ 1 file changed, 6 insertions(+) Index: linux-cell/fs/hugetlbfs/inode.c === --- linux-cell.orig/fs/hugetlbfs/inode.c2007-03-22

[RFC/PATCH 15/15] get_unmapped_area doesn't need hugetlbfs hacks anymore

2007-03-21 Thread Benjamin Herrenschmidt
Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- mm/mmap.c | 16 1 file changed, 16 deletions(-) Index: linux-cell/mm/mmap.c === --- linux-cell.orig/mm/mmap.c 2007-03-22 16:30:24.0 +1100 +++

[RFC/PATCH 14/15] get_unmapped_area handles MAP_FIXED in generic code

2007-03-21 Thread Benjamin Herrenschmidt
Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- mm/mmap.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) Index: linux-cell/mm/mmap.c === --- linux-cell.orig/mm/mmap.c 2007-03-22 1

[RFC/PATCH 9/15] get_unmapped_area handles MAP_FIXED on x86_64

2007-03-21 Thread Benjamin Herrenschmidt
Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- arch/x86_64/kernel/sys_x86_64.c |3 +++ 1 file changed, 3 insertions(+) Index: linux-cell/arch/x86_64/kernel/sys_x86_64.c === --- linux-cell.orig/arch/x86_64/kernel/s

[RFC/PATCH 11/15] get_unmapped_area handles MAP_FIXED on ramfs (nommu)

2007-03-21 Thread Benjamin Herrenschmidt
Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- fs/ramfs/file-nommu.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) Index: linux-cell/fs/ramfs/file-nommu.c === --- linux-cell.orig/fs/ramfs/file-nommu.c

[RFC/PATCH 8/15] get_unmapped_area handles MAP_FIXED on sparc64

2007-03-21 Thread Benjamin Herrenschmidt
Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- arch/sparc64/mm/hugetlbpage.c |6 ++ 1 file changed, 6 insertions(+) Index: linux-cell/arch/sparc64/mm/hugetlbpage.c === --- linux-cell.orig/arch/sparc64/mm/huget

[RFC/PATCH 6/15] get_unmapped_area handles MAP_FIXED on ia64

2007-03-21 Thread Benjamin Herrenschmidt
Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- arch/ia64/kernel/sys_ia64.c |7 +++ arch/ia64/mm/hugetlbpage.c |8 2 files changed, 15 insertions(+) Index: linux-cell/arch/ia64/kernel/sys_ia64.c =

[RFC/PATCH 7/15] get_unmapped_area handles MAP_FIXED on parisc

2007-03-21 Thread Benjamin Herrenschmidt
Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- arch/parisc/kernel/sys_parisc.c |5 + 1 file changed, 5 insertions(+) Index: linux-cell/arch/parisc/kernel/sys_parisc.c === --- linux-cell.orig/arch/parisc/kernel

[RFC/PATCH 2/15] get_unmapped_area handles MAP_FIXED on alpha

2007-03-21 Thread Benjamin Herrenschmidt
Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- arch/alpha/kernel/osf_sys.c |3 +++ 1 file changed, 3 insertions(+) Index: linux-cell/arch/alpha/kernel/osf_sys.c === --- linux-cell.orig/arch/alpha/kernel/osf_sys.c

[RFC/PATCH 3/15] get_unmapped_area handles MAP_FIXED on arm

2007-03-21 Thread Benjamin Herrenschmidt
Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- arch/arm/mm/mmap.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: linux-cell/arch/arm/mm/mmap.c === --- linux-cell.orig/arch/arm/mm/mmap.c 2007-03-22

[RFC/PATCH 4/15] get_unmapped_area handles MAP_FIXED on frv

2007-03-21 Thread Benjamin Herrenschmidt
Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- arch/frv/mm/elf-fdpic.c |4 1 file changed, 4 insertions(+) Index: linux-cell/arch/frv/mm/elf-fdpic.c === --- linux-cell.orig/arch/frv/mm/elf-fdpic.c 2007-03

[RFC/PATCH 5/15] get_unmapped_area handles MAP_FIXED on i386

2007-03-21 Thread Benjamin Herrenschmidt
Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- arch/i386/mm/hugetlbpage.c |6 ++ 1 file changed, 6 insertions(+) Index: linux-cell/arch/i386/mm/hugetlbpage.c === --- linux-cell.orig/arch/i386/mm/hugetlbpage.c

[RFC/PATCH 0/15] Pass MAP_FIXED down to get_unmapped_area

2007-03-21 Thread Benjamin Herrenschmidt
!!! This is a first cut, and there are still cleanups to be done in various areas touched by that code. I also haven't done descriptions yet for the individual patches. The current get_unmapped_area code calls the f_ops->get_unmapped_area or the arch one (via the mm) only when MAP_FIXED is not pas

[RFC/PATCH 1/15] get_unmapped_area handles MAP_FIXED on powerpc

2007-03-21 Thread Benjamin Herrenschmidt
Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- arch/powerpc/mm/hugetlbpage.c | 21 + 1 file changed, 21 insertions(+) Index: linux-cell/arch/powerpc/mm/hugetlbpage.c === --- linux-cell.orig/arch/

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-21 Thread Willy Tarreau
On Thu, Mar 22, 2007 at 01:02:50AM -0400, Dave Jones wrote: > On Thu, Mar 22, 2007 at 05:45:40AM +0100, Willy Tarreau wrote: > > On Thu, Mar 22, 2007 at 12:17:51AM -0400, Dave Jones wrote: > > > On Thu, Mar 22, 2007 at 05:12:42AM +0100, Willy Tarreau wrote: > > > > On Wed, Mar 21, 2007 at 07:43

Re: [PATCH 0/3] VM throttling: avoid blocking occasional writers

2007-03-21 Thread Tomoki Sekiyama
Hi, Thanks for your comments. I'm sorry for my late reply. Bill Davidsen wrote: > Andrew Morton wrote: >>> On Wed, 14 Mar 2007 21:42:46 +0900 Tomoki Sekiyama >>> <[EMAIL PROTECTED]> wrote: >>> >>> ... >>> >>> >>> -Solution: >>> >>> I consider that all of the dirty pages for the disk have been wr

Re: [PATCH -mm 1/4] Blackfin: architecture update patch

2007-03-21 Thread Wu, Bryan
On Wed, 2007-03-21 at 20:08 -0800, Andrew Morton wrote: > On Thu, 22 Mar 2007 10:24:51 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote: > > > > 1 out of 1 hunk FAILED -- saving rejects to file > > > include/asm-blackfin/cplbinit.h.rej > > > 1 out of 1 hunk FAILED -- saving rejects to file > > > incl

Re: $CHECK can't be overridden

2007-03-21 Thread Keith Owens
Dave Jones (on Thu, 22 Mar 2007 01:37:14 -0400) wrote: >On Thu, Mar 22, 2007 at 04:26:39PM +1100, Keith Owens wrote: > > Dave Jones (on Thu, 22 Mar 2007 01:15:25 -0400) wrote: > > >make help implies that supplying $CHECK on the command line > > >should override sparse as the checker used when build

Re: [PATCH -mm 4/4] Blackfin: on-chip Two Wire Interface I2C driver

2007-03-21 Thread Mike Frysinger
On 3/21/07, Jean Delvare <[EMAIL PROTECTED]> wrote: > + p_adap->class = I2C_CLASS_ALL; This pretty much voids the point of these probing classes. You should only select the classes matching devices which may actually be probed for on this bus. If different boards have different needs, get th

Re: $CHECK can't be overridden

2007-03-21 Thread Dave Jones
On Thu, Mar 22, 2007 at 04:26:39PM +1100, Keith Owens wrote: > Dave Jones (on Thu, 22 Mar 2007 01:15:25 -0400) wrote: > >make help implies that supplying $CHECK on the command line > >should override sparse as the checker used when building with C=1 > >Yet, this doesn't seem to be the case. >

Re: $CHECK can't be overridden

2007-03-21 Thread Keith Owens
Dave Jones (on Thu, 22 Mar 2007 01:15:25 -0400) wrote: >make help implies that supplying $CHECK on the command line >should override sparse as the checker used when building with C=1 >Yet, this doesn't seem to be the case. > >This would be useful for cases where for eg, sparse isn't in >the $PATH,

Re: [PATCH] Unset msi and msix flags on pci_device_disable

2007-03-21 Thread Eric W. Biederman
Thomas Meyer <[EMAIL PROTECTED]> writes: > The commit f5f2b13129a6541debf8851bae843cbbf48298b7 broke suspend/resume > to disk two or more times in a row. This patches fixes the problem: Please clue me in, on what the problem is, I see why my patch would have changed things I don't see how it is

$CHECK can't be overridden

2007-03-21 Thread Dave Jones
make help implies that supplying $CHECK on the command line should override sparse as the checker used when building with C=1 Yet, this doesn't seem to be the case. This would be useful for cases where for eg, sparse isn't in the $PATH, allowing an explicit path to the executable to be passed in a

Re: PNPACPI probes serial twice, messes up serial console

2007-03-21 Thread Bjorn Helgaas
On Wednesday 21 March 2007 22:23, Keith Owens wrote: > The aim of the patch looks sensible, but it will not compile for > 2.6.21-rc4. 8250_x86.c tests pnp_platform_devices, which does not > exist. Also the combination of CONFIG_SERIAL_8250_X86=y and > CONFIG_SERIAL_8250_PNP=m would result in 8250

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-21 Thread Dave Jones
On Thu, Mar 22, 2007 at 05:45:40AM +0100, Willy Tarreau wrote: > On Thu, Mar 22, 2007 at 12:17:51AM -0400, Dave Jones wrote: > > On Thu, Mar 22, 2007 at 05:12:42AM +0100, Willy Tarreau wrote: > > > On Wed, Mar 21, 2007 at 07:43:18PM -0400, Dave Jones wrote: > > > > On Thu, Mar 22, 2007 at 12:

Re: [PATCH] sched: rsdl improvements

2007-03-21 Thread Con Kolivas
On Thursday 22 March 2007 10:36, Andrew Morton wrote: > On Thu, 22 Mar 2007 04:29:44 +1100 > > Con Kolivas <[EMAIL PROTECTED]> wrote: > > Further improve the deterministic nature of the RSDL cpu scheduler and > > make the rr_interval tunable. > > I might actually need to drop RSDL from next -mm, se

Re: [PATCH 2/7] Initial implementation of the trec driver and include files

2007-03-21 Thread Wink Saville
On 3/21/07, Johannes Weiner <[EMAIL PROTECTED]> wrote: Hi, On Wed, Mar 21, 2007 at 09:49:12AM -0700, Wink Saville wrote: > >>Please don't use camel-case - in general. > >> > Would p_next, p_cur and p_end be OK? I think it's generally disliked. Quoting Documentation/CodingStyle: ``Encoding the

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread David Chinner
On Wed, Mar 21, 2007 at 10:38:33PM +0100, Rafael J. Wysocki wrote: > > I think this is the XFS problem with freezable workqueues. > > Maxim, please try to apply the appended patch and see if it helps. > > Greetings, > Rafael > > > --- > Since freezable workqueues are broken in 2.6.21-rc > (cf.

Re: RSDL v0.31

2007-03-21 Thread Willy Tarreau
On Wed, Mar 21, 2007 at 06:07:33PM +0100, Mike Galbraith wrote: > On Wed, 2007-03-21 at 16:11 +0100, Paolo Ornati wrote: > > On Wed, 21 Mar 2007 15:57:44 +0100 > > Mike Galbraith <[EMAIL PROTECTED]> wrote: > > > > > I was more than a bit surprised that mainline did this well, considering > > > tha

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-21 Thread Willy Tarreau
On Thu, Mar 22, 2007 at 12:17:51AM -0400, Dave Jones wrote: > On Thu, Mar 22, 2007 at 05:12:42AM +0100, Willy Tarreau wrote: > > On Wed, Mar 21, 2007 at 07:43:18PM -0400, Dave Jones wrote: > > > On Thu, Mar 22, 2007 at 12:24:33AM +0100, Willy Tarreau wrote: > > > > > > > Then a printk() on e

Re: PNPACPI probes serial twice, messes up serial console

2007-03-21 Thread Keith Owens
Bjorn Helgaas (on Wed, 21 Mar 2007 10:35:38 -0600) wrote: >On Tuesday 20 March 2007 08:32, Bjorn Helgaas wrote: >> On Tuesday 20 March 2007 00:46, Keith Owens wrote: >> > Booting with 'console=tty console=ttyS0,9600'. The serial console on >> > ttyS0 (0x3f8, irq 4) is probed twice, once from seria

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-21 Thread Dave Jones
On Thu, Mar 22, 2007 at 05:12:42AM +0100, Willy Tarreau wrote: > On Wed, Mar 21, 2007 at 07:43:18PM -0400, Dave Jones wrote: > > On Thu, Mar 22, 2007 at 12:24:33AM +0100, Willy Tarreau wrote: > > > > > Then a printk() on every open() should be enough. We've all been seeing > > > "Warning:

Re: [1/6] 2.6.21-rc4: known regressions

2007-03-21 Thread Nick Piggin
Linus Torvalds wrote: In contrast, the hang reported by Mariusz Kozlowski has a slightly different feel to it, but there's a tantalizing pattern in there too: http://www.ussg.iu.edu/hypermail/linux/kernel/0703.0/1243.html Call Trace: [] io_schedule+0x42/0x59 [] sleep

Re: [PATCH] Delete obsolete RAW driver feature.

2007-03-21 Thread Willy Tarreau
On Wed, Mar 21, 2007 at 07:43:18PM -0400, Dave Jones wrote: > On Thu, Mar 22, 2007 at 12:24:33AM +0100, Willy Tarreau wrote: > > > Then a printk() on every open() should be enough. We've all been seeing > > "Warning: tcpdump uses obsolete AF_PACKET"... and it finally disappeared. > > There's a

Re: Oops after cd /sys/.../cpufreq/; rmmod; cat stats/time_in_state

2007-03-21 Thread Andrew Morton
On Wed, 21 Mar 2007 21:00:06 -0700 Greg KH <[EMAIL PROTECTED]> wrote: > On Wed, Mar 21, 2007 at 11:51:04PM -0400, Dave Jones wrote: > > On Wed, Mar 21, 2007 at 08:07:53PM -0700, Greg KH wrote: > > > > > > After modprobe/rmmod cpufreq/stats directory appears but doesn't get > > > > removed. Sho

Re: [PATCH -mm 1/4] Blackfin: architecture update patch

2007-03-21 Thread Andrew Morton
On Thu, 22 Mar 2007 10:24:51 +0800 "Wu, Bryan" <[EMAIL PROTECTED]> wrote: > > 1 out of 1 hunk FAILED -- saving rejects to file > > include/asm-blackfin/cplbinit.h.rej > > 1 out of 1 hunk FAILED -- saving rejects to file > > include/asm-blackfin/mach-bf535/bf535.h.rej > > 1 out of 1 hunk FAILED -

Re: [PATCH] Use X86_EFLAGS_IF in irqflags.h, lguest.

2007-03-21 Thread Keith Owens
Rusty Russell (on Thu, 22 Mar 2007 14:52:29 +1100) wrote: >On Thu, 2007-03-22 at 14:24 +1100, Rusty Russell wrote: >> Belay this: there's a X86_EFLAGS_IF in asm/processor.h which we should >> use. Will send patch. > >How's this. There may be other users, but they're not easy to grep for. One les

Re: Oops after cd /sys/.../cpufreq/; rmmod; cat stats/time_in_state

2007-03-21 Thread Greg KH
On Wed, Mar 21, 2007 at 11:51:04PM -0400, Dave Jones wrote: > On Wed, Mar 21, 2007 at 08:07:53PM -0700, Greg KH wrote: > > > > After modprobe/rmmod cpufreq/stats directory appears but doesn't get > > > removed. Should it? > > Well, one can argue that those stats should never be in sysfs at all

[PATCH] Use X86_EFLAGS_IF in irqflags.h, lguest.

2007-03-21 Thread Rusty Russell
On Thu, 2007-03-22 at 14:24 +1100, Rusty Russell wrote: > Belay this: there's a X86_EFLAGS_IF in asm/processor.h which we should > use. Will send patch. How's this. There may be other users, but they're not easy to grep for. == Move X86_EFLAGS_IF et al out to a new header: processor-flags.h, so

Re: Oops after cd /sys/.../cpufreq/; rmmod; cat stats/time_in_state

2007-03-21 Thread Dave Jones
On Wed, Mar 21, 2007 at 08:07:53PM -0700, Greg KH wrote: > > After modprobe/rmmod cpufreq/stats directory appears but doesn't get > > removed. Should it? > Well, one can argue that those stats should never be in sysfs at all > anyway, I mean come on, a histogram in sysfs? That's, not ok. Me

Re: [1/6] 2.6.21-rc4: known regressions

2007-03-21 Thread Linus Torvalds
On Sun, 18 Mar 2007, Adrian Bunk wrote: > > Subject: weird system hangs > References : http://lkml.org/lkml/2007/3/16/288 > Submitter : Michal Piotrowski <[EMAIL PROTECTED]> > Mariusz Kozlowski <[EMAIL PROTECTED]> > Status : unknown According to the console log, it seems t

Re: [BUG] no boot with 2.6.21-rc3 and later

2007-03-21 Thread Bob Tracy
john stultz wrote: > > > Also, does booting w/ "clocksource=jiffies" change the behavior? Works fine with 2.6.21-rc4. I'm running on that kernel as I type this. > Also trying booting w/ "notsc" would be a useful data point. Boot hangs at the point indicated in my original message. I *did* noti

Re: [PATCH] Define EFLAGS_IF

2007-03-21 Thread Rusty Russell
On Thu, 2007-03-22 at 14:16 +1100, Rusty Russell wrote: > There is now more than one place where we use the fact that bit 9 of > eflags is the interrupt-enabled flag, so define EFLAGS_IF. We make it > 512 so it can be used in asm, too. Belay this: there's a X86_EFLAGS_IF in asm/processor.h which

Re: Oops after cd /sys/.../cpufreq/; rmmod; cat stats/time_in_state

2007-03-21 Thread Greg KH
On Tue, Mar 20, 2007 at 01:06:34PM +0300, Alexey Dobriyan wrote: > On Mon, Mar 19, 2007 at 01:41:25PM -0700, Greg KH wrote: > > On Mon, Mar 19, 2007 at 06:30:13PM +0300, Alexey Dobriyan wrote: > > > Steps to reproduce: > > > > > > # modprobe p4-clockmod > > > $ cd /sys/devices/system/cpu/cpu0/c

Re: [PATCH 2/2] Replace pid_t in autofs with struct pid reference

2007-03-21 Thread Ian Kent
On Wed, 2007-03-21 at 21:19 -0500, Serge E. Hallyn wrote: > Quoting Ian Kent ([EMAIL PROTECTED]): > > On Tue, 2007-03-20 at 16:01 -0600, Eric W. Biederman wrote: > > > "Serge E. Hallyn" <[EMAIL PROTECTED]> writes: > > > > > > >> > void autofs4_dentry_release(struct dentry *); > > > >> > extern v

[PATCH] Define EFLAGS_IF

2007-03-21 Thread Rusty Russell
There is now more than one place where we use the fact that bit 9 of eflags is the interrupt-enabled flag, so define EFLAGS_IF. We make it 512 so it can be used in asm, too. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> --- a/arch/i386/lguest/lguest.c +++ b/arch/i386/lguest/lguest.c @@ -107,9

[PATCH] lguest: Compile hypervisor.S into the lg module directly

2007-03-21 Thread Rusty Russell
Because of legacy-induced blindness, I insisted on separately building the hypervisor.S switcher code (which is mapped at 0xFFC in host and guest). However, the lguest64 patches showed the error of my ways: it has no relocations, so it can be linked into the module like normal then remapped.

[PATCH] lguest: clean up some l"references .init.text" warnings

2007-03-21 Thread Rusty Russell
Thanks to Andrew for pointing these out. This patch moves the parvirtprobe section into .init.data: it's only used in very very early boot, and for similar reasons, puts lguest_maybe_init and lguest_memory_setup in init.text. As well as fixing some warnings, this frees up a tiny bit more memory.

[PATCH] make KVM conform to sucky rdmsr interface

2007-03-21 Thread Rusty Russell
Grrr Andi refused to take my "rdmsr64" patch which moved to a function-like interface for MSRs, dismissing it as pointless churn. paravirt_ops cleanups changed a macro to an inline and spotted this kvm bug. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r 47c6ee74a5c5 drivers/kvm/vmx

[PATCH] Cleanup: rationalize paravirt wrappers

2007-03-21 Thread Rusty Russell
paravirt.c used to implement native versions of all low-level functions. Far cleaner is to have the native versions exposed in the headers and as inline native_XXX, and if !CONFIG_PARAVIRT, then simply #define XXX native_XXX. There are four nice side effects: 1) write_dt_entry() now takes the co

Re: [PATCH 2/2] Replace pid_t in autofs with struct pid reference

2007-03-21 Thread Ian Kent
On Wed, 2007-03-21 at 15:58 -0500, Serge E. Hallyn wrote: > Quoting Eric W. Biederman ([EMAIL PROTECTED]): > > "Serge E. Hallyn" <[EMAIL PROTECTED]> writes: > > > > >> > void autofs4_dentry_release(struct dentry *); > > >> > extern void autofs4_kill_sb(struct super_block *); > > >> > diff --git

[PATCH -mm] cpuidle: unsigned bitfield

2007-03-21 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> A 1-bit bitfield has no room for a sign bit. drivers/cpuidle/governors/ladder.c:54:16: error: dubious bitfield without explicit `signed' or `unsigned' Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- drivers/cpuidle/governors/ladder.c |2 +- 1 file

[PATCH -mm] ipwireless: use ANSI func. decl.

2007-03-21 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix function declaration: drivers/char/pcmcia/ipwireless_cs_tty.c:730:29: warning: non-ANSI function declaration of function 'ipwireless_tty_release' Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- drivers/char/pcmcia/ipwireless_cs_tty.c |2 +- 1 f

[PATCH -mm] nozomi: use NULL for pointers

2007-03-21 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Use NULL instead of 0 for pointers: drivers/char/nozomi.c:1028:68: warning: Using plain integer as NULL pointer drivers/char/nozomi.c:1029:68: warning: Using plain integer as NULL pointer drivers/char/nozomi.c:1031:68: warning: Using plain integer as NULL poi

Re: [PATCH -mm 1/4] Blackfin: architecture update patch

2007-03-21 Thread Wu, Bryan
On Wed, 2007-03-21 at 15:53 -0700, Andrew Morton wrote: > On Wed, 21 Mar 2007 18:19:23 +0800 > "Wu, Bryan" <[EMAIL PROTECTED]> wrote: > > > 1) Some issues are fixed according to LKML patch review. > > 2) Remove not supported BF535 code > > 3) Fixed some bugs from blackfin.uclinux.org SVN update >

[PATCH 2.6.21 5/4] cxgb3 - fix white spaces in drivers/net/Kconfig

2007-03-21 Thread divy
From: Divy Le Ray <[EMAIL PROTECTED]> Use tabs instead of white spaces for CHELSIO_T3 entry. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/Kconfig | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/net/Kconfig b/drivers/net

Re: [PATCH] FRV: Fix unannotated variable declarations

2007-03-21 Thread Yasunori Goto
> From: David Howells <[EMAIL PROTECTED]> > > Fix unannotated variable declarations. Variables that have allocation section > annotations (such as __meminitdata) on their definitions must also have them > on > their declarations as not doing so may affect the addressing mode used by the > compil

Re: [PATCH 2/2] Replace pid_t in autofs with struct pid reference

2007-03-21 Thread Serge E. Hallyn
Quoting Ian Kent ([EMAIL PROTECTED]): > On Tue, 2007-03-20 at 16:01 -0600, Eric W. Biederman wrote: > > "Serge E. Hallyn" <[EMAIL PROTECTED]> writes: > > > > >> > void autofs4_dentry_release(struct dentry *); > > >> > extern void autofs4_kill_sb(struct super_block *); > > >> > diff --git a/fs/au

Re: [PATCH 2.6.21 3/4] cxgb3 - Fix potential MAC hang

2007-03-21 Thread Divy Le Ray
Andrew Morton wrote: On Sun, 18 Mar 2007 13:10:12 -0700 [EMAIL PROTECTED] wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Under rare conditions, the MAC might hang while generating a pause frame. This patch fine tunes the MAC settings to avoid the issue, allows for periodic MAC state check, a

[PATCH] sched: rsdl check for niced tasks lowering prio level

2007-03-21 Thread Con Kolivas
Here is the best fix for the bug pointed out. Thanks. I'll try and find pc time to wrap these two patches together and make a v0.32 available. --- Ensure niced tasks are not inappropriately limiting sleeping unniced tasks by explicitly checking what the best static priority that has run this majo

Re: AIO, FIO and Threads ...

2007-03-21 Thread Davide Libenzi
On Wed, 21 Mar 2007, Jens Axboe wrote: > On Tue, Mar 20 2007, Davide Libenzi wrote: > > > > I was looking at Jens FIO stuff, and I decided to cook a quick patch for > > FIO to support GUASI (Generic Userspace Asyncronous Syscall Interface): > > > > http://www.xmailserver.org/guasi-lib.html > >

Re: [PATCH 2/2] Replace pid_t in autofs with struct pid reference

2007-03-21 Thread Ian Kent
On Tue, 2007-03-20 at 16:01 -0600, Eric W. Biederman wrote: > "Serge E. Hallyn" <[EMAIL PROTECTED]> writes: > > >> > void autofs4_dentry_release(struct dentry *); > >> > extern void autofs4_kill_sb(struct super_block *); > >> > diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c > >> > index 98

Re: [PATCH 2.6.21 2/4] cxgb3 - Auto-load FW if mismatch detected

2007-03-21 Thread Divy Le Ray
Andrew Morton wrote: On Sun, 18 Mar 2007 13:10:06 -0700 [EMAIL PROTECTED] wrote: config CHELSIO_T3 tristate "Chelsio Communications T3 10Gb Ethernet support" depends on PCI + select FW_LOADER Something has gone wrong with the indenting there. The added li

Re: 2.6.21-rc1 and 2.6.21-rc2 kwin dies silently

2007-03-21 Thread Randy Dunlap
On Thu, 22 Mar 2007 01:32:36 + Sid Boyce wrote: > Eric W. Biederman wrote: > > Adrian Bunk <[EMAIL PROTECTED]> writes: > > > > > >> On Wed, Mar 21, 2007 at 05:43:11PM +, Sid Boyce wrote: > >> > >>> Sid Boyce wrote: > >>> > Andrew Morton wrote: > > > (c

mmap and swap

2007-03-21 Thread Phy Prabab
Hello, I have a mysterious issue with swapping. I have a 32b machine running 2.4.21.x (RHEE30) w/4G RAM and 8G swap. If I run one application and pause it after having allocated 2.5G and then run another application (or just another instance of the same app) and try to allocate another 2.5G I w

Re: 2.6.21-rc1 and 2.6.21-rc2 kwin dies silently

2007-03-21 Thread Sid Boyce
Eric W. Biederman wrote: Adrian Bunk <[EMAIL PROTECTED]> writes: On Wed, Mar 21, 2007 at 05:43:11PM +, Sid Boyce wrote: Sid Boyce wrote: Andrew Morton wrote: (cc restored. Please always do reply-to-all) On Wed, 28 Feb 2007 18:05:13 +0200 [EMAIL PROT

  1   2   3   4   5   >