Re: util-linux: orphan

2006-12-29 Thread Valdis . Kletnieks
On Wed, 27 Dec 2006 23:12:51 +0100, Karel Zak said: > For example for my laptop is it true that "life is too short to > enable SELinux", but it's probably not true for servers in the bank where > I have money. (I hope so:-) On the other hand, the case can be made that your laptop needs SELinux

Re: [BUG 2.6.20-rc2] atkbd.c: Spurious ACK

2006-12-29 Thread Rene Herman
Dmitry Torokhov wrote: Somehow you get 2 ACks in a row, I wonder if on your boxes i8042 pumps command and data into keyboard before i8042_interrupt gets a chance to run. Could you please apply the debug patch below and tell me the pattern of the data flow. Yes, I believe the below trace confir

Re: Oops in 2.6.19-rc6-mm2 on USB disconnect

2006-12-29 Thread Pete Zaitcev
On Fri, 29 Dec 2006 20:45:57 -0500, Eric Buddington <[EMAIL PROTECTED]> wrote: > Kernel 2.6.19-rc6-mm2 on an Athlon XP gave me the following Oops when > unplugging a USB device. I an usually plug and unplug devices without > trouble, so this is probably not easily repeatable. > [1742510.173840] PR

Re: [patch 2.6.20-rc1 5/6] SA1100 GPIO wrappers

2006-12-29 Thread David Brownell
On Friday 29 December 2006 7:15 pm, Nicolas Pitre wrote: > On Fri, 29 Dec 2006, David Brownell wrote: > > > Here's a version that compiles ... > > This patch is completely broken. It's just what Philipp sent, with the "won't compile" bugs fixed. Oh, and some #include tweaks. Philipp? > > Arch

Re: [PATCH 2.6.16.29 1/1] memory: enhance Linux swap subsystem

2006-12-29 Thread Zhou Yingchao
2006/12/27, yunfeng zhang <[EMAIL PROTECTED]>: To multiple address space, multiple memory inode architecture, we can introduce a new core object -- section which has several features Do you mean "in-memory inode" or "memory node(pglist_data)" by "memory inode" ? The idea issued by me is whethe

Re: [BUG 2.6.20-rc2] atkbd.c: Spurious ACK

2006-12-29 Thread Dmitry Torokhov
On Friday 29 December 2006 14:08, Rene Herman wrote: > Laurent Riffard wrote: > > > Le 29.12.2006 06:54, Rene Herman a écrit : > > >> Not even an analog camera, but with or without the above, I get a single: > >> > >> " <7>drivers/input/serio/i8042.c: fa <- i8042 (interrupt, 0, 1) [ 902]" > > ..

[KORG] re: [PATCH] cfq-iosched: tighten allow merge criteria - error in final return value ?

2006-12-29 Thread DAVID HORNER
I noticed a probable error in commit 719d34027e1a186e46a3952e8a24bf91ecc33837 > > - if (cfqq != RQ_CFQQ(rq)) > - return 0; > + > + if (cfqq == RQ_CFQQ(rq)) > + return 1; > > return 1; > } Either the final return value should be 0 (zero) or the if statement is redundant. (I lack

Re: [PATCH] Print sysrq-m messages with KERN_INFO priority

2006-12-29 Thread * *
Was this patch tested? On 12/29/06, Theodore Ts'o <[EMAIL PROTECTED]> wrote: Print messages resulting from sysrq-m with a KERN_INFO instead of the default KERN_WARNING priority Signed-off-by: "Theodore Ts'o" <[EMAIL PROTECTED]> Index: linux-2.6/mm/page_alloc.c =

Re: [RFC][PATCH -mm take2 3/5] add interface for netconsole using sysfs

2006-12-29 Thread Stephen Hemminger
Keiichi KII wrote: > From: Keiichi KII <[EMAIL PROTECTED]> > > This patch contains the following changes. > > create a sysfs entry for netconsole in /sys/class/misc. > This entry has elements related to netconsole as follows. > You can change configuration of netconsole(writable attributes such as

Re: [PATCH] Print sysrq-m messages with KERN_INFO priority

2006-12-29 Thread Dave Jones
On Fri, Dec 29, 2006 at 08:42:47PM -0800, Andrew Morton wrote: > On Fri, 29 Dec 2006 22:24:53 -0500 > "Theodore Ts'o" <[EMAIL PROTECTED]> wrote: > > > Print messages resulting from sysrq-m with a KERN_INFO instead of the > > default KERN_WARNING priority > > hm, I wonder why. If someone d

Re: [PATCH] Print sysrq-m messages with KERN_INFO priority

2006-12-29 Thread Andrew Morton
On Fri, 29 Dec 2006 22:24:53 -0500 "Theodore Ts'o" <[EMAIL PROTECTED]> wrote: > Print messages resulting from sysrq-m with a KERN_INFO instead of the > default KERN_WARNING priority hm, I wonder why. If someone does sysrq- then they presumably want to display the result? Tricky. Is this patch

Re: Display class

2006-12-29 Thread Dmitry Torokhov
Hi, On Tuesday 05 December 2006 13:03, James Simmons wrote: > +int probe_edid(struct display_device *dev, void *data) > +{ > +   struct fb_monspecs spec; > +   ssize_t size = 45; const ssize_t size = 45? > + > +   dev->name = kzalloc(size, GFP_KERNEL); Why do you need kzalloc here?

[PATCH] Print sysrq-m messages with KERN_INFO priority

2006-12-29 Thread Theodore Ts'o
Print messages resulting from sysrq-m with a KERN_INFO instead of the default KERN_WARNING priority Signed-off-by: "Theodore Ts'o" <[EMAIL PROTECTED]> Index: linux-2.6/mm/page_alloc.c === --- linux-2.6.orig/mm/page_alloc.c 2006-

[patch] aio: make aio_ring_info->nr_pages an unsigned int

2006-12-29 Thread Chen, Kenneth W
The number of io_event in AIO event queue allowed currently is no more than 2^32-1, because the syscall defines: asmlinkage long sys_io_setup(unsigned nr_events, aio_context_t __user *ctxp) We internally allocate a ring buffer for nr_events and keeps tracks of page descriptors for each o

Re: [patch 2.6.20-rc1 5/6] SA1100 GPIO wrappers

2006-12-29 Thread Nicolas Pitre
On Fri, 29 Dec 2006, David Brownell wrote: > Here's a version that compiles ... This patch is completely broken. > Arch-neutral GPIO calls for PXA. This is not PXA but SA1100 to start with. > Signed-off-by: David Brownell <[EMAIL PROTECTED]> > > Index: pxa/include/asm-arm/arch-sa1100/gpio.h >

Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer

2006-12-29 Thread Komuro
> > > I investigated the ftp-file-transfer-stop problem by git-bisect method, > > and found this problem was introduced by > > "[TCP]: MD5 Signature Option (RFC2385) support" patch. > > > > Mr.YOSHIFUJI san, please fix this problem. > > Hmm, have you try disabling CONFIG_TCP_MD5SIG? > (Is it al

[patch] aio: remove spurious ring head index modulo info->nr

2006-12-29 Thread Chen, Kenneth W
In aio_read_evt(), the ring->head will never wrap info->nr because we already does the wrap when updating the ring head index: if (head != ring->tail) { ... head = (head + 1) % info->nr; ring->head = head; } This makes the modulo of

Re: potential for buffer_head shrinkage.

2006-12-29 Thread Dave Jones
On Fri, Dec 29, 2006 at 09:45:54PM -0500, Dave Jones wrote: > Looking at struct buffer_head, it seems that b_state > uses at most 15 bits, where it's defined as a 64bit entity > due to it being used by bit_spin_lock and friends. > > Given it's not uncommon for a few hundred thousand of these

[patch] aio: streamline read events after woken up

2006-12-29 Thread Chen, Kenneth W
The read event loop in the blocking path is also inefficient. For every event it reap (if not blocking), it does the following in a loop: while (i < nr) { prepare_to_wait_exclusive aio_read_evt finish_wait ... } Given the previous patch

potential for buffer_head shrinkage.

2006-12-29 Thread Dave Jones
Looking at struct buffer_head, it seems that b_state uses at most 15 bits, where it's defined as a 64bit entity due to it being used by bit_spin_lock and friends. Given it's not uncommon for a few hundred thousand of these to be present, I wonder if it's worth the effort of folding b_count into th

Re: [patch 2.6.20-rc1 4/6] PXA GPIO wrappers

2006-12-29 Thread David Brownell
On Friday 29 December 2006 6:15 pm, Nicolas Pitre wrote: > On Thu, 28 Dec 2006, David Brownell wrote: > > > Phillip: is this the final version, then? It's missing > > a signed-off-by line, so I can't do anything appropriate. > > > > Nico, your signoff here would be a Good Thing too if it > > me

[patch] aio: add per task aio wait event condition

2006-12-29 Thread Chen, Kenneth W
The AIO wake-up notification from aio_complete is really inefficient in current AIO implementation in the presence of process waiting in io_getevents(). For example, if app calls io_getevents with min_nr > 1, and aio event queue doesn't have enough completed aio event, the process will block in re

Re: [patch 2.6.20-rc1 5/6] SA1100 GPIO wrappers

2006-12-29 Thread David Brownell
Here's a version that compiles ... From: Philipp Zabel <[EMAIL PROTECTED]> Arch-neutral GPIO calls for PXA. Signed-off-by: David Brownell <[EMAIL PROTECTED]> Index: pxa/include/asm-arm/arch-sa1100/gpio.h === --- /dev/null 1970-01-01

Re: [patch 2.6.20-rc1 4/6] PXA GPIO wrappers

2006-12-29 Thread Nicolas Pitre
On Thu, 28 Dec 2006, David Brownell wrote: > Phillip: is this the final version, then? It's missing > a signed-off-by line, so I can't do anything appropriate. > > Nico, your signoff here would be a Good Thing too if it > meets your technical review. (My only comment, ISTR, was > that gpio_set

Re: OpenAFS gatekeepers request addition of AFS_SUPER_MAGIC to magic.h

2006-12-29 Thread Adam Megacz
Drat. Diffed in the wrong direction. Yes, you're right. - a Stephen Frost <[EMAIL PROTECTED]> writes: > * Adam Megacz ([EMAIL PROTECTED]) wrote: >> --- include/linux/magic.h 2006-12-29 15:48:50.0 -0800 >> +++ include/linux/magic.h 2006-11-29 13:57:37.0 -0800 >> @@

Re: 2.6.20-rc2: known unfixed regressions

2006-12-29 Thread Adrian Bunk
On Fri, Dec 29, 2006 at 10:21:36PM -0300, Horst H. von Brand wrote: > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > [...] > > > Subject: BUG at fs/buffer.c:1235 when using gdb > > References : http://lkml.org/lkml/2006/12/17/134 > > Submitter : Andrew J. Barr <[EMAIL PROTECTED]> > > Fixed-By

Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer

2006-12-29 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Sat, 30 Dec 2006 18:50:43 +0900), Komuro <[EMAIL PROTECTED]> says: > I investigated the ftp-file-transfer-stop problem by git-bisect method, > and found this problem was introduced by > "[TCP]: MD5 Signature Option (RFC2385) support" patch. > > Mr.YOSHIFUJI san

Oops in 2.6.19-rc6-mm2 on USB disconnect

2006-12-29 Thread Eric Buddington
Kernel 2.6.19-rc6-mm2 on an Athlon XP gave me the following Oops when unplugging a USB device. I an usually plug and unplug devices without trouble, so this is probably not easily repeatable. -Eric -- [1742504.966893] usb 1-6.4.

[patch] aio: fix buggy put_ioctx call in aio_complete - v2

2006-12-29 Thread Chen, Kenneth W
An AIO bug was reported that sleeping function is being called in softirq context: BUG: warning at kernel/mutex.c:132/__mutex_lock_common() Call Trace: [] __mutex_lock_slowpath+0x640/0x6c0 [] mutex_lock+0x20/0x40 [] flush_workqueue+0xb0/0x1a0 [] __put_ioctx+0xc0/0x240 [] a

Re: 2.6.20-rc2: known unfixed regressions

2006-12-29 Thread Horst H. von Brand
Adrian Bunk <[EMAIL PROTECTED]> wrote: [...] > Subject: BUG at fs/buffer.c:1235 when using gdb > References : http://lkml.org/lkml/2006/12/17/134 > Submitter : Andrew J. Barr <[EMAIL PROTECTED]> > Fixed-By : Jeremy Fitzhardinge <[EMAIL PROTECTED]> > Commit : 8701ea957dd2a7c309e17c8dcde

Re: [patch 2.6.20-rc1 1/6] GPIO core

2006-12-29 Thread David Brownell
On Thursday 28 December 2006 4:27 pm, Pavel Machek wrote: > > > > > +GPIOs are identified by unsigned integers in the range 0..MAX_INT > > > > > > Perhaps these should not be integers, then? > > > > Thing is, the platforms **DO** identify them as integers. > > ... > > Well. when you see (so

Re: Ok, explained.. (was Re: [PATCH] mm: fix page_mkclean_one)

2006-12-29 Thread Andrew Morton
On Fri, 29 Dec 2006 16:58:41 -0800 (PST) Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > On Fri, 29 Dec 2006, Andrew Morton wrote: > > > > > > Somewhat nastily, but as ext3 directories are metadata it is appropriate > > > > that modifications to them be done in terms of buffer_heads (ie: > > >

Re: [patch 2.6.20-rc1 4/6] PXA GPIO wrappers

2006-12-29 Thread David Brownell
Just FYI -- I updated your patch, fixed a compile bug, and switched some code over to use this new API. The patch is appended. I happen to think it's a lot easier to read this way. Maybe to some people it's easy to remember what a GPLR, GPCR, and GPSR register is supposed to do, after a long tim

Re: Finding hardlinks

2006-12-29 Thread Mikulas Patocka
On Fri, 29 Dec 2006, Trond Myklebust wrote: On Thu, 2006-12-28 at 19:14 +0100, Mikulas Patocka wrote: Why don't you rip off the support for colliding inode number from the kernel at all (i.e. remove iget5_locked)? It's reasonable to have either no support for colliding ino_t or full support

Re: Ok, explained.. (was Re: [PATCH] mm: fix page_mkclean_one)

2006-12-29 Thread Linus Torvalds
On Fri, 29 Dec 2006, Andrew Morton wrote: > > > > Somewhat nastily, but as ext3 directories are metadata it is appropriate > > > that modifications to them be done in terms of buffer_heads (ie: blocks). > > > > No. There is nothing "appropriate" about using buffer_heads for metadata. > > I sai

Re: open /dev/kvm: No such file or directory

2006-12-29 Thread H. Peter Anvin
Avi Kivity wrote: Greg, /dev/kvm is a MISC_DYNAMIC_MINOR device. Is there any way of using it without udev? Should I allocate a static number? Especially for something like /dev/kvm, I think it would make sense to allocate a static number for it. -hpa - To unsubscribe from thi

Re: Ok, explained.. (was Re: [PATCH] mm: fix page_mkclean_one)

2006-12-29 Thread Linus Torvalds
On Fri, 29 Dec 2006, Andrew Morton wrote: > > Adam Richter spent considerable time a few years ago trying to make the > mpage code go direct-to-BIO in all cases and we eventually gave up. The > conceptual layering of page<->blocks<->bio is pretty clean, and it is hard > and ugly to fully optimi

Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer

2006-12-29 Thread Komuro
Hi, I investigated the ftp-file-transfer-stop problem by git-bisect method, and found this problem was introduced by "[TCP]: MD5 Signature Option (RFC2385) support" patch. Mr.YOSHIFUJI san, please fix this problem. >commit cfb6eeb4c860592edd123fdea908d23c6ad1c7dc >Author: YOSHIFUJI Hideaki <[EMA

Re: OpenAFS gatekeepers request addition of AFS_SUPER_MAGIC to magic.h

2006-12-29 Thread Stephen Frost
* Adam Megacz ([EMAIL PROTECTED]) wrote: > --- include/linux/magic.h 2006-12-29 15:48:50.0 -0800 > +++ include/linux/magic.h 2006-11-29 13:57:37.0 -0800 > @@ -3,7 +3,6 @@ > > #define ADFS_SUPER_MAGIC 0xadf5 > #define AFFS_SUPER_MAGIC 0xadff > -#define AFS

Re: Ok, explained.. (was Re: [PATCH] mm: fix page_mkclean_one)

2006-12-29 Thread Andrew Morton
On Fri, 29 Dec 2006 16:11:44 -0800 (PST) Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > > JBD implements physical block-based journalling, so it is 100% appropriate > > that JBD deal with these disk blocks using their buffer_head > > representation. > > And as long as it does that, you just ha

Re: Ok, explained.. (was Re: [PATCH] mm: fix page_mkclean_one)

2006-12-29 Thread Linus Torvalds
On Fri, 29 Dec 2006, Andrew Morton wrote: > > They're extra. As in "can be optimised away". Sure. Don't use buffer heads. > The buffer_head is not an IO container. It is the kernel's core > representation of a disk block. Please come back from the 90's. The buffer heads are nothing but a m

Re: Ok, explained.. (was Re: [PATCH] mm: fix page_mkclean_one)

2006-12-29 Thread Andrew Morton
On Fri, 29 Dec 2006 18:32:07 -0500 Theodore Tso <[EMAIL PROTECTED]> wrote: > On Fri, Dec 29, 2006 at 02:42:51PM -0800, Linus Torvalds wrote: > > I think ext3 is terminally crap by now. It still uses buffer heads in > > places where it really really shouldn't, and as a result, things like > > dir

OpenAFS gatekeepers request addition of AFS_SUPER_MAGIC to magic.h

2006-12-29 Thread Adam Megacz
Hello, Jeffrey Altman, one of the gatekeepers of OpenAFS (the open source project which inherited the Transarc/IBM AFS codebase) has requested that the magic number 0x5346414F (little endian 'OAFS') be allocated for the f_type field of the fsinfo structure on Linux: https://lists.openafs.org/p

Re: Want comments regarding patch

2006-12-29 Thread Bodo Eggert
Jan Engelhardt <[EMAIL PROTECTED]> wrote: > On Dec 29 2006 07:57, Daniel Marjamäki wrote: >> It was my goal to improve the readability. I failed. >> >> I personally prefer to use standard functions instead of writing code. >> In my opinion using standard functions means less code that is easier to

Re: Ok, explained.. (was Re: [PATCH] mm: fix page_mkclean_one)

2006-12-29 Thread Linus Torvalds
On Fri, 29 Dec 2006, Theodore Tso wrote: > > If we do get this fixed for ext4, one interesting question is whether > people would accept a patch to backport the fixes to ext3, given the > the grief this is causing the page I/O and VM routines. I don't think backporting is the smartest option (un

Re: [PATCH 1/6] UML - Console locking fixes

2006-12-29 Thread Randy Dunlap
On Fri, 29 Dec 2006 18:41:27 -0500 Jeff Dike wrote: > arch/um/drivers/line.c | 188 > ++-- > arch/um/drivers/stdio_console.c |6 - > arch/um/include/line.h | 14 +- > 3 files changed, 135 insertions(+), 73 deletions(-) > > Index: linu

RE: 2.6.19-rt14 slowdown compared to 2.6.19

2006-12-29 Thread Chen, Tim C
Ingo Molnar wrote: > > If you'd like to profile this yourself then the lowest-cost way of > profiling lock contention on -rt is to use the yum kernel and run the > attached trace-it-lock-prof.c code on the box while your workload is > in 'steady state' (and is showing those extended idle times): >

Re: Ok, explained.. (was Re: [PATCH] mm: fix page_mkclean_one)

2006-12-29 Thread Andrew Morton
On Fri, 29 Dec 2006 14:42:51 -0800 (PST) Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > On Fri, 29 Dec 2006, Andrew Morton wrote: > > > > - The above change means that we do extra writeout. If a page is dirtied > > once, kjournald will write it and then pdflush will come along and > > nee

[PATCH 0/6] UML - Locking, whitespace, style, and hotplug fixes

2006-12-29 Thread Jeff Dike
This stuff is all post-2.6.20 material. I'm fixing the locking through UML, and discovering other nastinesses along the way. Patches 1, 4, and 5 fix locking in the console and network drivers. I have a huge raft of whitespace and style fixes which I will feed in as I fix the locking in the same

[PATCH 6/6] UML - Network driver whitespace and style fixes

2006-12-29 Thread Jeff Dike
Some whitespace and coding style cleanups in the network driver code. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/drivers/net_kern.c | 29 +++-- arch/um/include/net_kern.h |6 +++--- 2 files changed, 18 insertions(+), 17 deletions(-) Index: linux-2.6.18

[PATCH 5/6] UML - Add locking to network transport registration

2006-12-29 Thread Jeff Dike
The registration of host network transports needed some locking. The transport list itself is locked, but calls to the registration routines are not. This is compensated for by checking that a transport structure is not yet on any list. I also took the opportunity to const all fields in the tran

[PATCH 1/6] UML - Console locking fixes

2006-12-29 Thread Jeff Dike
Clean up the console driver locking. There are various problems here, including sleeping under a spinlock and spinlock recursion, some of which are fixed here. This patch deals with the locking involved with opens and closes. The problem is that an mconsole request to change a console's configur

[PATCH 2/6] UML - Return hotplug errors to host

2006-12-29 Thread Jeff Dike
I noticed that errors happening while hotplugging devices from the host were never returned back to the mconsole client. In some cases, success was returned instead of even an information-free error. This patch cleans that up by having the low-level configuration code pass back an error string al

[PATCH 3/6] UML - Console whitespace and comment tidying

2006-12-29 Thread Jeff Dike
Some comment and whitespace cleanups in the console and mconsole code. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/drivers/stdio_console.c |2 -- arch/um/include/mconsole_kern.h |2 +- 2 files changed, 1 insertion(+), 3 deletions(-) Index: linux-2.6.18-mm/arch/um/drivers/st

[PATCH 4/6] UML - Lock the irqs_to_free list

2006-12-29 Thread Jeff Dike
Fix (i.e. add some) the locking around the irqs_to_free list. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/drivers/chan_kern.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) Index: linux-2.6.18-mm/arch/um/drivers/chan_kern.c ===

Re: Ok, explained.. (was Re: [PATCH] mm: fix page_mkclean_one)

2006-12-29 Thread Theodore Tso
On Fri, Dec 29, 2006 at 02:42:51PM -0800, Linus Torvalds wrote: > I think ext3 is terminally crap by now. It still uses buffer heads in > places where it really really shouldn't, and as a result, things like > directory accesses are simply slower than they should be. Sadly, I don't > think ext4

[PATCH] lock stat for -rt 2.6.20-rc2-rt2 [was Re: 2.6.19-rt14 slowdown compared to 2.6.19]

2006-12-29 Thread hui
On Tue, Dec 26, 2006 at 04:51:21PM -0800, Chen, Tim C wrote: > Ingo Molnar wrote: > > If you'd like to profile this yourself then the lowest-cost way of > > profiling lock contention on -rt is to use the yum kernel and run the > > attached trace-it-lock-prof.c code on the box while your workload is

[git patches] ocfs2 fixes

2006-12-29 Thread Mark Fasheh
Hi Linus, Here are some 2.6.20 fixes for ocfs2. The patch by Zhen Wei isn't really a fix, but a very small amount of support for a feature which is mostly implemented in ocfs2-tools. Considering it's just a single attribute export via configfs, I'd say it's pretty safe to merge. Please pul

Re: VM: Fix nasty and subtle race in shared mmap'ed page writeback

2006-12-29 Thread Andrea Gelmini
On Fri, Dec 29, 2006 at 06:59:02PM +, Linux Kernel Mailing List wrote: > Gitweb: > http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7658cc289288b8ae7dd2c2224549a048431222b3 > Commit: 7658cc289288b8ae7dd2c2224549a048431222b3 > Parent: 3bf8ba38f38d36473

Re: 2.6.20-rc2: kernel BUG at include/asm/dma-mapping.h:110!

2006-12-29 Thread Stefan Richter
Benjamin Herrenschmidt wrote: >> Bisecting has identified this commit: >> >> commit 9b7d9c096dd4e4baacc21b2588662bbb56f36c4e >> Author: Stefan Richter <[EMAIL PROTECTED]> >> Date: Wed Nov 22 21:44:34 2006 +0100 >> >> ieee1394: sbp2: convert from PCI DMA to generic DMA >> >> API con

Re: Ok, explained.. (was Re: [PATCH] mm: fix page_mkclean_one)

2006-12-29 Thread Linus Torvalds
On Fri, 29 Dec 2006, Andrew Morton wrote: > > - The above change means that we do extra writeout. If a page is dirtied > once, kjournald will write it and then pdflush will come along and > needlessly write it again. There's zero extra writeout for any flushing that flushes BY PAGES. Only

Re: Ok, explained.. (was Re: [PATCH] mm: fix page_mkclean_one)

2006-12-29 Thread Andrew Morton
On Fri, 29 Dec 2006 14:16:32 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > - Poor old IO accounting broke again. No it didn't - we're relying upon the behaviour of __set_page_dirty_buffers() against an already-dirty page. - To unsubscribe from this list: send the line "unsubscribe linux-kernel

Re: [patch] remove MAX_ARG_PAGES

2006-12-29 Thread Ingo Molnar
[Cc:-ed Ulrich too] * Linus Torvalds <[EMAIL PROTECTED]> wrote: > On Fri, 29 Dec 2006, Russell King wrote: > > > > Suggest you test (eg) a rebuild of libX11 to see how it reacts to > > this patch. > > Also: please rebuild "xargs" and install first. Otherwise, a lot of > build script etc that

Re: No sound in KDE with intel hda since 2.6.20-rc1

2006-12-29 Thread Ismail Dönmez
29 Ara 2006 Cum 09:18 tarihinde, Michael S. Tsirkin şunları yazmıştı: > > Since 2.6.20-rc1 (tested both -rc1 and rc2), system notification sounds > > under KDE, and sound in games (e.g. TuxPaint) no longer seem to work on > > my T60 thinkpad. Works fine under 2.6.19 though. The strange thing is >

Re: Ok, explained.. (was Re: [PATCH] mm: fix page_mkclean_one)

2006-12-29 Thread Andrew Morton
On Fri, 29 Dec 2006 02:48:35 -0800 (PST) Linus Torvalds <[EMAIL PROTECTED]> wrote: > + if (mapping && mapping_cap_account_dirty(mapping)) { > + /* > + * Yes, Virginia, this is indeed insane. > + * > + * We use this sequence to make sure that >

Re: Three if-clauses of constant logic value; char drivers for kernel 2.4.33.3

2006-12-29 Thread Willy Tarreau
On Tue, Dec 19, 2006 at 09:59:37PM +0100, Mats Erik Andersson wrote: > Hi there, all masters of kernel code, Hi ! > I just discovered that the kernel code for 2.4.33.3 contains three > if-statements that never can change their values, whence they should > be repaired or eliminated. In source dire

Re: PROBLEM: setup apm as module version 2.4.34

2006-12-29 Thread Willy Tarreau
Hi, On Fri, Dec 29, 2006 at 07:28:55PM +0100, Dr.-Ing. Ingo D. Rullhusen wrote: > Hello, > > i hope that's the right address for this little problem, which arises > with linux kernel 2.4.34. Yes, it's the right address. > If i compile the Advanced Power Management as module it do not work. If

[PATCH] ondemand governor use new cpufreq rwsem locking in work callback

2006-12-29 Thread Venkatesh Pallipadi
Eliminate flush_workqueue in cpufreq_governor(STOP) callpath. Using flush there has a deadlock potential as in http://uwsg.iu.edu/hypermail/linux/kernel/0611.3/1223.html Also, cleanup the locking issues with do_dbs_timer delayed_work callback. As it changes the CPU frequency using __cpufreq_ta

[PATCH] ondemand governor restructure the work callback

2006-12-29 Thread Venkatesh Pallipadi
Restructure the delayed_work callback in ondemand. This eliminates the need for smp_processor_id in the callback function and also helps in proper locking and avoiding flush_workqueue when stopping the governor (done in subsequent patch). Signed-off-by: Venkatesh Pallipadi <[EMAIL PROTECTED]> I

[PATCH] Rewrite lock in cpufreq to eliminate cpufreq/hotplug related issues

2006-12-29 Thread Venkatesh Pallipadi
Yet another attempt to resolve cpufreq and hotplug locking issues. Patchset has 3 patches: * Rewrite the lock infrastructure of cpufreq using a per cpu rwsem. * Minor restructuring of work callback in ondemand driver. * Use the new cpufreq rwsem infrastructure in ondemand work. This patch: Con

[PATCH] kobject: kobj->k_name verification fix

2006-12-29 Thread Martin Stoilov
The function 'kobject_add' tries to verify the name of a new kobject instance is properly set before continuing. if (!kobj->k_name) kobj->k_name = kobj->name; if (!kobj->k_name) { pr_debug("kobject attempted to be registered with no name!\n"); WARN_ON(1); ret

Re: [patch] remove MAX_ARG_PAGES

2006-12-29 Thread Ingo Molnar
* Russell King <[EMAIL PROTECTED]> wrote: > On Fri, Dec 29, 2006 at 09:03:57PM +0100, Ingo Molnar wrote: > > FYI, i have forward ported your MAX_ARG_PAGES limit removal patch to > > 2.6.20-rc2 and have included it in the -rt kernel. It's working great - > > i can now finally do a "ls -t patches

Re: 2.6.20-rc2: kernel BUG at include/asm/dma-mapping.h:110!

2006-12-29 Thread Benjamin Herrenschmidt
> Bisecting has identified this commit: > > commit 9b7d9c096dd4e4baacc21b2588662bbb56f36c4e > Author: Stefan Richter <[EMAIL PROTECTED]> > Date: Wed Nov 22 21:44:34 2006 +0100 > > ieee1394: sbp2: convert from PCI DMA to generic DMA > > API conversion without change in functionalit

[PATCH 2/2] Handle error in sync_sb_inodes()

2006-12-29 Thread Guillaume Chazarain
Against 2.6.20-rc2, and now the bug fix. -- Guillaume I/O errors could go unnoticed when syncing, for example the following code could write a file bigger than 10Mib on a 10Mib filesystem. With this patch, msync() will report the error originally encountered by sync(). Tuning the number of sync

Re: PROBLEM: 2.6.19 + highmem = BUG at do_wp_page

2006-12-29 Thread Sami Farin
On Tue, Dec 12, 2006 at 15:10:56 -0500, Chuck Ebbert wrote: > In-Reply-To: <[EMAIL PROTECTED]> > > On Tue, 5 Dec 2006 19:25:13 +0200, Sami Farin wrote: > > > BUG: unable to handle kernel paging request at virtual address fffb9dc0 > > > eax: fffb8000 ebx: fffb9000 ecx: 0090 edx: 000

[PATCH 1/2] Factor outstanding I/O error handling

2006-12-29 Thread Guillaume Chazarain
Against 2.6.20-rc2, first some cleanup, then a bug fix. -- Guillaume Cleanup: setting an outstanding error on a mapping was open coded too many times. Factor it out in mapping_set_error(). Signed-off-by: Guillaume Chazarain <[EMAIL PROTECTED]> --- fs/gfs2/glops.c |5 + fs/mpag

Re: [Patch] scsi: megaraid_{mm,mbox}: init fix for kdump

2006-12-29 Thread Randy Dunlap
On Fri, 29 Dec 2006 08:02:17 -0800 Sumant Patro wrote: See Documentation/SubmittingPatches: Please include output of "diffstat -p1 -w70" so that we can easily see the scope of the changes. and see Documentation/CodingStyle for comments below: > diff -uprN linux-2.6.orig/drivers/scsi/megaraid/me

[Patch] scsi: megaraid_{mm,mbox}: init fix for kdump

2006-12-29 Thread Sumant Patro
- Changes in Initialization to fix kdump failure. Without this fix, megaraid driver either panics or fails to initialize the adapter during the kdump's 2nd kernel boot if there are pending commands or interrupts from other devices sharing the same IRQ. Fix:Send SYNC command on loading. This comman

Re: [patch] remove MAX_ARG_PAGES

2006-12-29 Thread Linus Torvalds
On Fri, 29 Dec 2006, Russell King wrote: > > Suggest you test (eg) a rebuild of libX11 to see how it reacts to > this patch. Also: please rebuild "xargs" and install first. Otherwise, a lot of build script etc that use "xargs" won't ever trigger the new limits (or lack thereof), because xargs

[Patch] scsi:megaraid_sas:Update module author

2006-12-29 Thread Sumant Patro
Update domain name change from lsil.com to lsi.com. Change module author to [EMAIL PROTECTED] Signed-Off By: Sumant Patro <[EMAIL PROTECTED]> diff -uprN linux-2.6.orig/drivers/scsi/megaraid/megaraid_sas.c linux-2.6.new/drivers/scsi/megaraid/megaraid_sas.c --- linux-2.6.orig/drivers/scsi/megaraid

Re: PROBLEM: setup apm as module version 2.4.34

2006-12-29 Thread bert hubert
On Fri, Dec 29, 2006 at 07:28:55PM +0100, Dr.-Ing. Ingo D. Rullhusen wrote: > i hope that's the right address for this little problem, which arises > with linux kernel 2.4.34. > > If i compile the Advanced Power Management as module it do not work. If > i try a depmod i get an unresolved symbols

[PATCH -rt] scheduling while atomic in remove_proc_entry()

2006-12-29 Thread Daniel Walker
Found this in 2.6.20-rc2-rt3 w/ PREEMPT_RT off on x86_64, BUG: scheduling while atomic: swapper/0x0001/1, CPU#0 Call Trace: [] __sched_text_start+0xb0/0x85a [] try_to_wake_up+0x3fc/0x420 [] add_preempt_count+0x2b/0x130 [] schedule+0xe5/0x110 [] flush_cpu_workqueue+0x8d/0xd0 [] autoremov

Re: OpenSolaris under KVM?

2006-12-29 Thread Parag Warudkar
Avi Kivity argo.co.il> writes: > > John Freighter wrote: > > Has anybody succeded running OpenSolaris under KVM virtualization? > > Before I download OS install DVD in vain... > > > > There was indeed a report (and a patch) from Michael Riepe to that > effect. -rc2 should contain that patch.

[PATCH 4/4] Char: mxser_new, fix twice resource releasing

2006-12-29 Thread Jiri Slaby
mxser_new, fix twice resource releasing Because brd->info is not NULLed, resources are released twice. NULL it in pci_remove function. Also take care of retval and releasing in pci_probe -- mxser_initbrd alreasy releases resource, do not do it again in fail path in probe function. Cc: Sergei Orga

[PATCH 3/4] Char: mxser_new, less loops in isr

2006-12-29 Thread Jiri Slaby
mxser_new, less loops in isr Loop only 100^2 times, not 9^2 times in isr (at most). Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit 5065aa25fd624e3477d993baebbf3255a1d492fa tree a4b05ea113ceea8b8ad1382fa3a5778473597d0f parent cc46acb974ba967794f7b199fb65ad4abd9531b7 author Jiri Slab

[PATCH 2/4] Char: mxser_new, header file cleanup

2006-12-29 Thread Jiri Slaby
mxser_new, header file cleanup - Remove no longer used macros - Move some macros from the header to the code - Remove c++ comments - Align backslashes to one column Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit cc46acb974ba967794f7b199fb65ad4abd9531b7 tree 56be354d64287e9b79013b8d8d35

[PATCH 1/4] Char: mxser_new, alter locking in isr

2006-12-29 Thread Jiri Slaby
mxser_new, alter locking in isr Avoid oopsing when stress-testing open/close -- port->tty is NULL sometimes, but is expected to be non-NULL, since dereferencing. Receive/transmit chars iff ASYNC_CLOSING is not set and ASYNC_INITIALIZED is set. Thanks Sergei for pointing this out and testing. Cc:

[PATCH 1/1] Doc: isicom, remove reserved ioctl-number

2006-12-29 Thread Jiri Slaby
isicom, remove reserved ioctl-number Isicom driver no longer registers chardev with ioctl function. It used to use for firmware loading. Remove the reserved letter (M) from ioctl-number, so that the conflict get away. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit 5bdb7cc0e955ee7724ff5

Re: kobject_add unreachable code

2006-12-29 Thread Olaf Dietsche
Martin Stoilov <[EMAIL PROTECTED]> writes: > Martin Stoilov wrote: >> Olaf Dietsche wrote: >> >>> Martin Stoilov <[EMAIL PROTECTED]> writes: >>> >>> >>> The following code in kobject_add if (!kobj->k_name) kobj->k_name = kobj->name; if (!kobj->k_name)

Re: [patch] remove MAX_ARG_PAGES

2006-12-29 Thread Russell King
On Fri, Dec 29, 2006 at 09:03:57PM +0100, Ingo Molnar wrote: > FYI, i have forward ported your MAX_ARG_PAGES limit removal patch to > 2.6.20-rc2 and have included it in the -rt kernel. It's working great - > i can now finally do a "ls -t patches/*.patch" in my patch repository - > something i ha

select() to /dev/rtc to wait for clock tick timed out

2006-12-29 Thread Ritesh Raj Sarraf
Hi, I have a Dell XPS M1210 notebook with 2.6.18 running on it. I've noticed that a recent BIOS upgrade (A03 -> A05) has started giving me this message on system boot when hwclock runs. select() to /dev/rtc to wait for clock tick timed out My machine has a dual-core Intel processor. A quick se

Re: [patch 2.6.20-rc1 6/6] input: ads7846 directly senses PENUP state

2006-12-29 Thread David Brownell
On Thursday 28 December 2006 10:22 pm, Dmitry Torokhov wrote: > > I appied all patches except for hwmon as it had some issues with CONFIG_HWMON > handling. Could you please take a look at the patch below and tell me if it > works for you? Looked OK, except: > +#if defined(CONFIG_HWMON) || (defin

Re: 2.6.20-rc2: known unfixed regressions

2006-12-29 Thread Daniel Barkalow
On Fri, 29 Dec 2006, Adrian Bunk wrote: > On Fri, Dec 29, 2006 at 01:14:13PM -0500, Daniel Barkalow wrote: > > > There's also http://lkml.org/lkml/2006/12/21/47; the included patch break > > my nVidia devices and probably all PCIX devices, so it's not right, but > > something has to be done to

PROBLEM: setup apm as module version 2.4.34

2006-12-29 Thread Dr.-Ing. Ingo D. Rullhusen
Hello, i hope that's the right address for this little problem, which arises with linux kernel 2.4.34. If i compile the Advanced Power Management as module it do not work. If i try a depmod i get an unresolved symbols message and so it cannot be loaded of course. But if the APM part is com

[patch] remove MAX_ARG_PAGES

2006-12-29 Thread Ingo Molnar
FYI, i have forward ported your MAX_ARG_PAGES limit removal patch to 2.6.20-rc2 and have included it in the -rt kernel. It's working great - i can now finally do a "ls -t patches/*.patch" in my patch repository - something i havent been able to do for years ;-) what is keeping this fix from go

Re: 2.6.20-rc2: known unfixed regressions

2006-12-29 Thread Adrian Bunk
On Fri, Dec 29, 2006 at 01:07:10PM -0500, Ben Collins wrote: > On Thu, 2006-12-28 at 23:39 +0100, Adrian Bunk wrote: > > This email lists some known regressions in 2.6.20-rc2 compared to 2.6.19. > > > > If you find your name in the Cc header, you are either submitter of one > > of the bugs, mainta

Re: 2.6.20-rc2: known unfixed regressions

2006-12-29 Thread Adrian Bunk
On Fri, Dec 29, 2006 at 01:14:13PM -0500, Daniel Barkalow wrote: > There's also http://lkml.org/lkml/2006/12/21/47; the included patch break > my nVidia devices and probably all PCIX devices, so it's not right, but > something has to be done to fix ATI. My guess is a quirk to say that > pci_int

Re: 2.6.19 file content corruption on ext3

2006-12-29 Thread Dave Jones
On Fri, Dec 29, 2006 at 07:52:15PM +0100, maximilian attems wrote: > > The only -mm stuff I recall being in the Fedora 2.6.18 is > > the inode-diet stuff which ended up in 2.6.19, though the xmas > > break has left my head somewhat empty so I may be forgetting something. > > What patch in par

[PATCH 2/3] change libfs sb creation routines to avoid collisions with their root inodes

2006-12-29 Thread Jeff Layton
This changes the superblock creation routines that call new_inode to take steps to avoid later collisions with other inodes that get created. I took the approach here of not hashing things unless is was strictly necessary, though that does mean that filesystem authors need to be careful to avoid co

[PATCH 3/3] have pipefs ensure i_ino uniqueness by calling iunique and hashing the inode

2006-12-29 Thread Jeff Layton
This converts pipefs to use the new scheme. Here we're calling iunique to get a unique i_ino value for the new inode, and then hashing it afterward. We call iunique with a max_reserved value of 1 to avoid collision with the root inode. Since the inode is now hashed, we need to take care that we en

  1   2   >