On Thu, 28 Dec 2006, David Brownell wrote: > Phillip: is this the final version, then? It's missing > a signed-off-by line, so I can't do anything appropriate. > > Nico, your signoff here would be a Good Thing too if it > meets your technical review. (My only comment, ISTR, was > that gpio_set_value macro should probably test for whether > the value is a constant too, not just the gpio pin.)
I don't think so. Expansion of GPIO_bit(x) is pretty simple even if x is not constant. That probably makes it still less costly than a function call. Nicolas - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
