ted packets, so
> replace the WARN_ONCE to ratelimited error logging, because we don't
> need stack trace here.
>
> Cc: sta...@vger.kernel.org
> Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network
> Adapter (MANA)")
> Signed-off-by: Haiyang Zhang
Reviewed-by: Simon Horman
unters for
> easier troubleshooting")
> Signed-off-by: Haiyang Zhang
Reviewed-by: Simon Horman
On Fri, Sep 29, 2023 at 07:47:57AM +0200, Simon Horman wrote:
> On Sat, Sep 23, 2023 at 06:31:45PM -0700, Haiyang Zhang wrote:
> > For an unknown TX CQE error type (probably from a newer hardware),
> > still free the SKB, update the queue tail, etc., otherwise the
> > acc
On Sat, Sep 23, 2023 at 06:31:47PM -0700, Haiyang Zhang wrote:
> Handle the case when GSO SKB linear length is too large.
>
> MANA NIC requires GSO packets to put only the header part to SGE0,
> otherwise the TX queue may stop at the HW level.
>
> So, use 2 SGEs for the skb linear part which cont
On Fri, Sep 29, 2023 at 03:51:48PM +, Haiyang Zhang wrote:
>
>
> > -Original Message-
> > From: Simon Horman
> > Sent: Friday, September 29, 2023 1:51 AM
> > To: Haiyang Zhang
> > Cc: linux-hyperv@vger.kernel.org; net...@vger.kernel.org; D
On Fri, Sep 29, 2023 at 04:11:15PM +, Haiyang Zhang wrote:
...
> > > @@ -209,19 +281,6 @@ netdev_tx_t mana_start_xmit(struct sk_buff *skb,
> > struct net_device *ndev)
> > > pkg.wqe_req.client_data_unit = 0;
> > >
> > > pkg.wqe_req.num_sge = 1 + skb_shinfo(skb)->nr_frags;
> > > - WARN_ON_
ak after a case match and then process
> the complete() call.
> The current code has not caused any known failures. But nonetheless, the
> code should be corrected as a different ordering of the switch cases might
> cause a length check to fail when it should not.
>
> Signed-off-by:
linear part which contains more than the
> packet header.
>
> Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network
> Adapter (MANA)")
> Signed-off-by: Haiyang Zhang
> ---
> v2: coding style updates suggested by Simon Horman
Reviewed-by: Simon Horman
: 1ce09e899d28 ("hyperv: Add support for setting MAC from within guests")
> Signed-off-by: Randy Dunlap
Reviewed-by: Simon Horman
Tested-by: Simon Horman # build-tested
nia Sharma
>
> ---
> Changes in v3:
> * added return statement in default case as pointed by Michael Kelley.
> Changes in v4:
> * added fixes tag
> * modified commit message to explain the issue fixed by patch.
> Changes in v5:
> * Dropped fixes tag as suggested by Simo
On Fri, Nov 10, 2023 at 06:38:59AM -0800, Haiyang Zhang wrote:
> If VF NIC is registered earlier, NETDEV_REGISTER event is replayed,
> but NETDEV_POST_INIT is not.
>
> Move register_netdevice_notifier() earlier, so the call back
> function is set before probing.
>
> Cc: sta...@vger.kernel.org
> F
: e04e7a7bbd4b ("hv_netvsc: Fix a deadlock by getting rtnl lock earlier
> in netvsc_probe()")
> Reported-by: Dexuan Cui
> Signed-off-by: Haiyang Zhang
> Reviewed-by: Wojciech Drewek
Reviewed-by: Simon Horman
On Wed, Nov 22, 2023 at 07:10:08PM -0800, lon...@linuxonhyperv.com wrote:
> From: Long Li
>
> Before the software can create an RDMA adapter handle with SoC, it needs to
> create EQs for processing SoC events from RDMA device. Because MSI-X
> vectors are shared between MANA Ethernet device and RD
On Mon, Dec 04, 2023 at 03:02:59PM -0800, lon...@linuxonhyperv.com wrote:
> From: Long Li
>
> At probing time, the MANA core code allocates EQs for supporting interrupts
> on Ethernet queues. The same interrupt mechanisum is used by RAW QP.
>
> Use the same EQs for delivering interrupts on the C
make[1]: *** [/home/yury/work/linux/Makefile:234: __sub-make] Error 2
> make[1]: Leaving directory '/home/yury/work/build-linux-x86_64'
> make: *** [Makefile:234: __sub-make] Error 2
>
> So we need to select it explicitly.
>
> Signed-off-by: Yury Norov
Reviewed-by: Simon Horman
Tested-by: Simon Horman # build-tested
On Mon, Jan 22, 2024 at 08:20:28AM -0800, mhkelle...@gmail.com wrote:
> From: Michael Kelley
>
> Current code in netvsc_drv_init() incorrectly assumes that PAGE_SIZE
> is 4 Kbytes, which is wrong on ARM64 with 16K or 64K page size. As a
> result, the default VMBus ring buffer size on ARM64 with 6
On Tue, Jan 23, 2024 at 05:13:12PM +, Michael Kelley wrote:
> From: Simon Horman @ 2024-01-22 20:49 UTC (permalink / raw)
> >
> > On Mon, Jan 22, 2024 at 08:20:28AM -0800, mhkelle...@gmail.com wrote:
> > > From: Michael Kelley
> > >
> > > Current cod
x27/0x40 [hv_vmbus]
>
> Cc: sta...@vger.kernel.org
> Fixes: ac5047671758 ("hv_netvsc: Disable NAPI before closing the VMBus
> channel")
> Signed-off-by: Souradeep Chakrabarti
> Reviewed-by: Dexuan Cui
> Reviewed-by: Haiyang Zhang
Reviewed-by: Simon Horman
adha Gupta
Thanks for following-up with this clean-up, much appreciated.
Reviewed-by: Simon Horman
On Sun, Jul 14, 2024 at 08:40:20PM -0700, Shradha Gupta wrote:
> Currently the values of WQs for RX and TX queues for MANA devices
> are hardcoded to default sizes.
> Allow configuring these values for MANA devices as ringparam
> configuration(get/set) through ethtool_ops.
>
> Signed-off-by: Shrad
On Wed, Aug 07, 2024 at 04:17:06PM -0700, lon...@linuxonhyperv.com wrote:
> From: Long Li
>
> After napi_complete_done() is called when NAPI is polling in the current
> process context, another NAPI may be scheduled and start running in
> softirq on another CPU and may ring the doorbell before th
On Sat, Sep 14, 2024 at 09:56:24PM -0700, Shradha Gupta wrote:
> Through some experiments, we found out that increasing the default
> RX buffers count from 512 to 1024, gives slightly better throughput
> and significantly reduces the no_wqe_rx errs on the receiver side.
> Along with these, other pa
On Thu, Oct 03, 2024 at 12:51:04PM -0700, Nuno Das Neves wrote:
> To move toward importing headers from Hyper-V directly, switch to
> using hvhdk.h in all Hyper-V code. KVM code that uses Hyper-V
> definitions from hyperv-tlfs.h remains untouched.
>
> Add HYPERV_NONTLFS_HEADERS everywhere mshyperv
c: move VF to same namespace as netvsc device")
> Suggested-by: Stephen Hemminger
> Signed-off-by: Haiyang Zhang
> Reviewed-by: Simon Horman
> ---
> v3: Use RCT order as suggested by Simon.
> v2: Move my fix to synthetic NIC's NETDEV_REGISTER event as suggested by
> Stephen.
Thanks, this looks good to me.
On Tue, Oct 22, 2024 at 01:49:08PM -0700, Rosen Penev wrote:
> The latter is the preferred way to copy ethtool strings.
>
> Avoids manually incrementing the data pointer.
>
> Signed-off-by: Rosen Penev
Reviewed-by: Simon Horman
On Tue, Oct 22, 2024 at 01:56:56PM -0700, Rosen Penev wrote:
> On Tue, Oct 22, 2024 at 1:49 PM Rosen Penev wrote:
> >
> > The latter is the preferred way to copy ethtool strings.
> >
> > Avoids manually incrementing the data pointer.
> >
> > Signed-off-by: Rosen Penev
> forgot to put net-next.
H
On Fri, Sep 20, 2024 at 02:18:23PM -0700, Erni Sri Satya Vennela wrote:
> Add support for the ethtool get_link and get_link_ksettings
> operations. Display standard port information using ethtool.
>
> Before the change:
> $ethtool enP30832s1
> > No data available
>
> After the change:
> $ethtool
On Thu, Sep 26, 2024 at 08:42:32AM -0700, Joe Damato wrote:
> On Thu, Sep 26, 2024 at 04:10:24PM +0100, Simon Horman wrote:
> > On Tue, Sep 24, 2024 at 11:48:51PM +, Joe Damato wrote:
> > > Use netif_queue_set_napi to link queues to NAPI instances so that they
> > >
On Tue, Sep 24, 2024 at 11:48:51PM +, Joe Damato wrote:
> Use netif_queue_set_napi to link queues to NAPI instances so that they
> can be queried with netlink.
>
> Signed-off-by: Joe Damato
> ---
> drivers/net/hyperv/netvsc.c | 11 ++-
> drivers/net/hyperv/rndis_filter.c | 9 +
> PHYAD: 0
> Transceiver: internal
> Link detected: yes
>
> Signed-off-by: Erni Sri Satya Vennela
> Reviewed-by: Haiyang Zhang
> Reviewed-by: Shradha Gupta
> ---
> Changes in v2:
> * Remove support for displaying auto-negotiation details
> * Change PORT_DA to PORT_OTHER
Thanks, this version looks good to me.
Reviewed-by: Simon Horman
xt *ndev_ctx = netdev_priv(ndev);
struct net_device *vf_netdev;
int ret;
vf_netdev = rtnl_dereference(ndev_ctx->vf_netdev);
if (!vf_netdev)
return;
With that addressed please feel free to add:
Reviewed-by: Simon Horman
> +
> + if (!vf_netdev
On Thu, Nov 28, 2024 at 09:49:35PM +, Michael Kelley wrote:
> From: Maxim Levitsky Sent: Thursday, November 28, 2024
> 11:43 AM
> >
> > Commit 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
> > added memory allocation in mana_gd_setup_irqs of 'irqs' but the code
> > doesn't f
On Fri, Apr 18, 2025 at 09:53:24AM -0700, Erni Sri Satya Vennela wrote:
> On Thu, Apr 17, 2025 at 05:00:52PM -0700, Jakub Kicinski wrote:
> > On Thu, 17 Apr 2025 12:47:27 -0700 Erni Sri Satya Vennela wrote:
> > > > A single leaf is just Token Bucket Filter (TBF).
> > > > Are you just trying to supp
On Wed, Apr 16, 2025 at 08:36:21AM -0700, Shradha Gupta wrote:
> Currently, the MANA driver allocates pci vector statically based on
> MANA_MAX_NUM_QUEUES and num_online_cpus() values and in some cases ends
> up allocating more vectors than it needs.
> This is because, by this time we do not have a
On Fri, May 09, 2025 at 04:16:43PM -0700, Haiyang Zhang wrote:
> To collaborate with hardware servicing events, upon receiving the special
> EQE notification from the HW channel, remove the devices on this bus.
> Then, after a waiting period based on the device specs, rescan the parent
> bus to rec
On Mon, May 12, 2025 at 05:06:01PM -0700, mhkelle...@gmail.com wrote:
> From: Michael Kelley
>
> netvsc currently uses vmbus_sendpacket_pagebuffer() to send VMBus
> messages. This function creates a series of GPA ranges, each of which
> contains a single PFN. However, if the rndis header in the V
On Mon, May 12, 2025 at 05:06:02PM -0700, mhkelle...@gmail.com wrote:
> From: Michael Kelley
>
> Starting with commit dca5161f9bd0 ("hv_netvsc: Check status in
> SEND_RNDIS_PKT completion message") in the 6.3 kernel, the Linux
> driver for Hyper-V synthetic networking (netvsc) occasionally report
> bus to recover the devices.
>
> Signed-off-by: Haiyang Zhang
Reviewed-by: Simon Horman
On Tue, May 27, 2025 at 08:59:03AM -0700, Shradha Gupta wrote:
> Currently, the MANA driver allocates MSI-X vectors statically based on
> MANA_MAX_NUM_QUEUES and num_online_cpus() values and in some cases ends
> up allocating more vectors than it needs. This is because, by this time
> we do not hav
On Tue, May 27, 2025 at 08:57:33AM -0700, Shradha Gupta wrote:
> In this patchset we want to enable the MANA driver to be able to
> allocate MSI-X vectors in PCI dynamically.
>
> The first patch exports pci_msix_prepare_desc() in PCI to be able to
> correctly prepare descriptors for dynamically ad
On Wed, May 14, 2025 at 03:42:19PM +, Michael Kelley wrote:
> From: Simon Horman Sent: Wednesday, May 14, 2025 2:35 AM
> >
> > On Mon, May 12, 2025 at 05:06:02PM -0700, mhkelle...@gmail.com wrote:
> > > From: Michael Kelley
...
> >
On Wed, May 14, 2025 at 03:44:35PM +, Michael Kelley wrote:
> From: Simon Horman Sent: Wednesday, May 14, 2025 2:38 AM
> >
> > On Mon, May 12, 2025 at 05:06:01PM -0700, mhkelle...@gmail.com wrote:
> > > From: Michael Kelley
> > >
> > > netvsc curre
te multiple GPA ranges, no longer
> hardcode as having a single GPA range. Allow the calling driver to
> specify the rangecount in the supplied descriptor.
>
> Update the storvsc driver to reflect this new approach.
>
> Cc: # 6.1.x
> Signed-off-by: Michael Kelley
Reviewed-by: Simon Horman
r array entries used for
> the rndis message must no longer be tracked -- it is always just 1.
> Remove the rmsg_pgcnt field and use "1" where the value is needed.
>
> Cc: # 6.1.x
> Signed-off-by: Michael Kelley
Reviewed-by: Simon Horman
On Mon, May 19, 2025 at 09:20:36AM -0700, Haiyang Zhang wrote:
> To support Multi Vports on Bare metal, increase the device config response
> version. And, skip the register HW vport, and register filter steps, when
> the Bare metal hostmode is set.
>
> Signed-off-by: Haiyang Zhang
> ---
> v2:
>
On Wed, May 21, 2025 at 05:28:33PM +, Haiyang Zhang wrote:
>
>
> > -Original Message-
> > From: Simon Horman
> > Sent: Wednesday, May 21, 2025 10:03 AM
> > To: Haiyang Zhang
> > Cc: linux-hyperv@vger.kernel.org; net...@vger.kernel.org; Dexuan
for PF mode is implemented
Thanks for the updates.
I agree that this revision address Jakub's feedback on v2.
Which in turn addressed his feedback on v1.
Reviewed-by: Simon Horman
_ops")
> Reported-by: kernel test robot
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202506230625.bfulqb8o-...@intel.com/
Reviewed-by: Simon Horman
On Thu, May 29, 2025 at 06:28:45AM -0700, Shradha Gupta wrote:
> On Wed, May 28, 2025 at 07:55:08PM +0100, Simon Horman wrote:
> > On Tue, May 27, 2025 at 08:57:33AM -0700, Shradha Gupta wrote:
> > > In this patchset we want to enable the MANA driver to be able to
> > >
+ Xin Long
On Wed, Jul 16, 2025 at 08:26:05AM +0800, Li Tian wrote:
> Set an additional flag IFF_NO_ADDRCONF to prevent ipv6 addrconf.
>
> Commit under Fixes added a new flag change that was not made
> to hv_netvsc resulting in the VF being assinged an IPv6.
>
> Fixes: 8a321cf7becc ("net: add IF
On Wed, Jul 09, 2025 at 06:43:00AM -0700, Shradha Gupta wrote:
> Fix the typo in function name mana_gd_deregiser_irq()
>
> Signed-off-by: Shradha Gupta
Reviewed-by: Simon Horman
by: kernel test robot
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202506230625.bfulqb8o-...@intel.com/
> ---
> Changes in v2:
> * Use "select NET_SHAPER" in Kconfig instead of adding multiple checks for
> CONFIG_NET_SHAPER.
Reviewed-by: Simon Horman
On Mon, Jul 14, 2025 at 09:41:37AM -0700, Haiyang Zhang wrote:
> From: Haiyang Zhang
>
> The existing code move the VF NIC to new namespace when NETDEV_REGISTER is
> received on netvsc NIC. During deletion of the namespace,
> default_device_exit_batch() >> default_device_exit_net() is called. Whe
On Tue, Jul 29, 2025 at 01:14:10PM -0700, Dipayaan Roy wrote:
> This patch enhances RX buffer handling in the mana driver by allocating
> pages from a page pool and slicing them into MTU-sized fragments, rather
> than dedicating a full page per packet. This approach is especially
> beneficial on sy
On Mon, Jul 21, 2025 at 03:14:17AM -0700, Dipayaan Roy wrote:
> This patch enhances RX buffer handling in the mana driver by allocating
> pages from a page pool and slicing them into MTU-sized fragments, rather
> than dedicating a full page per packet. This approach is especially
> beneficial on sy
On Tue, Aug 05, 2025 at 02:49:17PM -0700, Bobby Eshleman wrote:
> From: Bobby Eshleman
>
> Add NS support to vsock loopback. Sockets in a global mode netns
> communicate with each other, regardless of namespace. Sockets in a local
> mode netns may only communicate with other sockets within the sa
On Tue, Aug 05, 2025 at 03:03:37PM -0700, Bobby Eshleman wrote:
> On Tue, Aug 05, 2025 at 02:49:08PM -0700, Bobby Eshleman wrote:
>
> ...
>
> >
> > Thanks again for everyone's help and reviews!
> >
> >
> > Changes in v4:
> > - removed RFC tag
>
> My bad, I didn't notice I still had the rfc ta
57 matches
Mail list logo
