On Sun, Sep 29, 2024 at 10:42:14PM -0700, Erni Sri Satya Vennela wrote: > Add support for the ethtool get_link and get_link_ksettings > operations. Display standard port information using ethtool. > > Before the change: > $ethtool enP30832s1 > > No data available > > After the change: > $ethtool enP30832s1 > > Settings for enP30832s1: > Supported ports: [ ] > Supported link modes: Not reported > Supported pause frame use: No > Supports auto-negotiation: No > Supported FEC modes: Not reported > Advertised link modes: Not reported > Advertised pause frame use: No > Advertised auto-negotiation: No > Advertised FEC modes: Not reported > Speed: Unknown! > Duplex: Full > Auto-negotiation: off > Port: Other > PHYAD: 0 > Transceiver: internal > Link detected: yes > > Signed-off-by: Erni Sri Satya Vennela <er...@linux.microsoft.com> > Reviewed-by: Haiyang Zhang <haiya...@microsoft.com> > Reviewed-by: Shradha Gupta <shradhagu...@linux.microsoft.com> > --- > Changes in v2: > * Remove support for displaying auto-negotiation details > * Change PORT_DA to PORT_OTHER
Thanks, this version looks good to me. Reviewed-by: Simon Horman <ho...@kernel.org>
