RE: [PATCH v5 2/3] drivers/hv: introduce vmbus_channel_set_cpu()

2025-01-22 Thread Michael Kelley
From: Hamza Mahfooz Sent: Friday, January 17, 2025 12:33 PM > > The core functionality in target_cpu_store() is also needed in a > subsequent patch for automatically changing the CPU when taking > a CPU offline. As such, factor out the body of target_cpu_store() > into new function vmbus_channel

RE: [PATCH v5 1/3] cpu: export lockdep_assert_cpus_held()

2025-01-22 Thread Michael Kelley
From: Hamza Mahfooz Sent: Friday, January 17, 2025 12:33 PM > > If CONFIG_HYPERV=m, lockdep_assert_cpus_held() is undefined for HyperV. > So, export the function so that GPL drivers can use it more broadly. > > Cc: Michael Kelley > Signed-off-by: Hamza Mahfooz > --- > v5: new to the series >

RE: [PATCH v5 3/3] drivers/hv: add CPU offlining support

2025-01-22 Thread Michael Kelley
From: Hamza Mahfooz Sent: Friday, January 17, 2025 12:33 PM > > Currently, it is tedious to offline CPUs in a Hyper-V VM since CPUs may > have VMBus channels attached to them that a user would have to manually > rebind elsewhere. So, as made mention of in > commit d570aec0f2154 ("Drivers: hv: vm

Re: Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-22 Thread Joel Granados
On Tue, Jan 21, 2025 at 02:40:16PM +0100, Alexander Gordeev wrote: > On Fri, Jan 10, 2025 at 03:16:08PM +0100, Joel Granados wrote: > > Hi Joel, > > > Add the const qualifier to all the ctl_tables in the tree except for > > watchdog_hardlockup_sysctl, memory_allocation_profiling_sysctls, > > load

Re: Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-22 Thread Ard Biesheuvel
On Wed, 22 Jan 2025 at 13:25, Joel Granados wrote: > > On Tue, Jan 21, 2025 at 02:40:16PM +0100, Alexander Gordeev wrote: > > On Fri, Jan 10, 2025 at 03:16:08PM +0100, Joel Granados wrote: > > > > Hi Joel, > > > > > Add the const qualifier to all the ctl_tables in the tree except for > > > watchdo

Re: [PATCH 1/2] hyperv: Move hv_current_partition_id to arch-generic code

2025-01-22 Thread Nuno Das Neves
On 12/6/2024 11:36 PM, Wei Liu wrote: > On Fri, Dec 06, 2024 at 02:21:46PM -0800, Nuno Das Neves wrote: >> From: Nuno Das Neves >> >> Make hv_current_partition_id available in both x86_64 and arm64. >> This feature isn't specific to x86_64 and will be needed by common >> code. >> >> While at it, r

Re: [PATCH 0/2] hyperv: Move some features to common code

2025-01-22 Thread Nuno Das Neves
On 12/17/2024 9:48 AM, Michael Kelley wrote: > From: Nuno Das Neves Sent: Monday, > December 9, 2024 12:20 PM >> >> On 12/7/2024 6:59 PM, Michael Kelley wrote: >>> From: Nuno Das Neves Sent: Friday, >>> December 6, 2024 2:22 PM There are several bits of Hyper-V-related code that today

[PATCH v2 2/2] hyperv: Move arch/x86/hyperv/hv_proc.c to drivers/hv

2025-01-22 Thread Nuno Das Neves
These helpers are not specific to x86_64 and will be needed by common code. Remove some unnecessary #includes. Signed-off-by: Nuno Das Neves --- arch/x86/hyperv/Makefile | 2 +- arch/x86/include/asm/mshyperv.h | 4 drivers/hv/Makefile | 2 +-

[PATCH v2 0/2] hyperv: Move some features to common code

2025-01-22 Thread Nuno Das Neves
There are several bits of Hyper-V-related code that today live in arch/x86 but are not really specific to x86_64 and will work on arm64 too. Some of these will be needed in the upcoming mshv driver code (for Linux as root partition on Hyper-V). So this is a good time to move them to drivers/hv. S

[PATCH v2 1/2] hyperv: Move hv_current_partition_id to arch-generic code

2025-01-22 Thread Nuno Das Neves
From: Nuno Das Neves Move hv_current_partition_id and hv_get_partition_id() to hv_common.c. These aren't specific to x86_64 and will be needed by common code. Set hv_current_partition_id to HV_PARTITION_ID_SELF by default. Use a stack variable for the output of the hypercall. This allows moving

[PATCH v2] scsi: storvsc: Set correct data length for sending SCSI command without payload

2025-01-22 Thread longli
From: Long Li In StorVSC, payload->range.len is used to indicate if this SCSI command carries payload. This data is allocated as part of the private driver data by the upper layer and may get passed to lower driver uninitialized. For example, the SCSI error handling mid layer may send TEST_UNIT_

RE: [PATCH rdma-next 01/13] RDMA/mana_ib: Allow registration of DMA-mapped memory in PDs

2025-01-22 Thread Long Li
> Subject: [PATCH rdma-next 01/13] RDMA/mana_ib: Allow registration of DMA- > mapped memory in PDs > > From: Konstantin Taranov > > Allow the HW to register DMA-mapped memory for kernel-level PDs. > > Signed-off-by: Konstantin Taranov > Reviewed-by: Shiraz Saleem Reviewed-by: Long Li > ---

RE: [PATCH rdma-next 02/13] RDMA/mana_ib: implement get_dma_mr

2025-01-22 Thread Long Li
> Subject: [PATCH rdma-next 02/13] RDMA/mana_ib: implement get_dma_mr > > From: Konstantin Taranov > > Implement allocation of DMA-mapped memory regions. > > Signed-off-by: Konstantin Taranov > Reviewed-by: Shiraz Saleem Reviewed-by: Long Li > --- > drivers/infiniband/hw/mana/device.c |

RE: [PATCH rdma-next 03/13] RDMA/mana_ib: helpers to allocate kernel queues

2025-01-22 Thread Long Li
> Subject: [PATCH rdma-next 03/13] RDMA/mana_ib: helpers to allocate kernel > queues > > From: Konstantin Taranov > > Introduce helpers to allocate queues for kernel-level use. > > Signed-off-by: Konstantin Taranov > Reviewed-by: Shiraz Saleem Reviewed-by: Long Li > --- > drivers/infiniba

RE: [PATCH rdma-next 05/13] RDMA/mana_ib: Create and destroy UD/GSI QP

2025-01-22 Thread Long Li
> Subject: [PATCH rdma-next 05/13] RDMA/mana_ib: Create and destroy UD/GSI > QP > > From: Konstantin Taranov > > Implement HW requests to create and destroy UD/GSI QPs. > An UD/GSI QP has send and receive queues. > > Signed-off-by: Konstantin Taranov > Reviewed-by: Shiraz Saleem Reviewed-by:

RE: [PATCH rdma-next 06/13] RDMA/mana_ib: UD/GSI QP creation for kernel

2025-01-22 Thread Long Li
> Subject: [PATCH rdma-next 06/13] RDMA/mana_ib: UD/GSI QP creation for > kernel > > From: Konstantin Taranov > > Implement UD/GSI QPs for the kernel. > Allow create/modify/destroy for such QPs. > > Signed-off-by: Konstantin Taranov > Reviewed-by: Shiraz Saleem Reviewed-by: Long Li > --- >

RE: [PATCH rdma-next 04/13] RDMA/mana_ib: create kernel-level CQs

2025-01-22 Thread Long Li
> Subject: [PATCH rdma-next 04/13] RDMA/mana_ib: create kernel-level CQs > > From: Konstantin Taranov > > Implement creation of CQs for the kernel. > > Signed-off-by: Konstantin Taranov > Reviewed-by: Shiraz Saleem > --- > drivers/infiniband/hw/mana/cq.c | 80 +---

RE: [PATCH rdma-next 07/13] RDMA/mana_ib: create/destroy AH

2025-01-22 Thread Long Li
> Subject: [PATCH rdma-next 07/13] RDMA/mana_ib: create/destroy AH > > From: Konstantin Taranov > > Implement create and destroy AH for kernel. > > In mana_ib, AV is passed as an sge in WQE. > Allocate DMA memory and write an AV there. > > Signed-off-by: Konstantin Taranov > Reviewed-by: Shir

RE: [PATCH] scsi: storvsc: Set correct data length for sending SCSI command without payload

2025-01-22 Thread Long Li
> > SCSI mid layer may send commands to lower driver without initializing > > private > data. > > For example, scsi_send_eh_cmnd() may send TEST_UNIT_READY and > > REQUEST_SENSE to lower layer driver without initializing private data. > > Right. Thanks for pointing out this path that I wasn't awa

RE: [PATCH] scsi: storvsc: Set correct data length for sending SCSI command without payload

2025-01-22 Thread Michael Kelley
From: Long Li > > > > SCSI mid layer may send commands to lower driver without initializing > > > private > > data. > > > For example, scsi_send_eh_cmnd() may send TEST_UNIT_READY and > > > REQUEST_SENSE to lower layer driver without initializing private data. > > > > Right. Thanks for pointing

RE: [PATCH rdma-next 11/13] RDMA/mana_ib: extend mana QP table

2025-01-22 Thread Long Li
> Subject: [PATCH rdma-next 11/13] RDMA/mana_ib: extend mana QP table > > From: Konstantin Taranov > > Enable mana QP table to store UD/GSI QPs. > For send queues, set the most significant bit to one, as send and receive WQs > can > have the same ID in mana. > > Signed-off-by: Konstantin Taran

RE: [PATCH rdma-next 10/13] RDMA/mana_ib: implement req_notify_cq

2025-01-22 Thread Long Li
> Subject: [PATCH rdma-next 10/13] RDMA/mana_ib: implement req_notify_cq > > From: Konstantin Taranov > > Arm a CQ when req_notify_cq is called. > > Signed-off-by: Konstantin Taranov > Reviewed-by: Shiraz Saleem Reviewed-by: Long Li > --- > drivers/infiniband/hw/mana/cq.c