From: Long Li <lon...@microsoft.com>
> 
> > > SCSI mid layer may send commands to lower driver without initializing 
> > > private
> > data.
> > > For example, scsi_send_eh_cmnd() may send TEST_UNIT_READY and
> > > REQUEST_SENSE to lower layer driver without initializing private data.
> >
> > Right. Thanks for pointing out this path that I wasn't aware of. My 
> > suggestion
> > would be to add a little more detail in the commit message, including 
> > identifying
> > this path where the private data isn't zero'ed. Some future developer will 
> > wonder
> > what's going on and appreciate having the specific reason provided.
> 
> I sent v2 adding more details to the comment.
> 

Thanks.  Looks good to me.

Michael


Reply via email to