RE: [PATCH] Drivers: hv: kvp/vss: Avoid accessing a ringbuffer not initialized yet

2024-11-01 Thread Dexuan Cui
> From: Michael Kelley > Sent: Friday, November 1, 2024 2:11 PM > > Michael, will you post a formal patch or want me to do it? > > Either works for me. > > I can do it. You probably have more pressing issues to keep > you busy :-) Thanks a lot! :-) > Fair enough. I'll do it that way. > > M

RE: [PATCH] Drivers: hv: kvp/vss: Avoid accessing a ringbuffer not initialized yet

2024-11-01 Thread Michael Kelley
From: Dexuan Cui Sent: Friday, November 1, 2024 1:27 PM > > > From: Michael Kelley > > Sent: Thursday, October 31, 2024 6:39 PM > > > > From: Michael Kelley > > > > Sent: Wednesday, October 30, 2024 5:12 PM > > > > [...] > > > > What do you think about this (compile tested only), which splits t

RE: [PATCH] Drivers: hv: kvp/vss: Avoid accessing a ringbuffer not initialized yet

2024-11-01 Thread Dexuan Cui
> From: Michael Kelley > Sent: Thursday, October 31, 2024 6:39 PM > > > From: Michael Kelley > > > Sent: Wednesday, October 30, 2024 5:12 PM > > > [...] > > > What do you think about this (compile tested only), which splits the > > > "init" function into two parts for devices that have char devs?

RE: [PATCH] Drivers: hv: kvp/vss: Avoid accessing a ringbuffer not initialized yet

2024-10-31 Thread Michael Kelley
From: Dexuan Cui Sent: Thursday, October 31, 2024 5:17 PM > > > From: Michael Kelley > > Sent: Wednesday, October 30, 2024 5:12 PM > > [...] > > What do you think about this (compile tested only), which splits the > > "init" function into two parts for devices that have char devs? I'm > > trying

RE: [PATCH] Drivers: hv: kvp/vss: Avoid accessing a ringbuffer not initialized yet

2024-10-31 Thread Dexuan Cui
> From: Michael Kelley > Sent: Wednesday, October 30, 2024 5:12 PM > [...] > What do you think about this (compile tested only), which splits the > "init" function into two parts for devices that have char devs? I'm > trying to avoid adding yet another synchronization point by just > doing the ini

RE: [PATCH] Drivers: hv: kvp/vss: Avoid accessing a ringbuffer not initialized yet

2024-10-30 Thread Michael Kelley
From: Dexuan Cui Sent: Wednesday, October 30, 2024 12:04 PM > > > From: Michael Kelley > > Sent: Tuesday, October 29, 2024 4:45 PM > > [...] > > An alternate approach occurs to me. util_probe() does these three > > things in order: > > > > 1) Allocates the receive buffer > > 2) Calls the util_i

RE: [PATCH] Drivers: hv: kvp/vss: Avoid accessing a ringbuffer not initialized yet

2024-10-30 Thread Dexuan Cui
> From: Michael Kelley > Sent: Tuesday, October 29, 2024 4:45 PM > [...] > An alternate approach occurs to me. util_probe() does these three > things in order: > > 1) Allocates the receive buffer > 2) Calls the util_init() function, which for KVP and VSS creates the char dev > 3) Sets up the VMBu

RE: [PATCH] Drivers: hv: kvp/vss: Avoid accessing a ringbuffer not initialized yet

2024-10-29 Thread Michael Kelley
From: Dexuan Cui Sent: Monday, September 9, 2024 9:47 AM > > If the KVP (or VSS) daemon starts before the VMBus channel's ringbuffer is > fully initialized, we can hit the panic below: > > hv_utils: Registering HyperV Utility Driver > hv_vmbus: registering driver hv_utils > ... > BUG: kernel NUL