Re: [PATCH] net: mana: Add get_link and get_link_ksettings in ethtool

2024-09-20 Thread Erni Sri Satya Vennela
On Thu, Sep 19, 2024 at 09:45:53AM +0200, Jakub Kicinski wrote: > On Tue, 17 Sep 2024 20:34:40 + Haiyang Zhang wrote: > > > Unless I'm misreading I don't see the answer to the "why?" in your > > > reply. > > > > > > What benefit does reporting duplex on a virtual device bring? > > > What kind

Re: [PATCH] net: mana: Add get_link and get_link_ksettings in ethtool

2024-09-19 Thread Jakub Kicinski
On Tue, 17 Sep 2024 20:34:40 + Haiyang Zhang wrote: > > Unless I'm misreading I don't see the answer to the "why?" in your > > reply. > > > > What benefit does reporting duplex on a virtual device bring? > > What kind of SW need this current patch? > > etc. > > I'm not aware of any SW has s

RE: [PATCH] net: mana: Add get_link and get_link_ksettings in ethtool

2024-09-17 Thread Haiyang Zhang
..@redhat.com; shradhagu...@linux.microsoft.com; > ahmed.z...@intel.com; colin.i.k...@gmail.com; linux- > hyp...@vger.kernel.org; net...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH] net: mana: Add get_link and get_link_ksettings in > ethtool > > On Tue, 17 Sep 2024

Re: [PATCH] net: mana: Add get_link and get_link_ksettings in ethtool

2024-09-17 Thread Jakub Kicinski
On Tue, 17 Sep 2024 14:35:21 + Haiyang Zhang wrote: > > Any reason why? Sometimes people add this callback for virtual > > devices to expose some approximate speed, but you're not reporting > > speed, so I'm curious. > Speed info isn't available from the HW yet. But we are requesting > that

RE: [PATCH] net: mana: Add get_link and get_link_ksettings in ethtool

2024-09-17 Thread Haiyang Zhang
..@redhat.com; shradhagu...@linux.microsoft.com; > ahmed.z...@intel.com; colin.i.k...@gmail.com; linux- > hyp...@vger.kernel.org; net...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH] net: mana: Add get_link and get_link_ksettings in > ethtool > > On Thu, 12 Sep 202

Re: [PATCH] net: mana: Add get_link and get_link_ksettings in ethtool

2024-09-13 Thread Jakub Kicinski
On Thu, 12 Sep 2024 00:44:43 -0700 Erni Sri Satya Vennela wrote: > Add support for the ethtool get_link and get_link_ksettings > operations. Display standard port information using ethtool. Any reason why? Sometimes people add this callback for virtual devices to expose some approximate speed, but

[PATCH] net: mana: Add get_link and get_link_ksettings in ethtool

2024-09-12 Thread Erni Sri Satya Vennela
Add support for the ethtool get_link and get_link_ksettings operations. Display standard port information using ethtool. Before the change: $ethtool enP30832s1 >No data available After the change: $ethtool enP30832s1 >Settings for enP30832s1: Supported ports: [ ] Supported link m