> -----Original Message-----
> From: Jakub Kicinski <k...@kernel.org>
> Sent: Tuesday, September 17, 2024 11:04 AM
> To: Haiyang Zhang <haiya...@microsoft.com>
> Cc: Erni Sri Satya Vennela <er...@linux.microsoft.com>; KY Srinivasan
> <k...@microsoft.com>; wei....@kernel.org; Dexuan Cui
> <de...@microsoft.com>; da...@davemloft.net; eduma...@google.com;
> pab...@redhat.com; shradhagu...@linux.microsoft.com;
> ahmed.z...@intel.com; colin.i.k...@gmail.com; linux-
> hyp...@vger.kernel.org; net...@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH] net: mana: Add get_link and get_link_ksettings in
> ethtool
>
> On Tue, 17 Sep 2024 14:35:21 +0000 Haiyang Zhang wrote:
> > > Any reason why? Sometimes people add this callback for virtual
> > > devices to expose some approximate speed, but you're not reporting
> > > speed, so I'm curious.
> > Speed info isn't available from the HW yet. But we are requesting
> > that from HW team. For now, we just add some minimal info, like
> > duplex, etc.
>
> Unless I'm misreading I don't see the answer to the "why?" in your
> reply.
>
> What benefit does reporting duplex on a virtual device bring?
> What kind of SW need this current patch?
> etc.
I'm not aware of any SW has such requirement either.
We just want the "ethtool <nic>" cmd can output something we already know.
Is this acceptable?
Thanks,
- Haiyang
