Re: [PATCH] MAINTAINERS: hardening: Add __counted_by regex

2023-09-25 Thread Eric Biggers
Hi Kees, On Mon, Sep 25, 2023 at 10:20:41AM -0700, Kees Cook wrote: > Since __counted_by annotations may also require that code be changed to > get initialization ordering correct, let's get an extra group of eyes on > code that is working on these annotations. > > Signed-off-by: Kees Cook > ---

Re: [PATCH v3 2/3] overflow: Introduce add_wrap(), sub_wrap(), and mul_wrap()

2024-02-05 Thread Eric Biggers
On Mon, Feb 05, 2024 at 01:12:30AM -0800, Kees Cook wrote: > Subject: Re: [PATCH v3 2/3] overflow: Introduce add_wrap(), sub_wrap(), and > mul_wrap() Maybe these should be called wrapping_add, wrapping_sub, and wrapping_mul? Those names are more grammatically correct, and Rust chose those names t

Re: [PATCH v3 2/3] overflow: Introduce add_wrap(), sub_wrap(), and mul_wrap()

2024-02-05 Thread Eric Biggers
On Mon, Feb 05, 2024 at 02:44:14PM -0800, Kees Cook wrote: > On Mon, Feb 05, 2024 at 12:21:45PM -0800, Eric Biggers wrote: > > On Mon, Feb 05, 2024 at 01:12:30AM -0800, Kees Cook wrote: > > > Subject: Re: [PATCH v3 2/3] overflow: Introduce add_wrap(), sub_wrap(),

Re: [PATCH 3/4] xattr: Use dedicated slab buckets for setxattr()

2024-03-04 Thread Eric Biggers
On Mon, Mar 04, 2024 at 10:49:31AM -0800, Kees Cook wrote: > xattr: Use dedicated slab buckets for setxattr() This patch actually changes listxattr(), not setxattr(). getxattr(), setxattr(), and listxattr() all allocate a user controlled size. Perhaps you meant to change all three? What is speci

Re: [PATCH] proc: add config to block FOLL_FORCE in mem writes

2024-07-17 Thread Eric Biggers
On Wed, Jul 17, 2024 at 02:13:58PM +0300, Adrian Ratiu wrote: > +config SECURITY_PROC_MEM_RESTRICT_FOLL_FORCE > + bool "Remove FOLL_FORCE usage from /proc/pid/mem writes" > + default n > + help > + This restricts FOLL_FORCE flag usage in procfs mem write calls > + because it

Re: [PATCH v3 6/8] crypto: x86/crc32c - Use idiomatic relative jump table

2024-10-13 Thread Eric Biggers
On Fri, Oct 11, 2024 at 07:08:54PM +0200, Ard Biesheuvel wrote: > diff --git a/arch/x86/crypto/crc32c-pcl-intel-asm_64.S > b/arch/x86/crypto/crc32c-pcl-intel-asm_64.S > index bbcff1fb78cb..45b005935194 100644 > --- a/arch/x86/crypto/crc32c-pcl-intel-asm_64.S > +++ b/arch/x86/crypto/crc32c-pcl-inte