Re: [PATCH v4 1/1] exec: seal system mappings

2025-01-15 Thread Kees Cook
On Wed, Jan 15, 2025 at 07:46:00PM +, Lorenzo Stoakes wrote: > You are now suggesting disabling the !CRIU requirement. Which violates my > _requirements_ (not optional features). Why not make this simply incremental? The feature isn't intended to work with CRIU. Why don't we get the feature in

Re: [PATCH v4 1/1] exec: seal system mappings

2025-01-15 Thread Christoph Hellwig
On Wed, Jan 15, 2025 at 03:52:23PM -0800, Kees Cook wrote: > > You seem to be saying you're pushing an internal feature on upstream and > > only care about internal use cases, this is not how upstream works, as > > Matthew alludes to. > > Internal? No. Chrome OS and Android. Linux runs more Androi

Re: [PATCH v14 2/4] arm64: Kconfig.platforms: Add config for Marvell PXA1908 platform

2025-01-15 Thread Krzysztof Kozlowski
On Wed, Jan 15, 2025 at 09:35:55PM +0100, Duje Mihanović wrote: > Add ARCH_MMP configuration option for Marvell PXA1908 SoC. > > Signed-off-by: Duje Mihanović > --- > arch/arm64/Kconfig.platforms | 8 > 1 file changed, 8 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Kr

Re: [PATCH v14 4/4] MAINTAINERS: add myself as Marvell PXA1908 maintainer

2025-01-15 Thread Krzysztof Kozlowski
On Wed, Jan 15, 2025 at 09:35:57PM +0100, Duje Mihanović wrote: > Add myself as the maintainer for Marvell PXA1908 SoC support. > > Signed-off-by: Duje Mihanović > --- > MAINTAINERS | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index > a87ddad78e

Re: [PATCH v4 1/1] exec: seal system mappings

2025-01-15 Thread Lorenzo Stoakes
Jeff, My name is Lorenzo, not Lorenze. I've made it abundantly clear that this (NACKed) series cannot allow the kernel to be in a broken state even if a user sets flags to do so. This is because users might lack context to make this decision and incorrectly do so, and now we ship a known-broken

Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-15 Thread Wei Liu
On Fri, Jan 10, 2025 at 03:16:08PM +0100, Joel Granados wrote: [...] > diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c > index 7a35c82976e0..9453f0c26f2a 100644 > --- a/drivers/hv/hv_common.c > +++ b/drivers/hv/hv_common.c > @@ -141,7 +141,7 @@ static int sysctl_record_panic_msg = 1; >

Re: [PATCH v4 1/1] exec: seal system mappings

2025-01-15 Thread Jeff Xu
Hi Lorenzo On Wed, Jan 15, 2025 at 11:46 AM Lorenzo Stoakes wrote: > > Jeff, > > My name is Lorenzo, not Lorenze. > I apologize. > I've made it abundantly clear that this (NACKed) series cannot allow the > kernel to be in a broken state even if a user sets flags to do so. > > This is because use

Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-15 Thread Bill O'Donnell
On Fri, Jan 10, 2025 at 03:16:08PM +0100, Joel Granados wrote: > Add the const qualifier to all the ctl_tables in the tree except for > watchdog_hardlockup_sysctl, memory_allocation_profiling_sysctls, > loadpin_sysctl_table and the ones calling register_net_sysctl (./net, > drivers/inifiniband dirs

[PATCH v14 1/4] dt-bindings: marvell: Document PXA1908 SoC and samsung,coreprimevelte

2025-01-15 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add dt bindings for the Marvell PXA1908 SoC and the Samsung Galaxy Core Prime VE LTE phone (model number SM-G361F) using the SoC. The SoC comes with 4 Cortex-A53 cores clocked up to ~1.2GHz and a Vivante GC7000UL GPU. The phone also has a 4.5" 480x800 touchscreen, 8GB eMMC a

[PATCH v14 3/4] arm64: dts: Add DTS for Marvell PXA1908 and samsung,coreprimevelte

2025-01-15 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add DTS for Marvell PXA1908 SoC and Samsung Galaxy Core Prime Value Edition LTE, a smartphone based on said SoC. Signed-off-by: Duje Mihanović --- arch/arm64/boot/dts/marvell/Makefile | 3 + .../dts/marvell/pxa1908-samsung-coreprimevelte.dts | 336 +

[PATCH v14 0/4] Initial Marvell PXA1908 support

2025-01-15 Thread Duje Mihanović via B4 Relay
Hello, This series adds initial support for the Marvell PXA1908 SoC and "samsung,coreprimevelte", a smartphone using the SoC. USB works and the phone can boot a rootfs from an SD card, but there are some warnings in the dmesg: During SMP initialization: [0.006519] CPU features: SANITY CHECK:

[PATCH v14 2/4] arm64: Kconfig.platforms: Add config for Marvell PXA1908 platform

2025-01-15 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add ARCH_MMP configuration option for Marvell PXA1908 SoC. Signed-off-by: Duje Mihanović --- arch/arm64/Kconfig.platforms | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index 370a9d2b6919d24d6c7111b9

[PATCH v14 4/4] MAINTAINERS: add myself as Marvell PXA1908 maintainer

2025-01-15 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add myself as the maintainer for Marvell PXA1908 SoC support. Signed-off-by: Duje Mihanović --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a87ddad78e26f28ffd0f3433560d6db1518f9f95..caa5f6b96251a3da0f3f9d2f760b3

Re: [RFC PATCH v1 1/1] selftest/mm: refactor mseal_test

2025-01-15 Thread Jeff Xu
Hi Lorenzo, On Thu, Jan 2, 2025 at 9:30 AM Lorenzo Stoakes wrote: > > Sorry for delay, was super busy leading up to xmas break, then had ~2.5 > weeks off. > Thanks for reviewing. There are lots of comments, so it takes some time to go through comments and experiment with some of the suggested ch

Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-15 Thread Thomas Gleixner
On Fri, Jan 10 2025 at 15:16, Joel Granados wrote: > sed: > sed --in-place \ > -e "s/struct ctl_table .table = &uts_kern/const struct ctl_table *table > = \&uts_kern/" \ > kernel/utsname_sysctl.c > > Reviewed-by: Song Liu > Acked-by: Steven Rostedt (Google) # for kernel/trace/ >

Re: [PATCH v4 1/1] exec: seal system mappings

2025-01-15 Thread Jeff Xu
On Mon, Jan 13, 2025 at 1:26 PM Jeff Xu wrote: > > On Mon, Jan 6, 2025 at 5:12 PM Kees Cook wrote: > > > > On Fri, Jan 03, 2025 at 09:38:10PM +, Lorenzo Stoakes wrote: > > > On Tue, Dec 17, 2024 at 02:18:53PM -0800, Kees Cook wrote: > > > > On Mon, Nov 25, 2024 at 08:20:21PM +, jef...@chr

Re: [DISCUSSION] vsprintf: the current state of restricted pointers (%pK)

2025-01-15 Thread Petr Mladek
On Tue 2025-01-14 16:35:57, Andy Shevchenko wrote: > On Mon, Jan 13, 2025 at 05:46:44PM +0100, Thomas Weißschuh wrote: > > Hi everybody, > > > > as you know, leaking raw kernel pointers to the user is problematic as > > they can be used to break KASLR. > > Therefore back in 2011 the %pK format spe