Re: [PATCH 00/82] overflow: Refactor open-coded arithmetic wrap-around

2024-01-28 Thread Kees Cook
On Tue, Jan 23, 2024 at 09:46:35AM +, Mark Rutland wrote: > This also misses the include/linux/atomic/atomic-arch-fallback.h > implementations. Those are generated from the scripts/atomic/fallbacks/* > templates, and you'll need to adjust at least fetch_add_unless and > inc_unless_negative. As

Re: [PATCH 00/82] overflow: Refactor open-coded arithmetic wrap-around

2024-01-23 Thread Kees Cook
On Tue, Jan 23, 2024 at 09:46:35AM +, Mark Rutland wrote: > With that in mind, I note that this patch primarily modifies addition > operations, but leaves subtraction operations unchanged (even though those > permit the value to go below the minimum, or above the maximum if a negative > value i

Re: [PATCH 00/82] overflow: Refactor open-coded arithmetic wrap-around

2024-01-23 Thread Mark Rutland
On Mon, Jan 22, 2024 at 04:26:35PM -0800, Kees Cook wrote: > Hi, Hi Kees, > In our continuing effort to eliminate root causes of flaws in the kernel, > this series is the start to providing a way to have sensible coverage > for catching unexpected arithmetic wrap-around. > > A quick word on lang

Re: [PATCH 00/82] overflow: Refactor open-coded arithmetic wrap-around

2024-01-22 Thread Kees Cook
On January 22, 2024 6:22:13 PM PST, Kent Overstreet wrote: >On Mon, Jan 22, 2024 at 04:26:35PM -0800, Kees Cook wrote: >> In our continuing effort to eliminate root causes of flaws in the kernel, >> this series is the start to providing a way to have sensible coverage >> for catching unexpecte

Re: [PATCH 00/82] overflow: Refactor open-coded arithmetic wrap-around

2024-01-22 Thread Kent Overstreet
On Mon, Jan 22, 2024 at 04:26:35PM -0800, Kees Cook wrote: > Hi, > > In our continuing effort to eliminate root causes of flaws in the kernel, > this series is the start to providing a way to have sensible coverage > for catching unexpected arithmetic wrap-around. > > A quick word on language: wh

[PATCH 00/82] overflow: Refactor open-coded arithmetic wrap-around

2024-01-22 Thread Kees Cook
Hi, In our continuing effort to eliminate root causes of flaws in the kernel, this series is the start to providing a way to have sensible coverage for catching unexpected arithmetic wrap-around. A quick word on language: while discussing[1] the finer details of the C standard's view on arithmeti