Re: [PATCH 00/10] lib/string_choices: Add new helpers

2025-03-03 Thread Kuninori Morimoto
Hi Kees, Andy Thank you for your feedback > > > > Do you have some Coccinelle scripts or other patches that show the use > > > > of these helpers? We tend to avoid adding new helpers to the kernel > > > > unless there are active uses of them. (snip) > > I am not Kees, but my point of view on th

Re: [PATCH 00/10] lib/string_choices: Add new helpers

2025-03-03 Thread Kees Cook
On Fri, Feb 28, 2025 at 10:24:22PM +0200, Andy Shevchenko wrote: > On Fri, Feb 28, 2025 at 9:44 PM Kees Cook wrote: > > > > On Wed, Feb 26, 2025 at 05:34:48AM +, Kuninori Morimoto wrote: > > > I would like to use string_choices helper to cleanup the code, but it > > > missing > > > some of we

Re: [PATCH 00/10] lib/string_choices: Add new helpers

2025-03-03 Thread Andy Shevchenko
On Mon, Mar 3, 2025 at 7:18 PM Kees Cook wrote: > On Fri, Feb 28, 2025 at 10:24:22PM +0200, Andy Shevchenko wrote: > > On Fri, Feb 28, 2025 at 9:44 PM Kees Cook wrote: ... > > Kees, what is the status of the > > https://lore.kernel.org/linux-kernel/20241119021719.7659-1-prosunoffic...@gmail.com

Re: [PATCH 00/10] lib/string_choices: Add new helpers

2025-03-03 Thread Kees Cook
On Mon, Mar 03, 2025 at 08:20:20AM +0200, Andy Shevchenko wrote: > On Mon, Mar 3, 2025 at 1:16 AM Kuninori Morimoto > wrote: > > > > > > Hi Kees > > > > Thank you for your feedback > > > > > > I would like to use string_choices helper to cleanup the code, but it > > > > missing > > > > some of we

Re: [PATCH 00/10] lib/string_choices: Add new helpers

2025-03-02 Thread Andy Shevchenko
On Mon, Mar 3, 2025 at 1:16 AM Kuninori Morimoto wrote: > > > Hi Kees > > Thank you for your feedback > > > > I would like to use string_choices helper to cleanup the code, but it > > > missing > > > some of well used string pair in kernel. This patch-set adds it. > > > > Do you have some Coccine

Re: [PATCH 00/10] lib/string_choices: Add new helpers

2025-03-02 Thread Kuninori Morimoto
Hi Kees Thank you for your feedback > > I would like to use string_choices helper to cleanup the code, but it > > missing > > some of well used string pair in kernel. This patch-set adds it. > > Do you have some Coccinelle scripts or other patches that show the use > of these helpers? We tend

Re: [PATCH 00/10] lib/string_choices: Add new helpers

2025-03-01 Thread Kees Cook
On Wed, Feb 26, 2025 at 05:34:48AM +, Kuninori Morimoto wrote: > I would like to use string_choices helper to cleanup the code, but it missing > some of well used string pair in kernel. This patch-set adds it. Do you have some Coccinelle scripts or other patches that show the use of these help

Re: [PATCH 00/10] lib/string_choices: Add new helpers

2025-02-28 Thread Andy Shevchenko
On Fri, Feb 28, 2025 at 9:44 PM Kees Cook wrote: > > On Wed, Feb 26, 2025 at 05:34:48AM +, Kuninori Morimoto wrote: > > I would like to use string_choices helper to cleanup the code, but it > > missing > > some of well used string pair in kernel. This patch-set adds it. > > Do you have some C

[PATCH 00/10] lib/string_choices: Add new helpers

2025-02-25 Thread Kuninori Morimoto
Hi Kees I would like to use string_choices helper to cleanup the code, but it missing some of well used string pair in kernel. This patch-set adds it. Kuninori Morimoto (10): lib/string_choices: Add str_tx_rx() helper lib/string_choices: Add str_enabling_disabling() helper lib/string_choice