On Mon, Mar 03, 2025 at 08:20:20AM +0200, Andy Shevchenko wrote: > On Mon, Mar 3, 2025 at 1:16 AM Kuninori Morimoto > <kuninori.morimoto...@renesas.com> wrote: > > > > > > Hi Kees > > > > Thank you for your feedback > > > > > > I would like to use string_choices helper to cleanup the code, but it > > > > missing > > > > some of well used string pair in kernel. This patch-set adds it. > > > > > > Do you have some Coccinelle scripts or other patches that show the use > > > of these helpers? We tend to avoid adding new helpers to the kernel > > > unless there are active uses of them. > > > > I have a lot of patches which uses new helper functions. > > Because it has dependency (add new helper 1st, use it in 2nd), and > > different maintainers (helper patch maintainers vs each driver/framwork > > maintainers), I have posted new helper patch-set 1st (= this patch-set). > > After that, I will post 2nd patch-set which uses new helper, like > > new helper patch for v6.15, each driver/framework patch for v6.16, etc. > > > > Because there are a lot of patches which uses new helpers, is it OK to > > indicates some of them (as sample patch) ? > > I am not Kees, but my point of view on this is that you may take one > subsystem which, for example, I can review (listed as a Designated > Reviewer or Maintainer in the MAINTAINERS) and add sample patches from > it. It will speed up the process as my tag would suffice. Also you can > add into the cover letter the statistics (how many drivers are > affected (per subsystem/folder) by each of the new helpers in the > upcoming series.
Yeah, I'd say just post the series you have and in the cover letter refer to this series as a prerequisite. -- Kees Cook
