Re: [PATCH v2 1/2][next] UAPI: ethtool: Use __struct_group() in struct ethtool_link_settings

2024-12-05 Thread Nick Desaulniers
On Fri, Nov 15, 2024 at 12:38:55PM -0800, Kees Cook wrote: > On Tue, Nov 12, 2024 at 07:08:32PM -0600, Gustavo A. R. Silva wrote: > > > > > > On 11/11/24 16:22, Gustavo A. R. Silva wrote: > > > > > > > > > On 09/11/24 12:02, Jakub Kicinski wrote: > > > > On Tue, 29 Oct 2024 15:55:35 -0600 Gusta

Re: [PATCH v4 1/2] kernel.h: removed REPEAT_BYTE from kernel.h

2023-12-19 Thread Nick Desaulniers
ring work, and if so, what the guidance is there? For example, consider include/linux/sysfs.h. It's 600+ lines long and contains 4 copyright assignments explicitly in sources. If we split that header file in half, which copyright assignments do we transfer to the new half, if any? -- Thanks, ~Nick Desaulniers

Re: [PATCH v3 2/2] lib/string: shrink lib/string.i via IWYU

2023-12-19 Thread Nick Desaulniers
)." > > > +#include > > Just use linux/limits.h. > > VDSO is a very special UAPI case. So it's even stricter rule > than for asm/ for using anything from there. We can add a special rule for this, Tanzir, please add. And remember to re-measure the results of that change for this patch's commit message. > > Expected result: > > #include > #include > #include > #include > #include > #include > #include > #include > #include > > #include > #include > #include > #include > > -- > With Best Regards, > Andy Shevchenko > > -- Thanks, ~Nick Desaulniers

Re: [PATCH v2 1/2] sh: Added kernel.h to word-at-a-time

2023-12-18 Thread Nick Desaulniers
cantly more soak time than this series IMO. Tanzir is also working on statistical analysis; I suspect if he analyzes include/linux/kernel.h, he can comment on whether the usage of REPEAT_BYTE is correlated with the usage of upper_* and lower_* in order to inform whether they should be grouped together or not. -- Thanks, ~Nick Desaulniers

Re: [PATCH v2 1/2] sh: Added kernel.h to word-at-a-time

2023-12-14 Thread Nick Desaulniers
mmit you picked up) Debian stable says it has 0.12.0 https://packages.debian.org/stable/b4 Debian unstable says it has 0.12.4 https://packages.debian.org/unstable/b4 IDK where 0.12.3 is coming from. Perhaps our internal mirrors are lagging behind. -- Thanks, ~Nick Desaulniers

Re: [PATCH] lib/string: shrink lib/string.i via IWYU

2023-12-11 Thread Nick Desaulniers
On Tue, Dec 5, 2023 at 1:44 PM Al Viro wrote: > > On Tue, Dec 05, 2023 at 01:39:47PM -0800, Nick Desaulniers wrote: > > > The tooling Tanzir is working on does wrap IWYU, and does support such > > mapping (of 'low level' to 'high level' headers; more so, i

Re: [PATCH] lib/string: shrink lib/string.i via IWYU

2023-12-05 Thread Nick Desaulniers
s like this myself for debugging LLVM: https://github.com/ClangBuiltLinux/llvm-dev-conf-2020/issues/3 (and recently gcc: https://github.com/ClangBuiltLinux/llvm-dev-conf-2020/issues/4) -- Thanks, ~Nick Desaulniers

Re: [PATCH] lib/string: shrink lib/string.i via IWYU

2023-12-05 Thread Nick Desaulniers
On Tue, Dec 5, 2023 at 2:15 PM Al Viro wrote: > > On Wed, Dec 06, 2023 at 12:01:56AM +0200, Andy Shevchenko wrote: > > On Tue, Dec 05, 2023 at 01:51:10PM -0800, Nick Desaulniers wrote: > > > On Tue, Dec 5, 2023 at 1:38 PM Al Viro wrote: > > > > On Tue, Dec 0

Re: [PATCH] lib/string: shrink lib/string.i via IWYU

2023-12-05 Thread Nick Desaulniers
On Tue, Dec 5, 2023 at 1:59 PM Greg KH wrote: > > On Tue, Dec 05, 2023 at 01:51:10PM -0800, Nick Desaulniers wrote: > > On Tue, Dec 5, 2023 at 1:38 PM Al Viro wrote: > > > > > > It also breeds includes of asm/*.h, by the look of the output, which is > > &g

Re: [PATCH] lib/string: shrink lib/string.i via IWYU

2023-12-05 Thread Nick Desaulniers
his work was to see if we could help automate Ingo's work. https://www.youtube.com/watch?v=eFq_oqLiXPM -- Thanks, ~Nick Desaulniers

Re: [PATCH] lib/string: shrink lib/string.i via IWYU

2023-12-05 Thread Nick Desaulniers
On Tue, Dec 5, 2023 at 1:44 PM Al Viro wrote: > > On Tue, Dec 05, 2023 at 01:39:47PM -0800, Nick Desaulniers wrote: > > > The tooling Tanzir is working on does wrap IWYU, and does support such > > mapping (of 'low level' to 'high level' headers; more so, i

Re: [PATCH] lib/string: shrink lib/string.i via IWYU

2023-12-05 Thread Nick Desaulniers
t; issue on the github. > > Sorry, no. Your tool, your workflow, of course, but I don't do github issues. > You are welcome to the contents of this reply, but I'm not using browser-based > UI without very strong reasons; this one isn't. No problem; Tanzir, please drop that part of the commit message in future patches. -- Thanks, ~Nick Desaulniers

Re: [PATCH] lib/string: shrink lib/string.i via IWYU

2023-12-05 Thread Nick Desaulniers
On Tue, Dec 5, 2023 at 1:24 PM Andrew Morton wrote: > > On Tue, 5 Dec 2023 13:14:16 -0800 Nick Desaulniers > wrote: > > > > > > > The preferred way to import bit-fiddling stuff is to include > > > . Under the hood this may include asm/bitsperlong.h. Or

Re: [PATCH] lib/string: shrink lib/string.i via IWYU

2023-12-05 Thread Nick Desaulniers
ich is implemented per arch) most of which seem to include asm-generic/bitsperlong.h. include/linux/bits.h also defines a few macros (BIT_MASK, BIT_WORD, BITS_PER_BYTE, GENMASK, etc). If lib/string.c is not using any of those, why can't we go straight to #including asm/bitsperlong.h? That should resolve to the arch specific impl which may include asm-generic/bitsperlong.h? -- Thanks, ~Nick Desaulniers