[PATCH v3 6/6] nvmem: max77759: add Maxim MAX77759 NVMEM driver

2025-02-28 Thread André Draszik
. Signed-off-by: André Draszik --- v2: * align sentinel in max77759_nvmem_of_id[] with other max77759 drivers (Christophe) --- MAINTAINERS| 1 + drivers/nvmem/Kconfig | 12 drivers/nvmem/Makefile | 2 + drivers/nvmem/max77759-nvmem.c | 156

[PATCH v3 2/6] dt-bindings: nvmem: add max77759 binding

2025-02-28 Thread André Draszik
The Maxim MAX77759 is a companion PMIC for USB Type-C applications and includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C Port Controller (TCPC), NVMEM, and a GPIO expander. This describes its storage module (NVMEM). Reviewed-by: Rob Herring (Arm) Signed-off-by: André Draszik

[PATCH v3 4/6] mfd: max77759: add Maxim MAX77759 core mfd driver

2025-02-28 Thread André Draszik
are therefore excluded from the MFD core device driver here. The GPIO and NVMEM interfaces are accessed via specific commands to the built-in microprocessor. This driver implements an API that client drivers can use for accessing those. Signed-off-by: André Draszik --- v2: * add kernel doc for

[PATCH v3 5/6] gpio: max77759: add Maxim MAX77759 gpio driver

2025-02-28 Thread André Draszik
. Signed-off-by: André Draszik --- v3: * drop duplicate init of 'handled' variable in irq handler * use boolean with IRQ_RETVAL() (Linus) * drop 'virq' variable inside irq handler to avoid confusion (Linus) * drop assignment of struct gpio_chip::owne

[PATCH v3 3/6] dt-bindings: mfd: add max77759 binding

2025-02-28 Thread André Draszik
The Maxim MAX77759 is a companion PMIC for USB Type-C applications and includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C Port Controller (TCPC), NVMEM, and a GPIO expander. This describes the top-level device. Signed-off-by: André Draszik --- v3: * drop gpio-controller and

[PATCH v3 1/6] dt-bindings: gpio: add max77759 binding

2025-02-28 Thread André Draszik
The Maxim MAX77759 is a companion PMIC for USB Type-C applications and includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C Port Controller (TCPC), NVMEM, and a GPIO expander. This describes its GPIO module. Reviewed-by: Rob Herring (Arm) Signed-off-by: André Draszik --- v2

[PATCH v3 0/6] Maxim Integrated MAX77759 PMIC MFD-based drivers

2025-02-28 Thread André Draszik
the whole charging topic in more detail. To make maintainers' work easier, I am planning to send the relevant DTS and defconfig changes via a different series, unless everything is expected to go via Lee's MFD tree in one series? Cheers, Andre' Signed-off-by: André Draszik --- Changes

Re: [PATCH v2 3/6] dt-bindings: mfd: add max77759 binding

2025-02-28 Thread André Draszik
On Fri, 2025-02-28 at 07:01 -0600, Rob Herring wrote: > On Thu, Feb 27, 2025 at 7:14 AM André Draszik > wrote: > > > > On Thu, 2025-02-27 at 07:04 -0600, Rob Herring wrote: > > > > > > > > > Why do you have GPIO properties here and in the chil

Re: [PATCH v2 5/6] gpio: max77759: add Maxim MAX77759 gpio driver

2025-02-28 Thread André Draszik
On Fri, 2025-02-28 at 10:58 +, André Draszik wrote: > Hi Linus, > > Thanks for you review! > > On Fri, 2025-02-28 at 08:10 +0100, Linus Walleij wrote: > > Hi André, > > > > thanks for your patch! > > > > mostly looks fine, given the MFD design

Re: [PATCH v2 5/6] gpio: max77759: add Maxim MAX77759 gpio driver

2025-02-28 Thread André Draszik
Hi Linus, Thanks for you review! On Fri, 2025-02-28 at 08:10 +0100, Linus Walleij wrote: > Hi André, > > thanks for your patch! > > mostly looks fine, given the MFD design is accepted. > Nitpicks below: > > On Wed, Feb 26, 2025 at 6:51 PM André Draszik > wrote:

Re: [PATCH v2 3/6] dt-bindings: mfd: add max77759 binding

2025-02-27 Thread André Draszik
On Thu, 2025-02-27 at 07:04 -0600, Rob Herring wrote: > On Wed, Feb 26, 2025 at 05:51:22PM +0000, André Draszik wrote: > > The Maxim MAX77759 is a companion PMIC for USB Type-C applications and > > includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C > >

Re: [PATCH v2 1/6] dt-bindings: gpio: add max77759 binding

2025-02-27 Thread André Draszik
On Thu, 2025-02-27 at 06:51 -0600, Rob Herring wrote: > On Thu, Feb 27, 2025 at 11:19:55AM +0000, André Draszik wrote: > > > The error is because the binding's 'description:' references the > > mfd binding using the complete path and the mfd binding is added

Re: [PATCH v2 1/6] dt-bindings: gpio: add max77759 binding

2025-02-27 Thread André Draszik
On Wed, 2025-02-26 at 14:30 -0600, Rob Herring (Arm) wrote: > > On Wed, 26 Feb 2025 17:51:20 +, André Draszik wrote: > > The Maxim MAX77759 is a companion PMIC for USB Type-C applications and > > includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C > &g

[PATCH v2 2/6] dt-bindings: nvmem: add max77759 binding

2025-02-26 Thread André Draszik
The Maxim MAX77759 is a companion PMIC for USB Type-C applications and includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C Port Controller (TCPC), NVMEM, and a GPIO expander. This describes its storage module (NVMEM). Signed-off-by: André Draszik --- v2: * drop example as the

[PATCH v2 4/6] mfd: max77759: add Maxim MAX77759 core mfd driver

2025-02-26 Thread André Draszik
are therefore excluded from the MFD core device driver here. The GPIO and NVMEM interfaces are accessed via specific commands to the built-in microprocessor. This driver implements an API that client drivers can use for accessing those. Signed-off-by: André Draszik --- v2: * add kernel doc for

Re: [PATCH 1/6] dt-bindings: mfd: add max77759 binding

2025-02-26 Thread André Draszik
On Mon, 2025-02-24 at 16:05 +, André Draszik wrote: > Hi Rob, > > Thanks for the review! > > On Mon, 2025-02-24 at 09:37 -0600, Rob Herring wrote: > > On Mon, Feb 24, 2025 at 10:28:49AM +, André Draszik wrote: > > > Add device tree binding for the Maxim M

[PATCH v2 5/6] gpio: max77759: add Maxim MAX77759 gpio driver

2025-02-26 Thread André Draszik
. Signed-off-by: André Draszik --- v2: * fix max77759_gpio_direction_from_control() * add missing error handling of devm_mutex_init() (Christophe) * align sentinel in max77759_gpio_of_id[] with other max77759 drivers (Christophe) --- MAINTAINERS | 1 + drivers/gpio/Kconfig

[PATCH v2 6/6] nvmem: max77759: add Maxim MAX77759 NVMEM driver

2025-02-26 Thread André Draszik
. Signed-off-by: André Draszik --- v2: * align sentinel in max77759_nvmem_of_id[] with other max77759 drivers (Christophe) --- MAINTAINERS| 1 + drivers/nvmem/Kconfig | 12 drivers/nvmem/Makefile | 2 + drivers/nvmem/max77759-nvmem.c | 156

[PATCH v2 1/6] dt-bindings: gpio: add max77759 binding

2025-02-26 Thread André Draszik
The Maxim MAX77759 is a companion PMIC for USB Type-C applications and includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C Port Controller (TCPC), NVMEM, and a GPIO expander. This describes its GPIO module. Signed-off-by: André Draszik --- v2: * drop 'interrupts' pr

[PATCH v2 3/6] dt-bindings: mfd: add max77759 binding

2025-02-26 Thread André Draszik
The Maxim MAX77759 is a companion PMIC for USB Type-C applications and includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C Port Controller (TCPC), NVMEM, and a GPIO expander. This describes the top-level device. Signed-off-by: André Draszik --- v2: * rename expected nvmem

[PATCH v2 0/6] Maxim Integrated MAX77759 PMIC MFD-based drivers

2025-02-26 Thread André Draszik
the whole charging topic in more detail. To make maintainers' work easier, I am planning to send the relevant DTS and defconfig changes via a different series, unless everything is expected to go via Lee's MFD tree in one series? Cheers, Andre' Signed-off-by: André Draszik --- Chang

Re: [PATCH 2/6] dt-bindings: gpio: add max77759 binding

2025-02-24 Thread André Draszik
Hi Rob, On Mon, 2025-02-24 at 09:38 -0600, Rob Herring wrote: > On Mon, Feb 24, 2025 at 10:28:50AM +0000, André Draszik wrote: > > Add the DT binding document for the GPIO module of the Maxim MAX77759. > > > > Signed-off-by: André Draszik > > --- > >  .../bindi

Re: [PATCH 4/6] mfd: max77759: add Maxim MAX77759 core mfd driver

2025-02-24 Thread André Draszik
Hi Christophe, Thanks for your review! On Mon, 2025-02-24 at 21:20 +0100, Christophe JAILLET wrote: > Le 24/02/2025 à 11:28, André Draszik a écrit : > > The Maxim MAX77759 is a companion Power Management IC for USB Type-C > > applications with Battery Charger, Fuel Gauge, temp

Re: [PATCH 3/6] dt-bindings: nvmem: add max77759 binding

2025-02-24 Thread André Draszik
On Mon, 2025-02-24 at 09:38 -0600, Rob Herring wrote: > On Mon, Feb 24, 2025 at 10:28:51AM +0000, André Draszik wrote: > > Add the DT binding document for the NVMEM module of the Maxim MAX77759. > > > > Signed-off-by: André Draszik > > --- > >  .../binding

Re: [PATCH 1/6] dt-bindings: mfd: add max77759 binding

2025-02-24 Thread André Draszik
Hi Rob, Thanks for the review! On Mon, 2025-02-24 at 09:37 -0600, Rob Herring wrote: > On Mon, Feb 24, 2025 at 10:28:49AM +0000, André Draszik wrote: > > Add device tree binding for the Maxim MAX77759 companion PMIC for USB > > Type-C applications. > > > > The MAX777

Re: [PATCH 1/6] dt-bindings: mfd: add max77759 binding

2025-02-24 Thread André Draszik
On Mon, 2025-02-24 at 14:07 +0100, Krzysztof Kozlowski wrote: > On 24/02/2025 11:28, André Draszik wrote: > > +  gpio-controller: true > > + > > +  "#gpio-cells": > > +    const: 2 > > + > > +  gpio: > > +    $ref: /schemas/gpio/maxim,max77

Re: [PATCH 1/6] dt-bindings: mfd: add max77759 binding

2025-02-24 Thread André Draszik
On Mon, 2025-02-24 at 06:48 -0600, Rob Herring (Arm) wrote: > > On Mon, 24 Feb 2025 10:28:49 +, André Draszik wrote: > > Add device tree binding for the Maxim MAX77759 companion PMIC for USB > > Type-C applications. > > > > The MAX77759 includes Battery Ch

Re: [PATCH 5/6] gpio: max77759: add Maxim MAX77759 gpio driver

2025-02-24 Thread André Draszik
On Mon, 2025-02-24 at 10:28 +, André Draszik wrote: > [...] > > +#define MAX77759_GPIOx_TRIGGER(offs, val) (((val) & 1) << (offs)) > +#define MAX77759_GPIOx_TRIGGER_MASK(offs) MAX77759_GPIOx_TRIGGER(offs, ~0) > +enum max77759_trigger_gpio_type { > + MAX7

[PATCH 4/6] mfd: max77759: add Maxim MAX77759 core mfd driver

2025-02-24 Thread André Draszik
interrupt lines and are therefore excluded from the MFD core device driver here. The GPIO and NVMEM interfaces are accessed via specific commands to the built-in microprocessor. This driver implements an API that client drivers can use for accessing those. Signed-off-by: André Draszik

[PATCH 0/6] Maxim Integrated MAX77759 PMIC MFD-based drivers

2025-02-24 Thread André Draszik
expected to go via Lee's MFD tree in one series? Cheers, Andre' Signed-off-by: André Draszik --- André Draszik (6): dt-bindings: mfd: add max77759 binding dt-bindings: gpio: add max77759 binding dt-bindings: nvmem: add max77759 binding mfd: max77759: add Maxim

[PATCH 5/6] gpio: max77759: add Maxim MAX77759 gpio driver

2025-02-24 Thread André Draszik
core MFD driver. Signed-off-by: André Draszik --- MAINTAINERS | 1 + drivers/gpio/Kconfig | 13 ++ drivers/gpio/Makefile| 1 + drivers/gpio/gpio-max77759.c | 522 +++ 4 files changed, 537 insertions(+) diff --git a

[PATCH 6/6] nvmem: max77759: add Maxim MAX77759 NVMEM driver

2025-02-24 Thread André Draszik
the core MFD driver. Signed-off-by: André Draszik --- MAINTAINERS| 1 + drivers/nvmem/Kconfig | 12 drivers/nvmem/Makefile | 2 + drivers/nvmem/max77759-nvmem.c | 156 + 4 files changed, 171 insertions(+) diff

[PATCH 2/6] dt-bindings: gpio: add max77759 binding

2025-02-24 Thread André Draszik
Add the DT binding document for the GPIO module of the Maxim MAX77759. Signed-off-by: André Draszik --- .../bindings/gpio/maxim,max77759-gpio.yaml | 47 ++ 1 file changed, 47 insertions(+) diff --git a/Documentation/devicetree/bindings/gpio/maxim,max77759-gpio.yaml

[PATCH 3/6] dt-bindings: nvmem: add max77759 binding

2025-02-24 Thread André Draszik
Add the DT binding document for the NVMEM module of the Maxim MAX77759. Signed-off-by: André Draszik --- .../bindings/nvmem/maxim,max77759-nvmem.yaml | 50 ++ 1 file changed, 50 insertions(+) diff --git a/Documentation/devicetree/bindings/nvmem/maxim,max77759

[PATCH 1/6] dt-bindings: mfd: add max77759 binding

2025-02-24 Thread André Draszik
Add device tree binding for the Maxim MAX77759 companion PMIC for USB Type-C applications. The MAX77759 includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C Port Controller (TCPC), NVMEM, and a GPIO expander. This describes the core mfd device. Signed-off-by: André Draszik