On Mon, Mar 10, 2025 at 03:46:26PM +1030, Gustavo A. R. Silva wrote:
> Hi all,
>
> As part of the efforts to globally enable -Wflex-array-member-not-at-end,
> I'm currently trying to fix the following warnings:
>
> drivers/rtc/rtc-cros-ec.c:62:40: warning: structure containing a flexible
> array
The GB200NVL BMC is an Aspeed Ast2600 based BMC
for Nvidia Blackwell GB200NVL platform.
Reference to Ast2600 SOC [1].
Reference to Blackwell GB200NVL Platform [2].
Co-developed-by: Mars Yang
Signed-off-by: Mars Yang
Cc: Krzysztof Kozlowski
Cc: Andrew Lunn
Cc: Paul Menzel
Link: Reference to Ast
acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/qcom/&
From: Jeff Xu
Initially, when mseal was introduced in 6.10, semantically, when a VMA
within the specified address range is sealed, the mprotect will be rejected,
leaving all of VMA unmodified. However, adding an extra loop to check the mseal
flag for every VMA slows things down a bit, therefore i
From: Jeff Xu
Initially, when mseal was introduced in 6.10, semantically, when a VMA
within the specified address range is sealed, the mprotect will be rejected,
leaving all of VMA unmodified. However, adding an extra loop to check the mseal
flag for every VMA slows things down a bit, therefore i
From: Jeff Xu
Modify mseal_tests to avoid using no-op mprotect.
The no-op mprotect shall be allowed.
Signed-off-by: Jeff Xu
Fixes: 4a2dd02b0916 ("mm/mprotect: replace can_modify_mm with can_modify_vma")
---
tools/testing/selftests/mm/mseal_test.c | 6 +++---
1 file changed, 3 insertions(+), 3
It does seem that using "volatile" isn't going to be sane compared to
using OPTIMIZER_HIDE_VAR() going forward. Some strange interactions[1]
with the sanitizers have been observed in the self-test code, so replace
the logic.
Reported-by: Nathan Chancellor
Closes: https://github.com/ClangBuiltLinu
It seems that Clang thinks __builtin_constant_p() of undefined variables
should return true[1]. This is being fixed separately[2], but in the
meantime, expand the fortify tests to help track this kind of thing down
faster in the future.
Link: https://github.com/ClangBuiltLinux/linux/issues/2073 [1
On Tue, Mar 11, 2025 at 3:44 PM Kees Cook wrote:
>
> When a character array without a terminating NUL character has a static
> initializer, GCC 15's -Wunterminated-string-initialization will only
> warn if the array lacks the "nonstring" attribute[1]. Mark the arrays
> with __nonstring to and corr
When a character array without a terminating NUL character has a static
initializer, GCC 15's -Wunterminated-string-initialization will only
warn if the array lacks the "nonstring" attribute[1]. Mark the arrays
with __nonstring to and correctly identify the char array as "not a C
string" and thereb
When a character array without a terminating NUL character has a static
initializer, GCC 15's -Wunterminated-string-initialization will only
warn if the array lacks the "nonstring" attribute[1]. Mark the arrays
with __nonstring to and correctly identify the char array as "not a C
string" and thereb
When a character array without a terminating NUL character has a static
initializer, GCC 15's -Wunterminated-string-initialization will only
warn if the array lacks the "nonstring" attribute[1]. Mark the arrays
with __nonstring to and correctly identify the char array as "not a C
string" and thereb
On Tue, Mar 11, 2025 at 03:12:00PM +0100, Andrew Lunn wrote:
> On Mon, Mar 10, 2025 at 03:24:16PM -0700, Kees Cook wrote:
> > GCC 15's -Wunterminated-string-initialization saw that this string was
> > being truncated. Adjust the initializer so that the needed final NUL
> > character will be present
On Tue, Mar 11, 2025 at 08:27:45AM +0100, Michal Swiatkowski wrote:
> On Mon, Mar 10, 2025 at 03:24:16PM -0700, Kees Cook wrote:
> > GCC 15's -Wunterminated-string-initialization saw that this string was
> > being truncated. Adjust the initializer so that the needed final NUL
> > character will be
On Tue, Mar 11, 2025 at 10:25:10AM +0100, Johannes Berg wrote:
> On Mon, 2025-03-10 at 15:23 -0700, Kees Cook wrote:
> >
> > drivers/net/wireless/virtual/virt_wifi.c | 2 +-
> > drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 2 +-
> >
>
> That's not mac80211?
Hrm, you're right. The automati
One more thing: do you want to update mseal.rst to add s390 as
supported architecture?
Currently in the mseal.rst:
"The following architectures currently support this feature: x86-64 and arm64."
Thanks
-Jeff
On Tue, Mar 11, 2025 at 2:55 PM Jeff Xu wrote:
>
> On Tue, Mar 11, 2025 at 5:33 AM Hei
On Tue, Mar 11, 2025 at 11:19:27AM +0100, Jakub Kicinski wrote:
> On Mon, 10 Mar 2025 15:22:50 -0700 Kees Cook wrote:
> > When a character array without a terminating NUL character has a static
> > initializer, GCC 15's -Wunterminated-string-initialization will only
> > warn if the array lacks the
On Tue, Mar 11, 2025 at 5:33 AM Heiko Carstens wrote:
>
> Provide support for CONFIG_MSEAL_SYSTEM_MAPPINGS on s390, covering the
> vdso.
>
> Signed-off-by: Heiko Carstens
> ---
> arch/s390/Kconfig | 1 +
> arch/s390/kernel/vdso.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
On Tue, Mar 11, 2025 at 5:33 AM Heiko Carstens wrote:
>
> With the introduction of the generic vdso data storage the VM_SEALED_SYSMAP
> vm flag must be moved from the architecture specific
> _install_special_mapping() call [1] [2] which maps the vvar mapping to
> generic code.
>
Thanks for fixing
On Sun, 09 Mar 2025 01:45:51 +0100, David Heidelberg wrote:
> From: Ivan Belokobylskiy
>
> Add initial support for LG Nexus 4 (mako).
>
> Features currently working: regulators, eMMC, WiFi, and volume keys.
>
> Signed-off-by: Ivan Belokobylskiy
> Signed-off-by: David Heidelberg
> ---
> Chan
GCC has expanded support of the "nonstring" attribute so that it can be
applied to arrays of character arrays[1], which is needed to identify
correct static initialization of those kinds of objects. Since this was
not supported prior to GCC 15, we need to distinguish the usage of Linux's
existing _
GCC 15's -Wunterminated-string-initialization saw that this string was
being truncated. Adjust the initializer so that the needed final NUL
character will be present.
Cc: Nicolas Ferre
Cc: Claudiu Beznea
Cc: Andrew Lunn
Cc: "David S. Miller"
Cc: Eric Dumazet
Cc: Jakub Kicinski
Cc: Paolo Aben
Hi Gustavo,
On 2025-03-11 01:01, Gustavo A. R. Silva wrote:
Hi all,
I'm trying to fix the following warning:
drivers/misc/bcm-vk/bcm_vk.h:415:32: warning: structure containing a flexible
array member is not at the end of another structure
[-Wflex-array-member-not-at-end]
after a quick look,
On Tue, Mar 11, 2025 at 01:33:26PM +0100, Heiko Carstens wrote:
> Provide support for CONFIG_MSEAL_SYSTEM_MAPPINGS on s390, covering the
> vdso.
>
> Signed-off-by: Heiko Carstens
Reviewed-by: Lorenzo Stoakes
> ---
> arch/s390/Kconfig | 1 +
> arch/s390/kernel/vdso.c | 2 +-
> 2 files cha
On Fri, Mar 07, 2025 at 06:33:13PM -0800, Peter Collingbourne wrote:
> The optimized strscpy() and dentry_string_cmp() routines will read 8
> unaligned bytes at a time via the function read_word_at_a_time(), but
> this is incompatible with MTE which will fault on a partially invalid
> read. The att
When a character array without a terminating NUL character has a static
initializer, GCC 15's -Wunterminated-string-initialization will only
warn if the array lacks the "nonstring" attribute[1]. Mark the arrays
with __nonstring to and correctly identify the char array as "not a C
string" and thereb
On Sat, 08 Mar 2025 09:30:10 +0800, Gabriel Gonzales wrote:
> This patchset introduces support for the Redmi Note 8 (codenamed ginkgo).
> This series is a follow-up to v1 (message-id in in-reply-to header) which was
> sent without a cover letter.
>
> Changes in v2:
> - Add missing cover letter
When a character array without a terminating NUL character has a static
initializer, GCC 15's -Wunterminated-string-initialization will only
warn if the array lacks the "nonstring" attribute[1]. Mark the arrays
with __nonstring to and correctly identify the char array as "not a C
string" and thereb
On Mon, Mar 10, 2025 at 10:42 PM Kees Cook wrote:
>
> GCC has expanded support of the "nonstring" attribute so that it can be
> applied to arrays of character arrays[1], which is needed to identify
> correct static initialization of those kinds of objects. Since this was
> not supported prior to G
On Tue, Mar 11, 2025 at 05:10:02PM +0100, David Heidelberg via B4 Relay wrote:
> From: Ivan Belokobylskiy
>
> Add initial support for LG Nexus 4 (mako).
>
> Features currently working: regulators, eMMC, and volume keys.
>
> Signed-off-by: Ivan Belokobylskiy
> Co-developed-by: David Heidelberg
From: Ivan Belokobylskiy
Add initial support for LG Nexus 4 (mako).
Features currently working: regulators, eMMC, and volume keys.
Signed-off-by: Ivan Belokobylskiy
Co-developed-by: David Heidelberg
Signed-off-by: David Heidelberg
---
Changes in v4:
- Sorted regulators and added regulators c
On Tue, Mar 11, 2025 at 01:33:25PM +0100, Heiko Carstens wrote:
> With the introduction of the generic vdso data storage the VM_SEALED_SYSMAP
> vm flag must be moved from the architecture specific
> _install_special_mapping() call [1] [2] which maps the vvar mapping to
> generic code.
>
> [1] https
5.4-stable review patch. If anyone has any objections, please let me know.
--
From: Kees Cook
commit d219d2a9a92e39aa92799efe8f2aa21259b6dd82 upstream.
When the check_[op]_overflow() helpers were introduced, all arguments
were required to be the same type to make the fallback
On Mon, Mar 10, 2025 at 03:24:16PM -0700, Kees Cook wrote:
> GCC 15's -Wunterminated-string-initialization saw that this string was
> being truncated. Adjust the initializer so that the needed final NUL
> character will be present.
This is where we get into the ugliness of the ethtool API for stri
On Tue, Mar 11, 2025 at 01:42:01PM +, Lorenzo Stoakes wrote:
> > Just like for arm64, and x86_64 the s390 part is just adding the new
> > vm flag to the _install_mappings() call in vdso code. Otherwise there
> > is nothing to be considered.
>
> No, they are not just adding a flag, they are ena
On Tue, Mar 11, 2025 at 03:21:14PM +0100, Heiko Carstens wrote:
> On Tue, Mar 11, 2025 at 02:09:30PM +, Lorenzo Stoakes wrote:
> > > When it comes to unmapping vdso: this would break user space since
> > > commit df29a7440c4b ("s390/signal: switch to using vdso for sigreturn
> > > and syscall r
On Tue, Mar 11, 2025 at 02:09:30PM +, Lorenzo Stoakes wrote:
> > When it comes to unmapping vdso: this would break user space since
> > commit df29a7440c4b ("s390/signal: switch to using vdso for sigreturn
> > and syscall restart") - there haven't been any reports.
>
> OK that seems to implici
On Tue, Mar 11, 2025 at 03:06:30PM +0100, Heiko Carstens wrote:
> On Tue, Mar 11, 2025 at 01:42:01PM +, Lorenzo Stoakes wrote:
> > > Just like for arm64, and x86_64 the s390 part is just adding the new
> > > vm flag to the _install_mappings() call in vdso code. Otherwise there
> > > is nothing
On Tue, Mar 11, 2025 at 02:37:36PM +0100, Heiko Carstens wrote:
> On Tue, Mar 11, 2025 at 01:02:47PM +, Lorenzo Stoakes wrote:
> > On Tue, Mar 11, 2025 at 01:33:24PM +0100, Heiko Carstens wrote:
> > > When rebasing the mseal series on top of the generic vdso data storage
> > > the VM_SEALED_SYS
On Tue, Mar 11, 2025 at 01:02:47PM +, Lorenzo Stoakes wrote:
> On Tue, Mar 11, 2025 at 01:33:24PM +0100, Heiko Carstens wrote:
> > When rebasing the mseal series on top of the generic vdso data storage
> > the VM_SEALED_SYSMAP vm flag for the vvar mapping got lost. Add that again.
>
> I'm conf
On Tue, Mar 11, 2025 at 01:59:21PM +0100, Thomas Weißschuh wrote:
> Hi Heiko,
>
> On Tue, Mar 11, 2025 at 01:33:25PM +0100, Heiko Carstens wrote:
> > With the introduction of the generic vdso data storage the VM_SEALED_SYSMAP
> > vm flag must be moved from the architecture specific
> > _install_sp
Hi Heiko,
On Tue, Mar 11, 2025 at 01:33:25PM +0100, Heiko Carstens wrote:
> With the introduction of the generic vdso data storage the VM_SEALED_SYSMAP
> vm flag must be moved from the architecture specific
> _install_special_mapping() call [1] [2] which maps the vvar mapping to
> generic code.
I
On Tue, Mar 11, 2025 at 01:33:24PM +0100, Heiko Carstens wrote:
> When rebasing the mseal series on top of the generic vdso data storage
> the VM_SEALED_SYSMAP vm flag for the vvar mapping got lost. Add that again.
I'm confused by this? Some merge patch resolution thing?
I don't think this should
With the introduction of the generic vdso data storage the VM_SEALED_SYSMAP
vm flag must be moved from the architecture specific
_install_special_mapping() call [1] [2] which maps the vvar mapping to
generic code.
[1] https://lkml.kernel.org/r/20250305021711.3867874-4-jef...@google.com
[2] https:/
When rebasing the mseal series on top of the generic vdso data storage
the VM_SEALED_SYSMAP vm flag for the vvar mapping got lost. Add that again.
Also add s390 support for MSEAL_SYSTEM_MAPPINGS.
Heiko Carstens (2):
mseal sysmap: generic vdso vvar mapping
mseal sysmap: enable s390
arch/s390
Provide support for CONFIG_MSEAL_SYSTEM_MAPPINGS on s390, covering the
vdso.
Signed-off-by: Heiko Carstens
---
arch/s390/Kconfig | 1 +
arch/s390/kernel/vdso.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
index 608a965e2344..93
On Mon, 10 Mar 2025 15:25:31 -0700, Kees Cook wrote:
> When a character array without a terminating NUL character has a static
> initializer, GCC 15's -Wunterminated-string-initialization will only
> warn if the array lacks the "nonstring" attribute[1]. Mark the arrays
> with __nonstring to and cor
On Mon, Mar 10, 2025 at 07:37:32PM +, Mark Rutland wrote:
> On Mon, Mar 10, 2025 at 06:40:11PM +, Catalin Marinas wrote:
> > On Mon, Mar 10, 2025 at 06:13:58PM +, Mark Rutland wrote:
> > > On Mon, Mar 10, 2025 at 05:37:50PM +, Catalin Marinas wrote:
> > > > On Fri, Mar 07, 2025 at 0
On Tue, 2025-03-11 at 11:40 +0100, Johannes Berg wrote:
> On Mon, 2025-03-10 at 14:17 +1030, Gustavo A. R. Silva wrote:
> > Hi all,
> >
> > I wonder who can take this patch, please. :)
> >
>
> At the very least you're going to have to resend, I don't have the patch
> in patchwork any more.
>
O
On Tue, Mar 11, 2025 at 11:45:21AM +, Catalin Marinas wrote:
> On Mon, Mar 10, 2025 at 07:37:32PM +, Mark Rutland wrote:
> > I was worried that ex_handler_load_unaligned_zeropad() might not do the
> > right thing in response to a tag check fault (e.g. access the wrong 8
> > bytes), but it l
On Mon, 2025-03-10 at 14:17 +1030, Gustavo A. R. Silva wrote:
> Hi all,
>
> I wonder who can take this patch, please. :)
>
At the very least you're going to have to resend, I don't have the patch
in patchwork any more.
johannes
On Mon, 10 Mar 2025 15:22:50 -0700 Kees Cook wrote:
> When a character array without a terminating NUL character has a static
> initializer, GCC 15's -Wunterminated-string-initialization will only
> warn if the array lacks the "nonstring" attribute[1]. Mark the arrays
> with __nonstring to and corr
Hi,
On 10-Mar-25 11:25 PM, Kees Cook wrote:
> When a character array without a terminating NUL character has a static
> initializer, GCC 15's -Wunterminated-string-initialization will only
> warn if the array lacks the "nonstring" attribute[1]. Mark the arrays
> with __nonstring to and correctly i
Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of
a flexible structure where the size of the flexible-array member
is known at compile-time, and refactor the rest of the code,
accordingly.
So, with these changes, fix the following warning:
drivers/firewire/core-cdev.c:1141:38: warn
On Mon, 2025-03-10 at 15:23 -0700, Kees Cook wrote:
>
> drivers/net/wireless/virtual/virt_wifi.c | 2 +-
> drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 2 +-
>
That's not mac80211?
Also, I have no idea how you came up with the CC list but it seems
excessive. :)
johannes
Hi all,
I'm trying to fix the following warning:
drivers/misc/bcm-vk/bcm_vk.h:415:32: warning: structure containing a flexible
array member is not at the end of another structure
[-Wflex-array-member-not-at-end]
after a quick look, I don't see any code directly using the flexible
array `data[]
On 10.03.25 23:22, Kees Cook wrote:
When a character array without a terminating NUL character has a static
initializer, GCC 15's -Wunterminated-string-initialization will only
warn if the array lacks the "nonstring" attribute[1]. Mark the arrays
with __nonstring to and correctly identify the cha
On Mon, Mar 10, 2025 at 03:24:16PM -0700, Kees Cook wrote:
> GCC 15's -Wunterminated-string-initialization saw that this string was
> being truncated. Adjust the initializer so that the needed final NUL
> character will be present.
>
> Cc: Nicolas Ferre
> Cc: Claudiu Beznea
> Cc: Andrew Lunn
>
58 matches
Mail list logo
