Re: [PATCH] md/md-multipath: Convert "struct mpconf" to flexible array

2023-12-07 Thread Song Liu
On Mon, Dec 4, 2023 at 2:20 PM Kees Cook wrote: > > On Sun, Dec 03, 2023 at 08:48:06PM +0100, Christophe JAILLET wrote: > > The 'multipaths' field of 'struct mpconf' can be declared as a flexible > > array. > > > > The advantages are: > >- 1 less indirection when accessing to the 'multipaths'

Re: (subset) [PATCH v11 1/2] dt-bindings: arm: qcom: Add Xiaomi Pad 6 (xiaomi-pipa)

2023-12-07 Thread Bjorn Andersson
On Sat, 25 Nov 2023 23:03:14 +0100, Luka Panio wrote: > Add a compatible for Xiaomi Pad 6. > > Applied, thanks! [1/2] dt-bindings: arm: qcom: Add Xiaomi Pad 6 (xiaomi-pipa) commit: 25bb226508a1384723b201da8bd5c16ac57f34cd [2/2] arm64: dts: qcom: sm8250-xiaomi-pipa: Add initial device tr

Re: (subset) [PATCH v2 1/9] arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered

2023-12-07 Thread Bjorn Andersson
On Mon, 06 Nov 2023 14:43:28 -0800, Douglas Anderson wrote: > On sc7180 when the watchdog timer fires your logs get filled with: > watchdog0: pretimeout event > watchdog0: pretimeout event > watchdog0: pretimeout event > ... > watchdog0: pretimeout event > > [...] Applied, thanks! [1

[PATCH] arm64: smp: smp_send_stop() and crash_smp_send_stop() should try non-NMI first

2023-12-07 Thread Douglas Anderson
When testing hard lockup handling on my sc7180-trogdor-lazor device with pseudo-NMI enabled, with serial console enabled and with kgdb disabled, I found that the stack crawls printed to the serial console ended up as a jumbled mess. After rebooting, the pstore-based console looked fine though. Also

Re: [PATCH v2] net: mdio-gpio: replace deprecated strncpy with strscpy

2023-12-07 Thread Russell King (Oracle)
On Thu, Dec 07, 2023 at 09:54:31PM +, Justin Stitt wrote: > We expect new_bus->id to be NUL-terminated but not NUL-padded based on > its prior assignment through snprintf: > | snprintf(new_bus->id, MII_BUS_ID_SIZE, "gpio-%x", bus_id); > > We can also use sizeof() instead of a length macr

[PATCH v2] net: mdio_bus: replace deprecated strncpy with strscpy

2023-12-07 Thread Justin Stitt
strncpy() is deprecated for use on NUL-terminated destination strings [1] and as such we should prefer more robust and less ambiguous string interfaces. We expect mdiodev->modalias to be NUL-terminated based on its usage with strcmp(): | return strcmp(mdiodev->modalias, drv->name) == 0; Mor

[PATCH v2] net: mdio-gpio: replace deprecated strncpy with strscpy

2023-12-07 Thread Justin Stitt
strncpy() is deprecated for use on NUL-terminated destination strings [1] and as such we should prefer more robust and less ambiguous string interfaces. We expect new_bus->id to be NUL-terminated but not NUL-padded based on its prior assignment through snprintf: | snprintf(new_bus->id, MII_B

RE: [PATCH v2] net: ena: replace deprecated strncpy with strscpy

2023-12-07 Thread Kiyanovski, Arthur
> -Original Message- > From: justinst...@google.com > > `strncpy` is deprecated for use on NUL-terminated destination strings [1] and > as > such we should prefer more robust and less ambiguous string interfaces. > > A suitable replacement is `strscpy` [2] due to the fact that it guaran

[PATCH v2] qlcnic: replace deprecated strncpy with strscpy

2023-12-07 Thread Justin Stitt
strncpy() is deprecated for use on NUL-terminated destination strings [1] and as such we should prefer more robust and less ambiguous string interfaces. We expect fw_info->fw_file_name to be NUL-terminated based on its use within _request_firmware_prepare() wherein `name` refers to it: | if

[PATCH v2] net: ena: replace deprecated strncpy with strscpy

2023-12-07 Thread justinstitt
`strncpy` is deprecated for use on NUL-terminated destination strings [1] and as such we should prefer more robust and less ambiguous string interfaces. A suitable replacement is `strscpy` [2] due to the fact that it guarantees NUL-termination on the destination buffer without unnecessarily NUL-pa

Re: [PATCH v2] net: dsa: lan9303: use ethtool_sprintf() for lan9303_get_strings()

2023-12-07 Thread Justin Stitt
On Fri, Dec 1, 2023 at 10:19 AM Kees Cook wrote: > > On Thu, Nov 30, 2023 at 10:40:21PM -0800, Jakub Kicinski wrote: > > On Thu, 30 Nov 2023 13:59:58 -0800 Kees Cook wrote: > > > Applied to for-next/hardening, thanks! > > > > > > [1/1] net: dsa: lan9303: use ethtool_sprintf() for lan9303_get_strin

Re: [PATCH v2 13/18] sysctl: move sysctl type to ctl_table_header

2023-12-07 Thread Thomas Weißschuh
On 2023-12-07 13:14:37+0100, Joel Granados wrote: > On Wed, Dec 06, 2023 at 06:53:10AM +0100, Thomas Weißschuh wrote: > > On 2023-12-05 14:50:01-0800, Luis Chamberlain wrote: > > > On Tue, Dec 5, 2023 at 2:41 PM Thomas Weißschuh > > > wrote: > > > > > > > > On 2023-12-05 14:33:38-0800, Luis Chamb

Re: [PATCH v2 00/18] sysctl: constify sysctl ctl_tables

2023-12-07 Thread Thomas Weißschuh
On 2023-12-07 12:19:57+0100, Joel Granados wrote: > On Tue, Dec 05, 2023 at 06:16:53PM +0100, Thomas Weißschuh wrote: > > Hi Luis, Joel, > > > > On 2023-12-05 09:04:08+0100, Thomas Weißschuh wrote: > > > On 2023-12-04 21:50:14-0800, Luis Chamberlain wrote: > > > > On Mon, Dec 04, 2023 at 08:52:13A

Re: [PATCH v2 00/18] sysctl: constify sysctl ctl_tables

2023-12-07 Thread Thomas Weißschuh
On 2023-12-07 11:43:57+0100, Joel Granados wrote: > Hey Thomas > > You have a couple of test bot issues for your 12/18 patch. Can you > please address those for your next version. I have these fixed locally, I assumed Luis would also pick them up directly until I have a proper v2, properly should

Re: [PATCH v2 03/18] sysctl: drop sysctl_is_perm_empty_ctl_table

2023-12-07 Thread Joel Granados
If you are separating the work for permanently empty directories, you can add this patch to that set. as well as 2/18 Best On Mon, Dec 04, 2023 at 08:52:16AM +0100, Thomas Weißschuh wrote: > It is used only once and that caller would be simpler with > sysctl_is_perm_empty_ctl_header(). > So use t

Re: [PATCH] lib/string: shrink lib/string.i via IWYU

2023-12-07 Thread Andy Shevchenko
On Wed, Dec 06, 2023 at 03:10:46PM +0800, kernel test robot wrote: > Hi, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on 33cc938e65a98f1d29d0a18403dbbee050dcad9a] > > url: > https://github.com/intel-lab-lkp/linux/commits/tanzirh-google-com/lib-string-s

Re: [PATCH] lib/string: shrink lib/string.i via IWYU

2023-12-07 Thread Andy Shevchenko
On Tue, Dec 05, 2023 at 10:15:21PM +, Al Viro wrote: > On Wed, Dec 06, 2023 at 12:01:56AM +0200, Andy Shevchenko wrote: > > On Tue, Dec 05, 2023 at 01:51:10PM -0800, Nick Desaulniers wrote: > > > On Tue, Dec 5, 2023 at 1:38 PM Al Viro wrote: > > > > On Tue, Dec 05, 2023 at 08:58:53PM +, ta

Re: [PATCH] lib/string: shrink lib/string.i via IWYU

2023-12-07 Thread Andy Shevchenko
On Tue, Dec 05, 2023 at 02:14:55PM -0800, Nick Desaulniers wrote: > On Tue, Dec 5, 2023 at 1:59 PM Greg KH wrote: ... > For example, lib/math/int_log.c includes asm/bug.h. Is that a case > where lib/math/int_log.c should be #include 'ing linux/bug.h rather > than asm/bug.h? For the C-files it'

Re: [PATCH v2 13/18] sysctl: move sysctl type to ctl_table_header

2023-12-07 Thread Joel Granados
On Wed, Dec 06, 2023 at 06:53:10AM +0100, Thomas Weißschuh wrote: > On 2023-12-05 14:50:01-0800, Luis Chamberlain wrote: > > On Tue, Dec 5, 2023 at 2:41 PM Thomas Weißschuh > > wrote: > > > > > > On 2023-12-05 14:33:38-0800, Luis Chamberlain wrote: > > > > On Mon, Dec 04, 2023 at 08:52:26AM +0100

Re: [PATCH v2 13/18] sysctl: move sysctl type to ctl_table_header

2023-12-07 Thread Joel Granados
On Tue, Dec 05, 2023 at 02:50:01PM -0800, Luis Chamberlain wrote: > On Tue, Dec 5, 2023 at 2:41 PM Thomas Weißschuh wrote: > > > > On 2023-12-05 14:33:38-0800, Luis Chamberlain wrote: > > > On Mon, Dec 04, 2023 at 08:52:26AM +0100, Thomas Weißschuh wrote: > > > > @@ -231,7 +231,8 @@ static int ins

Re: [PATCH v2 13/18] sysctl: move sysctl type to ctl_table_header

2023-12-07 Thread Joel Granados
This is the patch that I said could be on its own to facilitate review On Mon, Dec 04, 2023 at 08:52:26AM +0100, Thomas Weißschuh wrote: > In a future commit the sysctl core will only use > "const struct ctl_table". As a preparation for that move this mutable > field from "struct ctl_table" to "st

Re: [PATCH v2 00/18] sysctl: constify sysctl ctl_tables

2023-12-07 Thread Joel Granados
On Tue, Dec 05, 2023 at 02:27:04PM -0800, Luis Chamberlain wrote: > On Tue, Dec 05, 2023 at 06:16:53PM +0100, Thomas Weißschuh wrote: > > Hi Luis, Joel, > > > > On 2023-12-05 09:04:08+0100, Thomas Weißschuh wrote: > > > On 2023-12-04 21:50:14-0800, Luis Chamberlain wrote: > > > > On Mon, Dec 04, 2

Re: [PATCH v2 00/18] sysctl: constify sysctl ctl_tables

2023-12-07 Thread Joel Granados
On Tue, Dec 05, 2023 at 06:16:53PM +0100, Thomas Weißschuh wrote: > Hi Luis, Joel, > > On 2023-12-05 09:04:08+0100, Thomas Weißschuh wrote: > > On 2023-12-04 21:50:14-0800, Luis Chamberlain wrote: > > > On Mon, Dec 04, 2023 at 08:52:13AM +0100, Thomas Weißschuh wrote: > > > > Tested by booting and

Re: [PATCH v2 00/18] sysctl: constify sysctl ctl_tables

2023-12-07 Thread Joel Granados
On Tue, Dec 05, 2023 at 09:04:08AM +0100, Thomas Weißschuh wrote: > On 2023-12-04 21:50:14-0800, Luis Chamberlain wrote: > > On Mon, Dec 04, 2023 at 08:52:13AM +0100, Thomas Weißschuh wrote: > > > Tested by booting and with the sysctl selftests on x86. > > > > Can I trouble you to rebase on sysctl

Re: [PATCH v2 00/18] sysctl: constify sysctl ctl_tables

2023-12-07 Thread Joel Granados
Hey Thomas You have a couple of test bot issues for your 12/18 patch. Can you please address those for your next version. On Mon, Dec 04, 2023 at 08:52:13AM +0100, Thomas Weißschuh wrote: > Problem description: > > The kernel contains a lot of struct ctl_table throught the tree. > These are very