Re: Trying to work with the tests

2024-04-22 Thread Ian Kent
On 22/4/24 19:30, Jingbo Xu wrote: On 4/22/24 5:12 PM, Gao Xiang wrote: Hi Ian, (+Cc Jingbo here). On 2024/4/22 16:31, Ian Kent wrote: I'm new to the list so Hi to all, I'm working with a heavily patched 5.14 kernel and I've gathered together patches to bring erofs up to 5.19 and I'm tryi

Re: Trying to work with the tests

2024-04-22 Thread Ian Kent
On 22/4/24 17:12, Gao Xiang wrote: Hi Ian, (+Cc Jingbo here). On 2024/4/22 16:31, Ian Kent wrote: I'm new to the list so Hi to all, I'm working with a heavily patched 5.14 kernel and I've gathered together patches to bring erofs up to 5.19 and I'm trying to run the erofs and fscache tests

Re: [PATCH -next v3 2/2] erofs: reliably distinguish block based and fscache mode

2024-04-22 Thread Jingbo Xu
On 4/19/24 8:36 PM, Baokun Li wrote: > From: Christian Brauner > > When erofs_kill_sb() is called in block dev based mode, s_bdev may not > have been initialised yet, and if CONFIG_EROFS_FS_ONDEMAND is enabled, > it will be mistaken for fscache mode, and then attempt to free an anon_dev > that

Re: [PATCH -next v3 1/2] erofs: get rid of erofs_fs_context

2024-04-22 Thread Jingbo Xu
On 4/22/24 7:31 PM, Baokun Li wrote: > Hi Jingbo, > > On 2024/4/22 18:25, Jingbo Xu wrote: >> >> On 4/19/24 8:36 PM, Baokun Li wrote: >> >>> @@ -761,12 +747,15 @@ static void erofs_free_dev_context(struct >>> erofs_dev_context *devs) >>>     static void erofs_fc_free(struct fs_context *fc) >>>

Re: [PATCH -next v3 1/2] erofs: get rid of erofs_fs_context

2024-04-22 Thread Baokun Li via Linux-erofs
Hi Jingbo, On 2024/4/22 18:25, Jingbo Xu wrote: On 4/19/24 8:36 PM, Baokun Li wrote: @@ -761,12 +747,15 @@ static void erofs_free_dev_context(struct erofs_dev_context *devs) static void erofs_fc_free(struct fs_context *fc) { - struct erofs_fs_context *ctx = fc->fs_private; +

[PATCH v2] erofs-utils: fsck: extract chunk-based file with hole correctly

2024-04-22 Thread Yifan Zhao
Currently fsck skips file extraction if it finds that EROFS_MAP_MAPPED is unset, which is not the case for chunk-based files with hole. This patch handles the corner case correctly. Signed-off-by: Yifan Zhao --- changelog since v1: - use lseek instead of write zero to the hole fsck/main.c | 11

Re: Trying to work with the tests

2024-04-22 Thread Jingbo Xu
On 4/22/24 5:12 PM, Gao Xiang wrote: > Hi Ian, > > (+Cc Jingbo here). > > On 2024/4/22 16:31, Ian Kent wrote: >> I'm new to the list so Hi to all, >> >> >> I'm working with a heavily patched 5.14 kernel and I've gathered >> together patches to bring erofs >> >> up to 5.19 and I'm trying to run

Re: [PATCH] erofs-utils: fsck: extract chunk-based file with hole correctly

2024-04-22 Thread Gao Xiang
On 2024/4/22 18:05, Yifan Zhao wrote: Currently fsck skips file extraction if it finds that EROFS_MAP_MAPPED is unset, which is not the case for chunk-based files with hole. This patch handles the corner case correctly. Signed-off-by: Yifan Zhao --- fsck/main.c | 13 + 1 file

Re: [PATCH -next v3 1/2] erofs: get rid of erofs_fs_context

2024-04-22 Thread Jingbo Xu
On 4/19/24 8:36 PM, Baokun Li wrote: > @@ -761,12 +747,15 @@ static void erofs_free_dev_context(struct > erofs_dev_context *devs) > > static void erofs_fc_free(struct fs_context *fc) > { > - struct erofs_fs_context *ctx = fc->fs_private; > + struct erofs_sb_info *sbi = fc->s_fs_inf

[PATCH] erofs-utils: fsck: extract chunk-based file with hole correctly

2024-04-22 Thread Yifan Zhao
Currently fsck skips file extraction if it finds that EROFS_MAP_MAPPED is unset, which is not the case for chunk-based files with hole. This patch handles the corner case correctly. Signed-off-by: Yifan Zhao --- fsck/main.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) dif

Re: Trying to work with the tests

2024-04-22 Thread Gao Xiang
Hi Ian, (+Cc Jingbo here). On 2024/4/22 16:31, Ian Kent wrote: I'm new to the list so Hi to all, I'm working with a heavily patched 5.14 kernel and I've gathered together patches to bring erofs up to 5.19 and I'm trying to run the erofs and fscache tests from a checkout of the 1.7.1 repo.

Trying to work with the tests

2024-04-22 Thread Ian Kent
I'm new to the list so Hi to all, I'm working with a heavily patched 5.14 kernel and I've gathered together patches to bring erofs up to 5.19 and I'm trying to run the erofs and fscache tests from a checkout of the 1.7.1 repo. (branch experimental-tests-fscache) and I have a couple of fail