Re: [PATCH 1/3] erofs-utils: determine the [un]compressed data block is inline or not early

2024-04-18 Thread Noboru Asai
Hi Gao, Thank you for your kind explanation. I respect your policy. Please let me know if you change your mind, since I will maintainance this patch personally. 2024年4月18日(木) 16:37 Gao Xiang : > > Hi Noboru, > > On Thu, Apr 18, 2024 at 02:52:29PM +0900, Noboru Asai wrote: > > Introducing erofs_g

[PATCH -next] erofs: get rid of erofs_fs_context

2024-04-18 Thread Baokun Li via Linux-erofs
Instead of allocating the erofs_sb_info in get_tree() allocate it during init_fs_context() and after this erofs_fs_context is no longer needed, so replace ctx with sbi, no functional changes. Suggested-by: Jingbo Xu Signed-off-by: Baokun Li --- Hi Gao Xiang, Hi Jingbo, I noticed that Christian'

Re: [PATCH] fs/erofs: add DEFLATE algorithm support

2024-04-18 Thread Tom Rini
On Sun, 14 Apr 2024 23:04:14 +0800, Jianan Huang wrote: > This patch adds DEFLATE compression algorithm support. It's a good choice > to trade off between compression ratios and performance compared to LZ4. > Alternatively, DEFLATE could be used for some specific files since EROFS > supports multi

[PATCH v2] erofs-utils: mkfs: skip the redundant write for ztailpacking block

2024-04-18 Thread Gao Xiang
From: Yifan Zhao z_erofs_merge_segment() doesn't consider the ztailpacking block in the extent list and unnecessarily writes it back to the disk. This patch fixes this issue by introducing a new `inlined` field in the struct `z_erofs_inmem_extent`. Fixes: 830b27bc2334 ("erofs-utils: mkfs: introd

Re: [PATCH v2] erofs: reliably distinguish block based and fscache mode

2024-04-18 Thread Baokun Li via Linux-erofs
On 2024/4/18 15:49, Gao Xiang wrote: Hi, On Thu, Apr 18, 2024 at 02:12:39PM +0800, Baokun Li wrote: On 2024/4/18 13:50, Jingbo Xu wrote: On 4/18/24 11:36 AM, Baokun Li wrote: On 2024/4/18 10:16, Jingbo Xu wrote: Hi Baokun, Thanks for catching this and move forward fixing this! Hi Jingbo,

Re: [PATCH v2] erofs: reliably distinguish block based and fscache mode

2024-04-18 Thread Gao Xiang
Hi, On Thu, Apr 18, 2024 at 02:12:39PM +0800, Baokun Li wrote: > On 2024/4/18 13:50, Jingbo Xu wrote: > > > > On 4/18/24 11:36 AM, Baokun Li wrote: > > > On 2024/4/18 10:16, Jingbo Xu wrote: > > > > Hi Baokun, > > > > > > > > Thanks for catching this and move forward fixing this! > > > Hi Jingbo

Re: [PATCH 1/3] erofs-utils: determine the [un]compressed data block is inline or not early

2024-04-18 Thread Gao Xiang
Hi Noboru, On Thu, Apr 18, 2024 at 02:52:29PM +0900, Noboru Asai wrote: > Introducing erofs_get_inodesize function and erofs_get_lowest_offset function, > we can determine the [un]compressed data block is inline or not before > executing z_erofs_merge_segment function. It enable the following, >