Hi Noboru, On Thu, Apr 18, 2024 at 02:52:29PM +0900, Noboru Asai wrote: > Introducing erofs_get_inodesize function and erofs_get_lowest_offset function, > we can determine the [un]compressed data block is inline or not before > executing z_erofs_merge_segment function. It enable the following, > > * skip the redundant write for ztailpacking block. > * simplify erofs_prepare_inode_buffer function. (remove handling ENOSPC error) > > Signed-off-by: Noboru Asai <a...@sijam.com>
I appreciate and thanks for your effort and time. Yet I tend to avoid assuming if the inline is ok or not before prepare_inode_buffer() since it will be free for space allocator to decide inline or not at that time. So personally I still would like to write a final compressed index for inline fallback. I will fix this issue myself later (it should be just a small patch to fix this). Thanks for your effort on this issue again! Thanks, Gao Xiang
