Re: [PATCH v3 2/3] dt-bindings: i3c: Document Synopsys DesignWare I3C master bindings

2018-11-13 Thread vitor
Hi Boris, On 12/11/18 09:17, Boris Brezillon wrote: On Thu, 8 Nov 2018 17:14:10 + Vitor soares wrote: Document Synopsys DesignWare I3C master module Signed-off-by: Vitor soares --- Changes in v3: - Remove dummy characters Changes in v2: - Address the changes in Documentation

Re: [PATCH v3 2/3] dt-bindings: i3c: Document Synopsys DesignWare I3C master bindings

2018-11-13 Thread vitor
Hi Rob, On 13/11/18 02:09, Rob Herring wrote: On Thu, Nov 08, 2018 at 05:14:10PM +, Vitor soares wrote: Document Synopsys DesignWare I3C master module Signed-off-by: Vitor soares Please make your author and S-o-b emails match. This is an alias and both email will work. Anyway I agree

Re: [PATCH v10 0/9] Add the I3C subsystem

2018-11-15 Thread vitor
through the /sys as you plan for SETNEWDA . What do you think about this? Best regards, Vitor Soares

Re: [PATCH v10 0/9] Add the I3C subsystem

2018-11-15 Thread vitor
Hi, On 15/11/18 12:57, Boris Brezillon wrote: +Mark Brown for the question about /dev/spidev Hi Vitor, On Thu, 15 Nov 2018 12:14:37 + vitor wrote: Hi Boris, Given the current state of the subsystem I think it might worth start to think how to expose the devices under /dev. Thanks for

Re: [PATCH v10 0/9] Add the I3C subsystem

2018-11-15 Thread vitor
what a low-level interface to the device looks like in the kernel? Can this be abstracted as simply pread()/pwrite() plus an interrupt mechanism, or do we need a set of ioctl() operations as well? Like in i2c is likely to need the ioctl() too. Best regards, Vitor Soares

Re: [PATCH v10 0/9] Add the I3C subsystem

2018-11-15 Thread vitor
ffort on designing it without a user in sight. I kind of agree with that. Vitor, do you have a use case in mind for such userspace drivers? I don't think it's worth designing an API for something we don't need (yet). My use case is a tool for tests, lets say like the i2c to

Re: [PATCH v10 0/9] Add the I3C subsystem

2018-11-16 Thread vitor
Hi Boris, On 15/11/18 19:00, Boris Brezillon wrote: On Thu, 15 Nov 2018 18:03:47 + vitor wrote: Hi Boris, On 15/11/18 15:28, Boris Brezillon wrote: On Thu, 15 Nov 2018 16:01:37 +0100 Wolfram Sang wrote: Hi Boris, What we could do though, is expose I3C devices that do not

Re: [PATCH v10 0/9] Add the I3C subsystem

2018-11-19 Thread vitor
Hi Boris, On 16/11/18 13:16, Boris Brezillon wrote: On Fri, 16 Nov 2018 12:31:42 + vitor wrote: Hi Boris, On 15/11/18 19:00, Boris Brezillon wrote: On Thu, 15 Nov 2018 18:03:47 + vitor wrote: Hi Boris, On 15/11/18 15:28, Boris Brezillon wrote: On Thu, 15 Nov 2018 16:01:37

Re: [PATCH v10 0/9] Add the I3C subsystem

2018-11-19 Thread vitor
On 19/11/18 12:43, Boris Brezillon wrote: I know [1], but there might be other subsystems doing the same thing. [1]https://urldefense.proofpoint.com/v2/url?u=https-3A__elixir.bootlin.com_linux_v4.20-2Drc3_source_drivers_spi_spidev.c&d=DwIFaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=qVuU64u9x77Y0Kd0PhDK_lpxFgg

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-23 Thread vitor
Hi Boris, On 22/11/18 20:02, Boris Brezillon wrote: On Thu, 22 Nov 2018 17:54:54 + Vitor Soares wrote: From: Vitor Soares This patch slipts dw-i3c-master.c into three pieces: dw-i3c-master.c - contains the code that interacts directly with the core in master mode

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-26 Thread vitor
Hi Boris, On 23/11/18 12:50, Boris Brezillon wrote: On Fri, 23 Nov 2018 12:39:31 + vitor wrote: Hi Boris, On 22/11/18 20:02, Boris Brezillon wrote: On Thu, 22 Nov 2018 17:54:54 + Vitor Soares wrote: From: Vitor Soares This patch slipts dw-i3c-master.c into three pieces

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-26 Thread vitor
On 26/11/18 12:35, Boris Brezillon wrote: On Mon, 26 Nov 2018 12:06:24 + vitor wrote: Hi Boris, On 23/11/18 12:50, Boris Brezillon wrote: On Fri, 23 Nov 2018 12:39:31 + vitor wrote: Hi Boris, On 22/11/18 20:02, Boris Brezillon wrote: On Thu, 22 Nov 2018 17:54:54 +

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-26 Thread vitor
On 26/11/18 19:08, Boris Brezillon wrote: On Mon, 26 Nov 2018 19:56:18 +0100 Boris Brezillon wrote:     - for the others it will easy the SoC integration avoiding duplicated work and doing things from scratch. What would be duplicated? You want to support a new SoC, just add a new entry

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-26 Thread vitor
On 26/11/18 18:56, Boris Brezillon wrote: On Mon, 26 Nov 2018 18:33:37 + vitor wrote: On 26/11/18 12:35, Boris Brezillon wrote: On Mon, 26 Nov 2018 12:06:24 + vitor wrote: Hi Boris, On 23/11/18 12:50, Boris Brezillon wrote: On Fri, 23 Nov 2018 12:39:31 + vitor wrote

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-27 Thread vitor
Hi Boris On 26/11/18 21:33, Boris Brezillon wrote: On Mon, 26 Nov 2018 20:11:39 + vitor wrote: Look at the bus discovery mechanism, the notion of DCR (close to the concept of USB class), or the fact that each dev has a unique manufacturer+PID pair (which resemble the product/vendor ID

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-12-03 Thread vitor
Hi Boris, Sorry for the delayed response. On 27/11/18 12:33, Boris Brezillon wrote: Hi Vitor, On Tue, 27 Nov 2018 11:50:53 + vitor wrote: Sorry for that and don't take me wrong... maybe I should rise this question early but this only came up now when I started splitting and thi

Re: [PATCH v10 0/9] Add the I3C subsystem

2018-10-26 Thread vitor
r codes (M0 to M2) so that the core and device drivers can have fine grained information on what caused an EIO error. Only minor things happened between v3 and v5 (you can go check the changelog in each patch for more details). Main changes between v2 and v3 are: - Reworked the DT bindings as sugg

Re: [PATCH v10 0/9] Add the I3C subsystem

2018-10-26 Thread vitor
On 26/10/18 17:15, Boris Brezillon wrote: On Fri, 26 Oct 2018 16:22:06 +0100 vitor wrote: Can you update the i3c/next tree? Done. Thanks. I will apply the driver and them I give you feedback.

Re: [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP

2018-11-07 Thread vitor
Hi Matthew, Thank for your feedback. On 29/10/18 13:41, Matthew Wilcox wrote: On Mon, Oct 29, 2018 at 10:06:56AM +, Vitor soares wrote: +config DW_I3C_MASTER + tristate "Synospsys DesignWare I3C master driver" + depends on I3C + depends on !(ALPHA || PA

Re: [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP

2018-11-07 Thread vitor
Hi Geert, On 07/11/18 15:34, Geert Uytterhoeven wrote: Hi Vitor, On Wed, Nov 7, 2018 at 4:15 PM vitor wrote: On 29/10/18 13:41, Matthew Wilcox wrote: On Mon, Oct 29, 2018 at 10:06:56AM +, Vitor soares wrote: +config DW_I3C_MASTER +tristate "Synospsys DesignWare I3C master d

Re: [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP

2018-11-07 Thread vitor
Hi Matthew, On 07/11/18 17:05, Matthew Wilcox wrote: On Mon, Oct 29, 2018 at 10:06:56AM +, Vitor soares wrote: Add driver for Synopsys DesignWare I3C master IP The so-called "data sheet" (actually just an advertising brochure) The datasheet is there to download. on yo

Re: [PATCH v2 0/7] Add the I3C subsystem

2018-02-22 Thread Vitor Soares
Hi Boris, We are very interested in your I3C subsystem proposal and we would like to colaborate with you in order to add support for the Synopsys Host Controller. We are doing the review for this patch-set and will send our conclusions as soon as possible. Best regards, Vitor Soares Às

Re: [PATCH v2 2/7] i3c: Add core I3C infrastructure

2018-02-23 Thread Vitor Soares
more space for an extra IBI registration > + * @free_ibi: free an IBI previously requested with ->request_ibi(). The IBI > + * should have been disabled with ->disable_irq() prior to that > + * @enable_ibi: enable the IBI. Only valid if ->request_ibi() has been calle

Re: [PATCH v2 2/7] i3c: Add core I3C infrastructure

2018-02-26 Thread Vitor Soares
Hi Boris Às 8:30 PM de 2/23/2018, Boris Brezillon escreveu: > Hi Vitor, > > On Fri, 23 Feb 2018 16:56:14 +0000 > Vitor Soares wrote: > >> Hi Boris, >> >> Às 3:16 PM de 12/14/2017, Boris Brezillon escreveu: >>> + >>> +enum i3c_addr_slot_stat

Re: [PATCH v2 2/7] i3c: Add core I3C infrastructure

2018-02-27 Thread Vitor Soares
Hi Boris Às 8:36 PM de 2/26/2018, Boris Brezillon escreveu: > Hi Vitor, > > On Mon, 26 Feb 2018 18:58:15 +0000 > Vitor Soares wrote: > >>>>> +/** >>>>> + * i3c_device_do_priv_xfers() - do I3C SDR private transfers directed to >>>>&g

[PATCH v4 0/3] Add driver for Synopsys DesignWare I3C master IP

2018-11-13 Thread Vitor Soares
driver now calls writesl/readsl() instead readl/writel - Rename some variables in the driver Vitor Soares (3): i3c: master: Add driver for Synopsys DesignWare IP dt-binding: i3c: Document Synopsys DesignWare I3C MAINTAINERS: Add myself as the dw-i3c-master module maintainer .../devicetree

[PATCH v4 3/3] MAINTAINERS: Add myself as the dw-i3c-master module maintainer

2018-11-13 Thread Vitor Soares
Signed-off-by: Vitor Soares --- Change in v4: - Change email soa...@synopsys.com to vitor.soa...@synopsys.com Change in v3: - Remove dummy characters Change in v2: - None MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 293c863..39910b3

[PATCH v4 2/3] dt-binding: i3c: Document Synopsys DesignWare I3C

2018-11-13 Thread Vitor Soares
Document Synopsys DesignWare I3C master module Signed-off-by: Vitor Soares Reviewed-by: Rob Herring --- Changes in v4: - Change email soa...@synopsys.com to vitor.soa...@synopsys.com - Add Rob Herring R-b Changes in v3: - Remove dummy characters Changes in v2: - Address the changes in

[PATCH v4 1/3] i3c: master: Add driver for Synopsys DesignWare IP

2018-11-13 Thread Vitor Soares
Add driver for Synopsys DesignWare I3C master IP Signed-off-by: Vitor Soares --- Change in v4: - Change email soa...@synopsys.com to vitor.soa...@synopsys.com Change in v3: - Use struct_size() (suggested by Matthew) Change in v2: - Rename some variables - Remove dw_i3c_master_dev_set_info

[PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-22 Thread Vitor Soares
From: Vitor Soares This patch slipts dw-i3c-master.c into three pieces: dw-i3c-master.c - contains the code that interacts directly with the core in master mode. dw-i3c-platdrv.c - contains the code specific to the platform driver. dw-i3c-core.h - contains the

[PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP

2018-10-29 Thread Vitor soares
Add driver for Synopsys DesignWare I3C master IP Signed-off-by: Vitor soares --- Change in v2: -Rename some variables -Remove dw_i3c_master_dev_set_info() -Ajust code to match the changes made of i3c subsystem -Use readsl/writesl() to populate TX/RX buffers drivers/i3c/master/Kconfig

[PATCH 0/3] Add driver for Synopsys DesignWare I3C master IP

2018-10-29 Thread Vitor soares
for I3C_BUS_MODE_MIXED_SLOW. Hot-join. IBI. Main change between v1 and v2: Add controller version on dt-binding The driver now calls writesl/readsl() instead readl/writel Rename some variables in the driver Vitor soares (3): i3c: master: Add driver for Synopsys DesignWare IP dt

[PATCH 3/3] MAINTAINERS: Add myself as the dw-i3c-master module maintainer

2018-10-29 Thread Vitor soares
Signed-off-by: Vitor soares --- Change in v2: -None MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 293c863..38c2760 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6930,6 +6930,12 @@ F: drivers/i3c/ F: include/linux/i3c/ F

[PATCH 2/3] dt-bindings: i3c: Document Synopsys DesignWare I3C master bindings

2018-10-29 Thread Vitor soares
Document Synopsys DesignWare I3C master module Signed-off-by: Vitor soares --- Changes in v2: -Address the changes in Documentation/devicetree/bindings/i3c/i3c.txt -Add controller version on compatible string .../devicetree/bindings/i3c/snps,dw-i3c-master.txt | 42 ++ 1

[PATCH v3 0/3] Add driver for Synopsys DesignWare I3C master IP

2018-11-08 Thread Vitor soares
in the driver Vitor soares (3): i3c: master: Add driver for Synopsys DesignWare IP dt-bindings: i3c: Document Synopsys DesignWare I3C master bindings MAINTAINERS: Add myself as the dw-i3c-master module maintainer .../devicetree/bindings/i3c/snps,dw-i3c-master.txt | 42 + MAINTAINERS

[PATCH v3 1/3] i3c: master: Add driver for Synopsys DesignWare IP

2018-11-08 Thread Vitor soares
Add driver for Synopsys DesignWare I3C master IP Signed-off-by: Vitor soares --- Change in v3: - Use struct_size() (suggested by Matthew) Change in v2: - Rename some variables - Remove dw_i3c_master_dev_set_info() - Ajust code to match the changes made of i3c subsystem - Use readsl/writesl() to

[PATCH v3 2/3] dt-bindings: i3c: Document Synopsys DesignWare I3C master bindings

2018-11-08 Thread Vitor soares
Document Synopsys DesignWare I3C master module Signed-off-by: Vitor soares --- Changes in v3: - Remove dummy characters Changes in v2: - Address the changes in Documentation/devicetree/bindings/i3c/i3c.txt - Add controller version on compatible string .../devicetree/bindings/i3c/snps,dw-i3c

[PATCH v3 3/3] MAINTAINERS: Add myself as the dw-i3c-master module maintainer

2018-11-08 Thread Vitor soares
Signed-off-by: Vitor soares --- Change in v3: - Remove dummy characters Change in v2: - None MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 293c863..39910b3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6930,6 +6930,12 @@ F: drivers