Re: [PATCH net-next] docs: try to encourage (netdev?) reviewers

2023-10-10 Thread Matthieu Baerts
Hi Jakub, On 10/10/2023 00:56, Jakub Kicinski wrote: > Add a section to netdev maintainer doc encouraging reviewers > to chime in on the mailing list. > > The questions about "when is it okay to share feedback" > keep coming up (most recently at netconf) and the answer > is "pretty much always".

Re: [PATCH net-next] docs: try to encourage (netdev?) reviewers

2023-10-10 Thread Matthieu Baerts
Hi Geert, On 10/10/2023 17:52, Geert Uytterhoeven wrote: > Hi Matt, > > On Tue, Oct 10, 2023 at 5:19 PM Matthieu Baerts wrote: >> On 10/10/2023 00:56, Jakub Kicinski wrote: >>> Add a section to netdev maintainer doc encouraging reviewers >>> to chime in

Re: [RFC Draft net-next] docs: netdev: add section on using lei to manage netdev mail volume

2023-11-07 Thread Matthieu Baerts
Hi David, On 06/11/2023 17:57, David Wei wrote: > On 2023-11-06 03:24, Matthieu Baerts wrote: >> On 05/11/2023 19:50, David Wei wrote: >>> As a beginner to netdev I found the volume of mail to be overwhelming. I >>> only >>> want to focus on core netdev chang

Re: [PATCH net-next v3 3/6] net/tcp: Move tcp_inbound_hash() from headers

2024-06-06 Thread Matthieu Baerts
Hi Dmitry, On 06/06/2024 02:58, Dmitry Safonov via B4 Relay wrote: > From: Dmitry Safonov <0x7f454...@gmail.com> > > Two reasons: > 1. It's grown up enough > 2. In order to not do header spaghetti by including >, which is necessary for TCP tracepoints. > > While at it, unexport and make stat

[PATCH doc] docs: gcov: fix link to LCOV website

2024-09-26 Thread Matthieu Baerts (NGI0)
/https://ltp.sourceforge.net/coverage/lcov.php [1] Link: https://github.com/linux-test-project/lcov/commit/6da8399c7a7a [2] Signed-off-by: Matthieu Baerts (NGI0) --- Documentation/dev-tools/gcov.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/dev-tools

[PATCH net-next 04/12] mptcp: pm: only fill id_avail_bitmap for in-kernel pm

2025-03-13 Thread Matthieu Baerts (NGI0)
From: Geliang Tang id_avail_bitmap of struct mptcp_pm_data is currently only used by the in-kernel PM, so this patch moves its initialization operation under the "if (pm_type == MPTCP_PM_TYPE_KERNEL)" condition. Suggested-by: Matthieu Baerts Signed-off-by: Geliang Tang Reviewed-by

[PATCH net-next 11/12] mptcp: sysctl: add available_path_managers

2025-03-13 Thread Matthieu Baerts (NGI0)
From: Geliang Tang Similarly to net.mptcp.available_schedulers, this patch adds a new one net.mptcp.available_path_managers to list the available path managers. Signed-off-by: Geliang Tang Reviewed-by: Matthieu Baerts (NGI0) Signed-off-by: Matthieu Baerts (NGI0) --- Documentation/networking

[PATCH net-next 00/12] mptcp: pm: prep work for new ops and sysctl knobs

2025-03-13 Thread Matthieu Baerts (NGI0)
ype. - Patch 9: map the new path_manager sysctl knob with pm_type. - Patch 10: map the old pm_type sysctl knob with path_manager. - Patch 11: new net.mptcp.available_path_managers sysctl knob. - Patch 12: new test to validate path_manager and pm_type mapping. Signed-off-by: Matthieu Baerts (N

[PATCH net-next 02/12] mptcp: pm: in-kernel: use kmemdup helper

2025-03-13 Thread Matthieu Baerts (NGI0)
From: Geliang Tang Instead of using kmalloc() or kzalloc() to allocate an entry and then immediately duplicate another entry to the newly allocated one, kmemdup() helper can be used to simplify the code. Signed-off-by: Geliang Tang Reviewed-by: Matthieu Baerts (NGI0) Signed-off-by: Matthieu

[PATCH net-next 03/12] mptcp: pm: use pm variable instead of msk->pm

2025-03-13 Thread Matthieu Baerts (NGI0)
From: Geliang Tang The variable "pm" has been defined in mptcp_pm_fully_established() and mptcp_pm_data_reset() as "msk->pm", so use "pm" directly instead of using "msk->pm". Signed-off-by: Geliang Tang Reviewed-by: Matthieu Baerts (NGI0) Signed-

[PATCH net-next 01/12] mptcp: pm: split netlink and in-kernel init

2025-03-13 Thread Matthieu Baerts (NGI0)
Martineau Signed-off-by: Matthieu Baerts (NGI0) --- net/mptcp/pm.c | 1 + net/mptcp/pm_kernel.c | 5 + net/mptcp/pm_netlink.c | 6 ++ net/mptcp/protocol.h | 1 + 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a/net/mptcp/pm.c b/net/mptcp/pm.c index

[PATCH net-next 05/12] mptcp: pm: add struct_group in mptcp_pm_data

2025-03-13 Thread Matthieu Baerts (NGI0)
From: Geliang Tang This patch adds a "struct_group(reset, ...)" in struct mptcp_pm_data to simplify the reset, and make sure we don't miss any. Suggested-by: Matthieu Baerts Signed-off-by: Geliang Tang Reviewed-by: Matthieu Baerts (NGI0) Signed-off-by: Matthieu Baerts (NGI0)

[PATCH net-next 07/12] mptcp: pm: register in-kernel and userspace PM

2025-03-13 Thread Matthieu Baerts (NGI0)
, and register it in mptcp_pm_init(). To ensure that there's always a valid path manager available, the default path manager "mptcp_pm_kernel" will be skipped in mptcp_pm_unregister(). Signed-off-by: Geliang Tang Reviewed-by: Matthieu Baerts (NGI0) Signed-off-by: Matthieu

[PATCH net-next 08/12] mptcp: sysctl: set path manager by name

2025-03-13 Thread Matthieu Baerts (NGI0)
will be introduced. This sysctl knob makes the old one "pm_type" deprecated. Signed-off-by: Geliang Tang Reviewed-by: Matthieu Baerts (NGI0) Signed-off-by: Matthieu Baerts (NGI0) --- Documentation/networking/mptcp-sysctl.rst | 19 net/mptcp/ctrl.c

[PATCH net-next 06/12] mptcp: pm: define struct mptcp_pm_ops

2025-03-13 Thread Matthieu Baerts (NGI0)
uot;name" to find a path manager on the list. mptcp_pm_unregister is not used in this set, but will be invoked in .unreg of struct bpf_struct_ops. mptcp_pm_validate() will be invoked in .validate of struct bpf_struct_ops. That's why they are exported. Signed-off-by: Geliang Tang Revie

[PATCH net-next 09/12] mptcp: sysctl: map path_manager to pm_type

2025-03-13 Thread Matthieu Baerts (NGI0)
rs -> __MPTCP_PM_TYPE_NR It is important to add this to keep a compatibility with the now deprecated pm_type sysctl knob. Signed-off-by: Geliang Tang Reviewed-by: Matthieu Baerts (NGI0) Signed-off-by: Matthieu Baerts (NGI0) --- net/mptcp/ctrl.c | 15 ++- 1 file changed,

[PATCH net-next 10/12] mptcp: sysctl: map pm_type to path_manager

2025-03-13 Thread Matthieu Baerts (NGI0)
l" MPTCP_PM_TYPE_USERSPACE -> "userspace" It is important to add this to keep a compatibility with the now deprecated pm_type sysctl knob. Signed-off-by: Geliang Tang Reviewed-by: Matthieu Baerts (NGI0) Signed-off-by: Matthieu Baerts (NGI0) --- net/mptcp/ctrl.c |

[PATCH net-next 12/12] selftests: mptcp: add pm sysctl mapping tests

2025-03-13 Thread Matthieu Baerts (NGI0)
From: Geliang Tang This patch checks if the newly added net.mptcp.path_manager is mapped successfully from or to the old net.mptcp.pm_type in userspace_pm.sh. Signed-off-by: Geliang Tang Reviewed-by: Matthieu Baerts (NGI0) Signed-off-by: Matthieu Baerts (NGI0) --- tools/testing/selftests