Re: [PATCH v3] watchdog: nic7018_wdt: Add NIC7018 watchdog driver

2016-12-10 Thread Guenter Roeck
On 12/10/2016 02:25 AM, Hui Chun Ong wrote: Add support for the watchdog timer on PXI Embedded Controller. Signed-off-by: Hui Chun Ong --- v2: Remove mutex lock and platform_device *pdev fields from struct nic7018_wdt. Update config NIC7018_WDT description. Update nic7018_get_config() t

Re: [PATCH v3] watchdog: nic7018_wdt: Add NIC7018 watchdog driver

2016-12-13 Thread Guenter Roeck
On Tue, Dec 13, 2016 at 10:16:23AM +, Hui Chun Ong wrote: > On Sat, 2016-12-10 at 09:22 -0800, Guenter Roeck wrote: > > On 12/10/2016 02:25 AM, Hui Chun Ong wrote: > > > > > > Add support for the watchdog timer on PXI Embedded Controller. > > >

Re: [PATCH v4] watchdog: nic7018_wdt: Add NIC7018 watchdog driver

2016-12-15 Thread Guenter Roeck
Hi, On 12/15/2016 02:05 AM, Hui Chun Ong wrote: Add support for the watchdog timer on PXI Embedded Controller. Signed-off-by: Hui Chun Ong --- v3: Update timeout calculation from miliseconds to seconds. Reorder watchdog_regiser_device() call to prevent potential race condition. v2: Remove

Re: [PATCH v5] watchdog: nic7018_wdt: Add NIC7018 watchdog driver

2016-12-28 Thread Guenter Roeck
On 12/27/2016 11:51 PM, Hui Chun Ong wrote: Add support for the watchdog timer on PXI Embedded Controller. Signed-off-by: Hui Chun Ong Reviewed-by: Guenter Roeck --- v4: Remove nic7018_stop() from nic7018_remove(). Lock WDT registers when watchdog_register_device() call failed. v3

Re: [PATCH v6] watchdog: nic7018_wdt: Add NIC7018 watchdog driver

2016-12-29 Thread Guenter Roeck
On 12/28/2016 10:56 PM, Hui Chun Ong wrote: Add support for the watchdog timer on PXI Embedded Controller. Reviewed-by: Guenter Roeck Signed-off-by: Hui Chun Ong --- v5: Add Reviewed-by. There is no need to re-send a patch just to add a Reviewed-by:. Guenter v4: Remove nic7018_stop

Re: [PATCH linux 2/6] hwmon: occ: Add sysfs interface

2016-12-30 Thread Guenter Roeck
On Fri, Dec 30, 2016 at 11:56:04AM -0600, eajames@gmail.com wrote: > From: "Edward A. James" > > Add a generic mechanism to expose the sensors provided by the OCC in > sysfs. > > Signed-off-by: Edward A. James > Signed-off-by: Andrew Jeffery > Reviewed-by: Andrew Jeffery > --- > Document

Re: Documentation: fix spelling mistakes of "Celcius" -- > "Celsius"

2017-01-02 Thread Guenter Roeck
On Wed, Dec 28, 2016 at 09:51:37PM +, Colin Ian King wrote: > From: Colin Ian King > > Signed-off-by: Colin Ian King Acked-by: Guenter Roeck > --- > Documentation/hwmon/ds1621| 8 > Documentation/thermal/nouveau_thermal | 2 +- > 2 files change

Re: [PATCH v6] watchdog: nic7018_wdt: Add NIC7018 watchdog driver

2017-01-02 Thread Guenter Roeck
On 01/02/2017 07:22 PM, Hui Chun Ong wrote: On Thu, 2016-12-29 at 02:09 -0800, Guenter Roeck wrote: On 12/28/2016 10:56 PM, Hui Chun Ong wrote: Add support for the watchdog timer on PXI Embedded Controller. Reviewed-by: Guenter Roeck Signed-off-by: Hui Chun Ong --- v5: Add Reviewed-by

Re: [PATCH RFC V2 2/6] hwmon: Add support for RPi voltage sensor

2018-05-22 Thread Guenter Roeck
On 05/22/2018 04:21 AM, Stefan Wahren wrote: Currently there is no easy way to detect undervoltage conditions on a remote Raspberry Pi. This hwmon driver retrieves the state of the undervoltage sensor via mailbox interface. The handling based on Noralf's modifications to the downstream firmware d

Re: [PATCH RFC V2 2/6] hwmon: Add support for RPi voltage sensor

2018-05-22 Thread Guenter Roeck
On 05/22/2018 06:51 AM, Stefan Wahren wrote: Hi Guenter, Guenter Roeck hat am 22. Mai 2018 um 15:41 geschrieben: On 05/22/2018 04:21 AM, Stefan Wahren wrote: Currently there is no easy way to detect undervoltage conditions on a remote Raspberry Pi. This hwmon driver retrieves the state of

Re: [PATCH RFC V2 2/6] hwmon: Add support for RPi voltage sensor

2018-05-23 Thread Guenter Roeck
On Wed, May 23, 2018 at 01:12:10PM +0100, Robin Murphy wrote: > On 22/05/18 20:31, Stefan Wahren wrote: > [...] > >+static int rpi_hwmon_probe(struct platform_device *pdev) > >+{ > >+struct device *dev = &pdev->dev; > >+struct rpi_hwmon_data *data; > >+in

Re: [PATCH V3 2/6] hwmon: Add support for RPi voltage sensor

2018-05-25 Thread Guenter Roeck
modifications to the downstream firmware driver. In case of > an undervoltage condition only an entry is written to the kernel log. > > CC: "Noralf Trønnes" > Signed-off-by: Stefan Wahren Acked-by: Guenter Roeck ... assuming this will go through some arm tree. > --

Re: [PATCH v3 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-22 Thread Guenter Roeck
Hi, On 09/21/2018 03:32 PM, Nicolin Chen wrote: Texas Instruments INA3221 is a triple-channel shunt and bus voltage monitor. This patch adds a DT binding doc for it. Signed-off-by: Nicolin Chen --- Changelog v2->v3: * Added a simple subject in the line 1 * Fixed the shunt resistor value in

Re: [PATCH v3 2/2] hwmon: ina3221: Read channel input source info from DT

2018-09-22 Thread Guenter Roeck
Hi, On 09/21/2018 03:32 PM, Nicolin Chen wrote: From: Nicolin Chen An ina3221 chip has three input ports. Each port is used to measure the voltage and current of its input source. The DT binding now has defined bindings for their input sources, so the driver should read these information and

Re: [PATCH v3 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-22 Thread Guenter Roeck
On 09/22/2018 11:03 AM, Nicolin Chen wrote: +2) child nodes + The names of child nodes should indicate input source names + + Required properties: + - input-id: Must be 1, 2 or 3 + + Optional properties: + - shunt-resistor: Shunt resistor value in micro-Ohm + - status: Should be "disabled"

Re: [PATCH v3 2/2] hwmon: ina3221: Read channel input source info from DT

2018-09-22 Thread Guenter Roeck
On 09/22/2018 11:46 AM, Nicolin Chen wrote: This patch adds a new structure of input source specific information including input source label, shunt resistor value and its connection status. It exposes these labels via sysfs and also disables those channels where there's no input source being con

Re: [PATCH v3 2/2] hwmon: ina3221: Read channel input source info from DT

2018-09-22 Thread Guenter Roeck
On 09/22/2018 05:38 PM, Nicolin Chen wrote: On Sat, Sep 22, 2018 at 04:59:55PM -0700, Guenter Roeck wrote: + /* Disable channels if their inputs are disconnected */ + for (i = 0, mask = 0; i < INA3221_NUM_CHANNELS; i++) { + if (ina->inputs[i].discon

Re: [PATCH v4 2/2] hwmon: ina3221: Read channel input source info from DT

2018-09-22 Thread Guenter Roeck
On 09/22/2018 09:11 PM, Nicolin Chen wrote: An ina3221 chip has three input ports. Each port is used to measure the voltage and current of its input source. The DT binding now has defined bindings for their input sources, so the driver should read these information and handle accordingly. This

Re: [PATCH v4 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-22 Thread Guenter Roeck
On 09/22/2018 09:11 PM, Nicolin Chen wrote: Texas Instruments INA3221 is a triple-channel shunt and bus voltage monitor. This patch adds a DT binding doc for it. Signed-off-by: Nicolin Chen --- Changelog v3->v4: * Removed the attempt of putting labels in the node names * Added a new optiona

Re: [PATCH v3 2/2] hwmon: ina3221: Read channel input source info from DT

2018-09-22 Thread Guenter Roeck
On 09/22/2018 08:33 PM, Nicolin Chen wrote: No. If the chip was configured by the BIOS/ROMMON, it is supposed to be that way. We can not just override that. For this driver, it does soft reset in the probe() so we're sure that all channels are enabled at the moment of calling this regmap_updat

Re: [PATCH v4 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-22 Thread Guenter Roeck
On 09/22/2018 10:31 PM, Nicolin Chen wrote: On Sat, Sep 22, 2018 at 10:19:42PM -0700, Guenter Roeck wrote: +2) child nodes + Required properties: + - input-id: Must be 1, 2 or 3 + + Optional properties: + - input-label: Name of the input source + - shunt-resistor: Shunt resistor value in

Re: [PATCH v4 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-22 Thread Guenter Roeck
On 09/22/2018 11:01 PM, Nicolin Chen wrote: On Sat, Sep 22, 2018 at 10:45:49PM -0700, Guenter Roeck wrote: On 09/22/2018 10:31 PM, Nicolin Chen wrote: On Sat, Sep 22, 2018 at 10:19:42PM -0700, Guenter Roeck wrote: +2) child nodes + Required properties: + - input-id: Must be 1, 2 or 3

Re: [PATCH v5 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-25 Thread Guenter Roeck
Hi Nicolin, On 09/25/2018 03:59 PM, Nicolin Chen wrote: Texas Instruments INA3221 is a triple-channel shunt and bus voltage monitor. This patch adds a DT binding doc for it. Signed-off-by: Nicolin Chen --- Changelog v4->v5: * Replaced "input-id" with "reg" and added address-cells and size-ce

Re: [PATCH v5 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-09-25 Thread Guenter Roeck
On 09/25/2018 08:08 PM, Nicolin Chen wrote: Hello Guenter, On Tue, Sep 25, 2018 at 06:52:29PM -0700, Guenter Roeck wrote: +2) child nodes + Required properties: + - reg: Must be 0, 1 or 2, corresponding to IN1, IN2 or IN3 port of INA3221 + + Optional properties: + - label: Name of the

Re: [PATCH 1/2] hwmon: ina3221: Add power sysfs nodes

2018-09-26 Thread Guenter Roeck
Hi Nicolin, On 09/25/2018 11:42 PM, Nicolin Chen wrote: The hwmon sysfs ABI supports powerX_input and powerX_crit. This can ease user space programs who care more about power in total than voltage or current individually. So this patch adds these two sysfs nodes for INA3221 driver. Ah, sorry

Re: [PATCH 2/2] hwmon: ina3221: Add enable sysfs nodes

2018-09-26 Thread Guenter Roeck
Hi Nicolin, On 09/25/2018 11:42 PM, Nicolin Chen wrote: The inX_enable interface allows user space to enable or disable the corresponding channel. Meanwhile, according to hwmon ABI, a disabled channel/sensor should return -ENODATA as a read result. However, there're configurable nodes sharing t

Re: [PATCH 1/2] hwmon: ina3221: Add power sysfs nodes

2018-09-26 Thread Guenter Roeck
Hi Nicolin, On Wed, Sep 26, 2018 at 11:20:06AM -0700, Nicolin Chen wrote: > On Wed, Sep 26, 2018 at 05:34:53AM -0700, Guenter Roeck wrote: > > Hi Nicolin, > > > > On 09/25/2018 11:42 PM, Nicolin Chen wrote: > > > The hwmon sysfs ABI supports powerX_input and powerX_

Re: [PATCH 2/2] hwmon: ina3221: Add enable sysfs nodes

2018-09-26 Thread Guenter Roeck
Nicolin, On Wed, Sep 26, 2018 at 11:02:44AM -0700, Nicolin Chen wrote: > On Wed, Sep 26, 2018 at 06:06:32AM -0700, Guenter Roeck wrote: > > On 09/25/2018 11:42 PM, Nicolin Chen wrote: > > > The inX_enable interface allows user space to enable or disable > > > the corre

Re: [PATCH 2/2] hwmon: ina3221: Add enable sysfs nodes

2018-09-26 Thread Guenter Roeck
On Wed, Sep 26, 2018 at 01:25:20PM -0700, Nicolin Chen wrote: > Hello, > > On Wed, Sep 26, 2018 at 12:58:17PM -0700, Guenter Roeck wrote: > > On Wed, Sep 26, 2018 at 11:02:44AM -0700, Nicolin Chen wrote: > > > On Wed, Sep 26, 2018 at 06:06:32AM -0700, Guenter Roeck wrote:

Re: [PATCH 2/2] hwmon: ina3221: Add enable sysfs nodes

2018-09-27 Thread Guenter Roeck
Hi Nicolin, On Wed, Sep 26, 2018 at 02:55:06PM -0700, Nicolin Chen wrote: > On Wed, Sep 26, 2018 at 01:44:55PM -0700, Guenter Roeck wrote: > > On Wed, Sep 26, 2018 at 01:25:20PM -0700, Nicolin Chen wrote: > > > Hello, > > > > > > On Wed, Sep 26, 2018 at 1

Re: [PATCH v7 2/2] hwmon: ina3221: Read channel input source info from DT

2018-09-27 Thread Guenter Roeck
On Thu, Sep 27, 2018 at 01:54:06PM -0700, Nicolin Chen wrote: > An ina3221 chip has three input ports. Each port is used > to measure the voltage and current of its input source. > > The DT binding now has defined bindings for their input > sources, so the driver should read these information and

Re: [PATCH 2/2] hwmon: ina3221: Add enable sysfs nodes

2018-09-27 Thread Guenter Roeck
On Thu, Sep 27, 2018 at 03:26:14PM -0700, Nicolin Chen wrote: > On Wed, Sep 26, 2018 at 06:06:32AM -0700, Guenter Roeck wrote: > > > +static inline bool ina3221_is_enable(struct ina3221_data *ina, int > > > channel) > > > > s/is_enable/is_enabled/, maybe ? >

Re: [PATCH v8 2/2] hwmon: ina3221: Read channel input source info from DT

2018-09-30 Thread Guenter Roeck
Hi Nicolin, On 09/28/2018 06:39 PM, Nicolin Chen wrote: An ina3221 chip has three input ports. Each port is used to measure the voltage and current of its input source. The DT binding now has defined bindings for their input sources, so the driver should read these information and handle accord

Re: [PATCH v9 1/2] dt-bindings: hwmon: Add ina3221 documentation

2018-10-02 Thread Guenter Roeck
Hi Nicolin, On Mon, Oct 01, 2018 at 06:05:22PM -0700, Nicolin Chen wrote: > Texas Instruments INA3221 is a triple-channel shunt and bus > voltage monitor. This patch adds a DT binding doc for it. > > Signed-off-by: Nicolin Chen > --- This version of the series looks good to me. I'll add both pa

Re: [PATCH 1/2] hwmon: (core) Add hwmon_mode structure and mode sysfs node

2018-10-10 Thread Guenter Roeck
Hi Nicolin, On 10/09/2018 09:33 PM, Nicolin Chen wrote: There are a few hwmon sensors support different operating modes, for example, one-shot and continuous modes. So it's probably not a bad idea to abstract a mode sysfs node as a common feature in the hwmon core. Right beside the hwmon device

Re: [PATCH 2/2] hwmon: (ina3221) Add operating mode support

2018-10-10 Thread Guenter Roeck
Hi Nicolin, On 10/09/2018 09:33 PM, Nicolin Chen wrote: The hwmon core now has a new optional mode interface. So this patch just implements this mode support so that user space can check and configure via sysfs node its operating modes: power-down, one-shot, and continuous modes. One-shot mod

Re: [PATCH 1/2] hwmon: (core) Add hwmon_mode structure and mode sysfs node

2018-10-10 Thread Guenter Roeck
Hi Nicolin, On Wed, Oct 10, 2018 at 02:13:57PM -0700, Nicolin Chen wrote: > Hi Guenter, > > On Wed, Oct 10, 2018 at 06:08:30AM -0700, Guenter Roeck wrote: > > > +available_modes The available operating modes of the chip. > > > + This should be short, lower

Re: [PATCH 2/2] hwmon: (ina3221) Add operating mode support

2018-10-10 Thread Guenter Roeck
Hi Nicolin, On Wed, Oct 10, 2018 at 04:09:07PM -0700, Nicolin Chen wrote: > Hello Guenter, > > On Wed, Oct 10, 2018 at 06:22:39AM -0700, Guenter Roeck wrote: > > > > The hwmon core now has a new optional mode interface. So this patch > > > just implements this m

Re: [PATCH 2/2] hwmon: (ina3221) Add operating mode support

2018-10-11 Thread Guenter Roeck
On Wed, Oct 10, 2018 at 05:24:12PM -0700, Nicolin Chen wrote: > Hi Guenter, > > On Wed, Oct 10, 2018 at 04:43:00PM -0700, Guenter Roeck wrote: > > > > The effort to do all this using CPU cycles would in most if not all > > > > cases > > > > outweigh

Re: [PATCH 2/2] hwmon: (ina3221) Add operating mode support

2018-10-11 Thread Guenter Roeck
Hi Nicolin, On Thu, Oct 11, 2018 at 12:36:59PM -0700, Nicolin Chen wrote: > On Thu, Oct 11, 2018 at 12:31:52PM -0700, Guenter Roeck wrote: > > > > One more question here, and this might sound a bit abuse of using > > > the existing hwmon ABI: would it sound plausible to y

Re: [PATCH v5 01/10] dt-bindings: fsi: Add P9 OCC device documentation

2018-10-12 Thread Guenter Roeck
On Wed, Sep 12, 2018 at 09:56:33AM +0200, Benjamin Herrenschmidt wrote: > On Mon, 2018-09-10 at 13:16 -0500, Rob Herring wrote: > > On Thu, Aug 30, 2018 at 04:32:32PM -0500, Eddie James wrote: > > > Document the bindings for the FSI-attached POWER9 On-Chip Controller. > > > > > > Signed-off-by: Ed

Re: [PATCH v5 05/10] hwmon: Add On-Chip Controller (OCC) hwmon driver

2018-10-12 Thread Guenter Roeck
On Sat, Sep 01, 2018 at 08:06:16PM +0800, kbuild test robot wrote: > Hi Eddie, > > I love your patch! Yet something to improve: > > [auto build test ERROR on hwmon/hwmon-next] > [also build test ERROR on v4.19-rc1 next-20180831] > [if your patch is applied to the wrong git tree, please drop us a

Re: [PATCH] hwmon: (adt7475) document mapping of sysfs entries to inputs

2018-10-30 Thread Guenter Roeck
On 10/30/18 1:25 PM, Chris Packham wrote: As per the usual standard with hwmon drivers the mapping to sysfs entries follows the register map of the device e.g. in0_input corresponds to the register 0x20, in1_input corresponds to 0x21 etc. Hardware designers tend to work with input pins instead o

Re: [PATCH v12 4/4] Watchdog: introduce ARM SBSA watchdog driver

2016-02-16 Thread Guenter Roeck
On 02/16/2016 12:36 AM, fu@linaro.org wrote: From: Fu Wei According to Server Base System Architecture (SBSA) specification, the SBSA Generic Watchdog has two stage timeouts: the first signal (WS0) is for alerting the system by interrupt, the second one (WS1) is a real hardware reset. More

Re: [PATCH v12 2/4] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts

2016-02-16 Thread Guenter Roeck
On 02/16/2016 12:36 AM, fu@linaro.org wrote: From: Fu Wei This can be a example of adding SBSA Generic Watchdog device node into some dts files for the Soc which contains SBSA Generic Watchdog. Acked-by: Arnd Bergmann Signed-off-by: Fu Wei Reviewed-by: Guenter Roeck --- arch

Re: [PATCH v12 1/4] Documentation: add sbsa-gwdt driver documentation

2016-02-16 Thread Guenter Roeck
-by: Arnd Bergmann Acked-by: Rob Herring Signed-off-by: Fu Wei Reviewed-by: Guenter Roeck --- .../devicetree/bindings/watchdog/sbsa-gwdt.txt | 31 ++ Documentation/watchdog/watchdog-parameters.txt | 7 + 2 files changed, 38 insertions(+) diff --git a

Re: [PATCH v12 3/4] ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi

2016-02-16 Thread Guenter Roeck
Reviewed-by: Guenter Roeck --- arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi b/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi index 2874d92..0a8ca1d 100644 --- a/arch/arm64/boot/dts/amd/amd-seattle

Re: [PATCH v12 4/4] Watchdog: introduce ARM SBSA watchdog driver

2016-02-16 Thread Guenter Roeck
On Wed, Feb 17, 2016 at 12:33:24AM +0800, Fu Wei wrote: [ ... ] > >>> +MODULE_AUTHOR("Fu Wei "); > >>> +MODULE_AUTHOR("Suravee Suthikulpanit "); > >>> +MODULE_AUTHOR("Al Stone "); > >>> +MODULE_AUTHOR("Timur Tabi "); > >>> +MODULE_LICENSE("GPL v2"); > >>> > >> Do you need a MODULE_ALIAS ? > > > > F

Re: [PATCH v13 4/4] Watchdog: introduce ARM SBSA watchdog driver

2016-02-16 Thread Guenter Roeck
out from module parameter and FDT at the driver init stage. Signed-off-by: Fu Wei Reviewed-by: Graeme Gregory Tested-by: Pratyush Anand Acked-by: Timur Tabi Reviewed-by: Mathieu Poirier Tested-by: Suravee Suthikulpanit Reviewed-by: Guenter Roeck -- To unsubscribe from this list: send the li

Re: [PATCH] [linux-next] Doc: hwmon: Fix typo "montoring" in hwmon

2016-02-27 Thread Guenter Roeck
On 02/27/2016 07:57 PM, Masanari Iida wrote: This patch fix typos found in files within Documentation/hwmon. Signed-off-by: Masanari Iida Applied, thanks! Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org Mo

Re: [PATCH v7 1/9] watchdog: Introduce hardware maximum timeout in watchdog core

2016-02-28 Thread Guenter Roeck
UNNING flag * and a patch that makes the stop function optional. Ok. Done all and pushed into the watchdog-timer branch of my repository on kernel.org. I'll do some more testing, wait for results from 0day, and then resubmit the series. Thanks, Guenter Thanks in advance, Wim. From

[PATCH v8 0/10] watchdog: Add support for keepalives triggered by infrastructure

2016-02-28 Thread Guenter Roeck
The watchdog infrastructure is currently purely passive, meaning it only passes information from user space to drivers and vice versa. Since watchdog hardware tends to have its own quirks, this can result in quite complex watchdog drivers. A number of scanarios are especially common. - A watchdog

[RFC PATCH v8 08/10] watchdog: retu: Convert to use infrastructure triggered keepalives

2016-02-28 Thread Guenter Roeck
The watchdog infrastructure now supports handling watchdog keepalive if the watchdog is running while the watchdog device is closed. Convert the driver to use this infrastructure. Signed-off-by: Guenter Roeck --- v8: max_hw_timeout_ms -> max_hw_heartbeat_ms Rebased to v4.5-rc5 v7:

[RFC PATCH v8 10/10] watchdog: gpio: Convert to use infrastructure triggered keepalives

2016-02-28 Thread Guenter Roeck
driver to use this infrastructure. Signed-off-by: Guenter Roeck --- v8: Added patch to series --- drivers/watchdog/gpio_wdt.c | 73 - 1 file changed, 13 insertions(+), 60 deletions(-) diff --git a/drivers/watchdog/gpio_wdt.c b/drivers/watchdog

[PATCH v8 05/10] watchdog: Add support for minimum time between heartbeats

2016-02-28 Thread Guenter Roeck
Some watchdogs require a minimum time between heartbeats. Examples are the watchdogs in DA9062 and AT91SAM9x. Signed-off-by: Guenter Roeck --- v8: Rebased to v4.5-rc5 v7: Rebased to v4.5-rc1 v6: Rebased to v4.4-rc2 v5: Rebased to v4.4-rc1 Fixed typo in documentation. v4: Added patch

[PATCH v8 06/10] watchdog: dw_wdt: Convert to use watchdog infrastructure

2016-02-28 Thread Guenter Roeck
Convert driver to use watchdog infrastructure. This includes infrastructure support to handle watchdog keepalive if the watchdog is running while the watchdog device is closed. Signed-off-by: Guenter Roeck --- v8: max_hw_timeout_ms -> max_hw_heartbeat_ms Rebased to v4.5-rc5 v7:

[RFC PATCH v8 09/10] watchdog: at91sam9: Convert to use infrastructure triggered keepalives

2016-02-28 Thread Guenter Roeck
driver to use this infrastructure. Signed-off-by: Guenter Roeck --- v8: max_hw_timeout_ms -> max_hw_heartbeat_ms Rebased to v4.5-rc5 v7: Rebased to v4.5-rc1 v6: Rebased to v4.4-rc2 v5: Rebased to v4.4-rc1 v4: No changes v3: No changes v2: No changes --- drivers/watchdog/at91sam9_wdt.c |

[PATCH v8 07/10] watchdog: imx2: Convert to use infrastructure triggered keepalives

2016-02-28 Thread Guenter Roeck
The watchdog infrastructure now supports handling watchdog keepalive if the watchdog is running while the watchdog device is closed. Convert the driver to use this infrastructure. Signed-off-by: Guenter Roeck --- v8: max_hw_timeout_ms -> max_hw_heartbeat_ms Rebased to v4.5-rc5 v7:

[PATCH v8 02/10] watchdog: Introduce hardware maximum heartbeat in watchdog core

2016-02-28 Thread Guenter Roeck
watchdog core enables a timer function to assist sending keepalive requests to the watchdog driver. Signed-off-by: Guenter Roeck --- v8: - Rebased to v4.5-rc5 - Now second patch of series - max_hw_timeout_ms -> max_hw_heartbeat_ms - Merged 'watchdog: Simplify update_worker' into

[PATCH v8 04/10] watchdog: Make stop function optional

2016-02-28 Thread Guenter Roeck
Not all hardware watchdogs can be stopped. The driver for such watchdogs would typically only set the WATCHDOG_HW_RUNNING flag in its stop function. Make the stop function optional and set WATCHDOG_HW_RUNNING in the watchdog core if it is not provided. Signed-off-by: Guenter Roeck --- v8: Split

[PATCH v8 01/10] watchdog: Make set_timeout function optional

2016-02-28 Thread Guenter Roeck
k optional. If WDIOF_SETTIMEOUT is configured but the .set_timeout callback is not available, update the timeout variable in the infrastructure code. Signed-off-by: Guenter Roeck --- v8: Moved to be first patch of series Rebased to v4.5-rc5 v7: Rebased to v4.5-rc1 v6: Rebased to v4.4-rc2 v5:

[PATCH v8 03/10] watchdog: Introduce WDOG_HW_RUNNING flag

2016-02-28 Thread Guenter Roeck
not be stopped. If stopping the watchdog is not possible but the driver implements a stop function, it is responsible to set the WDOG_HW_RUNNING flag in its stop function. Signed-off-by: Guenter Roeck --- v8: Rebased to v4.5-rc5 max_hw_timeout_ms -> max_hw_heartbeat_ms Split out mak

Re: [PATCH] hwmon: (ntc_thermistor) Add support for ncpXXxh103

2016-02-28 Thread Guenter Roeck
On 02/28/2016 02:31 PM, Joseph wrote: From: Joseph McNally This patch adds support for the Murata NCP15XH103 thermistor series. Signed-off-by: Joseph McNally Applied. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord

Re: [PATCH v8 06/10] watchdog: dw_wdt: Convert to use watchdog infrastructure

2016-03-02 Thread Guenter Roeck
On Tue, Mar 01, 2016 at 02:59:06PM -0800, Doug Anderson wrote: > Guenter, > > On Sun, Feb 28, 2016 at 1:12 PM, Guenter Roeck wrote: > > Convert driver to use watchdog infrastructure. This includes > > infrastructure support to handle watchdog keepalive if the watchdog >

Re: [PATCH v8 0/10] watchdog: Add support for keepalives triggered by infrastructure

2016-03-06 Thread Guenter Roeck
Hi Wim, any chance to get this series into the next release ? Thanks, Guenter On 02/28/2016 01:12 PM, Guenter Roeck wrote: The watchdog infrastructure is currently purely passive, meaning it only passes information from user space to drivers and vice versa. Since watchdog hardware tends to

Re: [PATCH v8 0/10] watchdog: Add support for keepalives triggered by infrastructure

2016-03-07 Thread Guenter Roeck
Hi Wim, On Sun, Mar 06, 2016 at 11:49:56AM +0100, Wim Van Sebroeck wrote: > Hi Guenter, > > > The watchdog infrastructure is currently purely passive, meaning > > it only passes information from user space to drivers and vice versa. > > [ ... ] > > Patches 1 till 7 of this series has been added

Re: [PATCH v8 0/10] watchdog: Add support for keepalives triggered by infrastructure

2016-03-07 Thread Guenter Roeck
On Mon, Mar 07, 2016 at 07:50:23PM +0100, Wim Van Sebroeck wrote: > Hi Guenter, > > > Hi Wim, > > > > On Sun, Mar 06, 2016 at 11:49:56AM +0100, Wim Van Sebroeck wrote: > > > Hi Guenter, > > > > > > > The watchdog infrastructure is currently purely passive, meaning > > > > it only passes informat

Re: [PATCH 1/1] hwmon: add support for Sensirion SHT3x sensors

2016-03-10 Thread Guenter Roeck
On Thu, Mar 10, 2016 at 02:56:43PM +, Pascal Sachs wrote: > From: David Frey > > This driver implements support for the Sensirion SHT3x-DIS chip, > a humidity and temperature sensor. Temperature is measured > in degrees Celsius, relative humidity is expressed as a percentage. > In the sysfs i

Re: [PATCH 1/1] hwmon: add support for Sensirion SHT3x sensors

2016-03-14 Thread Guenter Roeck
Hi Pascal, On Mon, Mar 14, 2016 at 03:28:52PM +, Pascal Sachs wrote: > Hi Guenter > > Thank you for the fast code review. > During extended testing of the updated driver we found some other minor > issues with the alert feature we would like to fix before submitting again. > Take your time

Re: [PATCH v5 1/4] i2c: add a protocol parameter to the alert callback

2016-03-15 Thread Guenter Roeck
On Tue, Mar 15, 2016 at 03:53:41PM +0100, Benjamin Tissoires wrote: > .alert() is meant to be generic, but there is currently no way > for the device driver to know which protocol generated the alert. > Add a parameter in .alert() to help the device driver to understand > what is given in data. >

Re: [PATCH v6 1/4] i2c: add a protocol parameter to the alert callback

2016-03-18 Thread Guenter Roeck
iven in data. > > This patch is required to have the support of SMBus Host Notify protocol > through .alert(). > > Signed-off-by: Benjamin Tissoires For hwmon: Acked-by: Guenter Roeck > --- > > new in v2 > > changes in v3: > - added also lm90.c to support the

Re: [PATCH v14 3/4] ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi

2016-03-28 Thread Guenter Roeck
On 29 February 2016 at 16:46, wrote: From: Fu Wei This can be a example of adding SBSA Generic Watchdog device node into some dts files for the Soc which contains SBSA Generic Watchdog. Acked-by: Arnd Bergmann Signed-off-by: Suravee Suthikulpanit Signed-off-by: Fu Wei Reviewed-by: Guenter

Re: [PATCH v5 08/46] hwmon: pwm-fan: use pwm_get_args() where appropriate

2016-03-30 Thread Guenter Roeck
On Wed, Mar 30, 2016 at 10:03:31PM +0200, Boris Brezillon wrote: > The PWM framework has clarified the concept of reference PWM config > (the platform dependent config retrieved from the DT or the PWM > lookup table) and real PWM state. > > Use pwm_get_args() when the PWM user wants to retrieve th

Re: [PATCH 1/1] hwmon: Add support for INA3221 Triple Current/Voltage Monitors

2016-04-19 Thread Guenter Roeck
On 04/11/2016 01:50 PM, Andrew F. Davis wrote: Add support for the the INA3221 26v capable, Triple channel, Bi-Directional, Zero-Drift, Low-/High-Side, Current/Voltage Monitor with I2C interface. Signed-off-by: Andrew F. Davis --- Documentation/hwmon/ina3221 | 32 drivers/hwmon/Kconfig

Re: [PATCH v2 2/2] hwmon: Add support for INA3221 Triple Current/Voltage Monitors

2016-04-23 Thread Guenter Roeck
On 04/19/2016 11:28 AM, Andrew F. Davis wrote: Add support for the the INA3221 26v capable, Triple channel, Bi-Directional, Zero-Drift, Low-/High-Side, Current/Voltage Monitor with I2C interface. Signed-off-by: Andrew F. Davis --- Documentation/hwmon/ina3221 | 35 drivers/hwmon/Kconfig

Re: [PATCH 1/1 v2] hwmon: add support for Sensirion SHT3x sensors

2016-05-14 Thread Guenter Roeck
On 04/25/2016 01:42 AM, Pascal Sachs wrote: From: David Frey This driver implements support for the Sensirion SHT3x-DIS chip, a humidity and temperature sensor. Temperature is measured in degrees celsius, relative humidity is expressed as a percentage. In the sysfs interface, all values are sca

Re: [PATCH v3 2/2] hwmon: Add support for INA3221 Triple Current/Voltage Monitors

2016-05-15 Thread Guenter Roeck
On 04/25/2016 12:39 PM, Andrew F. Davis wrote: Add support for the the INA3221 26v capable, Triple channel, Bi-Directional, Zero-Drift, Low-/High-Side, Current/Voltage Monitor with I2C interface. Signed-off-by: Andrew F. Davis --- Documentation/hwmon/ina3221 | 35 drivers/hwmon/Kconfig

Re: [PATCH 1/1 v2] hwmon: add support for Sensirion SHT3x sensors

2016-05-17 Thread Guenter Roeck
Hi Pascal, On 05/17/2016 06:18 AM, Pascal Sachs wrote: [ ... ] +While in periodic measure mode, read out of humidity and temperature values are +not supported. Nevertheless it is possible to read out the values with maximal Really ? I seem to be missing this in the datasheet. Section 4.4 s

Re: [PATCH 0041/1529] Fix typo

2016-05-22 Thread Guenter Roeck
On 05/21/2016 04:41 AM, Andrea Gelmini wrote: Signed-off-by: Andrea Gelmini Applied, with updated subject line. Guenter --- Documentation/hwmon/max1668 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/hwmon/max1668 b/Documentation/hwmon/max1668 index 0616

Re: [PATCH 0040/1529] Fix typo

2016-05-22 Thread Guenter Roeck
On 05/21/2016 04:41 AM, Andrea Gelmini wrote: Signed-off-by: Andrea Gelmini Applied, but please use a more descriptive subject line the next time. It should include the affected subsystem and driver. Thanks, Guenter --- Documentation/hwmon/abituguru | 2 +- 1 file changed, 1 insertion(+)

Re: [PATCH 1/1 v3] hwmon: add support for Sensirion SHT3x sensors

2016-05-29 Thread Guenter Roeck
On 05/26/2016 12:25 AM, Pascal Sachs wrote: From: David Frey This driver implements support for the Sensirion SHT3x-DIS chip, a humidity and temperature sensor. Temperature is measured in degrees celsius, relative humidity is expressed as a percentage. In the sysfs interface, all values are sca

Re: [PATCH 1/1 v3] hwmon: add support for Sensirion SHT3x sensors

2016-05-29 Thread Guenter Roeck
On 05/26/2016 12:25 AM, Pascal Sachs wrote: From: David Frey This driver implements support for the Sensirion SHT3x-DIS chip, a humidity and temperature sensor. Temperature is measured in degrees celsius, relative humidity is expressed as a percentage. In the sysfs interface, all values are sca

Re: [2/3] hwmon: xgene: Adds hwmon driver

2016-05-29 Thread Guenter Roeck
On Mon, May 16, 2016 at 09:17:26AM -0700, hotran wrote: > This patch adds hardware temperature and power reading support for > APM X-Gene SoC's using the mailbox communication interface. > Please drop the "'". > > Signed-off-by: Hoan Tran > --- > Documentation/hwmon/xgene-hwmon | 32 ++ > dri

Re: [PATCH 1/1 v4] hwmon: add support for Sensirion SHT3x sensors

2016-05-30 Thread Guenter Roeck
Hi Pascal, On 05/30/2016 07:46 AM, Pascal Sachs wrote: From: David Frey This driver implements support for the Sensirion SHT3x-DIS chip, a humidity and temperature sensor. Temperature is measured in degrees celsius, relative humidity is expressed as a percentage. In the sysfs interface, all va

Re: [PATCH 1/1 v4] hwmon: add support for Sensirion SHT3x sensors

2016-05-31 Thread Guenter Roeck
On Tue, May 31, 2016 at 09:08:27AM +0200, Pascal Sachs wrote: > Hi Guenter > > I want to thank you again for the fast and detailed code review. > I really appreciate it. > Sorry it took so long. [ ... ] > >>+static struct sht3x_data *sht3x_update_client(struct device *dev) > >>+{ > >>+stru

Re: [2/3] hwmon: xgene: Adds hwmon driver

2016-06-01 Thread Guenter Roeck
On Tue, May 31, 2016 at 11:00:05PM -0700, Hoan Tran wrote: > Hi Guenter, > > > > > Overall, I have to say that the code is quite complex due to the repeated > > checks for ACPI. I am close to suggest having two separate drivers, > > one for ACPI and one for non-ACPI. Any chance to separate ACPI vs

Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-03 Thread Guenter Roeck
On 06/03/2016 03:06 AM, Jonathan Cameron wrote: On 01/06/16 13:34, Laxman Dewangan wrote: The INA3221 is a three-channel, high-side current and bus voltage monitor with an I2C interface from Texas Instruments. The INA3221 monitors both shunt voltage drops and bus supply voltages in addition to h

Re: [PATCH 1/1 v6] hwmon: add support for Sensirion SHT3x sensors

2016-06-03 Thread Guenter Roeck
On 06/02/2016 12:59 AM, Pascal Sachs wrote: From: David Frey This driver implements support for the Sensirion SHT3x-DIS chip, a humidity and temperature sensor. Temperature is measured in degrees celsius, relative humidity is expressed as a percentage. In the sysfs interface, all values are sca

Re: [PATCH] hwmon: (tmp401) Add support for TI TMP461

2016-06-03 Thread Guenter Roeck
On 05/31/2016 09:27 AM, Andrew F. Davis wrote: Signed-off-by: Andrew F. Davis --- Documentation/hwmon/tmp401 | 18 +-- drivers/hwmon/Kconfig | 2 +- drivers/hwmon/tmp401.c | 81 ++ 3 files changed, 92 insertions(+), 9 deletions(-

Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-07 Thread Guenter Roeck
On Fri, Jun 03, 2016 at 10:17:55AM -0500, Andrew F. Davis wrote: > On 06/03/2016 09:14 AM, Laxman Dewangan wrote: > > > > On Friday 03 June 2016 06:59 PM, Guenter Roeck wrote: > >> On 06/03/2016 03:06 AM, Jonathan Cameron wrote: > >>> On 01/06/16 13:34, Laxma

Re: [PATCH] hwmon: (tmp401) Add support for TI TMP461

2016-06-08 Thread Guenter Roeck
On Wed, Jun 08, 2016 at 11:56:29AM -0500, Andrew F. Davis wrote: [ ... ] > >> static const u8 TMP432_TEMP_MSB_READ[4][3] = { > >> @@ -149,6 +156,7 @@ static const struct i2c_device_id tmp401_id[] = { > >> { "tmp431", tmp431 }, > >> { "tmp432", tmp432 }, > >> { "tmp435", tmp435

Re: [PATCH v2 1/1] hwmon: (tmp401) Add support for TI TMP461

2016-06-08 Thread Guenter Roeck
On Wed, Jun 08, 2016 at 12:00:54PM -0500, Andrew F. Davis wrote: > Signed-off-by: Andrew F. Davis Applied to hwmon-next. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vg

Re: [PATCH v5 1/1] hwmon: Add support for INA3221 Triple Current/Voltage Monitors

2016-06-10 Thread Guenter Roeck
On Fri, Jun 10, 2016 at 10:32:33AM -0500, Andrew F. Davis wrote: > Add support for the the INA3221 26v capable, Triple channel, > Bi-Directional, Zero-Drift, Low-/High-Side, Current/Voltage Monitor > with I2C interface. > > Signed-off-by: Andrew F. Davis Applied to -next. Can you by any chance

Re: [PATCH v5 1/1] hwmon: Add support for INA3221 Triple Current/Voltage Monitors

2016-06-18 Thread Guenter Roeck
Hi Andrew, On 06/17/2016 04:21 PM, Andrew F. Davis wrote: On 06/10/2016 11:44 AM, Guenter Roeck wrote: On Fri, Jun 10, 2016 at 10:32:33AM -0500, Andrew F. Davis wrote: Add support for the the INA3221 26v capable, Triple channel, Bi-Directional, Zero-Drift, Low-/High-Side, Current/Voltage

Re: [PATCH v5 1/1] hwmon: Add support for INA3221 Triple Current/Voltage Monitors

2016-06-24 Thread Guenter Roeck
On Fri, Jun 24, 2016 at 10:02:51AM -0500, Andrew F. Davis wrote: > On 06/18/2016 10:16 AM, Guenter Roeck wrote: > > > > The chip registers are 16 bit. Can you repeat the command using the "w" > > option ? > > > > # i2cdump -y 2 0x40 w > 0,8 1,9

Re: [PATCH v5 1/1] hwmon: Add support for INA3221 Triple Current/Voltage Monitors

2016-06-24 Thread Guenter Roeck
On Fri, Jun 24, 2016 at 12:30:56PM -0500, Andrew F. Davis wrote: > On 06/24/2016 11:46 AM, Guenter Roeck wrote: > > On Fri, Jun 24, 2016 at 10:02:51AM -0500, Andrew F. Davis wrote: > >> On 06/18/2016 10:16 AM, Guenter Roeck wrote: > >>> > >>> The chi

Re: [PATCH] hwmon: (jc42) Add support for Microchip MCP9808 temperature sensor

2016-06-27 Thread Guenter Roeck
On 06/27/2016 05:23 PM, Alison Schofield wrote: MCP9808 is not officially compliant to JC-42, similar to MCP9804, but its registers are compatible to JC-42. Signed-off-by: Alison Schofield Cc: Daniel Baluta Applied to -next. Thanks, Guenter -- To unsubscribe from this list: send the line "

Re: [PATCH v2 2/3] hwmon: xgene: Add hwmon driver

2016-07-16 Thread Guenter Roeck
On 07/11/2016 05:30 PM, Hoan Tran wrote: This patch adds hardware temperature and power reading support for APM X-Gene SoC using the mailbox communication interface. Signed-off-by: Hoan Tran --- Documentation/hwmon/xgene-hwmon | 30 ++ drivers/hwmon/Kconfig | 7 + drivers/hwmon

Re: [PATCH] Documentation/watchdog: check return value for magic close

2016-07-19 Thread Guenter Roeck
On 07/19/2016 02:24 AM, Arnd Bergmann wrote: A recent commit added a write to the watchdog test code for doing the "magic close", but that caused a compile-time warning: Documentation/watchdog/src/watchdog-test.c: In function ‘main’: Documentation/watchdog/src/watchdog-test.c:94:5: warning: igno

Re: [PATCH v2] Documentation/watchdog: check return value for magic close

2016-07-19 Thread Guenter Roeck
Bergmann Reviewed-by: Guenter Roeck --- v2: fix typo as pointed out by both Guenter Roeck and Randy Dunlap --- Documentation/watchdog/src/watchdog-test.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/Documentation/watchdog/src/watchdog-test.c b/Docume

<    1   2   3   4   >