Re: [PATCH v3] Documentation/process/coding-style.rst: space around const

2023-10-10 Thread Guenter Roeck
et/ > Link: > https://lore.kernel.org/r/f511170fe61d7e7214a3a062661cf4103980dad6.ca...@perches.com/ > Signed-off-by: Max Kellermann Reviewed-by: Guenter Roeck > --- > V1 -> V2: removed "volatile" on gregkh's request. > V2 -> V3: moved patch changelo

Re: [PATCH 04/16] watchdog: remove ks8695 driver

2019-08-09 Thread Guenter Roeck
On Fri, Aug 09, 2019 at 10:27:32PM +0200, Arnd Bergmann wrote: > The platform is getting removed, so there are no remaining > users of this driver. > > Signed-off-by: Arnd Bergmann Acked-by: Guenter Roeck Please let me know if this should be applied through the watchdog tree.

Re: [PATCH 06/16] watchdog: remove w90x900 driver

2019-08-09 Thread Guenter Roeck
On Fri, Aug 09, 2019 at 10:27:34PM +0200, Arnd Bergmann wrote: > The ARM w90x900 platform is getting removed, so this driver is obsolete > > Signed-off-by: Arnd Bergmann Acked-by: Guenter Roeck > --- > .../watchdog/watchdog-parameters.rst | 10 - > driver

Re: [PATCH 04/16] watchdog: remove ks8695 driver

2019-08-10 Thread Guenter Roeck
On Sat, Aug 10, 2019 at 10:37:14AM +0200, Arnd Bergmann wrote: > On Fri, Aug 9, 2019 at 10:42 PM Guenter Roeck wrote: > > > > On Fri, Aug 09, 2019 at 10:27:32PM +0200, Arnd Bergmann wrote: > > > The platform is getting removed, so there are no remaining &g

Re: [PATCH v3 2/2] hwmon: pmbus: Add Inspur Power System power supply driver

2019-08-11 Thread Guenter Roeck
On 8/11/19 7:53 PM, John Wang wrote: Add the driver to monitor Inspur Power System power supplies with hwmon over pmbus. This driver adds sysfs attributes for additional power supply data, including vendor, model, part_number, serial number, firmware revision, hardware revision, and psu mode(act

Re: [PATCH v3 2/2] hwmon: pmbus: Add Inspur Power System power supply driver

2019-08-12 Thread Guenter Roeck
On Mon, Aug 12, 2019 at 12:48:34PM +0800, John Wang wrote: > > So I should > > 1. Add SENSOR_INSPUR_IPSPS to the end of the file > 2. Add SENSOR_INSPUR_IPSPS in alphabetical order, without additional tab > 3. other suggestions > I would suggest 2). Just use a space before += instead of a tab. G

Re: [PATCH v4 2/2] hwmon: pmbus: Add Inspur Power System power supply driver

2019-08-15 Thread Guenter Roeck
On Thu, Aug 15, 2019 at 06:43:52PM +, Vijay Khemka wrote: > > > On 8/13/19, 1:36 AM, "openbmc on behalf of John Wang" > wangz...@inspur.com> wrote: > > Add the driver to monitor Inspur Power System power supplies > with hwmon over pmbus. > > This driver adds sysfs attribu

Re: [PATCH v4 2/2] hwmon: pmbus: Add Inspur Power System power supply driver

2019-08-15 Thread Guenter Roeck
On 8/15/19 7:44 PM, John Wang wrote: On Fri, Aug 16, 2019 at 3:41 AM Guenter Roeck wrote: On Thu, Aug 15, 2019 at 06:43:52PM +, Vijay Khemka wrote: On 8/13/19, 1:36 AM, "openbmc on behalf of John Wang" wrote: Add the driver to monitor Inspur Power System powe

Re: [PATCH v5 2/2] hwmon: pmbus: Add Inspur Power System power supply driver

2019-08-16 Thread Guenter Roeck
On Fri, Aug 16, 2019 at 04:01:05PM +, Vijay Khemka wrote: > > > On 8/16/19, 3:20 AM, "openbmc on behalf of John Wang" > wangz...@inspur.com> wrote: > > Add the driver to monitor Inspur Power System power supplies > with hwmon over pmbus. > > This driver adds sysfs attribu

Re: [PATCH v5 2/2] hwmon: pmbus: Add Inspur Power System power supply driver

2019-08-18 Thread Guenter Roeck
On 8/18/19 7:20 PM, Joel Stanley wrote: On Fri, 16 Aug 2019 at 10:19, John Wang wrote: Add the driver to monitor Inspur Power System power supplies with hwmon over pmbus. This driver adds sysfs attributes for additional power supply data, including vendor, model, part_number, serial number, f

Re: [PATCH v6 2/2] hwmon: pmbus: Add Inspur Power System power supply driver

2019-08-20 Thread Guenter Roeck
On Mon, Aug 19, 2019 at 05:15:09PM +0800, John Wang wrote: > Add the driver to monitor Inspur Power System power supplies > with hwmon over pmbus. > > This driver adds sysfs attributes for additional power supply data, > including vendor, model, part_number, serial number, > firmware revision, har

Re: [PATCH] k10temp: update documentation

2019-09-21 Thread Guenter Roeck
On Thu, Sep 19, 2019 at 11:25:03AM +0200, Lukas Zapletal wrote: > It's been a while since the k10temp documentation has been updated. > There are new CPU families supported as well as Tdie temp was added. > This patch adds all missing families which I was able to find from git > history and provide

Re: [PATCH] k10temp: update documentation

2019-09-22 Thread Guenter Roeck
On Sun, Sep 22, 2019 at 08:25:40PM +0200, Lukas Zapletal wrote: > > Your patch does not apply to the curent mainline kernel. > > What is the parent branch ? > > Oh well, this is my first contribution. I used Greg's staging tree > which I found in a first contributor tutorial on web. I will rebase,

Re: [PATCH] k10temp: update documentation

2019-09-23 Thread Guenter Roeck
On Mon, Sep 23, 2019 at 09:10:52AM +0200, Lukas Zapletal wrote: > It's been a while since the k10temp documentation has been updated. > There are new CPU families supported as well as Tdie temp was added. > This patch adds all missing families which I was able to find from git > history and provide

Re: [PATCH RESEND] k10temp: update docs and add temp2_input info

2019-10-02 Thread Guenter Roeck
On Mon, Sep 23, 2019 at 12:59:31PM +0200, Lukas Zapletal wrote: > It's been a while since the k10temp documentation has been updated. > There are new CPU families supported as well as Tdie temp was added. > This patch adds all missing families which I was able to find from git > history and provide

Re: [PATCH 1/3] hwmon: Fix HWMON_P_MIN_ALARM mask

2019-10-02 Thread Guenter Roeck
On Tue, Sep 24, 2019 at 02:49:43PM +0200, Nuno Sá wrote: > Both HWMON_P_MIN_ALARM and HWMON_P_MAX_ALARM were using > BIT(hwmon_power_max_alarm). > > Fixes: aa7f29b07c870 ("hwmon: Add support for power min, lcrit, min_alarm and > lcrit_alarm") > CC: > Signed-off-by: Nuno Sá Applied. Thanks, Gu

Re: [PATCH 1/3] docs: fix some broken references

2019-10-02 Thread Guenter Roeck
tree/bindings/cpu/cpu-topology.txt| 2 +- > Documentation/devicetree/bindings/timer/ingenic,tcu.txt | 2 +- > Documentation/driver-api/gpio/driver.rst | 2 +- > Documentation/hwmon/inspur-ipsps1.rst | 2 +- For hwmon: Acked-by: Guenter Roeck > D

Re: [PATCH 2/3] hwmon: Add support for ltc2947

2019-10-02 Thread Guenter Roeck
On Tue, Sep 24, 2019 at 02:49:44PM +0200, Nuno Sá wrote: > The ltc2947 is a high precision power and energy monitor with an > internal sense resistor supporting up to +/- 30A. Three internal no > Latency ADCs ensure accurate measurement of voltage and current, while > high-bandwidth analog multipli

Re: [PATCH 2/3] hwmon: Add support for ltc2947

2019-10-04 Thread Guenter Roeck
On Fri, Oct 04, 2019 at 07:45:07AM +, Sa, Nuno wrote: [ ... ] > > > +static int ltc2947_val_read(struct ltc2947_data *st, const u8 reg, > > > + const u8 page, const size_t size, s64 *val) > > > +{ > > > + int ret; > > > + u64 __val = 0; > > > + > > > + mutex_lock(&st->lock);

Re: [PATCH 2/3] hwmon: Add support for ltc2947

2019-10-07 Thread Guenter Roeck
On 10/7/19 5:25 AM, Sa, Nuno wrote: On Fri, 2019-10-04 at 08:06 -0700, Guenter Roeck wrote: On Fri, Oct 04, 2019 at 07:45:07AM +, Sa, Nuno wrote: [ ... ] +static int ltc2947_val_read(struct ltc2947_data *st, const u8 reg, + const u8 page, const size_t size, s64

Re: [PATCH] hwmon: docs: Extend inspur-ipsps1 title underline

2019-10-07 Thread Guenter Roeck
On 10/6/19 7:36 PM, Adam Zerella wrote: Sphinx is generating a build warning as the title underline of this file is too short. Signed-off-by: Adam Zerella Applied. Thanks, Guenter --- Documentation/hwmon/inspur-ipsps1.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 2/3] hwmon: Add support for ltc2947

2019-10-10 Thread Guenter Roeck
On Thu, Oct 10, 2019 at 07:13:06AM +, Sa, Nuno wrote: > > Quoting the reply I had: > > "As the LTC2947 is bi-directional, the most likely use for the Min/Max > Energy thresholds are for monitoring a battery being charged or > discharged. > A limit could be set based around the battery's stor

Re: [PATCH v2 1/2] hwmon: Add support for ltc2947

2019-10-20 Thread Guenter Roeck
On Fri, Oct 11, 2019 at 01:48:52PM +0200, Nuno Sá wrote: > The ltc2947 is a high precision power and energy monitor with an > internal sense resistor supporting up to +/- 30A. Three internal no > Latency ADCs ensure accurate measurement of voltage and current, while > high-bandwidth analog multipli

Re: [PATCH] hwmon: (ina3221) Add summation feature support

2019-10-20 Thread Guenter Roeck
On Wed, Oct 16, 2019 at 04:57:02PM -0700, Nicolin Chen wrote: > This patch implements the summation feature of INA3221, mainly the > SCC (enabling) and SF (warning flag) bits of MASK_ENABLE register, > INA3221_SHUNT_SUM (summation of shunt voltages) register, and the > INA3221_CRIT_SUM (its critica

Re: [PATCH 1/2] hwmon: pmbus: Add Infineon PXE1610 VR driver

2019-05-29 Thread Guenter Roeck
On 5/29/19 3:35 PM, Vijay Khemka wrote: Added pmbus driver for the new device Infineon pxe1610 voltage regulator. It also supports similar family device PXE1110 and PXM1310. Signed-off-by: Vijay Khemka --- drivers/hwmon/pmbus/Kconfig | 9 +++ drivers/hwmon/pmbus/Makefile | 1 + drive

Re: [PATCH 2/2] Docs: hwmon: pmbus: Add PXE1610 driver

2019-05-29 Thread Guenter Roeck
On 5/29/19 3:35 PM, Vijay Khemka wrote: Added support for Infenion PXE1610 driver Signed-off-by: Vijay Khemka --- Documentation/hwmon/pxe1610 | 84 + 1 file changed, 84 insertions(+) create mode 100644 Documentation/hwmon/pxe1610 diff --git a/Documentat

Re: [PATCH 2/2] Docs: hwmon: pmbus: Add PXE1610 driver

2019-05-30 Thread Guenter Roeck
On Thu, May 30, 2019 at 06:51:52PM +, Vijay Khemka wrote: > > > On 5/29/19, 6:05 PM, "Guenter Roeck" li...@roeck-us.net> wrote: > > On 5/29/19 3:35 PM, Vijay Khemka wrote: > > Added support for Infenion PXE1610 driver > &

Re: [PATCH 03/10] mfd / platform: cros_ec: Miscellaneous character device to talk with the EC

2019-06-04 Thread Guenter Roeck
On Tue, Jun 4, 2019 at 11:35 AM Greg Kroah-Hartman wrote: > > On Tue, Jun 04, 2019 at 01:58:38PM -0300, Ezequiel Garcia wrote: > > Hey Greg, > > > > > > + dev_info(&pdev->dev, "Created misc device /dev/%s\n", > > > > + data->misc.name); > > > > > > No need to be noisy, if all goes well, y

Re: [PATCH v2 1/2] hwmon: pmbus: Add Infineon PXE1610 VR driver

2019-06-05 Thread Guenter Roeck
-- > Changes in v2: > incorporated all the feedback from Guenter Roeck > > drivers/hwmon/pmbus/Kconfig | 9 +++ > drivers/hwmon/pmbus/Makefile | 1 + > drivers/hwmon/pmbus/pxe1610.c | 139 ++ > 3 files changed, 149 insertions(+) > create

Re: [PATCH v2 2/2] Docs: hwmon: pmbus: Add PXE1610 driver

2019-06-05 Thread Guenter Roeck
On Thu, May 30, 2019 at 04:11:57PM -0700, Vijay Khemka wrote: > Added support for Infenion PXE1610 driver > Applied, after fixing s/Infenion/Infineon/ s/Infinion/Infineon/ Guenter > Signed-off-by: Vijay Khemka > --- > Changes in v2: > incorporated all the fee

Re: [PATCH v10 3/3] watchdog: make the device time out at open_deadline when open_timeout is used

2019-06-07 Thread Guenter Roeck
g. > > - When !watchdoc_active(wdd), the "virtual timeout" should be taken to s/watchdoc_active/watchdog_active/ otherwise Reviewed-by: Guenter Roeck > be ->open_deadline". When the open_timeout feature is not used or the > device has been opened at least once, -&g

Re: [PATCH v10 1/3] watchdog: introduce watchdog.open_timeout commandline parameter

2019-06-07 Thread Guenter Roeck
eature with an > appropriate WDIOC_SETTIMEOUT immediately prior to closing the device. > > Signed-off-by: Rasmus Villemoes Reviewed-by: Guenter Roeck > --- > .../watchdog/watchdog-parameters.txt | 8 + > drivers/watchdog/watchdog_dev.c | 36 +++

Re: [PATCH v10 2/3] watchdog: introduce CONFIG_WATCHDOG_OPEN_TIMEOUT

2019-06-07 Thread Guenter Roeck
ate of the kernel command line. > > Signed-off-by: Rasmus Villemoes Reviewed-by: Guenter Roeck > --- > Documentation/watchdog/watchdog-parameters.txt | 8 > drivers/watchdog/Kconfig | 9 + > drivers/watchdog/watchdog_dev.c

Re: [PATCH v3 30/33] docs: watchdog: convert docs to ReST and rename to *.rst

2019-06-09 Thread Guenter Roeck
> > At its new index.rst, let's add a :orphan: while this is not linked to > the main index.rst file, in order to avoid build warnings. > > Cc: Mauro Carvalho Chehab , > linux-ker...@vger.kernel.org, Jonathan Corbet > Signed-off-by: Mauro Carvalho Chehab Reviewed-b

Re: [PATCH v10 3/3] watchdog: make the device time out at open_deadline when open_timeout is used

2019-06-14 Thread Guenter Roeck
On 6/14/19 1:41 AM, Rasmus Villemoes wrote: On 07/06/2019 20.38, Guenter Roeck wrote: On Wed, Jun 05, 2019 at 02:06:44PM +, Rasmus Villemoes wrote: When the watchdog device is not open by userspace, the kernel takes care of pinging it. When the open_timeout feature is in use, we should

Re: [PATCH linux 2/6] hwmon: occ: Add sysfs interface

2017-01-07 Thread Guenter Roeck
On 01/06/2017 02:17 PM, Edward James wrote: [ ... ] > +} > + > +static DEVICE_ATTR(online, S_IWUSR | S_IRUGO, show_occ_online, > + store_occ_online); > + > +struct occ_sysfs *occ_sysfs_start(struct device *dev, struct occ *occ, > + struct occ_sysfs_config *config) > +{ > +

Re: [PATCH linux 2/6] hwmon: occ: Add sysfs interface

2017-01-10 Thread Guenter Roeck
On Tue, Jan 10, 2017 at 11:41:44AM -0600, Benjamin Herrenschmidt wrote: > On Sat, 2017-01-07 at 09:15 -0800, Guenter Roeck wrote: > > > Instead of the "online" attribute, what do you think about using the > > > "bind"/"unbind" API to probe

Re: [PATCH v4 2/3] watchdog: introduce watchdog.open_timeout commandline parameter

2017-01-10 Thread Guenter Roeck
On Mon, Jan 09, 2017 at 04:02:32PM +0100, Rasmus Villemoes wrote: > The watchdog framework takes care of feeding a hardware watchdog until > userspace opens /dev/watchdogN. If that never happens for some reason > (buggy init script, corrupt root filesystem or whatnot) but the kernel > itself is fin

Re: [PATCH v4 2/3] watchdog: introduce watchdog.open_timeout commandline parameter

2017-01-11 Thread Guenter Roeck
On 01/11/2017 12:11 AM, Rasmus Villemoes wrote: On 2017-01-10 19:08, Guenter Roeck wrote: On Mon, Jan 09, 2017 at 04:02:32PM +0100, Rasmus Villemoes wrote: +static unsigned open_timeout; +module_param(open_timeout, uint, 0644); + +static bool watchdog_past_open_deadline(struct

Re: [PATCH linux v2 5/6] hwmon: occ: Add hwmon implementation for the P8 OCC

2017-01-15 Thread Guenter Roeck
On 01/11/2017 10:10 AM, eajames@gmail.com wrote: From: "Edward A. James" Add code to tie the hwmon sysfs code and the POWER8 OCC code together, as well as probe the entire driver from the I2C bus. I2C is the communication method between the BMC and the P8 OCC. Signed-off-by: Edward A. Jame

Re: [PATCH linux v2 2/6] hwmon: occ: Add sysfs interface

2017-01-15 Thread Guenter Roeck
On 01/11/2017 10:10 AM, eajames@gmail.com wrote: From: "Edward A. James" Add a generic mechanism to expose the sensors provided by the OCC in sysfs. Signed-off-by: Edward A. James Signed-off-by: Andrew Jeffery --- Documentation/hwmon/occ | 62 ++ drivers/hwmon/occ/Makefil

Re: [PATCH linux v2 5/6] hwmon: occ: Add hwmon implementation for the P8 OCC

2017-01-15 Thread Guenter Roeck
On 01/11/2017 10:10 AM, eajames@gmail.com wrote: From: "Edward A. James" Add code to tie the hwmon sysfs code and the POWER8 OCC code together, as well as probe the entire driver from the I2C bus. I2C is the communication method between the BMC and the P8 OCC. Signed-off-by: Edward A. Jame

Re: [PATCH linux v2 0/6] drivers: hwmon: Add On-Chip Controller driver

2017-01-15 Thread Guenter Roeck
On 01/11/2017 10:10 AM, eajames@gmail.com wrote: From: "Edward A. James" This patchset adds a hwmon driver to support the OCC (On-Chip Controller) on the IBM POWER8 and POWER9 processors, from a BMC (Baseboard Management Controller). The OCC is an embedded processor that provides real time

Re: [PATCH linux v1 2/2] drivers: hwmon: hwmon driver for ASPEED AST2400/2500 PWM and Fan tach controller

2017-01-15 Thread Guenter Roeck
On 01/09/2017 01:59 PM, Jaghathiswari Rankappagounder Natarajan wrote: The ASPEED AST2400/2500 PWM controller supports 8 PWM output ports. The ASPEED AST2400/2500 Fan tach controller supports 16 tachometer inputs. PWM clock types M, N and 0 are three types just to have three independent PWM sourc

Re: [PATCH linux v3 1/6] hwmon: Add core On-Chip Controller support for POWER CPUs

2017-01-21 Thread Guenter Roeck
On 01/16/2017 01:13 PM, eajames@gmail.com wrote: From: "Edward A. James" Add core support for polling the OCC for it's sensor data and parsing that data into sensor-specific information. Signed-off-by: Edward A. James Signed-off-by: Andrew Jeffery --- Documentation/hwmon/occ| 40 ++

Re: [PATCH linux v3 2/6] hwmon: occ: Add sysfs interface

2017-01-21 Thread Guenter Roeck
On 01/16/2017 01:13 PM, eajames@gmail.com wrote: From: "Edward A. James" Add a generic mechanism to expose the sensors provided by the OCC in sysfs. Signed-off-by: Edward A. James Signed-off-by: Andrew Jeffery --- Documentation/hwmon/occ | 62 ++ drivers/hwmon/occ/Makefil

Re: [PATCH linux v3 3/6] hwmon: occ: Add I2C transport implementation for SCOM operations

2017-01-21 Thread Guenter Roeck
On 01/16/2017 01:13 PM, eajames@gmail.com wrote: From: "Edward A. James" Add functions to send SCOM operations over I2C bus. The BMC can communicate with the Power8 host processor over I2C, but needs to use SCOM operations in order to access the OCC register space. Signed-off-by: Edward A.

Re: [PATCH linux v3 4/6] hwmon: occ: Add callbacks for parsing P8 OCC datastructures

2017-01-21 Thread Guenter Roeck
On 01/16/2017 01:13 PM, eajames@gmail.com wrote: From: "Edward A. James" Add functions to parse the data structures that are specific to the OCC on the POWER8 processor. These are the sensor data structures, including temperature, frequency, power, and "caps." Signed-off-by: Edward A. Jame

Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn

2017-01-21 Thread Guenter Roeck
On 01/21/2017 11:20 AM, Florian Fainelli wrote: We have a device reference, utilize it instead of pr_warn(). Signed-off-by: Florian Fainelli --- Applied to -next. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vg

Re: [PATCH 2/2] hwmon: (lm70) Add support for TI TMP122/124

2017-01-21 Thread Guenter Roeck
On 01/21/2017 11:20 AM, Florian Fainelli wrote: Add support for Texas Instruments TMP122/124 which are nearly identical to their TMP121/123 except that they also support programmable temperature thresholds. Signed-off-by: Florian Fainelli Applied to -next. Any plans to add support for the th

Re: [PATCH 2/2] hwmon: (lm70) Add support for TI TMP122/124

2017-01-21 Thread Guenter Roeck
On 01/21/2017 03:11 PM, Florian Fainelli wrote: On January 21, 2017 12:25:21 PM PST, Guenter Roeck wrote: On 01/21/2017 11:20 AM, Florian Fainelli wrote: Add support for Texas Instruments TMP122/124 which are nearly identical to their TMP121/123 except that they also support programmable

Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn

2017-01-22 Thread Guenter Roeck
On 01/22/2017 10:43 PM, Joe Perches wrote: On Sat, 2017-01-21 at 11:20 -0800, Florian Fainelli wrote: We have a device reference, utilize it instead of pr_warn(). There is at least one more hwmon to convert in applesmc.c Perhaps a coccinelle script? Two questions for Julia Lawall: o is ther

Re: [PATCH linux v3 1/6] hwmon: Add core On-Chip Controller support for POWER CPUs

2017-01-23 Thread Guenter Roeck
On Mon, Jan 23, 2017 at 01:28:52PM -0600, Edward James wrote: > I still just can't get gmail to reply to this. Thanks for the review. > > On Sat, Jan 21, 2017 at 11:49 AM, Guenter Roeck wrote: > > On 01/16/2017 01:13 PM, eajames@gmail.com wrote: > >>

Re: [PATCH linux v3 2/6] hwmon: occ: Add sysfs interface

2017-01-23 Thread Guenter Roeck
On Mon, Jan 23, 2017 at 04:01:25PM -0600, Edward James wrote: > > > On Sat, Jan 21, 2017 at 12:08 PM, Guenter Roeck wrote: > > On 01/16/2017 01:13 PM, eajames@gmail.com wrote: > >> > >> From: "Edward A. James" > >> > >> Add a g

[PATCH] watchdog: Introduce watchdog_stop_on_unregister helper

2017-01-25 Thread Guenter Roeck
reducing driver code size while retaining functionality. Signed-off-by: Guenter Roeck --- Documentation/watchdog/watchdog-kernel-api.txt | 6 ++ drivers/watchdog/watchdog_dev.c| 5 + include/linux/watchdog.h | 10 ++ 3 files changed, 21

Re: [PATCH linux v4 1/6] hwmon: Add core On-Chip Controller support for POWER CPUs

2017-01-29 Thread Guenter Roeck
On 01/26/2017 03:19 PM, eajames@gmail.com wrote: From: "Edward A. James" Add core support for polling the OCC for it's sensor data and parsing that data into sensor-specific information. Signed-off-by: Edward A. James Signed-off-by: Andrew Jeffery --- Documentation/hwmon/occ| 40 ++

Re: [PATCH linux v4 2/6] hwmon: occ: Add sysfs interface

2017-01-29 Thread Guenter Roeck
On 01/26/2017 03:19 PM, eajames@gmail.com wrote: From: "Edward A. James" Add a generic mechanism to expose the sensors provided by the OCC in sysfs. Signed-off-by: Edward A. James Signed-off-by: Andrew Jeffery --- Documentation/hwmon/occ | 62 ++ drivers/hwmon/occ/Makefil

Re: [PATCH linux v5 1/6] hwmon: Add core On-Chip Controller support for POWER CPUs

2017-02-04 Thread Guenter Roeck
On 01/31/2017 07:43 AM, eaja...@linux.vnet.ibm.com wrote: From: "Edward A. James" Add core support for polling the OCC for it's sensor data and parsing that data into sensor-specific information. Signed-off-by: Edward A. James Signed-off-by: Andrew Jeffery --- Documentation/hwmon/occ|

Re: [PATCH linux v7 4/6] hwmon: occ: Add callbacks for parsing P8 OCC datastructures

2017-02-13 Thread Guenter Roeck
On Mon, Feb 13, 2017 at 11:47:22AM +1030, Andrew Jeffery wrote: > On Fri, 2017-02-10 at 16:01 +1030, Joel Stanley wrote: > > > On Wed, Feb 8, 2017 at 9:40 AM,   wrote: > > > > > From: "Edward A. James" > > > > > > Add functions to parse the data structures that are specific to the OCC on > > > th

Re: [PATCH] docs: hwmon: Fix typo "Microship" should be "Microchip"

2017-02-21 Thread Guenter Roeck
On Tue, Feb 21, 2017 at 10:30:47PM +1300, Chris Packham wrote: > Signed-off-by: Chris Packham Applied to -next. Thanks, Guenter > --- > Documentation/hwmon/tc654 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/hwmon/tc654 b/Documentation/hwmon/tc654 > in

Re: [PATCH linux v8 0/6] drivers: hwmon: Add On-Chip Controller driver

2017-02-23 Thread Guenter Roeck
On Thu, Feb 23, 2017 at 04:43:20PM -0600, Edward James wrote: > Hi Guenter, > > Any thoughts on this patch set? Others welcome to chime in too. > Sorry, I have been busy. Weekend or next week, hopefully. Guenter > Thanks, > Eddie > > Eddie James wrote on 02/14/2017 02:34:17 PM: > > > From: E

Re: [RFC 2/2] hwmon: powernv: Hwmon driver for OCC inband power and temperature sensors

2017-03-09 Thread Guenter Roeck
reason to consider such an alternative ? Thanks, Guenter > Signed-off-by: Shilpasri G Bhat > CC: Rob Herring > CC: Mark Rutland > CC: Jean Delvare > CC: Guenter Roeck > CC: Jonathan Corbet > CC: devicet...@vger.kernel.org > CC: linux-hw...@vger.kernel.or

Re: [PATCH linux v8 2/6] hwmon: occ: Add sysfs interface

2017-03-12 Thread Guenter Roeck
On 02/14/2017 12:34 PM, Eddie James wrote: From: "Edward A. James" Add a generic mechanism to expose the sensors provided by the OCC in sysfs. Signed-off-by: Edward A. James Signed-off-by: Andrew Jeffery --- Documentation/hwmon/occ | 62 +++ drivers/hwmon/occ/Makefile|

Re: [RFC 2/2] hwmon: powernv: Hwmon driver for OCC inband power and temperature sensors

2017-03-12 Thread Guenter Roeck
On 03/09/2017 05:30 AM, Shilpasri G Bhat wrote: Hi Guenter, On 03/09/2017 05:40 PM, Guenter Roeck wrote: On Thu, Mar 09, 2017 at 05:19:15PM +0530, Shilpasri G Bhat wrote: Add support to read power and temperature sensors from OCC inband sensors which are copied to main memory by OCC. Is

Re: [PATCH linux v5 2/2] drivers: hwmon: Support for ASPEED PWM/Fan tach

2017-04-01 Thread Guenter Roeck
On 03/24/2017 11:17 AM, Jaghathiswari Rankappagounder Natarajan wrote: The ASPEED AST2400/2500 PWM controller supports 8 PWM output ports. The ASPEED AST2400/2500 Fan tach controller supports 16 tachometer inputs. The device driver matches on the device tree node. The configuration values are rea

Re: [PATCH linux v9 2/5] hwmon: occ: Add sysfs interface

2017-04-02 Thread Guenter Roeck
On 03/14/2017 01:55 PM, Eddie James wrote: From: "Edward A. James" Add a generic mechanism to expose the sensors provided by the OCC in sysfs. Signed-off-by: Edward A. James Signed-off-by: Andrew Jeffery --- Documentation/hwmon/occ | 62 +++ drivers/hwmon/occ/Makefile|

Re: [PATCH linux v6 1/2] Documentation: dt-bindings: Document bindings for ASPEED AST2400/AST2500 PWM and Fan tach controller device driver

2017-04-04 Thread Guenter Roeck
On 04/03/2017 04:30 PM, Jaghathiswari Rankappagounder Natarajan wrote: This binding provides interface for adding values related to ASPEED AST2400/2500 PWM and Fan tach controller support. The PWM controller can support upto 8 PWM output ports. The Fan tach controller can support upto 16 tachomet

Re: [PATCH linux v6 2/2] drivers: hwmon: Support for ASPEED PWM/Fan tach

2017-04-04 Thread Guenter Roeck
On 04/03/2017 04:30 PM, Jaghathiswari Rankappagounder Natarajan wrote: The ASPEED AST2400/2500 PWM controller supports 8 PWM output ports. The ASPEED AST2400/2500 Fan tach controller supports 16 tachometer inputs. The device driver matches on the device tree node. The configuration values are rea

Re: [PATCH linux v6 2/2] drivers: hwmon: Support for ASPEED PWM/Fan tach

2017-04-04 Thread Guenter Roeck
On 04/04/2017 05:55 AM, Guenter Roeck wrote: On 04/03/2017 04:30 PM, Jaghathiswari Rankappagounder Natarajan wrote: The ASPEED AST2400/2500 PWM controller supports 8 PWM output ports. The ASPEED AST2400/2500 Fan tach controller supports 16 tachometer inputs. The device driver matches on the

Re: [PATCH 2/2] devicetree: Document the max31760 device binding.

2017-04-11 Thread Guenter Roeck
On Tue, Apr 11, 2017 at 06:47:28AM -0700, John Muir wrote: > > On Apr 10, 2017, at 8:42 AM, Rob Herring wrote: > > > > On Tue, Apr 04, 2017 at 12:20:34PM -0700, John Muir wrote: > >> +MAX31760 fan controller > >> +--- > >> + > >> +This device supports I2C only. Many properties

Re: [PATCH 2/3] hwmon: (adt7475) fan stall prevention

2017-05-02 Thread Guenter Roeck
On Tue, May 02, 2017 at 05:45:35PM +1200, Chris Packham wrote: > By default adt7475 will stop the fans (pwm duty cycle 0%) when the > temperature drops past Tmin - hysteresis. Some systems want to keep the > fans moving even when the temperature drops so add new sysfs attributes > that configure th

Re: [RFC PATCH 3/3] hwmon: (adt7475) temperature smoothing

2017-05-02 Thread Guenter Roeck
On Tue, May 02, 2017 at 05:45:36PM +1200, Chris Packham wrote: > When enabled temperature smoothing allows ramping the fan speed over a > configurable period of time instead of jumping to the new speed > instantaneously. > > Signed-off-by: Chris Packham > --- > Documentation/hwmon/adt7475 | 5

Re: [RFC PATCH v2 2/3] hwmon: (adt7475) fan stall prevention

2017-05-03 Thread Guenter Roeck
On Wed, May 03, 2017 at 12:40:08PM +1200, Chris Packham wrote: > By default adt7475 will stop the fans (pwm duty cycle 0%) when the > temperature drops past Tmin - hysteresis. Some systems want to keep the > fans moving even when the temperature drops so add new sysfs attributes > that configure th

Re: [RFC PATCH v2 3/3] hwmon: (adt7475) temperature smoothing

2017-05-03 Thread Guenter Roeck
On Wed, May 03, 2017 at 12:40:09PM +1200, Chris Packham wrote: > When enabled temperature smoothing allows ramping the fan speed over a > configurable period of time instead of jumping to the new speed > instantaneously. > > Signed-off-by: Chris Packham > --- > Changes in v2: > - use a single tem

Re: [PATCH v3 2/4] hwmon: (adt7475) fan stall prevention

2017-05-14 Thread Guenter Roeck
On 05/10/2017 08:45 PM, Chris Packham wrote: By default adt7475 will stop the fans (pwm duty cycle 0%) when the temperature drops past Tmin - hysteresis. Some systems want to keep the fans moving even when the temperature drops so add new sysfs attributes that configure the enhanced acoustics min

Re: [PATCH v3 3/4] hwmon: (adt7475) temperature smoothing

2017-05-14 Thread Guenter Roeck
On 05/10/2017 08:45 PM, Chris Packham wrote: When enabled temperature smoothing allows ramping the fan speed over a configurable period of time instead of jumping to the new speed instantaneously. Signed-off-by: Chris Packham --- Changes in v2: - use a single tempN_smoothing attribute This i

Re: [PATCH v3 3/4] hwmon: (adt7475) temperature smoothing

2017-05-14 Thread Guenter Roeck
On 05/14/2017 02:23 PM, Chris Packham wrote: On 15/05/17 03:40, Guenter Roeck wrote: On 05/10/2017 08:45 PM, Chris Packham wrote: When enabled temperature smoothing allows ramping the fan speed over a configurable period of time instead of jumping to the new speed instantaneously. Signed-off

Re: [PATCH v4 1/3] hwmon: (adt7475) fan stall prevention

2017-05-15 Thread Guenter Roeck
On 05/14/2017 06:30 PM, Chris Packham wrote: By default adt7475 will stop the fans (pwm duty cycle 0%) when the temperature drops past Tmin - hysteresis. Some systems want to keep the fans moving even when the temperature drops so add new sysfs attributes that configure the enhanced acoustics min

Re: [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing

2017-05-15 Thread Guenter Roeck
On 05/14/2017 06:30 PM, Chris Packham wrote: When enabled temperature smoothing allows ramping the fan speed over a configurable period of time instead of jumping to the new speed instantaneously. Signed-off-by: Chris Packham Applied to -next. --- Changes in v2: - use a single tempN_smoothi

Re: [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing

2017-05-16 Thread Guenter Roeck
On Tue, May 16, 2017 at 08:30:52PM +, Chris Packham wrote: > On 16/05/17 20:23, kbuild test robot wrote: > > Hi Chris, > > > > [auto build test ERROR on hwmon/hwmon-next] > > [also build test ERROR on v4.12-rc1 next-20170516] > > [if your patch is applied to the wrong git tree, please drop us a

Re: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing

2017-05-16 Thread Guenter Roeck
On 05/16/2017 09:39 PM, Ye Xiaolong wrote: On 05/17, Chris Packham wrote: On 17/05/17 15:09, Ye Xiaolong wrote: On 05/16, Chris Packham wrote: On 16/05/17 20:23, kbuild test robot wrote: Hi Chris, [auto build test ERROR on hwmon/hwmon-next] [also build test ERROR on v4.12-rc1 next-20170516]

Re: [kbuild-all] [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing

2017-05-17 Thread Guenter Roeck
On 05/17/2017 08:05 PM, Ye Xiaolong wrote: On 05/16, Guenter Roeck wrote: 0day bot applied your patchset on top of commit 6eaaea1 ("hwmon: (pmbus) Add client driver for IR35221"), is it wrong or you have some prerequisite patches? Thanks for the info, seems we need to improve the

Re: [PATCH 0/5] hwmon: move include files out of include/linux/i2c

2017-05-21 Thread Guenter Roeck
On 05/21/2017 01:34 PM, Wolfram Sang wrote: It doesn't make sense to use include/linux/i2c for client drivers which may in fact rather be hwmon or input or whatever devices. As a result, I want to deprecate include/linux/i2c for good. This series moves the include files to a better location, larg

Re: [PATCH v5 0/3] watchdog: allow setting deadline for opening /dev/watchdogN

2017-05-22 Thread Guenter Roeck
On Mon, May 22, 2017 at 07:07:51PM +0100, Alan Cox wrote: > On Mon, 22 May 2017 16:06:36 +0200 > Rasmus Villemoes wrote: > > > If a watchdog driver tells the framework that the device is running, > > the framework takes care of feeding the watchdog until userspace opens > > the device. If the use

Re: [PATCH v5 2/3] watchdog: introduce watchdog.open_timeout commandline parameter

2017-05-24 Thread Guenter Roeck
On 05/22/2017 07:06 AM, Rasmus Villemoes wrote: The watchdog framework takes care of feeding a hardware watchdog until userspace opens /dev/watchdogN. If that never happens for some reason (buggy init script, corrupt root filesystem or whatnot) but the kernel itself is fine, the machine stays up

Re: [PATCH v3] hwmon: Add support for MAX31785 intelligent fan controller

2017-06-06 Thread Guenter Roeck
On 06/06/2017 12:02 AM, Andrew Jeffery wrote: Add a basic driver for the MAX31785, focusing on the fan control features but ignoring the temperature and voltage monitoring features of the device. This driver supports all fan control modes and tachometer / PWM readback where applicable. Signed-o

Re: [PATCH v6 0/3] watchdog: allow setting deadline for opening /dev/watchdogN

2017-06-06 Thread Guenter Roeck
On 06/06/2017 01:08 AM, Rasmus Villemoes wrote: On 2017-05-30 10:56, Rasmus Villemoes wrote: v6 tweaks the wording in watchdog-parameters.txt to avoid having to update it if and when the watchdog core grows new parameters. It also adds a little more rationale to the commit messages for 2/3 and

Re: [PATCH v3] hwmon: Add support for MAX31785 intelligent fan controller

2017-06-07 Thread Guenter Roeck
On Tue, Jun 06, 2017 at 04:32:30PM +0930, Andrew Jeffery wrote: > Add a basic driver for the MAX31785, focusing on the fan control > features but ignoring the temperature and voltage monitoring > features of the device. > > This driver supports all fan control modes and tachometer / PWM > readback

Re: [PATCH v3] hwmon: Add support for MAX31785 intelligent fan controller

2017-06-07 Thread Guenter Roeck
On Wed, Jun 07, 2017 at 04:15:06PM +0930, Andrew Jeffery wrote: > On Wed, 2017-06-07 at 12:18 +0930, Joel Stanley wrote: > > On Wed, Jun 7, 2017 at 1:50 AM, Matthew Barth > > > wrote: > > > > > > On 06/06/17 8:33 AM, Guenter Roeck wrote: > > > >

Re: [PATCH v3] hwmon: Add support for MAX31785 intelligent fan controller

2017-06-08 Thread Guenter Roeck
On 06/08/2017 12:53 AM, Andrew Jeffery wrote: On Wed, 2017-06-07 at 08:55 -0700, Guenter Roeck wrote: On Tue, Jun 06, 2017 at 04:32:30PM +0930, Andrew Jeffery wrote: Add a basic driver for the MAX31785, focusing on the fan control features but ignoring the temperature and voltage monitoring

Re: [v6, 2/3] watchdog: introduce watchdog.open_timeout commandline parameter

2017-07-08 Thread Guenter Roeck
On Tue, May 30, 2017 at 10:56:46AM +0200, Rasmus Villemoes wrote: > The watchdog framework takes care of feeding a hardware watchdog until > userspace opens /dev/watchdogN. If that never happens for some reason > (buggy init script, corrupt root filesystem or whatnot) but the kernel > itself is fin

Re: [v6,3/3] watchdog: introduce CONFIG_WATCHDOG_OPEN_TIMEOUT

2017-07-08 Thread Guenter Roeck
On Tue, May 30, 2017 at 10:56:47AM +0200, Rasmus Villemoes wrote: > This allows setting a default value for the watchdog.open_timeout > commandline parameter via Kconfig. > > Some BSPs allow remote updating of the kernel image and root file > system, but updating the bootloader requires physical a

Re: [v3, 02/12] Documentation: ABI: Add occ-hwmon driver sysfs documentation

2017-11-22 Thread Guenter Roeck
On Mon, Nov 20, 2017 at 05:53:31PM -0600, eaja...@linux.vnet.ibm.com wrote: > From: "Edward A. James" > > Detail the sysfs attributes provided by the occ-hwmon driver. > This describes my problem with this driver: All the sysfs attributes described here are not really hardware monitoring relate

Re: [v3, 09/12] hwmon (occ): Add sensor attributes and register hwmon device

2017-11-22 Thread Guenter Roeck
On Mon, Nov 20, 2017 at 05:53:38PM -0600, eaja...@linux.vnet.ibm.com wrote: > From: "Edward A. James" > > Setup the sensor attributes for every OCC sensor found by the first poll > response. Register the attributes with hwmon. Add hwmon documentation > for the driver. > > Signed-off-by: Edward A

Re: [v3,10/12] hwmon (occ): Add non-hwmon attributes

2017-11-22 Thread Guenter Roeck
On Mon, Nov 20, 2017 at 05:53:39PM -0600, eaja...@linux.vnet.ibm.com wrote: > From: "Edward A. James" > > Create device attributes for additional OCC properties that do not > belong as hwmon sensors. These provide additional information as to the > state of the processor and system. > ... and th

Re: [PATCH 1/2] watchdog: introduce watchdog.open_timeout commandline parameter

2017-11-28 Thread Guenter Roeck
On Tue, Nov 28, 2017 at 11:35:49AM +0100, Rasmus Villemoes wrote: > The watchdog framework takes care of feeding a hardware watchdog until > userspace opens /dev/watchdogN. If that never happens for some reason > (buggy init script, corrupt root filesystem or whatnot) but the kernel > itself is fin

Re: [PATCH 1/2] watchdog: introduce watchdog.open_timeout commandline parameter

2017-11-29 Thread Guenter Roeck
On Wed, Nov 29, 2017 at 11:56:57AM +0100, Rasmus Villemoes wrote: > On 2017-11-28 23:14, Guenter Roeck wrote: > > On Tue, Nov 28, 2017 at 11:35:49AM +0100, Rasmus Villemoes wrote: > >> > >> The unit is milliseconds rather than seconds because that covers more > >

Re: [v6,1/4] pmbus (core): Add fan control support

2017-11-29 Thread Guenter Roeck
On Mon, Nov 20, 2017 at 03:12:03PM +1030, Andrew Jeffery wrote: > Expose fanX_target, pwmX and pwmX_enable hwmon sysfs attributes. > > Fans in a PMBus device are driven by the configuration of two registers, > FAN_CONFIG_x_y and FAN_COMMAND_x: FAN_CONFIG_x_y dictates how the fan > and the tacho op

Re: [v6,2/4] pmbus (max31785): Add fan control

2017-11-29 Thread Guenter Roeck
On Mon, Nov 20, 2017 at 03:12:04PM +1030, Andrew Jeffery wrote: > The implementation makes use of the new fan control virtual registers > exposed by the pmbus core. It mixes use of the default implementations > with some overrides via the read/write handlers to handle FAN_COMMAND_1 > on the MAX3178

Re: [v6,3/4] pmbus (core): Add virtual page config bit

2017-11-29 Thread Guenter Roeck
On Mon, Nov 20, 2017 at 03:12:05PM +1030, Andrew Jeffery wrote: > Some circumstances call for virtual pages, to expose multiple values > packed into an extended PMBus register in a manner non-compliant with > the PMBus standard. An example of this is the Maxim MAX31785 controller, > which extends t

  1   2   3   4   >