Re: [PATCH v2 05/11] Doc: DT: thermal: new irq-mode for trip point

2018-11-13 Thread Lukasz Luba
Hi Krzysztof, Thanks for the comments. On 11/12/18 9:51 AM, Krzysztof Kozlowski wrote: > On Wed, 7 Nov 2018 at 18:10, Lukasz Luba wrote: >> > > Subject prefix: > dt-bindings: thermal: > >> Thermal trip point gets new flag in DT: irq-mode. >> Trip point may have a new explicit flag which indica

Re: [PATCH v2 06/11] arm64: dts: exynos5433: add support for thermal trip irq-mode

2018-11-13 Thread Lukasz Luba
Hi Krzysztof, On 11/12/18 10:00 AM, Krzysztof Kozlowski wrote: > Thanks Lukasz for patches. I like your work! > > I have few more comments which will probably apply for all the DTS commits. > > On Wed, 7 Nov 2018 at 18:10, Lukasz Luba wrote: >> >> This patch adds support for new flag which indi

Re: [PATCH v2 05/11] Doc: DT: thermal: new irq-mode for trip point

2018-11-13 Thread Lukasz Luba
Hi Rob, On 11/12/18 8:09 PM, Rob Herring wrote: > On Wed, Nov 07, 2018 at 06:09:47PM +0100, Lukasz Luba wrote: >> Thermal trip point gets new flag in DT: irq-mode. >> Trip point may have a new explicit flag which indicate >> IRQ support when the temperature is met (so the thermal framework >> deos

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Oleksandr Natalenko
Hi. ksm by default working only on memory that added by madvise(). And only way get that work on other applications: * Use LD_PRELOAD and libraries * Patch kernel Lets use kernel task list and add logic to import VMAs from tasks. That behaviour controlled by new attributes: * mode:

Re: [PATCH v3 2/3] dt-bindings: i3c: Document Synopsys DesignWare I3C master bindings

2018-11-13 Thread vitor
Hi Boris, On 12/11/18 09:17, Boris Brezillon wrote: On Thu, 8 Nov 2018 17:14:10 + Vitor soares wrote: Document Synopsys DesignWare I3C master module Signed-off-by: Vitor soares --- Changes in v3: - Remove dummy characters Changes in v2: - Address the changes in Documentation/devicetre

Re: [PATCH v3 2/3] dt-bindings: i3c: Document Synopsys DesignWare I3C master bindings

2018-11-13 Thread vitor
Hi Rob, On 13/11/18 02:09, Rob Herring wrote: On Thu, Nov 08, 2018 at 05:14:10PM +, Vitor soares wrote: Document Synopsys DesignWare I3C master module Signed-off-by: Vitor soares Please make your author and S-o-b emails match. This is an alias and both email will work. Anyway I agree t

[PATCH] Documentation/features: Refresh the features list to v4.20-rc2

2018-11-13 Thread Ingo Molnar
* Palmer Dabbelt wrote: > I didn't even know this existed until David submitted a patch set that > included updates to the documentation as a result of some features he > added to RISC-V. It looks like there may be a handful of other people > who don't know this exists either, so I figured I'd

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Timofey Titovets
вт, 13 нояб. 2018 г. в 04:49, Matthew Wilcox : > > On Tue, Nov 13, 2018 at 02:13:44AM +0300, Timofey Titovets wrote: > > Some numbers from different not madvised workloads. > > Formulas: > > Percentage ratio = (pages_sharing - pages_shared)/pages_unshared > > Memory saved = (pages_sharing - pag

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Timofey Titovets
вт, 13 нояб. 2018 г. в 05:25, Pavel Tatashin : > > On 18-11-13 02:13:44, Timofey Titovets wrote: > > From: Timofey Titovets > > > > ksm by default working only on memory that added by > > madvise(). > > > > And only way get that work on other applications: > > * Use LD_PRELOAD and libraries > >

[PATCH v4 0/8] clk: clkdev: managed clk lookup and provider registrations

2018-11-13 Thread Matti Vaittinen
Series add bd71837/bd71837 PMIC clock support + managed interfaces Few clk drivers appear to be leaking clkdev lookup registrations at driver remove. The patch series adds devm versions of lookup registrations and cleans up few drivers. Driver clean-up patches have not been tested as I lack the HW

[PATCH v4 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations

2018-11-13 Thread Matti Vaittinen
With MFD devices the clk properties may be contained in MFD (parent) DT node. Current devm_of_clk_add_hw_provider assumes the clk is bound to MFD subdevice not to MFD device (parent). Add devm_of_clk_add_hw_provider_parent to tackle this issue. Also clkdev registration lacks of managed registratio

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Timofey Titovets
вт, 13 нояб. 2018 г. в 14:06, Oleksandr Natalenko : > > Hi. > > > ksm by default working only on memory that added by > > madvise(). > > > > And only way get that work on other applications: > > * Use LD_PRELOAD and libraries > > * Patch kernel > > > > Lets use kernel task list and add logic to

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Jann Horn
On Tue, Nov 13, 2018 at 12:40 PM Timofey Titovets wrote: > ksm by default working only on memory that added by > madvise(). > > And only way get that work on other applications: > * Use LD_PRELOAD and libraries > * Patch kernel > > Lets use kernel task list and add logic to import VMAs from ta

[PATCH v4 2/8] clk: clk-max77686: Clean clkdev lookup leak and use devm

2018-11-13 Thread Matti Vaittinen
clk-max77686 never clean clkdev lookup at remove. This can cause oops if clk-max77686 is removed and inserted again. Fix leak by using new devm clkdev lookup registration. Simplify also error path by using new devm_of_clk_add_parent_hw_provider. Signed-off-by: Matti Vaittinen Reviewed-by: Krzyszt

[PATCH v4 3/8] clk: clk-st: avoid clkdev lookup leak at remove

2018-11-13 Thread Matti Vaittinen
Use devm based clkdev lookup registration to avoid leaking lookup structures. Signed-off-by: Matti Vaittinen --- drivers/clk/x86/clk-st.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/x86/clk-st.c b/drivers/clk/x86/clk-st.c index 3a0996f2d556..25d4b97aff9b 100

[PATCH v4 4/8] clk: clk-hi655x: Free of_provider at remove

2018-11-13 Thread Matti Vaittinen
use devm variant for of_provider registration so provider is freed at exit. Signed-off-by: Matti Vaittinen --- drivers/clk/clk-hi655x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-hi655x.c b/drivers/clk/clk-hi655x.c index 403a0188634a..394d0109104d 100

[PATCH v4 5/8] clk: rk808: use managed version of of_provider registration

2018-11-13 Thread Matti Vaittinen
Simplify clean-up for rk808 by using managed version of of_provider registration. Signed-off-by: Matti Vaittinen --- drivers/clk/clk-rk808.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/clk/clk-rk808.c b/drivers/clk/clk-rk808.c index 6461f2820a5b..

[PATCH v4 6/8] clk: clk-twl6040: Free of_provider at remove

2018-11-13 Thread Matti Vaittinen
use devm variant for of_provider registration so provider is freed at exit. Signed-off-by: Matti Vaittinen Acked-by: Peter Ujfalusi --- drivers/clk/clk-twl6040.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/clk/clk-twl6040.c b/drivers/clk/clk-twl6040.c index

[PATCH v4 7/8] clk: apcs-msm8916: simplify probe cleanup by using devm

2018-11-13 Thread Matti Vaittinen
use devm variant for of_provider registration. Signed-off-by: Matti Vaittinen --- drivers/clk/qcom/apcs-msm8916.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/apcs-msm8916.c b/drivers/clk/qcom/apcs-msm8916.c index b1cc8dbcd327..f4e0c136ab1a 100644 ---

[PATCH v4 8/8] clk: bd718x7: Initial support for ROHM bd71837/bd71847 PMIC clock

2018-11-13 Thread Matti Vaittinen
ROHM bd71837 and bd71847 contain 32768Hz clock gate. Support the clock using generic clock framework. Signed-off-by: Matti Vaittinen --- drivers/clk/Kconfig | 7 +++ drivers/clk/Makefile | 1 + drivers/clk/clk-bd718x7.c | 131 ++ 3 files

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Timofey Titovets
вт, 13 нояб. 2018 г. в 14:57, Jann Horn : > > On Tue, Nov 13, 2018 at 12:40 PM Timofey Titovets > wrote: > > ksm by default working only on memory that added by > > madvise(). > > > > And only way get that work on other applications: > > * Use LD_PRELOAD and libraries > > * Patch kernel > > >

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Jann Horn
On Tue, Nov 13, 2018 at 1:59 PM Timofey Titovets wrote: > > вт, 13 нояб. 2018 г. в 14:57, Jann Horn : > > > > On Tue, Nov 13, 2018 at 12:40 PM Timofey Titovets > > wrote: > > > ksm by default working only on memory that added by > > > madvise(). > > > > > > And only way get that work on other app

[PATCH v4 0/3] Add driver for Synopsys DesignWare I3C master IP

2018-11-13 Thread Vitor Soares
This patch series is a proposal for the I3C master driver for Synopsys IP. This patch is to be applied on top of I3C subsystem RFC V10 submitted by Boris Brezillon. Supported features: Regular CCC commands. I3C private transfers. I2C transfers. Missing functionalities: Support DMA interfa

[PATCH v4 3/3] MAINTAINERS: Add myself as the dw-i3c-master module maintainer

2018-11-13 Thread Vitor Soares
Signed-off-by: Vitor Soares --- Change in v4: - Change email soa...@synopsys.com to vitor.soa...@synopsys.com Change in v3: - Remove dummy characters Change in v2: - None MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 293c863..39910b3 1006

[PATCH v4 2/3] dt-binding: i3c: Document Synopsys DesignWare I3C

2018-11-13 Thread Vitor Soares
Document Synopsys DesignWare I3C master module Signed-off-by: Vitor Soares Reviewed-by: Rob Herring --- Changes in v4: - Change email soa...@synopsys.com to vitor.soa...@synopsys.com - Add Rob Herring R-b Changes in v3: - Remove dummy characters Changes in v2: - Address the changes in Document

[PATCH v4 1/3] i3c: master: Add driver for Synopsys DesignWare IP

2018-11-13 Thread Vitor Soares
Add driver for Synopsys DesignWare I3C master IP Signed-off-by: Vitor Soares --- Change in v4: - Change email soa...@synopsys.com to vitor.soa...@synopsys.com Change in v3: - Use struct_size() (suggested by Matthew) Change in v2: - Rename some variables - Remove dw_i3c_master_dev_set_info() - A

Re: [PATCH v10 07/22] kasan: initialize shadow to 0xff for tag-based mode

2018-11-13 Thread Andrey Konovalov
On Wed, Nov 7, 2018 at 6:08 PM, Mark Rutland wrote: > On Tue, Nov 06, 2018 at 06:30:22PM +0100, Andrey Konovalov wrote: >> A tag-based KASAN shadow memory cell contains a memory tag, that >> corresponds to the tag in the top byte of the pointer, that points to that >> memory. The native top byte v

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Oleksandr Natalenko
Hi. Yep. However, so far, it requires an application to explicitly opt in to this behavior, so it's not all that bad. Your patch would remove the requirement for application opt-in, which, in my opinion, makes this way worse and reduces the number of applications for which this is acceptable.

Re: [PATCH 10/17] prmem: documentation

2018-11-13 Thread Igor Stoppa
Hello, I've been studying v4 of the patch-set [1] that Nadav has been working on. Incidentally, I think it would be useful to cc also the security/hardening ml. The patch-set seems to be close to final, so I am resuming this discussion. On 30/10/2018 19:06, Andy Lutomirski wrote: I support th

Re: [PATCH v10 12/22] kasan, arm64: fix up fault handling logic

2018-11-13 Thread Andrey Konovalov
On Thu, Nov 8, 2018 at 1:22 PM, Mark Rutland wrote: > On Tue, Nov 06, 2018 at 06:30:27PM +0100, Andrey Konovalov wrote: >> show_pte in arm64 fault handling relies on the fact that the top byte of >> a kernel pointer is 0xff, which isn't always the case with tag-based >> KASAN. > > That's for the T

Re: [PATCH v15 23/23] x86/sgx: Driver documentation

2018-11-13 Thread Jarkko Sakkinen
On Thu, Nov 08, 2018 at 09:20:40PM +0200, Jarkko Sakkinen wrote: > On Thu, Nov 08, 2018 at 04:39:42PM +0200, Jarkko Sakkinen wrote: > > On Wed, Nov 07, 2018 at 09:09:37AM -0800, Dave Hansen wrote: > > > On 11/7/18 8:30 AM, Jarkko Sakkinen wrote: > > > >> Does this code run when I type "make kselfte

[PATCH] arm64: Make kpti command line options x86 compatible

2018-11-13 Thread Alexander Graf
I've already stumbled over 2 cases where people got confused about how to disable kpti on AArch64. In both cases, they used existing x86_64 options and just applied that to an AArch64 system, expecting it to work. I think it makes a lot of sense to have compatible kernel command line parameters wh

[PATCH v2] arm64: Make kpti command line options x86 compatible

2018-11-13 Thread Alexander Graf
I've already stumbled over 2 cases where people got confused about how to disable kpti on AArch64. In both cases, they used existing x86_64 options and just applied that to an AArch64 system, expecting it to work. I think it makes a lot of sense to have compatible kernel command line parameters wh

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Oleksandr Natalenko
So, …snip… +static int ksm_seeker_thread(void *nothing) +{ + pid_t last_pid = 1; + pid_t curr_pid; + struct task_struct *task; + + set_freezable(); + set_user_nice(current, 5); + + while (!kthread_should_stop()) { + wait_while_offlining(); + +

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Timofey Titovets
вт, 13 нояб. 2018 г. в 19:33, Oleksandr Natalenko : > > So, > > > …snip… > > +static int ksm_seeker_thread(void *nothing) > > +{ > > + pid_t last_pid = 1; > > + pid_t curr_pid; > > + struct task_struct *task; > > + > > + set_freezable(); > > + set_user_nice(current, 5); > > + >

Re: [PATCH 10/17] prmem: documentation

2018-11-13 Thread Andy Lutomirski
On Tue, Nov 13, 2018 at 6:25 AM Igor Stoppa wrote: > > Hello, > I've been studying v4 of the patch-set [1] that Nadav has been working on. > Incidentally, I think it would be useful to cc also the > security/hardening ml. > The patch-set seems to be close to final, so I am resuming this discussion

Re: [PATCH] hwmon (ina3221) Add single-shot mode support

2018-11-13 Thread Guenter Roeck
On Mon, Nov 12, 2018 at 08:58:24PM -0800, Nicolin Chen wrote: > Hi Guenter, > > On Mon, Nov 12, 2018 at 08:32:48PM -0800, Guenter Roeck wrote: > > On Mon, Nov 12, 2018 at 08:23:53PM -0800, Nicolin Chen wrote: > > > INA3221 supports both continuous and single-shot modes. When > > > running in the c

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Oleksandr Natalenko
On 13.11.2018 18:10, Timofey Titovets wrote: You mean try do something, like that right? read_lock(&tasklist_lock); task_lock(task); read_unlock(&tasklist_lock); last_pid = task_pid_nr(task); ksm_import_task_vma(task); task_unlock(task); No, task_lock() uses spin_lock() under th

Re: [PATCH 10/17] prmem: documentation

2018-11-13 Thread Nadav Amit
From: Andy Lutomirski Sent: November 13, 2018 at 5:16:09 PM GMT > To: Igor Stoppa > Cc: Kees Cook , Peter Zijlstra , > Nadav Amit , Mimi Zohar , > Matthew Wilcox , Dave Chinner , > James Morris , Michal Hocko , Kernel > Hardening , linux-integrity > , LSM List > , Igor Stoppa > , Dave Hanse

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Timofey Titovets
вт, 13 нояб. 2018 г. в 20:27, Oleksandr Natalenko : > > On 13.11.2018 18:10, Timofey Titovets wrote: > > You mean try do something, like that right? > > > > read_lock(&tasklist_lock); > > > > task_lock(task); > > read_unlock(&tasklist_lock); > > last_pid = task_pid_nr(task); > > ksm_im

Re: [PATCH 10/17] prmem: documentation

2018-11-13 Thread Andy Lutomirski
On Tue, Nov 13, 2018 at 9:43 AM Nadav Amit wrote: > > From: Andy Lutomirski > Sent: November 13, 2018 at 5:16:09 PM GMT > > To: Igor Stoppa > > Cc: Kees Cook , Peter Zijlstra > > , Nadav Amit , Mimi Zohar > > , Matthew Wilcox , Dave > > Chinner , James Morris , Michal > > Hocko , Kernel Harde

Re: [PATCH 01/12] kernfs: add function to find kernfs_node without increasing ref counter

2018-11-13 Thread Paolo Valente
> Il giorno 12 nov 2018, alle ore 13:28, Greg Kroah-Hartman > ha scritto: > > On Mon, Nov 12, 2018 at 10:56:21AM +0100, Paolo Valente wrote: >> From: Angelo Ruocco >> >> The kernfs pseudo file system doesn't export any function to only find >> a node by name, without also getting a referenc

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Pavel Tatashin
On 18-11-13 15:23:50, Oleksandr Natalenko wrote: > Hi. > > > Yep. However, so far, it requires an application to explicitly opt in > > to this behavior, so it's not all that bad. Your patch would remove > > the requirement for application opt-in, which, in my opinion, makes > > this way worse and

[PATCHv11 0/8] Add Intel Stratix10 FPGA manager and service layer

2018-11-13 Thread richard . gong
From: Richard Gong This is the 11th submission of Intel Stratix10 service layer and FPGA manager driver patches. Starting from 10th submission Stratix10 service layer driver .c file is moved to drivers/firmware, header files is moved to include/linux/firmware/intel. And other firmware interface i

[PATCHv11 2/8] arm64: dts: stratix10: add stratix10 service driver binding to base dtsi

2018-11-13 Thread richard . gong
From: Richard Gong Add Intel Stratix10 service layer to the device tree Signed-off-by: Richard Gong Signed-off-by: Alan Tull Acked-by: Moritz Fischer --- v2: change to put service layer driver node under the firmware node change compatible to "intel, stratix10-svc" v3: no change v4: s/ser

[PATCHv11 1/8] dt-bindings, firmware: add Intel Stratix10 service layer binding

2018-11-13 Thread richard . gong
From: Richard Gong Add a device tree binding for the Intel Stratix10 service layer driver Signed-off-by: Richard Gong Signed-off-by: Alan Tull Reviewed-by: Rob Herring Acked-by: Moritz Fischer --- v2: change to put service layer driver node under the firmware node change compatible to "i

[PATCHv11 3/8] firmware: add Intel Stratix10 service layer driver

2018-11-13 Thread richard . gong
From: Richard Gong Some features of the Intel Stratix10 SoC require a level of privilege higher than the kernel is granted. Such secure features include FPGA programming. In terms of the ARMv8 architecture, the kernel runs at Exception Level 1 (EL1), access to the features requires Exception Leve

[PATCHv11 7/8] Documentation: driver-api: add stratix10 service layer

2018-11-13 Thread richard . gong
From: Richard Gong Add Intel Stratix10 service layer driver document Signed-off-by: Richard Gong Signed-off-by: Alan Tull --- v5: this patch is added in patch set version 5, add new file stratix10-svc.rst add stratix10-svc.rst to driver-api/index.rst v6: no change v7: no change v8: no

[PATCHv11 8/8] firmware: add remote status update client support

2018-11-13 Thread richard . gong
From: Richard Gong Extend Intel Stratix10 service layer to support the second service layer client, Remote Status Update (RSU). RSU is used to provide our customers with protection against loading bad bitstreams onto their devices when those devices are booting from flash. Signed-off-by: Richar

Re: [PATCH 10/17] prmem: documentation

2018-11-13 Thread Nadav Amit
From: Andy Lutomirski Sent: November 13, 2018 at 5:47:16 PM GMT > To: Nadav Amit > Cc: Igor Stoppa , Kees Cook , > Peter Zijlstra , Mimi Zohar , > Matthew Wilcox , Dave Chinner , > James Morris , Michal Hocko , Kernel > Hardening , linux-integrity > , LSM List > , Igor Stoppa > , Dave Hanse

[PATCHv11 5/8] arm64: dts: stratix10: add fpga manager and region

2018-11-13 Thread richard . gong
From: Alan Tull Add the Stratix10 FPGA manager and a FPGA region to the device tree. Signed-off-by: Alan Tull Signed-off-by: Richard Gong --- v2: this patch is added in patch set version 2 v3: change to put fpga_mgr node under firmware/svc node v4: s/fpga-mgr@0/fpga-mgr/ to remove unit_address

[PATCHv11 6/8] fpga: add intel stratix10 soc fpga manager driver

2018-11-13 Thread richard . gong
From: Alan Tull Add driver for reconfiguring Intel Stratix10 SoC FPGA devices. This driver communicates through the Intel service layer driver which does communication with privileged hardware (that does the FPGA programming) through a secure mailbox. Signed-off-by: Alan Tull Signed-off-by: Ric

[PATCHv11 4/8] dt-bindings: fpga: add Stratix10 SoC FPGA manager binding

2018-11-13 Thread richard . gong
From: Alan Tull Add a Device Tree binding for the Intel Stratix10 SoC FPGA manager. Signed-off-by: Alan Tull Signed-off-by: Richard Gong Reviewed-by: Rob Herring Acked-by: Moritz Fischer --- v2: this patch is added in patch set version 2 v3: change to put fpga_mgr node under firmware/svc nod

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Timofey Titovets
вт, 13 нояб. 2018 г. в 20:59, Pavel Tatashin : > > On 18-11-13 15:23:50, Oleksandr Natalenko wrote: > > Hi. > > > > > Yep. However, so far, it requires an application to explicitly opt in > > > to this behavior, so it's not all that bad. Your patch would remove > > > the requirement for application

[PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Timofey Titovets
ksm by default working only on memory that added by madvise(). And only way get that work on other applications: * Use LD_PRELOAD and libraries * Patch kernel Lets use kernel task list and add logic to import VMAs from tasks. That behaviour controlled by new attributes: * mode: I try m

[PATCH V4] KSM: allow dedup all tasks memory

2018-11-13 Thread Timofey Titovets
ksm by default working only on memory that added by madvise(). And only way get that work on other applications: * Use LD_PRELOAD and libraries * Patch kernel Lets use kernel task list and add logic to import VMAs from tasks. That behaviour controlled by new attributes: * mode: I try m

Re: [PATCH 10/17] prmem: documentation

2018-11-13 Thread Igor Stoppa
On 13/11/2018 19:16, Andy Lutomirski wrote: > On Tue, Nov 13, 2018 at 6:25 AM Igor Stoppa wrote: [...] >> How about having one mm_struct for each writer (core or thread)? >> > > I don't think that helps anything. I think the mm_struct used for > prmem (or rare_write or whatever you want to cal

Re: [PATCH 10/17] prmem: documentation

2018-11-13 Thread Igor Stoppa
On 13/11/2018 19:47, Andy Lutomirski wrote: > For general rare-writish stuff, I don't think we want IRQs running > with them mapped anywhere for write. For AVC and IMA, I'm less sure. Why would these be less sensitive? But I see a big difference between my initial implementation and this one.

Re: [PATCH 10/17] prmem: documentation

2018-11-13 Thread Igor Stoppa
I forgot one sentence :-( On 13/11/2018 20:31, Igor Stoppa wrote: > On 13/11/2018 19:47, Andy Lutomirski wrote: > >> For general rare-writish stuff, I don't think we want IRQs running >> with them mapped anywhere for write. For AVC and IMA, I'm less sure. > > Why would these be less sensitive?

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Pavel Tatashin
On 18-11-13 21:17:42, Timofey Titovets wrote: > вт, 13 нояб. 2018 г. в 20:59, Pavel Tatashin : > > > > On 18-11-13 15:23:50, Oleksandr Natalenko wrote: > > > Hi. > > > > > > > Yep. However, so far, it requires an application to explicitly opt in > > > > to this behavior, so it's not all that bad. Y

Re: [PATCH 10/17] prmem: documentation

2018-11-13 Thread Andy Lutomirski
On Tue, Nov 13, 2018 at 10:26 AM Igor Stoppa wrote: > > On 13/11/2018 19:16, Andy Lutomirski wrote: > > > should be > > entirely abstracted away by an appropriate API, so neither SELinux nor > > IMA need to be aware that there's an mm_struct involved. > > Yes, that is fine. In my proposal I was th

Re: [PATCH 10/17] prmem: documentation

2018-11-13 Thread Andy Lutomirski
On Tue, Nov 13, 2018 at 10:33 AM Igor Stoppa wrote: > > I forgot one sentence :-( > > On 13/11/2018 20:31, Igor Stoppa wrote: > > On 13/11/2018 19:47, Andy Lutomirski wrote: > > > >> For general rare-writish stuff, I don't think we want IRQs running > >> with them mapped anywhere for write. For A

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Pavel Tatashin
> > Is it really necessary to have an extra thread in ksm just to add vma's > > for scanning? Can we do it right from the scanner thread? Also, may be > > it is better to add vma's at their creation time when KSM_MODE_ALWAYS is > > enabled? > > > > Thank you, > > Pasha > > Oh, thats a long story, a

Re: [PATCH v5 05/27] Documentation/x86: Add CET description

2018-11-13 Thread Borislav Petkov
On Thu, Oct 11, 2018 at 08:15:01AM -0700, Yu-cheng Yu wrote: > Explain how CET works and the no_cet_shstk/no_cet_ibt kernel > parameters. > > Signed-off-by: Yu-cheng Yu > --- > .../admin-guide/kernel-parameters.txt | 6 + > Documentation/index.rst | 1 + > Docum

Re: [PATCH 10/17] prmem: documentation

2018-11-13 Thread Andy Lutomirski
On Tue, Nov 13, 2018 at 10:31 AM Igor Stoppa wrote: > > On 13/11/2018 19:47, Andy Lutomirski wrote: > > > For general rare-writish stuff, I don't think we want IRQs running > > with them mapped anywhere for write. For AVC and IMA, I'm less sure. > > Why would these be less sensitive? I'm not rea

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Timofey Titovets
вт, 13 нояб. 2018 г. в 21:35, Pavel Tatashin : > > On 18-11-13 21:17:42, Timofey Titovets wrote: > > вт, 13 нояб. 2018 г. в 20:59, Pavel Tatashin : > > > > > > On 18-11-13 15:23:50, Oleksandr Natalenko wrote: > > > > Hi. > > > > > > > > > Yep. However, so far, it requires an application to explicit

Re: [PATCH 10/17] prmem: documentation

2018-11-13 Thread Igor Stoppa
On 13/11/2018 20:35, Andy Lutomirski wrote: > On Tue, Nov 13, 2018 at 10:26 AM Igor Stoppa wrote: [...] >> The high level API could be something like: >> >> wr_memcpy(void *src, void *dst, uint_t size) [...] > If you call a wr_memcpy() function with the signature you suggested, > then you c

Re: [PATCH 10/17] prmem: documentation

2018-11-13 Thread Igor Stoppa
On 13/11/2018 20:36, Andy Lutomirski wrote: > On Tue, Nov 13, 2018 at 10:33 AM Igor Stoppa wrote: [...] >> Unless the secondary mapping is also available to other cores, through >> the shared mm_struct ? >> > > I don't think this matters much. The other cores will only be able to > use that ma

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Pavel Tatashin
On 18-11-13 21:54:13, Timofey Titovets wrote: > вт, 13 нояб. 2018 г. в 21:35, Pavel Tatashin : > > > > On 18-11-13 21:17:42, Timofey Titovets wrote: > > > вт, 13 нояб. 2018 г. в 20:59, Pavel Tatashin : > > > > > > > > On 18-11-13 15:23:50, Oleksandr Natalenko wrote: > > > > > Hi. > > > > > > > > >

Re: [PATCH 01/12] kernfs: add function to find kernfs_node without increasing ref counter

2018-11-13 Thread Greg Kroah-Hartman
On Tue, Nov 13, 2018 at 06:53:59PM +0100, Paolo Valente wrote: > > > > Il giorno 12 nov 2018, alle ore 13:28, Greg Kroah-Hartman > > ha scritto: > > > > On Mon, Nov 12, 2018 at 10:56:21AM +0100, Paolo Valente wrote: > >> From: Angelo Ruocco > >> > >> The kernfs pseudo file system doesn't exp

Re: [PATCH 10/17] prmem: documentation

2018-11-13 Thread Igor Stoppa
On 13/11/2018 20:48, Andy Lutomirski wrote: > On Tue, Nov 13, 2018 at 10:31 AM Igor Stoppa wrote: >> >> On 13/11/2018 19:47, Andy Lutomirski wrote: >> >>> For general rare-writish stuff, I don't think we want IRQs running >>> with them mapped anywhere for write. For AVC and IMA, I'm less sure. >>

Re: [PATCH 0/2] Docs/EDID: Fixed and improved EDID documentation

2018-11-13 Thread Jani Nikula
On Tue, 06 Nov 2018, Jonathan Corbet wrote: > On Mon, 5 Nov 2018 09:48:33 +0100 > Christoph Niedermaier wrote: > >> A problem was found when EDID data sets for displays other >> than the provided samples were generated. The patch series has >> no effect on the provided samples that still match th

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Jann Horn
+cc Daniel Gruss On Tue, Nov 13, 2018 at 6:59 PM Pavel Tatashin wrote: > On 18-11-13 15:23:50, Oleksandr Natalenko wrote: > > Hi. > > > > > Yep. However, so far, it requires an application to explicitly opt in > > > to this behavior, so it's not all that bad. Your patch would remove > > > the req

Re: [PATCH v5 05/27] Documentation/x86: Add CET description

2018-11-13 Thread Yu-cheng Yu
On Tue, 2018-11-13 at 19:43 +0100, Borislav Petkov wrote: > On Thu, Oct 11, 2018 at 08:15:01AM -0700, Yu-cheng Yu wrote: > > Explain how CET works and the no_cet_shstk/no_cet_ibt kernel > > parameters. > > > > Signed-off-by: Yu-cheng Yu > > --- > > .../admin-guide/kernel-parameters.txt |

RE: [PATCH v7 01/13] arch/x86: Start renaming the rdt files to more generic names

2018-11-13 Thread Yu, Fenghua
> From: Borislav Petkov [mailto:b...@alien8.de] > Subject: [PATCH v7 01/13] arch/x86: Start renaming the rdt files to more > generic names > > I guess the subject prefix for all those should be "arch/resctrl:" or so now. Is "x86/resctrl" a better subject prefix? Thanks. -Fenghua

Re: [PATCH v7 01/13] arch/x86: Start renaming the rdt files to more generic names

2018-11-13 Thread Borislav Petkov
On Tue, Nov 13, 2018 at 09:35:40PM +, Yu, Fenghua wrote: > Is "x86/resctrl" a better subject prefix? Doh, of course. Diffstat is all arch/x86/. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.

RE: [PATCH v7 11/13] arch/x86: Introduce QOS feature for AMD

2018-11-13 Thread Yu, Fenghua
> From: Moger, Babu [mailto:babu.mo...@amd.com] > Subject: [PATCH v7 11/13] arch/x86: Introduce QOS feature for AMD > The specification for this feature is available at > https://developer.amd.com/wp-content/resources/56375.pdf > +bool cbm_validate_amd(char *buf, u32 *data, struct rdt_resource *r)

Re: [PATCH v10 12/22] kasan, arm64: fix up fault handling logic

2018-11-13 Thread Mark Rutland
On Tue, Nov 13, 2018 at 04:01:27PM +0100, Andrey Konovalov wrote: > On Thu, Nov 8, 2018 at 1:22 PM, Mark Rutland wrote: > > On Tue, Nov 06, 2018 at 06:30:27PM +0100, Andrey Konovalov wrote: > >> show_pte in arm64 fault handling relies on the fact that the top byte of > >> a kernel pointer is 0xff,

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Pavel Tatashin
> Wait, what? Can you name specific ones? Nowadays, enabling KSM for > untrusted VMs seems like a terrible idea to me, security-wise. Of course it is not used to share data among different customers/tenants, as far as I know it is used by Oracle Cloud to merge the same pages in clear containers.

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Timofey Titovets
вт, 13 нояб. 2018 г. в 22:17, Pavel Tatashin : > > On 18-11-13 21:54:13, Timofey Titovets wrote: > > вт, 13 нояб. 2018 г. в 21:35, Pavel Tatashin : > > > > > > On 18-11-13 21:17:42, Timofey Titovets wrote: > > > > вт, 13 нояб. 2018 г. в 20:59, Pavel Tatashin > > > > : > > > > > > > > > > On 18-11-

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Pavel Tatashin
> > > That must work, but we out of bit space in vm_flags [1]. > > > i.e. first 32 bits already defined, and other only accessible only on > > > 64-bit machines. > > > > So, grow vm_flags_t to 64-bit, or enable this feature on 64-bit only. > > With all due respect to you, for that type of things w

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Timofey Titovets
вт, 13 нояб. 2018 г. в 21:43, Pavel Tatashin : > > > > Is it really necessary to have an extra thread in ksm just to add vma's > > > for scanning? Can we do it right from the scanner thread? Also, may be > > > it is better to add vma's at their creation time when KSM_MODE_ALWAYS is > > > enabled? >

Re: [PATCH V3] KSM: allow dedup all tasks memory

2018-11-13 Thread Timofey Titovets
ср, 14 нояб. 2018 г. в 01:53, Pavel Tatashin : > > > > > That must work, but we out of bit space in vm_flags [1]. > > > > i.e. first 32 bits already defined, and other only accessible only on > > > > 64-bit machines. > > > > > > So, grow vm_flags_t to 64-bit, or enable this feature on 64-bit only.

[PATCH V5] KSM: allow dedup all tasks memory

2018-11-13 Thread Timofey Titovets
From: Timofey Titovets ksm by default working only on memory that added by madvise(). And only way get that work on other applications: * Use LD_PRELOAD and libraries * Patch kernel Lets use kernel task list and add logic to import VMAs from tasks. That behaviour controlled by new attribut

Re: [PATCH] hwmon (ina3221) Add single-shot mode support

2018-11-13 Thread Nicolin Chen
Hi Guenter, On Tue, Nov 13, 2018 at 09:21:02AM -0800, Guenter Roeck wrote: > > > > INA3221 supports both continuous and single-shot modes. When > > > > running in the continuous mode, it keeps measuring the inputs > > > > and converting them to the data register even if there are no > > > > users

Re: [RFCv3 PATCH 1/6] uacce: Add documents for WarpDrive/uacce

2018-11-13 Thread Kenneth Lee
在 2018/11/13 上午8:23, Leon Romanovsky 写道: On Mon, Nov 12, 2018 at 03:58:02PM +0800, Kenneth Lee wrote: From: Kenneth Lee WarpDrive is a general accelerator framework for the user application to access the hardware without going through the kernel in data path. The kernel component to provide