RE: [PATCH v4 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations

2018-12-04 Thread Vaittinen, Matti
Hello Stephen, . > > I think we should use parent device's node, not the paren node in DT, > > right? But I agree, we should only look "one level up in the chain". > Are these two things different? I'm suggesting looking at > device_node::parent and trying to find a #clock-cells property. I thoug

Re: [PATCH v4 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations

2018-12-04 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-12-03 23:13:15) > On Mon, Dec 03, 2018 at 03:35:10PM -0800, Stephen Boyd wrote: > > > If the DT doesn't have the #clock-cells property in the node being > > registered then calling clk_get() will fail for any consumer devices > > that point to the node with a phandle

Re: [PATCH v4 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations

2018-12-03 Thread Matti Vaittinen
Hello Again Stephen, I did already send v5 prior to your reply but I will create v6 today based on this discussion. On Mon, Dec 03, 2018 at 03:35:10PM -0800, Stephen Boyd wrote: > Quoting Matti Vaittinen (2018-11-30 02:50:22) > > Hello Stephen, > > > > Thanks a bunch for taking the time and revi

Re: [PATCH v4 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations

2018-12-03 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-11-30 02:50:22) > Hello Stephen, > > Thanks a bunch for taking the time and reviewing this! > > On Fri, Nov 30, 2018 at 12:54:10AM -0800, Stephen Boyd wrote: > > Quoting Matti Vaittinen (2018-11-13 03:55:58) > > > With MFD devices the clk properties may be contained

Re: [PATCH v4 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations

2018-12-03 Thread Matti Vaittinen
Hello Stephen & All, I created v5 where I fixed obvious issues. I'll send it in few minutes. Please note following topics: On Fri, Nov 30, 2018 at 12:50:22PM +0200, Matti Vaittinen wrote: > > On Fri, Nov 30, 2018 at 12:54:10AM -0800, Stephen Boyd wrote: > > Quoting Matti Vaittinen (2018-11-13 03

Re: [PATCH v4 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations

2018-11-30 Thread Matti Vaittinen
On Fri, Nov 30, 2018 at 11:06:53AM +, Russell King - ARM Linux wrote: > On Fri, Nov 30, 2018 at 12:50:22PM +0200, Matti Vaittinen wrote: > > Hello Stephen, > > > > Thanks a bunch for taking the time and reviewing this! > > > > On Fri, Nov 30, 2018 at 12:54:10AM -0800, Stephen Boyd wrote: > >

Re: [PATCH v4 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations

2018-11-30 Thread Russell King - ARM Linux
On Fri, Nov 30, 2018 at 12:50:22PM +0200, Matti Vaittinen wrote: > Hello Stephen, > > Thanks a bunch for taking the time and reviewing this! > > On Fri, Nov 30, 2018 at 12:54:10AM -0800, Stephen Boyd wrote: > > Quoting Matti Vaittinen (2018-11-13 03:55:58) > > > With MFD devices the clk propertie

Re: [PATCH v4 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations

2018-11-30 Thread Matti Vaittinen
Hello Stephen, Thanks a bunch for taking the time and reviewing this! On Fri, Nov 30, 2018 at 12:54:10AM -0800, Stephen Boyd wrote: > Quoting Matti Vaittinen (2018-11-13 03:55:58) > > With MFD devices the clk properties may be contained in MFD (parent) DT > > node. Current devm_of_clk_add_hw_prov

Re: [PATCH v4 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations

2018-11-30 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-11-13 03:55:58) > With MFD devices the clk properties may be contained in MFD (parent) DT > node. Current devm_of_clk_add_hw_provider assumes the clk is bound to MFD > subdevice not to MFD device (parent). Add > devm_of_clk_add_hw_provider_parent to tackle this issue.

[PATCH v4 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations

2018-11-13 Thread Matti Vaittinen
With MFD devices the clk properties may be contained in MFD (parent) DT node. Current devm_of_clk_add_hw_provider assumes the clk is bound to MFD subdevice not to MFD device (parent). Add devm_of_clk_add_hw_provider_parent to tackle this issue. Also clkdev registration lacks of managed registratio