Re: [PATCH] acpi, spcr: Make SPCR available to x86

2018-02-12 Thread Prarit Bhargava
On 02/12/2018 10:44 AM, Peter Zijlstra wrote: > On Mon, Feb 12, 2018 at 10:18:06AM -0500, Prarit Bhargava wrote: >>> But when I specify "earlyprintk=serial,ttyS0,115200" this SPCR crud will >>> not interfere? >>> >> >> I tested "earlyprintk=serial,ttyS0,115200" on a system which is known to >> h

Re: [PATCH] acpi, spcr: Make SPCR available to x86

2018-02-12 Thread Peter Zijlstra
On Mon, Feb 12, 2018 at 10:18:06AM -0500, Prarit Bhargava wrote: > > But when I specify "earlyprintk=serial,ttyS0,115200" this SPCR crud will > > not interfere? > > > > I tested "earlyprintk=serial,ttyS0,115200" on a system which is known to have > a > functional console with "console=ttyS0,1152

Re: [PATCH] acpi, spcr: Make SPCR available to x86

2018-02-12 Thread Prarit Bhargava
On 02/12/2018 09:56 AM, Peter Zijlstra wrote: > On Mon, Feb 12, 2018 at 08:47:57AM -0500, Prarit Bhargava wrote: >> >> >> On 02/12/2018 08:34 AM, Peter Zijlstra wrote: >>> On Thu, Jan 18, 2018 at 10:09:51AM -0500, Prarit Bhargava wrote: config ACPI_SPCR_TABLE + bool "ACPI Serial Port

Re: [PATCH] acpi, spcr: Make SPCR available to x86

2018-02-12 Thread Timur Tabi
On 2/12/18 8:49 AM, Prarit Bhargava wrote: That's true on ARM64. I specifically did not enable the console by default on x86. There are users who do not want a console active during boot & runtime. H... That's a good point. On ARM systems with SPCR, you get a console whether you like it

Re: [PATCH] acpi, spcr: Make SPCR available to x86

2018-02-12 Thread Peter Zijlstra
On Mon, Feb 12, 2018 at 08:47:57AM -0500, Prarit Bhargava wrote: > > > On 02/12/2018 08:34 AM, Peter Zijlstra wrote: > > On Thu, Jan 18, 2018 at 10:09:51AM -0500, Prarit Bhargava wrote: > >> config ACPI_SPCR_TABLE > >> + bool "ACPI Serial Port Console Redirection Support" > >> + default y if X

Re: [PATCH] acpi, spcr: Make SPCR available to x86

2018-02-12 Thread Prarit Bhargava
On 02/12/2018 09:43 AM, Timur Tabi wrote: > On 2/12/18 7:47 AM, Prarit Bhargava wrote: >> ACPI SPCR is used by a vendor to define the serial console for a system. If >> SPCR exists a user can add kernel parameter "earlycon" (no extra kernel >> parameters) and the console will work out-of-the-box

Re: [PATCH] acpi, spcr: Make SPCR available to x86

2018-02-12 Thread Timur Tabi
On 2/12/18 7:47 AM, Prarit Bhargava wrote: ACPI SPCR is used by a vendor to define the serial console for a system. If SPCR exists a user can add kernel parameter "earlycon" (no extra kernel parameters) and the console will work out-of-the-box. "earlycon" is needed only for an *early* console.

Re: [PATCH] acpi, spcr: Make SPCR available to x86

2018-02-12 Thread Prarit Bhargava
On 02/12/2018 08:34 AM, Peter Zijlstra wrote: > On Thu, Jan 18, 2018 at 10:09:51AM -0500, Prarit Bhargava wrote: >> config ACPI_SPCR_TABLE >> +bool "ACPI Serial Port Console Redirection Support" >> +default y if X86 >> +help >> + Enable support for Serial Port Console Redirectio

Re: [PATCH] acpi, spcr: Make SPCR available to x86

2018-02-12 Thread Peter Zijlstra
On Thu, Jan 18, 2018 at 10:09:51AM -0500, Prarit Bhargava wrote: > config ACPI_SPCR_TABLE > + bool "ACPI Serial Port Console Redirection Support" > + default y if X86 > + help > + Enable support for Serial Port Console Redirection (SPCR) Table. > + This table provides infor

Re: [PATCH] acpi, spcr: Make SPCR available to x86

2018-01-23 Thread Prarit Bhargava
On 01/22/2018 04:49 PM, Timur Tabi wrote: > On 01/18/2018 09:09 AM, Prarit Bhargava wrote: >> if (acpi_disabled) { >> -if (earlycon_init_is_deferred) >> +if (earlycon_acpi_spcr_enable) > > This patch works for me, so I can ACK it, but first you might want to rename > earlyc

Re: [PATCH] acpi, spcr: Make SPCR available to x86

2018-01-22 Thread Timur Tabi
On 01/18/2018 09:09 AM, Prarit Bhargava wrote: if (acpi_disabled) { - if (earlycon_init_is_deferred) + if (earlycon_acpi_spcr_enable) This patch works for me, so I can ACK it, but first you might want to rename earlycon_acpi_spcr_enable, because these two li

Re: [PATCH] acpi, spcr: Make SPCR available to x86

2018-01-21 Thread Mark Salter
On Thu, 2018-01-18 at 10:09 -0500, Prarit Bhargava wrote: > Note on testing: I've tested this on several ARM64 and x86 boxes (only > earlycon, console=ttyS0,115200, and with both options), verified that > functionality on ARM64 has not changed (ie, CONFIG_ACPI_SPCR_TABLE is > always =y), and verif

Re: [PATCH] acpi, spcr: Make SPCR available to x86

2018-01-20 Thread Ingo Molnar
* Prarit Bhargava wrote: > Note on testing: I've tested this on several ARM64 and x86 boxes (only > earlycon, console=ttyS0,115200, and with both options), verified that > functionality on ARM64 has not changed (ie, CONFIG_ACPI_SPCR_TABLE is > always =y), and verified functionality when !CONFIG

[PATCH] acpi, spcr: Make SPCR available to x86

2018-01-18 Thread Prarit Bhargava
Note on testing: I've tested this on several ARM64 and x86 boxes (only earlycon, console=ttyS0,115200, and with both options), verified that functionality on ARM64 has not changed (ie, CONFIG_ACPI_SPCR_TABLE is always =y), and verified functionality when !CONFIG_ACPI_SPCR_TABLE on x86. P. 8<