Re: [PATCH 10/10] tools/power/x86: A tool to validate Intel Speed Select commands

2019-07-03 Thread Len Brown
> I hope this is applicable for v2. Yes, Srinivas is doing the right thing. thanks, -Len > > Acked-by: Len Brown

Re: [PATCH 10/10] tools/power/x86: A tool to validate Intel Speed Select commands

2019-07-02 Thread Len Brown
Acked-by: Len Brown On Sat, Jun 29, 2019 at 10:31 AM Andy Shevchenko wrote: > > On Thu, Jun 27, 2019 at 1:39 AM Srinivas Pandruvada > wrote: > > > > The Intel(R) Speed select technologies contains four features. > > > > Performance profile:An non architectur

[PATCH 03/19] cpu topology: Export die_id

2019-05-13 Thread Len Brown
From: Len Brown Export die_id in cpu topology, for the benefit of hardware that has multiple-die/package. Signed-off-by: Len Brown Cc: linux-doc@vger.kernel.org --- Documentation/cputopology.txt | 15 --- drivers/base/topology.c | 4 include/linux/topology.h | 3

[PATCH 01/19] x86 topology: Add CPUID.1F multi-die/package support

2019-05-13 Thread Len Brown
From: Len Brown Some new systems have multiple software-visible die within each package. Update Linux parsing of the Intel CPUID "Extended Topology Leaf" to handle either CPUID.B, or the new CPUID.1F. Add cpuinfo_x86.die_id and cpuinfo_x86.max_dies to store the result. die_id will b

Re: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

2019-02-28 Thread Len Brown
ottom line is that it allows software to discover topology levels that previously needed to be discovered by looking up family/model, in the past, which was sort of annoying. The things that care are things that care about MSR scope. Thankfully, the list of things that care about MSR scope is quite finite. thanks, -Len -- Len Brown, Intel Open Source Technology Center

Re: [PATCH 04/14] x86 topology: Add CPUID.1F multi-die/package support

2019-02-28 Thread Len Brown
On Tue, Feb 26, 2019 at 2:46 PM Dave Hansen wrote: > > On 2/25/19 10:20 PM, Len Brown wrote: > > -/* leaf 0xb sub-leaf types */ > > +/* extended topology sub-leaf types */ > > #define INVALID_TYPE 0 > > #define SMT_TYPE 1 > > #define CORE_TYPE2 >

[PATCH 04/14] x86 topology: Add CPUID.1F multi-die/package support

2019-02-25 Thread Len Brown
From: Len Brown Some new systems have multiple software-visible die within each package. Update Linux parsing of the Intel CPUID "Extended Topology Leaf" to handle either CPUID.B, or the new CPUID.1F. Add cpuinfo_x86.die_id and cpuinfo_x86.max_dies to store the result. die_id will b

[PATCH 05/14] cpu topology: Export die_id

2019-02-25 Thread Len Brown
From: Len Brown Export die_id in cpu topology, for the benefit of hardware that has multiple-die/package. Signed-off-by: Len Brown Cc: linux-doc@vger.kernel.org --- Documentation/cputopology.txt | 6 ++ arch/x86/include/asm/topology.h | 1 + drivers/base/topology.c | 4

[PATCH 02/14] topolgy: Simplify cputopology.txt formatting and wording

2019-02-25 Thread Len Brown
From: Len Brown Syntax only, no functional or semantic change. Signed-off-by: Len Brown Cc: linux-doc@vger.kernel.org --- Documentation/cputopology.txt | 46 +-- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/Documentation/cputopology.txt b

[PATCH 01/14] x86 topology: Fix doc typo

2019-02-25 Thread Len Brown
From: Len Brown Syntax only, no functional or semantic change. reflect actual cpuinfo_x86 field name: s/logical_id/logical_proc_id/ Signed-off-by: Len Brown Cc: linux-doc@vger.kernel.org --- Documentation/x86/topology.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH 05/11] x86 topology: export die_siblings

2019-02-20 Thread Len Brown
e future proof if/when we add any new levels. the legacy thread_siblings and core_siblings will stick around as aliases: core_threads (thread_siblings) die_threads package_threads (core_siblings) thanks! Len Brown, Intel Open Source Technology Center

Re: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

2019-02-20 Thread Len Brown
re exotic MSR situations in future products -- the first ones are pretty simple -- something called a package-scope-MSR in the SDM today becomes a die-scope-MSR in this generation on a multi-die/package system. It also reflects how many packages appear in sysfs, and this can effect licensing of some kinds of software. thanks, Len Brown, Intel Open Source Technology Center

Re: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

2019-02-19 Thread Len Brown
visible modules and tiles, and they choose to use this mechanism, we can add support for them. But I do not advocate adding code to the kernel "just in case". In contrast, the need to support multi-die/package products as soon as possible is quite clear. thanks, Len Brown, Intel Open Source Technology Center

[PATCH 05/11] x86 topology: export die_siblings

2019-02-18 Thread Len Brown
like core_siblings, except it shows which die are in the same package. This is needed for lscpu(1) to correctly display die topology. Signed-off-by: Len Brown Cc: linux-doc@vger.kernel.org Signed-off-by: Len Brown --- Documentation/cputopology.txt | 10 ++ arch/x86/include/asm/smp.h

[PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

2019-02-18 Thread Len Brown
ID.1F case, the package id's reflect reality, and die_id's become meaningful. Subsequent patches in this series update the kernel to be multi-die aware. In particular, some software needs to know the difference between a die-scope MSR and a package-scope MSR. Signed-off-by: Len

[PATCH 02/11] topolgy: simplify cputopology.txt formatting and wording

2019-02-18 Thread Len Brown
No semantic changes. Signed-off-by: Len Brown Cc: linux-doc@vger.kernel.org Signed-off-by: Len Brown --- Documentation/cputopology.txt | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/Documentation/cputopology.txt b/Documentation

[PATCH 01/11] x86 topology: fix doc typo

2019-02-18 Thread Len Brown
reflect actual cpuinfo_x86 field name: s/logical_id/logical_proc_id/ Signed-off-by: Len Brown Cc: linux-doc@vger.kernel.org Signed-off-by: Len Brown --- Documentation/x86/topology.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/x86/topology.txt b

[PATCH 04/11] cpu topology: export die_id

2019-02-18 Thread Len Brown
to know the actual scope of "package-scope" MSRs. Signed-off-by: Len Brown Cc: linux-doc@vger.kernel.org Signed-off-by: Len Brown --- Documentation/cputopology.txt | 10 -- arch/x86/include/asm/topology.h | 1 + drivers/base/topology.c | 4 include/linux/