RE: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

2019-02-25 Thread Brown, Len
- From: Brice Goglin [mailto:brice.gog...@inria.fr] Sent: Sunday, February 24, 2019 5:04 AM To: Len Brown ; x...@kernel.org Cc: linux-ker...@vger.kernel.org; Brown, Len ; linux-doc@vger.kernel.org; Like Xu Subject: Re: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support Le 19/02

RE: [linux-drivers-review] [PATCH 02/11] topolgy: simplify cputopology.txt formatting and wording

2019-02-19 Thread Brown, Len
>> +if CONFIG_SCHED_BOOK and CONFIG_SCHED_DRAWER are selected, respectively. >> >> CONFIG_SCHED_BOOK and CONFIG_DRAWER are currently only used on s390, >> where >fwiw:CONFIG_SCHED_DRAWER Heh. Seems that every line of update to a .txt files uncovers two lines of existing

RE: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

2019-02-19 Thread Brown, Len
>> @@ -461,7 +463,7 @@ static bool match_llc(struct cpuinfo_x86 *c, struct >> cpuinfo_x86 *o) >>*/ >> static bool match_die(struct cpuinfo_x86 *c, struct cpuinfo_x86 *o) >> { >> -if (c->>phys_proc_id == o->>phys_proc_id) >> +if (c->>cpu_die_id == o->>cpu_die_id) >> ret

RE: [PATCH 05/11] x86 topology: export die_siblings

2019-02-19 Thread Brown, Len
Thanks for the comments, Kan, >> diff --git a/Documentation/cputopology.txt >> b/Documentation/cputopology.txt index 287213b4517b..7dd2ae3df233 >> 100644 >> --- a/Documentation/cputopology.txt >> +++ b/Documentation/cputopology.txt >> @@ -56,6 +56,16 @@ core_siblings_list: >> human-readable