RE: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

[Brown, Len]

>> @@ -461,7 +463,7 @@ static bool match_llc(struct cpuinfo_x86 *c, struct 
>> cpuinfo_x86 *o)
>>    */
>>   static bool match_die(struct cpuinfo_x86 *c, struct cpuinfo_x86 *o)
>>   {
>> -    if (c->>phys_proc_id == o->>phys_proc_id)
>> +    if (c->>cpu_die_id == o->>cpu_die_id)
>>              return true;
>>      return false;
>>   }

> Shouldn't we check the unique_die_id here?
> Die from different package can have the same cpu_die_id.

Good catch.
Updated this hunk as below.

Thanks!
-Len

@@ -461,7 +463,8 @@ static bool match_llc(struct cpuinfo_x86 *c, struct 
cpuinfo_x86 *o)
  */
 static bool match_die(struct cpuinfo_x86 *c, struct cpuinfo_x86 *o)
 {
-       if (c->phys_proc_id == o->phys_proc_id)
+       if ((c->phys_proc_id == o->phys_proc_id) &&
+               (c->cpu_die_id == o->cpu_die_id))
                return true;
        return false;
 }