[PATCH net-next v4 6/6] Documentation/tcp-ao: Add a few lines on tracepoints

2024-06-06 Thread Dmitry Safonov via B4 Relay
From: Dmitry Safonov <0x7f454...@gmail.com> Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> --- Documentation/networking/tcp_ao.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/networking/tcp_ao.rst b/Documentation/networking/tcp_ao.rst index 8a58321acce7..e96e

[PATCH net-next v4 3/6] net/tcp: Move tcp_inbound_hash() from headers

2024-06-06 Thread Dmitry Safonov via B4 Relay
From: Dmitry Safonov <0x7f454...@gmail.com> Two reasons: 1. It's grown up enough 2. In order to not do header spaghetti by including , which is necessary for TCP tracepoints. While at it, unexport and make static tcp_inbound_ao_hash(). Reviewed-by: Eric Dumazet Signed-off-by: Dmitry Safonov

[PATCH net-next v4 5/6] net/tcp: Remove tcp_hash_fail()

2024-06-06 Thread Dmitry Safonov via B4 Relay
From: Dmitry Safonov <0x7f454...@gmail.com> Now there are tracepoints, that cover all functionality of tcp_hash_fail(), but also wire up missing places They are also faster, can be disabled and provide filtering. This potentially may create a regression if a userspace depends on dmesg logs. Finge

[PATCH net-next v4 2/6] net/tcp: Add a helper tcp_ao_hdr_maclen()

2024-06-06 Thread Dmitry Safonov via B4 Relay
From: Dmitry Safonov <0x7f454...@gmail.com> It's going to be used more in TCP-AO tracepoints. Reviewed-by: Eric Dumazet Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> --- include/net/tcp_ao.h | 5 + net/ipv4/tcp_ao.c| 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --g

[PATCH net-next v4 1/6] net/tcp: Use static_branch_tcp_{md5,ao} to drop ifdefs

2024-06-06 Thread Dmitry Safonov via B4 Relay
From: Dmitry Safonov <0x7f454...@gmail.com> It's possible to clean-up some ifdefs by hiding that tcp_{md5,ao}_needed static branch is defined and compiled only under related configs, since commit 4c8530dc7d7d ("net/tcp: Only produce AO/MD5 logs if there are any keys"). Reviewed-by: Eric Dumazet

[PATCH net-next v4 4/6] net/tcp: Add tcp-md5 and tcp-ao tracepoints

2024-06-06 Thread Dmitry Safonov via B4 Relay
From: Dmitry Safonov <0x7f454...@gmail.com> Instead of forcing userspace to parse dmesg (that's what currently is happening, at least in codebase of my current company), provide a better way, that can be enabled/disabled in runtime. Currently, there are already tcp events, add hashing related one

[PATCH net-next v4 0/6] net/tcp: TCP-AO and TCP-MD5 tracepoints

2024-06-06 Thread Dmitry Safonov via B4 Relay
Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> --- Changes in v4: - Fix the build for CONFIG_TCP_MD5SIG=n (Matthieu Baerts, netdev dashboard) - Link to v3: https://lore.kernel.org/r/20240606-tcp_ao-tracepoints-v3-0-13621988c...@gmail.com Changes in v3: - Unexported tcp_inbound_a

Re: [PATCH v5 2/2] proc: restrict /proc/pid/mem

2024-06-06 Thread Kees Cook
On Wed, Jun 05, 2024 at 07:49:31PM +0300, Adrian Ratiu wrote: > + proc_mem.restrict_foll_force= [KNL] > + Format: {all | ptracer} > + Restricts the use of the FOLL_FORCE flag for > /proc/*/mem access. > + If restricted, the FOLL_FORCE

Re: [PATCH net-next v3 3/6] net/tcp: Move tcp_inbound_hash() from headers

2024-06-06 Thread Dmitry Safonov
Hi Matthieu, [re-sending as replying from mobile phone never works in plain text] On Thu, 6 Jun 2024 at 10:12, Matthieu Baerts wrote: > > Hi Dmitry, > > On 06/06/2024 02:58, Dmitry Safonov via B4 Relay wrote: > > From: Dmitry Safonov <0x7f454...@gmail.com> > > > > Two reasons: > > 1. It's grown

Re: [PATCH net-next v3 3/6] net/tcp: Move tcp_inbound_hash() from headers

2024-06-06 Thread Matthieu Baerts
Hi Dmitry, On 06/06/2024 02:58, Dmitry Safonov via B4 Relay wrote: > From: Dmitry Safonov <0x7f454...@gmail.com> > > Two reasons: > 1. It's grown up enough > 2. In order to not do header spaghetti by including >, which is necessary for TCP tracepoints. > > While at it, unexport and make stat

Re: [PATCH 2/2] docs: stable-kernel-rules: remind reader about DCO

2024-06-06 Thread Paul Barker
On 06/06/2024 07:43, Shung-Hsi Yu wrote: > When sending patch authored by someone else to stable, it is quite easy for > the sender to forget adding the Developer's Certification of Origin (DCO, > i.e. Signed-off-by). Mention DCO explicilty so senders are less likely to s/explicilty/explicitly/ >

Re: [PATCH net-next v3 3/6] net/tcp: Move tcp_inbound_hash() from headers

2024-06-06 Thread Eric Dumazet
On Thu, Jun 6, 2024 at 2:58 AM Dmitry Safonov via B4 Relay wrote: > > From: Dmitry Safonov <0x7f454...@gmail.com> > > Two reasons: > 1. It's grown up enough > 2. In order to not do header spaghetti by including >, which is necessary for TCP tracepoints. > > While at it, unexport and make stati

Re: [PATCH net-next v3 2/6] net/tcp: Add a helper tcp_ao_hdr_maclen()

2024-06-06 Thread Eric Dumazet
On Thu, Jun 6, 2024 at 2:58 AM Dmitry Safonov via B4 Relay wrote: > > From: Dmitry Safonov <0x7f454...@gmail.com> > > It's going to be used more in TCP-AO tracepoints. > > Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> Reviewed-by: Eric Dumazet

Re: [PATCH 1/2] docs: stable-kernel-rules: provide example of specifying target series

2024-06-06 Thread Paul Barker
On 06/06/2024 07:43, Shung-Hsi Yu wrote: > Provide a concrete example of how to specify what stable series should > be targeted for change inclusion. Looking around on the stable mailing > list this seems like a common practice already, so let's mention that in > the documentation as well (but word