-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 12/16/2011 08:57 AM, Linus Walleij wrote:
> On Fri, Dec 16, 2011 at 6:56 AM, Daniel Lezcano
> wrote:
>> [Me]
>>> what happens if you just reactivate CPUfreq then use menuconfig
>>> to go into drivers/ directly you
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
the kernel does not compile when
CONFIG_CLKSRC_DBX500_PRCMU_SCHED_CLOCK is set.
it fails with :
CHK include/linux/version.h
CHK include/generated/utsrelease.h
make[1]: `include/generated/mach-types.h' is up to date.
CALLscrip
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 01/02/2012 01:59 PM, Linus Walleij wrote:
> On Mon, Jan 2, 2012 at 12:49 PM, Daniel Lezcano
> wrote:
>
>> the kernel does not compile when
>> CONFIG_CLKSRC_DBX500_PRCMU_SCHED_CLOCK is set.
>>
>> it fails with :
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 01/02/2012 02:55 PM, Daniel Lezcano wrote:
>
> On 01/02/2012 01:59 PM, Linus Walleij wrote:
>> On Mon, Jan 2, 2012 at 12:49 PM, Daniel Lezcano
>> wrote:
>
>>> the kernel does not compile when
>>> CONFIG
Hi Linus,
While looking at the drivers/mfd/db8500-prcmu.c file I noticed:
595 /* Grab the HW semaphore. */
596 while ((readl(PRCM_SEM) & PRCM_SEM_PRCM_SEM) != 0)
597 cpu_relax();
I was wondering why is cpu_relax needed here as readl does a memory
barrier ?
On 02/01/2012 12:28 PM, Dmitry Antipov wrote:
I'm writing a kernel module which creates a substantial amount of
kernel threads. After dropping the real stuff, the module skeleton is:
#include
#include
#include
#include
#include
#include
MODULE_LICENSE("GPL");
static int nrthreads = 128;
On 02/01/2012 01:08 PM, Dmitry Antipov wrote:
On 02/01/2012 03:49 PM, Daniel Lezcano wrote:
IMO, you have a race condition with nrunning. What guarantee do you
have atomic_dec_and_test is called after atomic_inc ?
Nothing (but I believe ~1s is pretty enough for the kernel thread to get
woken
On 02/01/2012 09:17 PM, Linus Walleij wrote:
On Wed, Feb 1, 2012 at 12:34 PM, Daniel Lezcano
wrote:
Hi Linus,
While looking at the drivers/mfd/db8500-prcmu.c file I noticed:
595 /* Grab the HW semaphore. */
596 while ((readl(PRCM_SEM)& PRCM_SEM_PRCM_SEM) != 0)
This patch allows to decouple and recouple the gic from the PRCMU.
This is needed to put the A9 core in retention mode with the cpuidle
driver.
Signed-off-by: Daniel Lezcano
---
drivers/mfd/db8500-prcmu.c | 42 ++
include/linux/mfd/db8500-prcmu.h
recouple the gic from the PRCMU.
This is needed to put the A9 core in retention mode with the cpuidle
driver.
Signed-off-by: Daniel Lezcano
---
drivers/mfd/db8500-prcmu.c | 42 ++
include/linux/mfd/db8500-prcmu.h | 2 +
include/linux/mfd/dbx500-prcmu.h | 16 +++
On 02/06/2012 06:37 PM, Linus Walleij wrote:
On Mon, Feb 6, 2012 at 3:10 PM, Daniel Lezcano
wrote:
On 02/06/2012 10:19 AM, Rickard Andersson wrote:
- there is no reason to place these functions inside the db8500-prcmu.c
file. There is so much stuff in the PRCMU register base so we can not
On 02/07/2012 09:39 AM, Rickard Andersson wrote:
On 02/06/2012 03:10 PM, Daniel Lezcano wrote:
On 02/06/2012 10:19 AM, Rickard Andersson wrote:
Hi!
Our comments:
Thanks Rickard and Jonas for your comments.
- function names don't match commit comment disable/enable vs
recouple/dec
On 02/07/2012 10:57 AM, Rickard Andersson wrote:
On 02/07/2012 10:22 AM, Daniel Lezcano wrote:
On 02/07/2012 09:39 AM, Rickard Andersson wrote:
On 02/06/2012 03:10 PM, Daniel Lezcano wrote:
On 02/06/2012 10:19 AM, Rickard Andersson wrote:
Hi!
Our comments:
Thanks Rickard and Jonas for your
This patch allows to decouple and recouple the gic from the PRCMU.
This is needed to put the A9 core in retention mode with the cpuidle
driver.
Signed-off-by: Daniel Lezcano
---
drivers/mfd/db8500-prcmu.c | 29 +
include/linux/mfd/db8500-prcmu.h |2
ntion mode with the cpuidle
driver.
Signed-off-by: Daniel Lezcano
---
drivers/mfd/db8500-prcmu.c | 29 +
include/linux/mfd/db8500-prcmu.h | 2 ++
include/linux/mfd/dbx500-prcmu.h | 16
3 files changed, 47 insertions(+), 0 deletions(-)
diff --git a/drivers/
On 02/09/2012 01:19 PM, Rickard Andersson wrote:
On 02/09/2012 12:25 PM, Daniel Lezcano wrote:
On 02/09/2012 11:52 AM, Rickard Andersson wrote:
Hi Daniel!
Please see my embedded comments.
Also should we not keep the functions in pm.c file? I think Linus W
advised us not to move stuff around
This patch allows to decouple and recouple the gic from the PRCMU.
This is needed to put the A9 core in retention mode with the cpuidle
driver.
Signed-off-by: Daniel Lezcano
---
drivers/mfd/db8500-prcmu.c | 32
include/linux/mfd/db8500-prcmu.h |2
On 02/10/2012 11:22 AM, Daniel Lezcano wrote:
This patch allows to decouple and recouple the gic from the PRCMU.
This is needed to put the A9 core in retention mode with the cpuidle
driver.
Signed-off-by: Daniel Lezcano
---
Linus,
I think I addressed all the concerns, is it possible to merge
On 02/13/2012 08:43 PM, Linus Walleij wrote:
On Fri, Feb 10, 2012 at 11:38 AM, Daniel Lezcano
wrote:
I think I addressed all the concerns, is it possible to merge this patch ?
As detailed in another letter: does this build on top of the patch series
"DB8500 PRCMU update" that was
mode.
Signed-off-by: Daniel Lezcano
---
arch/arm/common/gic.c | 37 +++
arch/arm/include/asm/hardware/gic.h |2 +-
2 files changed, 38 insertions(+), 1 deletions(-)
diff --git a/arch/arm/common/gic.c b/arch/arm/common/gic.c
index aa52699..2528094
On 02/24/2012 07:27 PM, Russell King - ARM Linux wrote:
On Fri, Feb 24, 2012 at 02:45:48PM +0100, Daniel Lezcano wrote:
The following patch checks if there are pending interrupts on the gic.
This function is needed for example for the ux500 cpuidle driver.
When the A9 cores and the gic are
On 02/24/2012 05:49 PM, Rob Herring wrote:
On 02/24/2012 07:45 AM, Daniel Lezcano wrote:
The following patch checks if there are pending interrupts on the gic.
This function is needed for example for the ux500 cpuidle driver.
When the A9 cores and the gic are decoupled from the PRCMU, the idle
On 03/01/2012 12:39 PM, Samuel Ortiz wrote:
Hi Daniel,
On Tue, Feb 28, 2012 at 10:46:05PM +0100, daniel.lezc...@linaro.org wrote:
From: Daniel Lezcano
I missed in my previous patch the A9_MASK_REQ[_MASK] were
already defined. Let's remove the duplicate definitions.
The PRCMU_GIC_DELAY
arwar
Reviewed-by: Daniel Lezcano
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
Hi,
I am not succeeding to make ethernet to work on a 3.3-rc6 for the snowball.
I noticed the same problem occured a few versions ago and was fixed [1].
But it seems some modification around the fix location was made for the
3.3 and perhaps resulted on a new regression.
Was this problem alre
On 03/17/2012 11:53 PM, Daniel Lezcano wrote:
I also noticed the traces:
[5.231567] smsc911x: Driver version 2008-10-21
[5.236236] smsc911x smsc911x.0: Failed to get supply 'vdd33a': -19
[5.242523] smsc911x smsc911x.0: (unregistered net_device): couldn't
get regulat
On 03/19/2012 01:39 PM, Lee Jones wrote:
On 18/03/12 14:35, Daniel Lezcano wrote:
On 03/17/2012 11:53 PM, Daniel Lezcano wrote:
I also noticed the traces:
[5.231567] smsc911x: Driver version 2008-10-21
[5.236236] smsc911x smsc911x.0: Failed to get supply 'vdd33a': -19
[
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/cpuidle44xx.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle44xx.c
b/arch/arm/mach-omap2/cpuidle44xx.c
index 0455858..254f97b 100644
--- a/arch/arm/mach-omap2/cpuidle44xx.c
+++ b/arch
This patchset is a proposition to improve a bit the code.
The changes are code cleanup and does not change the behavior of the
driver itself.
A couple a things call my intention. Why the cpuidle device is set for cpu0 only
and why the WFI is not used ?
Daniel Lezcano (7):
ARM: OMAP4: cpuidle
We initialized it at compile time, no need to do that at boot
time.
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/cpuidle44xx.c | 26 +-
1 files changed, 1 insertions(+), 25 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle44xx.c
b/arch/arm/mach-omap2
We do not longer need this table as we defined the values
in the driver states.
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/cpuidle44xx.c | 11 +--
1 files changed, 1 insertions(+), 10 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle44xx.c
b/arch/arm/mach-omap2
plfies the code.
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/cpuidle44xx.c | 17 +
1 files changed, 5 insertions(+), 12 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle44xx.c
b/arch/arm/mach-omap2/cpuidle44xx.c
index e14cd56..cb91d1f 100644
--- a/arch/arm/mach-omap
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/cpuidle44xx.c | 19 ++-
1 files changed, 18 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle44xx.c
b/arch/arm/mach-omap2/cpuidle44xx.c
index 254f97b..e14cd56 100644
--- a/arch/arm/mach-omap2
The 'valid' field is never used in the code, let's remove it.
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/cpuidle44xx.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle44xx.c
b/arch/arm/mach-omap2/cpuidle44xx.
The cpuidle API allows to declare statically the states in the driver
structure. Let's use it.
We do no longer need the fill_cstate function called at runtime and
by the way adding more instructions at boot time.
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/cpuidle44xx.c |
On 03/21/2012 10:41 AM, Shilimkar, Santosh wrote:
On Wed, Mar 21, 2012 at 2:57 PM, Daniel Lezcano
wrote:
The 'valid' field is never used in the code, let's remove it.
Signed-off-by: Daniel Lezcano
---
It is used during the registration. This field has been very useful for
deb
On 03/21/2012 10:36 AM, Shilimkar, Santosh wrote:
On Wed, Mar 21, 2012 at 2:57 PM, Daniel Lezcano
wrote:
This patchset is a proposition to improve a bit the code.
The changes are code cleanup and does not change the behavior of the
driver itself.
Thanks. Will have a look at your series
On 03/21/2012 10:56 AM, Santosh Shilimkar wrote:
On Wednesday 21 March 2012 03:21 PM, Daniel Lezcano wrote:
On 03/21/2012 10:36 AM, Shilimkar, Santosh wrote:
On Wed, Mar 21, 2012 at 2:57 PM, Daniel Lezcano
wrote:
This patchset is a proposition to improve a bit the code.
The changes are
On 03/21/2012 11:07 AM, Santosh Shilimkar wrote:
Daniel,
On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote:
This patchset is a proposition to improve a bit the code.
The changes are code cleanup and does not change the behavior of the
driver itself.
A couple a things call my intention
On 03/21/2012 11:49 AM, Shilimkar, Santosh wrote:
On Wed, Mar 21, 2012 at 4:13 PM, Daniel Lezcano
wrote:
On 03/21/2012 10:56 AM, Santosh Shilimkar wrote:
On Wednesday 21 March 2012 03:21 PM, Daniel Lezcano wrote:
On 03/21/2012 10:36 AM, Shilimkar, Santosh wrote:
On Wed, Mar 21, 2012 at
On 03/21/2012 02:31 PM, Jean Pihet wrote:
On Wed, Mar 21, 2012 at 10:27 AM, Daniel Lezcano
wrote:
The cpuidle API allows to declare statically the states in the driver
structure. Let's use it.
We do no longer need the fill_cstate function called at runtime and
by the way adding
On 03/21/2012 02:19 PM, Jean Pihet wrote:
Hi Santosh, Daniel,
On Wed, Mar 21, 2012 at 11:07 AM, Santosh Shilimkar
wrote:
Daniel,
On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote:
This patchset is a proposition to improve a bit the code.
The changes are code cleanup and does not
On 03/21/2012 02:43 PM, Jean Pihet wrote:
On Wed, Mar 21, 2012 at 11:07 AM, Santosh Shilimkar
wrote:
Daniel,
On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote:
This patchset is a proposition to improve a bit the code.
The changes are code cleanup and does not change the behavior of
On 03/21/2012 02:43 PM, Jean Pihet wrote:
On Wed, Mar 21, 2012 at 11:07 AM, Santosh Shilimkar
wrote:
Daniel,
On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote:
This patchset is a proposition to improve a bit the code.
The changes are code cleanup and does not change the behavior of
On 03/21/2012 10:54 PM, Kevin Hilman wrote:
Daniel Lezcano writes:
On 03/21/2012 02:43 PM, Jean Pihet wrote:
On Wed, Mar 21, 2012 at 11:07 AM, Santosh Shilimkar
wrote:
Daniel,
On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote:
This patchset is a proposition to improve a bit the
On 03/22/2012 07:36 PM, Kevin Hilman wrote:
Daniel Lezcano writes:
On 03/21/2012 10:54 PM, Kevin Hilman wrote:
Daniel Lezcano writes:
On 03/21/2012 02:43 PM, Jean Pihet wrote:
On Wed, Mar 21, 2012 at 11:07 AM, Santosh Shilimkar
wrote:
Daniel,
On Wednesday 21 March 2012 02:57 PM
This variable is only used in the pm-debug.c file.
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/pm-debug.c |2 +-
arch/arm/mach-omap2/pm.h | 30 --
2 files changed, 13 insertions(+), 19 deletions(-)
diff --git a/arch/arm/mach-omap2/pm-debug.c b
Use the new cpuidle API and define in the driver the states.
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/cpuidle34xx.c | 85 +---
1 files changed, 59 insertions(+), 26 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle34xx.c
b/arch/arm/mach-omap2
lose the values which probably took time to be
measured, the table is converted into a comment with an array
description.
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/board-rx51.c | 38 +---
arch/arm/mach-omap2/cpuidle34xx.c | 17
As we will be able to remove C-states from userspace with the sysfs
API, this function is no longer needed. We remove it and that simplifies
the code for more consolidation.
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/cpuidle34xx.c | 85 +
1 files
With the previous changes all the states are valid, except
the last state which can be handled by decreasing the number
of states.
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/cpuidle34xx.c |6 +-
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/cpuidle34xx.c | 31 ++-
1 files changed, 30 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle34xx.c
b/arch/arm/mach-omap2/cpuidle34xx.c
index 877a7e1..34e1e34 100644
--- a/arch/arm/mach
We do not longer need the ''cpuidle_params_table' array as
we defined the states in the driver and we checked they are
all valid.
We also remove the structure definition as it is no longer used.
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/cpuid
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/Makefile | 11 +++
arch/arm/mach-omap2/cpuidle34xx.c |8
arch/arm/mach-omap2/cpuidle44xx.c |8
arch/arm/mach-omap2/pm.h | 17 +++--
4 files changed, 22 insertions(+), 22
is initialized statically, let's remove the initialization at
startup too.
Also, that simplfies the code.
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/cpuidle34xx.c | 60 -
1 files changed, 6 insertions(+), 54 deletions(-)
diff --git a
On 03/23/2012 01:22 PM, Jean Pihet wrote:
On Fri, Mar 23, 2012 at 10:26 AM, Daniel Lezcano
wrote:
This variable is only used in the pm-debug.c file.
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/pm-debug.c |2 +-
arch/arm/mach-omap2/pm.h | 30
On 03/23/2012 01:35 PM, Jean Pihet wrote:
On Fri, Mar 23, 2012 at 10:26 AM, Daniel Lezcano
wrote:
Use the new cpuidle API and define in the driver the states.
Signed-off-by: Daniel Lezcano
---
[ ... ]
/*
* Erratum i583: implementation for ES rev< Es1.2 on 3630.
ned-off-by: Daniel Lezcano
Acked-by: Deepthi Dharwar
Tested-by: Deepthi Dharwar
---
include/linux/cpuidle.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/cpuidle.h b/include/linux/cpuidle.h
index ca4e498..f7f1d90 100644
--- a/include/linux/cpuidle.h
+++
As far as I can see, this field is never used in the code.
Signed-off-by: Daniel Lezcano
---
include/linux/cpuidle.h |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/include/linux/cpuidle.h b/include/linux/cpuidle.h
index f7f1d90..f3ebbba 100644
--- a/include/linux
If the state_count is not initialized for the device use
the driver's state count as the default. That will prevent
to add it manually in the cpuidle driver initialization
routine and will save us from duplicate line of code.
Signed-off-by: Daniel Lezcano
---
drivers/cpuidle/cpuidle.c |
on routines,
we keep 'cpuidle_register_driver' and 'cpuidle_register_device' as low
level initialization routines to do some specific operations on the
cpuidle devices.
Signed-off-by: Daniel Lezcano
---
drivers/cpuidle/cpuidle.c | 34 ++
inclu
On 03/30/2012 01:25 PM, Srivatsa S. Bhat wrote:
On 03/30/2012 04:18 PM, Daniel Lezcano wrote:
The usual cpuidle initialization routines are to register the
driver, then register a cpuidle device per cpu.
With the device's state count default initialization with the
driver's state
On 03/30/2012 01:59 PM, Srivatsa S. Bhat wrote:
On 03/30/2012 05:15 PM, Daniel Lezcano wrote:
On 03/30/2012 01:25 PM, Srivatsa S. Bhat wrote:
On 03/30/2012 04:18 PM, Daniel Lezcano wrote:
The usual cpuidle initialization routines are to register the
driver, then register a cpuidle device
on routines,
we keep 'cpuidle_register_driver' and 'cpuidle_register_device' as low
level initialization routines to do some specific operations on the
cpuidle devices.
Signed-off-by: Daniel Lezcano
---
drivers/cpuidle/cpuidle.c | 42 ++
On 04/02/2012 03:21 PM, Srivatsa S. Bhat wrote:
On 04/02/2012 06:18 PM, Daniel Lezcano wrote:
The usual cpuidle initialization routines are to register the
driver, then register a cpuidle device per cpu.
With the device's state count default initialization with the
driver's state
ster_device' as low
level initialization routines to do some specific operations on the
cpuidle devices.
Signed-off-by: Daniel Lezcano
---
drivers/cpuidle/cpuidle.c | 42 ++
include/linux/cpuidle.h |3 +++
2 files changed, 45 insertions(+), 0 deletions(-)
We do not longer need this table as we defined the values
in the driver states.
Signed-off-by: Daniel Lezcano
Reviewed-by: Jean Pihet
Reviewed-by: Santosh Shilimkar
---
arch/arm/mach-omap2/cpuidle44xx.c | 11 +--
1 files changed, 1 insertions(+), 10 deletions(-)
diff --git a/arch
We initialized it at compile time, no need to do that at boot
time.
Signed-off-by: Daniel Lezcano
Reviewed-by: Jean Pihet
Reviewed-by: Santosh Shilimkar
---
arch/arm/mach-omap2/cpuidle44xx.c | 26 +-
1 files changed, 1 insertions(+), 25 deletions(-)
diff --git a
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/cpuidle34xx.c | 31 ++-
1 files changed, 30 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle34xx.c
b/arch/arm/mach-omap2/cpuidle34xx.c
index cdf1b8f..332b636 100644
--- a/arch/arm/mach
We do not longer need the ''cpuidle_params_table' array as
we defined the states in the driver and we checked they are
all valid.
We also remove the structure definition as it is no longer used.
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/cpuid
Signed-off-by: Daniel Lezcano
Reviewed-by: Jean Pihet
Reviewed-by: Santosh Shilimkar
---
arch/arm/mach-omap2/cpuidle44xx.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle44xx.c
b/arch/arm/mach-omap2/cpuidle44xx.c
index cdd7932..fb0f76e
Signed-off-by: Daniel Lezcano
Reviewed-by: Jean Pihet
Reviewed-by: Santosh Shilimkar
---
arch/arm/mach-omap2/cpuidle44xx.c | 19 ++-
1 files changed, 18 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle44xx.c
b/arch/arm/mach-omap2/cpuidle44xx.c
index
The cpuidle API allows to declare statically the states in the driver
structure. Let's use it.
We do no longer need the fill_cstate function called at runtime and
by the way adding more instructions at boot time.
Signed-off-by: Daniel Lezcano
Reviewed-by: Jean Pihet
Reviewed-by: Sa
Use the new cpuidle API and define in the driver the states.
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/cpuidle34xx.c | 86 +---
1 files changed, 60 insertions(+), 26 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle34xx.c
b/arch/arm/mach-omap2
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/cpuidle34xx.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle34xx.c
b/arch/arm/mach-omap2/cpuidle34xx.c
index 35a1471..f54e6ae 100644
--- a/arch/arm/mach-omap2/cpuidle34xx.c
+++ b/arch
is initialized statically, let's remove the initialization at
startup too.
Also, that simplfies the code.
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/cpuidle34xx.c | 65
1 files changed, 8 insertions(+), 57 deletions(-)
diff --git a/arch/arm/mach
This patchset makes some cleanup on these cpuidle drivers
and consolidate the code across both architecture.
Tested on OMAP3 (igepV2).
Partially tested on OMAP4 (pandaboard), without offlining the cpu1.
Daniel Lezcano (17):
ARM: OMAP4: cpuidle - Remove unused valid field
ARM: OMAP4: cpuidle
plfies the code.
Signed-off-by: Daniel Lezcano
Reviewed-by: Jean Pihet
Reviewed-by: Santosh Shilimkar
---
arch/arm/mach-omap2/cpuidle44xx.c | 15 ---
1 files changed, 4 insertions(+), 11 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle44xx.c
b/arch/arm/mach-omap2/cpuidle44xx.
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/Makefile | 11 +++
arch/arm/mach-omap2/cpuidle34xx.c |8
arch/arm/mach-omap2/cpuidle44xx.c |8
arch/arm/mach-omap2/pm.h | 17 +++--
4 files changed, 22 insertions(+), 22
and check the powerdomain lookup is successful.
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/cpuidle34xx.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle34xx.c
b/arch/arm/mach-omap2/cpuidle34xx.c
index 882d349..413aac4 100644
The 'valid' field is never used in the code, let's remove it.
Signed-off-by: Daniel Lezcano
Reviewed-by: Jean Pihet
Reviewed-by: Santosh Shilimkar
---
arch/arm/mach-omap2/cpuidle44xx.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch
lose the values which probably took time to be
measured, the table is converted into a comment with an array
description.
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/board-rx51.c | 38 +---
arch/arm/mach-omap2/cpuidle34xx.c | 17
With the previous changes all the states are valid, except
the last state which can be handled by decreasing the number
of states.
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/cpuidle34xx.c | 12 +++-
1 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/arch/arm
Simplify the indentation by removing the useless 'else' statement.
Remove the first loop for the 'idx' search as we have it already
with the 'index' passed as parameter.
Signed-off-by: Daniel Lezcano
---
arch/arm/mach-omap2/cpuidle34xx.c | 53 +--
On 04/04/2012 08:40 PM, Kevin Hilman wrote:
Hi Daniel,
Daniel Lezcano writes:
This patchset makes some cleanup on these cpuidle drivers
and consolidate the code across both architecture.
Tested on OMAP3 (igepV2).
Partially tested on OMAP4 (pandaboard), without offlining the cpu1.
Any
On 04/04/2012 06:05 PM, Jean Pihet wrote:
Daniel,
On Wed, Apr 4, 2012 at 11:42 AM, Daniel Lezcano
wrote:
This patchset makes some cleanup on these cpuidle drivers
and consolidate the code across both architecture.
Tested on OMAP3 (igepV2).
Partially tested on OMAP4 (pandaboard), without
Signed-off-by: Daniel Lezcano
Reviewed-by: Jean Pihet
---
arch/arm/mach-omap2/cpuidle34xx.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle34xx.c
b/arch/arm/mach-omap2/cpuidle34xx.c
index 35a1471..f54e6ae 100644
--- a/arch/arm/mach-omap2
Signed-off-by: Daniel Lezcano
Reviewed-by: Jean Pihet
Reviewed-by: Santosh Shilimkar
---
arch/arm/mach-omap2/cpuidle44xx.c | 19 ++-
1 files changed, 18 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle44xx.c
b/arch/arm/mach-omap2/cpuidle44xx.c
index
We do not longer need this table as we defined the values
in the driver states.
Signed-off-by: Daniel Lezcano
Reviewed-by: Jean Pihet
Reviewed-by: Santosh Shilimkar
---
arch/arm/mach-omap2/cpuidle44xx.c | 11 +--
1 files changed, 1 insertions(+), 10 deletions(-)
diff --git a/arch
The 'valid' field is never used in the code, let's remove it.
Signed-off-by: Daniel Lezcano
Reviewed-by: Jean Pihet
Reviewed-by: Santosh Shilimkar
---
arch/arm/mach-omap2/cpuidle44xx.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch
and check the powerdomain lookup is successful.
Signed-off-by: Daniel Lezcano
Reviewed-by: Jean Pihet
---
arch/arm/mach-omap2/cpuidle34xx.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle34xx.c
b/arch/arm/mach-omap2/cpuidle34xx.c
index
This patchset makes some cleanup on these cpuidle drivers
and consolidate the code across both architecture.
Tested on OMAP3 (igepV2).
Partially tested on OMAP4 (pandaboard), without offlining the cpu1.
V2 : Fixed a couple of typos in the patch description
V1 : Initial Post
Daniel Lezcano (17
plfies the code.
Signed-off-by: Daniel Lezcano
Reviewed-by: Jean Pihet
Reviewed-by: Santosh Shilimkar
---
arch/arm/mach-omap2/cpuidle44xx.c | 15 ---
1 files changed, 4 insertions(+), 11 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle44xx.c
b/arch/arm/mach-omap2/cpuidle44xx.
Signed-off-by: Daniel Lezcano
Reviewed-by: Jean Pihet
---
arch/arm/mach-omap2/Makefile | 11 +++
arch/arm/mach-omap2/cpuidle34xx.c |8
arch/arm/mach-omap2/cpuidle44xx.c |8
arch/arm/mach-omap2/pm.h | 17 +++--
4 files changed, 22
With the previous changes all the states are valid, except
the last state which can be handled by decreasing the number
of states.
Signed-off-by: Daniel Lezcano
Reviewed-by: Jean Pihet
---
arch/arm/mach-omap2/cpuidle34xx.c | 12 +++-
1 files changed, 3 insertions(+), 9 deletions
Simplify the indentation by removing the useless 'else' statement.
Remove the first loop for the 'idx' search as we have it already
with the 'index' passed as parameter.
Signed-off-by: Daniel Lezcano
Reviewed-by: Jean Pihet
---
arch/arm/m
The cpuidle API allows to declare statically the states in the driver
structure. Let's use it.
We do no longer need the fill_cstate function called at runtime and
by the way adding more instructions at boot time.
Signed-off-by: Daniel Lezcano
Reviewed-by: Jean Pihet
Reviewed-by: Sa
is initialized statically, let's remove the initialization at
startup too.
Also, that simplfies the code.
Signed-off-by: Daniel Lezcano
Reviewed-by: Jean Pihet
---
arch/arm/mach-omap2/cpuidle34xx.c | 65
1 files changed, 8 insertions(+), 57 deletions(-)
d
Signed-off-by: Daniel Lezcano
Reviewed-by: Jean Pihet
---
arch/arm/mach-omap2/cpuidle34xx.c | 31 ++-
1 files changed, 30 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle34xx.c
b/arch/arm/mach-omap2/cpuidle34xx.c
index cdf1b8f..332b636
We do not longer need the ''cpuidle_params_table' array as
we defined the states in the driver and we checked they are
all valid.
We also remove the structure definition as it is no longer used.
Signed-off-by: Daniel Lezcano
Reviewed-by: Jean Pihet
---
arch/arm/mach-omap2/cpuid
1 - 100 of 720 matches
Mail list logo
