On 30 October 2012 12:15, Viresh Kumar wrote:
> And so, if we select NET_DSA from these tagging drivers, then only slave.c
> will
> get compiled. Otherwise slave.c dsa.c dsa_core.c wouldn't be compiled and so
> no warnings.
If my above explanation/assumption is correct, then please review follow
On 10/30/2012 08:31 AM, Viresh Kumar wrote:
> On 30 October 2012 12:15, Viresh Kumar wrote:
>> And so, if we select NET_DSA from these tagging drivers, then only slave.c
>> will
>> get compiled. Otherwise slave.c dsa.c dsa_core.c wouldn't be compiled and so
>> no warnings.
>
> If my above explan
On 30 October 2012 13:23, Daniel Lezcano wrote:
>> From: Viresh Kumar
>> config NET_DSA_TAG_DSA
>> - bool
>> + bool "Original DSA packet tagging format"
>> + select NET_DSt
>
> typo NET_DSA
Unbelievable mistake :(
Will fix it after some reviews now :)
--
viresh
_
On 26 October 2012 12:39, hongbo.zhang wrote:
> From: "hongbo.zhang"
>
> Problem of using this list is that the cpufreq_get_max_state callback will be
> called when register cooling device by thermal_cooling_device_register, but
> this list isn't ready at this moment. What's more, there is no nee
On 30 October 2012 09:03, Amit Kachhap wrote:
> On 26 October 2012 12:39, hongbo.zhang wrote:
>> From: "hongbo.zhang"
>>
>> Problem of using this list is that the cpufreq_get_max_state callback will be
>> called when register cooling device by thermal_cooling_device_register, but
>> this list is
On 29 October 2012 12:42, Amit Kachhap wrote:
> On 24 October 2012 17:28, hongbo.zhang wrote:
>> From: "hongbo.zhang"
>>
>> The cpufreq works as a cooling device, so the cooling layer should check if
>> the
>> cpufreq driver is initialized or not.
>>
>> Signed-off-by: hongbo.zhang
>> ---
>> d
On 10/30/2012 08:55 AM, Viresh Kumar wrote:
> On 30 October 2012 13:23, Daniel Lezcano wrote:
>>> From: Viresh Kumar
>
>>> config NET_DSA_TAG_DSA
>>> - bool
>>> + bool "Original DSA packet tagging format"
>>> + select NET_DSt
>>
>> typo NET_DSA
>
> Unbelievable mistake :(
>
> Will
On 30 October 2012 14:30, Daniel Lezcano wrote:
> It is very curious if we disable all the configs option, a slave
> creation raise a BUG (cf. dsa_slave_create). IIUC, booting with NET_DSA
> enabled and none of the NET_DSA_TAG* enabled will raise a BUG in the
> probe function, right ?
>
> Maybe we
On 10/30/2012 10:03 AM, Viresh Kumar wrote:
> On 30 October 2012 14:30, Daniel Lezcano wrote:
>> It is very curious if we disable all the configs option, a slave
>> creation raise a BUG (cf. dsa_slave_create). IIUC, booting with NET_DSA
>> enabled and none of the NET_DSA_TAG* enabled will raise a
On 30 October 2012 14:56, Daniel Lezcano wrote:
> Well, it is the same here, no ? Except, it is up to the user to disable
> the option.
I didn't wanted to add code like this:
>> + select NET_DSA_TAG_DSA if (!NET_DSA_TAG_EDSA &&
>> !NET_DSA_TAG_TRAILER)
Why should we select NET_DSA_TAG_DSA
On 10/30/2012 10:45 AM, Viresh Kumar wrote:
> On 30 October 2012 14:56, Daniel Lezcano wrote:
>> Well, it is the same here, no ? Except, it is up to the user to disable
>> the option.
>
> I didn't wanted to add code like this:
>
>>> + select NET_DSA_TAG_DSA if (!NET_DSA_TAG_EDSA &&
>>> !NE
From: "hongbo.zhang"
In the while loop for counting cpu frequencies, if table[i].frequency equals
CPUFREQ_ENTRY_INVALID, index i won't be increased, so this leads to an endless
loop, what's more the index i cannot be referred as cpu frequencies number if
there is CPUFREQ_ENTRY_INVALID case.
Sign
From: "hongbo.zhang"
The curly bracket should be aligned with corresponding if else statements.
Signed-off-by: hongbo.zhang
Reviewed-by: Viresh Kumar
---
drivers/thermal/cpu_cooling.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/cpu_cooling.c b/drivers/t
From: "hongbo.zhang"
This patch adds device tree properties for ST-Ericsson DB8500 thermal driver,
also adds the platform data to support the old fashion.
Signed-off-by: hongbo.zhang
---
arch/arm/boot/dts/dbx5x0.dtsi | 14 +
arch/arm/boot/dts/snowball.dts | 31
From: "hongbo.zhang"
Problem of using this list is that the cpufreq_get_max_state callback will be
called when register cooling device by thermal_cooling_device_register, but
this list isn't ready at this moment. What's more, there is no need to maintain
such a list, we can get cpufreq_cooling_de
From: "hongbo.zhang"
V2->V3 Changes:
1. Moved the previous "[PATCH V2 2/6] Thermal: make sure cpufreq cooling
register after cpufreq driver" from generic cpu cooling layer to ST-Ericsson
driver, thus only 5 patches in total in V3 patch set.
2. Update ST-Ericsson thermal driver due to review com
From: "hongbo.zhang"
This diver is based on the thermal management framework in thermal_sys.c. A
thermal zone device is created with the trip points to which cooling devices
can be bound, the current cooling device is cpufreq, e.g. CPU frequency is
clipped down to cool the CPU, and other cooling
On Friday, October 26, 2012 06:05:21 PM Viresh Kumar wrote:
> __cpufreq_driver_target() must not pass target frequency beyond the limits of
> current policy.
>
> Today most of cpufreq platform drivers are doing this check in their target
> routines. Why not move it to __cpufreq_driver_target().
>
On Monday, October 29, 2012 03:48:40 PM Daniel Lezcano wrote:
> The "struct device" is only used in sysfs.c.
>
> The other .c files including the private header "cpuidle.h"
> do not need to pull the entire headers tree from there as they
> don't manipulate the "struct device".
>
> This patch fix
On Friday, October 26, 2012 01:17:12 PM Rafael J. Wysocki wrote:
> On Friday, October 26, 2012 03:06:26 PM Viresh Kumar wrote:
> > Avoid calling cpufreq driver's target() routine if new frequency is same as
> > policies current frequency.
> >
> > Signed-off-by: Viresh Kumar
>
> Looks reasonable.
On Thursday, October 25, 2012 01:46:17 PM Daniel Lezcano wrote:
> The structure cpuidle_state_kobj is not used anywhere except
> in the sysfs.c file. The definition of this structure is not
> needed in the cpuidle header file. This patch moves it to the
> sysfs.c file in order to encapsulate the co
On Tue, Oct 30, 2012 at 10:18 PM, hongbo.zhang wrote:
> From: "hongbo.zhang"
>
> V2->V3 Changes:
>
> 2. Update ST-Ericsson thermal driver due to review comments from Viresh Kumar
> and Francesco Lavra.
You expect people, who want to know what has changed, to go and check our
comments? That never
On Tue, Oct 30, 2012 at 10:19 PM, hongbo.zhang wrote:
> From: "hongbo.zhang"
Just a minor comment below.
> This patch adds device tree properties for ST-Ericsson DB8500 thermal driver,
> also adds the platform data to support the old fashion.
>
> Signed-off-by: hongbo.zhang
Reviewed-by: Vires
Sorry for late comments :(
On 30 October 2012 22:19, hongbo.zhang wrote:
> From: "hongbo.zhang"
>
> This diver is based on the thermal management framework in thermal_sys.c. A
s/diver/driver
> thermal zone device is created with the trip points to which cooling devices
> can be bound, the curr
24 matches
Mail list logo
