Re: [RFC 2/6] sched: add a new SD SHARE_POWERLINE flag for sched_domain

2012-10-29 Thread Vincent Guittot
On 24 October 2012 17:17, Santosh Shilimkar wrote: > Vincent, > > Few comments/questions. > > > On Sunday 07 October 2012 01:13 PM, Vincent Guittot wrote: >> >> This new flag SD SHARE_POWERLINE reflects the sharing of the power rail >> between the members of a domain. As this is the current assump

Re: [RFC 2/6] sched: add a new SD SHARE_POWERLINE flag for sched_domain

2012-10-29 Thread Vincent Guittot
It looks like i need to describe more what On 29 October 2012 10:40, Vincent Guittot wrote: > On 24 October 2012 17:17, Santosh Shilimkar wrote: >> Vincent, >> >> Few comments/questions. >> >> >> On Sunday 07 October 2012 01:13 PM, Vincent Guittot wrote: >>> >>> This new flag SD SHARE_POWERLINE

Re: [PATCH V2 2/6] Thermal: make sure cpufreq cooling register after cpufreq driver

2012-10-29 Thread Amit Kachhap
On 24 October 2012 17:28, hongbo.zhang wrote: > From: "hongbo.zhang" > > The cpufreq works as a cooling device, so the cooling layer should check if > the > cpufreq driver is initialized or not. > > Signed-off-by: hongbo.zhang > --- > drivers/thermal/cpu_cooling.c | 4 > 1 file changed, 4

Re: [PATCH V2 3/6] Thermal: fix bug of counting cpu frequencies.

2012-10-29 Thread Amit Kachhap
On 24 October 2012 19:04, Viresh Kumar wrote: > On 24 October 2012 17:28, hongbo.zhang wrote: >> From: "hongbo.zhang" >> >> In the while loop for counting cpu frequencies, if table[i].frequency equals >> CPUFREQ_ENTRY_INVALID, index i won't be increased, so this leads to an >> endless >> loop,

Re: [RFC 3/6] sched: pack small tasks

2012-10-29 Thread Vincent Guittot
On 24 October 2012 17:20, Santosh Shilimkar wrote: > Vincent, > > Few comments/questions. > > > On Sunday 07 October 2012 01:13 PM, Vincent Guittot wrote: >> >> During sched_domain creation, we define a pack buddy CPU if available. >> >> On a system that share the powerline at all level, the buddy

Re: [RFC 4/6] sched: secure access to other CPU statistics

2012-10-29 Thread Vincent Guittot
On 24 October 2012 17:21, Santosh Shilimkar wrote: > $subject is bit confusing here. > > > On Sunday 07 October 2012 01:13 PM, Vincent Guittot wrote: >> >> The atomic update of runnable_avg_sum and runnable_avg_period are ensured >> by their size and the toolchain. But we must ensure to not read a

Re: [RFC 5/6] sched: pack the idle load balance

2012-10-29 Thread Vincent Guittot
On 24 October 2012 17:21, Santosh Shilimkar wrote: > On Sunday 07 October 2012 01:13 PM, Vincent Guittot wrote: >> >> Look for an idle CPU close the pack buddy CPU whenever possible. > > s/close/close to yes > >> The goal is to prevent the wake up of a CPU which doesn't share the power >> line o

Re: [RFC 6/6] ARM: sched: clear SD_SHARE_POWERLINE

2012-10-29 Thread Vincent Guittot
On 24 October 2012 17:21, Santosh Shilimkar wrote: > On Sunday 07 October 2012 01:13 PM, Vincent Guittot wrote: >> >> The ARM platforms take advantage of packing small tasks on few cores. >> This is true even when the cores of a cluster can't be powergated >> independently. >> >> >> Signed-off-by:

[PATCH] cpuidle : fixup device.h header in cpuidle.h

2012-10-29 Thread Daniel Lezcano
The "struct device" is only used in sysfs.c. The other .c files including the private header "cpuidle.h" do not need to pull the entire headers tree from there as they don't manipulate the "struct device". This patch fix this by moving the header inclusion to sysfs.c and adding a forward declarat

[PATCH] ARM: mm: uninitialized warning corrections

2012-10-29 Thread Viresh Kumar
The variables here are really not used uninitialized. arch/arm/mm/alignment.c: In function 'do_alignment': arch/arm/mm/alignment.c:327:15: warning: 'offset.un' may be used uninitialized in this function [-Wmaybe-uninitialized] arch/arm/mm/alignment.c:748:21: note: 'offset.un' was declared here S

[PATCH] net: dsa/slave: Fix compilation warnings

2012-10-29 Thread Viresh Kumar
Currently when none of CONFIG_NET_DSA_TAG_DSA, CONFIG_NET_DSA_TAG_EDSA and CONFIG_NET_DSA_TAG_TRAILER is defined, we get following compilation warnings: net/dsa/slave.c:51:12: warning: 'dsa_slave_init' defined but not used [-Wunused-function] net/dsa/slave.c:60:12: warning: 'dsa_slave_open' defin

[PATCH] mtd: map: Fix compilation warning

2012-10-29 Thread Viresh Kumar
This patch is an attempt to fix following compilation warning. In file included from drivers/mtd/chips/cfi_cmdset_0001.c:35:0: drivers/mtd/chips/cfi_cmdset_0001.c: In function 'cfi_intelext_write_words': include/linux/mtd/map.h:331:11: warning: 'r.x[0]' may be used uninitialized in this function

Re: [PATCH] net: dsa/slave: Fix compilation warnings

2012-10-29 Thread Ben Hutchings
On Mon, 2012-10-29 at 22:27 +0530, Viresh Kumar wrote: > Currently when none of CONFIG_NET_DSA_TAG_DSA, CONFIG_NET_DSA_TAG_EDSA and > CONFIG_NET_DSA_TAG_TRAILER is defined, we get following compilation warnings: > > net/dsa/slave.c:51:12: warning: 'dsa_slave_init' defined but not used > [-Wunused

Re: [PATCH] net: dsa/slave: Fix compilation warnings

2012-10-29 Thread Viresh Kumar
On 30 October 2012 01:29, Ben Hutchings wrote: > On Mon, 2012-10-29 at 22:27 +0530, Viresh Kumar wrote: >> Currently when none of CONFIG_NET_DSA_TAG_DSA, CONFIG_NET_DSA_TAG_EDSA and >> CONFIG_NET_DSA_TAG_TRAILER is defined, we get following compilation warnings: >> >> net/dsa/slave.c:51:12: warnin