On 23 October 2012 02:51, Francesco Lavra wrote:
> On 10/22/2012 02:02 PM, Hongbo Zhang wrote:
> [...]
+static irqreturn_t prcmu_low_irq_handler(int irq, void *irq_data)
+{
+ struct db8500_thermal_zone *pzone = irq_data;
+ struct db8500_thsens_platform_data *ptrips;
>>>
On 10/22/2012 02:02 PM, Hongbo Zhang wrote:
[...]
>>> +static irqreturn_t prcmu_low_irq_handler(int irq, void *irq_data)
>>> +{
>>> + struct db8500_thermal_zone *pzone = irq_data;
>>> + struct db8500_thsens_platform_data *ptrips;
>>> + unsigned long next_low, next_high;
>>> + unsign
On 21 October 2012 23:01, Francesco Lavra wrote:
> Hi Hongbo,
Hi Francesco,
Thanks for your review, I will accept all the comments except the ones
I have some comments under them.
>
> On 10/16/2012 01:44 PM, hongbo.zhang wrote:
>> From: "hongbo.zhang"
>>
>> This diver is based on the thermal man
Hi Hongbo,
On 10/16/2012 01:44 PM, hongbo.zhang wrote:
> From: "hongbo.zhang"
>
> This diver is based on the thermal management framework in thermal_sys.c.
> A thermal zone device is created with the trip points to which cooling
> devices can be bound, the current cooling device is cpufreq, e.g.
On Wed, Oct 17, 2012 at 8:53 PM, Viresh Kumar wrote:
> On 16 October 2012 17:14, hongbo.zhang wrote:
>> +static int __devinit db8500_cpufreq_cooling_probe(struct platform_device
>> *pdev)
>> +{
>> + struct db8500_cpufreq_cdev *cooling_devs;
Hi Hongbo,
I saw somebody saying this in anoth
On 18 October 2012 16:07, Viresh Kumar wrote:
> On 18 October 2012 13:05, Hongbo Zhang wrote:
>> On 17 October 2012 23:23, Viresh Kumar wrote:
>>> On 16 October 2012 17:14, hongbo.zhang wrote:
>
+static struct db8500_trip_point db8500_trips_table[] = {
+ [0] = {
+
On 18 October 2012 13:05, Hongbo Zhang wrote:
> On 17 October 2012 23:23, Viresh Kumar wrote:
>> On 16 October 2012 17:14, hongbo.zhang wrote:
>>> +static struct db8500_trip_point db8500_trips_table[] = {
>>> + [0] = {
>>> + .temp = 7,
>>> + .type = THERMAL
Viresh, thanks a lot for all of your comments.
I accept them _by_default_ if no comment from me under them.
On 17 October 2012 23:23, Viresh Kumar wrote:
> On 16 October 2012 17:14, hongbo.zhang wrote:
>> From: "hongbo.zhang"
>>
>> This diver is based on the thermal management framework in ther
On Wed, 2012-10-17 at 20:53 +0530, Viresh Kumar wrote:
> On 16 October 2012 17:14, hongbo.zhang wrote:
[]
> > diff --git a/drivers/thermal/db8500_cpufreq_cooling.c
> > b/drivers/thermal/db8500_cpufreq_cooling.c
[]
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#in
On 17 October 2012 22:28, Joe Perches wrote:
>> > +#include
>> > +#include
>> > +#include
>> > +#include
>> > +#include
>> > +#include
>>
>> should be in alphabetical order
>
> There's no agreed kernel convention here.
> Some prefer christmas tree (shortest to longest length)
:)
I have see
On 16 October 2012 17:14, hongbo.zhang wrote:
> From: "hongbo.zhang"
>
> This diver is based on the thermal management framework in thermal_sys.c.
> A thermal zone device is created with the trip points to which cooling
> devices can be bound, the current cooling device is cpufreq, e.g. CPU
> fre
11 matches
Mail list logo