On 17 October 2012 22:28, Joe Perches <j...@perches.com> wrote: >> > +#include <linux/slab.h> >> > +#include <linux/module.h> >> > +#include <linux/platform_device.h> >> > +#include <linux/cpufreq.h> >> > +#include <linux/cpu_cooling.h> >> > +#include <linux/err.h> >> >> should be in alphabetical order > > There's no agreed kernel convention here. > Some prefer christmas tree (shortest to longest length)
:) I have seen a number of times this happening, because the list isn't in alphabetical order people aren't able to easily read if an #include ... is already there or not. And so one header file is included multiple times. Because git diff only shows few lines above and below a change, even people can't catch it in reviews. That's why they must always be in alphabetical order. -- viresh _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
