Re: [U-Boot] [PATCH v7 4/4] EXYNOS: SMDK5250: Add MMC SPL support

2012-02-09 Thread Mike Frysinger
On Wednesday 08 February 2012 18:35:28 Doug Anderson wrote: > On Thu, Feb 2, 2012 at 1:21 PM, Mike Frysinger wrote: > > On Thursday 02 February 2012 04:11:27 Chander Kashyap wrote: > > > +int main(int argc, char **argv) > > > +{ > > > ... > > > + unsigned char buffer[BUFSIZE] = {0}; > > > > th

Re: [Samsung] [U-Boot] [PATCH v7 4/4] EXYNOS: SMDK5250: Add MMC SPL support

2012-02-09 Thread Mike Frysinger
On Thursday 09 February 2012 00:25:35 Chander Kashyap wrote: > On 9 February 2012 09:21, Mike Frysinger wrote: > > On Wednesday 08 February 2012 18:35:28 Doug Anderson wrote: > >> On Thu, Feb 2, 2012 at 1:21 PM, Mike Frysinger wrote: > >> > On Thursday 02 February 2012 04:11:27 Chander Kashyap wrot

Re: [U-Boot] [PATCH v7 4/4] EXYNOS: SMDK5250: Add MMC SPL support

2012-02-09 Thread Doug Anderson
On Thu, Feb 2, 2012 at 1:21 PM, Mike Frysinger wrote: > On Thursday 02 February 2012 04:11:27 Chander Kashyap wrote: > > +int main(int argc, char **argv) > > +{ > > ... > > + unsigned char buffer[BUFSIZE] = {0}; > > this is an implicit memset() and from what i can see in the code, useless. >

Re: [Samsung] [U-Boot] [PATCH v7 4/4] EXYNOS: SMDK5250: Add MMC SPL support

2012-02-08 Thread Chander Kashyap
On 9 February 2012 09:21, Mike Frysinger wrote: > On Wednesday 08 February 2012 18:35:28 Doug Anderson wrote: >> On Thu, Feb 2, 2012 at 1:21 PM, Mike Frysinger wrote: >> > On Thursday 02 February 2012 04:11:27 Chander Kashyap wrote: >> > > +int main(int argc, char **argv) >> > > +{ >> > > ... >> >

Re: [U-Boot] [PATCH v7 4/4] EXYNOS: SMDK5250: Add MMC SPL support

2012-02-03 Thread Chander Kashyap
Hi Mike, On 3 February 2012 02:51, Mike Frysinger wrote: > On Thursday 02 February 2012 04:11:27 Chander Kashyap wrote: >> --- /dev/null >> +++ b/board/samsung/smdk5250/tools/mkexynos_image.c > > tools should be in tools/.  there are already plenty of examples in there (see > tools/msxboot.c as t

Re: [U-Boot] [PATCH v7 4/4] EXYNOS: SMDK5250: Add MMC SPL support

2012-02-02 Thread Mike Frysinger
On Thursday 02 February 2012 04:11:27 Chander Kashyap wrote: > --- /dev/null > +++ b/board/samsung/smdk5250/tools/mkexynos_image.c tools should be in tools/. there are already plenty of examples in there (see tools/msxboot.c as the first example i found by reading tools/Makefile). > +int main(i