Re: [PATCH v9 2/3] mmc: core: add random fault injection

2011-09-14 Thread Per Forlin
On 14 September 2011 10:04, Akinobu Mita wrote: > 2011/9/14 Per Forlin : > >> It's simple and the patch would be just two lines. >> The reason for changing my mind is that it may be useful to be able to >> pass the fault injection attributes even when mmc_core is a module. >> >>> module_param is m

Re: [PATCH v9 2/3] mmc: core: add random fault injection

2011-09-14 Thread Akinobu Mita
2011/9/14 Per Forlin : > It's simple and the patch would be just two lines. > The reason for changing my mind is that it may be useful to be able to > pass the fault injection attributes even when mmc_core is a module. > >> module_param is more complicated than this. Also the parameter is only >>

Re: [PATCH v9 2/3] mmc: core: add random fault injection

2011-09-13 Thread Per Forlin
On 14 September 2011 01:37, Akinobu Mita wrote: > 2011/9/14 Per Forlin : >> Hi Akinobu, >> >> On 13 September 2011 16:19, Per Forlin wrote: >>> On 13 September 2011 15:12, Akinobu Mita wrote: 2011/8/19 Per Forlin : > +#ifdef KERNEL > +/* > + * Internal function. Pass the bo

Re: [PATCH v9 2/3] mmc: core: add random fault injection

2011-09-13 Thread Akinobu Mita
2011/9/14 Per Forlin : > Hi Akinobu, > > On 13 September 2011 16:19, Per Forlin wrote: >> On 13 September 2011 15:12, Akinobu Mita wrote: >>> 2011/8/19 Per Forlin : >>> +#ifdef KERNEL +/* + * Internal function. Pass the boot param fail_mmc_request to + * the setup fault inject

Re: [PATCH v9 2/3] mmc: core: add random fault injection

2011-09-13 Thread Per Forlin
Hi Akinobu, On 13 September 2011 16:19, Per Forlin wrote: > On 13 September 2011 15:12, Akinobu Mita wrote: >> 2011/8/19 Per Forlin : >> >>> +#ifdef KERNEL >>> +/* >>> + * Internal function. Pass the boot param fail_mmc_request to >>> + * the setup fault injection attributes routine. >>> + */ >>

Re: [PATCH v9 2/3] mmc: core: add random fault injection

2011-09-13 Thread Per Forlin
On 13 September 2011 15:12, Akinobu Mita wrote: > 2011/8/19 Per Forlin : > >> +#ifdef KERNEL >> +/* >> + * Internal function. Pass the boot param fail_mmc_request to >> + * the setup fault injection attributes routine. >> + */ >> +static int __init setup_fail_mmc_request(char *str) >> +{ >> +    

Re: [PATCH v9 2/3] mmc: core: add random fault injection

2011-09-13 Thread Akinobu Mita
2011/8/19 Per Forlin : > +#ifdef KERNEL > +/* > + * Internal function. Pass the boot param fail_mmc_request to > + * the setup fault injection attributes routine. > + */ > +static int __init setup_fail_mmc_request(char *str) > +{ > +       return setup_fault_attr(&fail_mmc_request, str); > +} > +_

Re: [PATCH v9 2/3] mmc: core: add random fault injection

2011-08-19 Thread Linus Walleij
2011/8/19 Per Forlin : > From: Per Forlin > > This adds support to inject data errors after a completed host transfer. > The mmc core will return error even though the host transfer is successful. > This simple fault injection proved to be very useful to test the > non-blocking error handling in

[PATCH v9 2/3] mmc: core: add random fault injection

2011-08-19 Thread Per Forlin
From: Per Forlin This adds support to inject data errors after a completed host transfer. The mmc core will return error even though the host transfer is successful. This simple fault injection proved to be very useful to test the non-blocking error handling in the mmc_blk_issue_rw_rq(). Random f