On 14 September 2011 10:04, Akinobu Mita <akinobu.m...@gmail.com> wrote: > 2011/9/14 Per Forlin <per.for...@linaro.org>: > >> It's simple and the patch would be just two lines. >> The reason for changing my mind is that it may be useful to be able to >> pass the fault injection attributes even when mmc_core is a module. >> >>> module_param is more complicated than this. Also the parameter is only >>> usefull when when mmc_core is built into the kernel (it's useless when >>> mmc_core is built as a module). >>> >> If you want to enable fault injection for the mmc_core module at load >> time (during mmc initialisation) the param must be used. >> modprobe mmc_core fail_request=1,1,1,1 >> As soon as the module is loaded there is no need for the module param >> anymore. > > OK, I agree with you. The module parameter is the only way > to enable mmc fault injection if CONFIG_FAULT_INJECTION_DEBUG_FS > is disabled. > This is true as well. My point is that if using CONFIG_FAULT_INJECTION_DEBUG_FS the fault attributes can't be set until after the mmc module initialisation. One may want to test the error handling during the mmc initialisation. I'll send out a version v2 using module_param_cb().
Thanks again, Per _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
