Re: [PATCH V2] ARM: EXYNOS4: Add machine support for 7" LCD on ORIGEN

2011-09-14 Thread Tushar Behera
Hi Kukjin, On Thursday 15 September 2011 10:24 AM, Kukjin Kim wrote: Tushar Behera wrote: Hi Fabio, On Wednesday 14 September 2011 05:06 PM, Fabio Estevam wrote: On Wed, Sep 14, 2011 at 8:01 AM, Tushar Behera wrote: ... +static void lcd_hv070wsa_set_power(struct plat_lcd_data *pd, unsigne

RE: [PATCH V2] ARM: EXYNOS4: Add machine support for 7" LCD on ORIGEN

2011-09-14 Thread Kukjin Kim
Tushar Behera wrote: > > Hi Fabio, > > On Wednesday 14 September 2011 05:06 PM, Fabio Estevam wrote: > > On Wed, Sep 14, 2011 at 8:01 AM, Tushar Behera > wrote: > > ... > >> +static void lcd_hv070wsa_set_power(struct plat_lcd_data *pd, unsigned int > power) > >> +{ > >> + int gpio = EXYNOS4

RE: [PATCH V2] ARM: EXYNOS4: Add machine support for 7" LCD on ORIGEN

2011-09-14 Thread Kukjin Kim
Tushar Behera wrote: > > ORIGEN board is fitted with 7" LCD panel HV070WSA. The pixel > resolution of the LCD panel is 1024x600. > > Also power domain device for LCD0 is registered. > > Signed-off-by: Tushar Behera > --- > Changes for V2: > * Added power domain device registration for LCD

Re: [PATCH V2] ARM: EXYNOS4: Add machine support for 7" LCD on ORIGEN

2011-09-14 Thread Tushar Behera
Hi Fabio Estevam, On Wednesday 14 September 2011 06:09 PM, Fabio Estevam wrote: On Wed, Sep 14, 2011 at 9:07 AM, Tushar Behera wrote: ... Will this be better? static void lcd_hv070wsa_set_power(struct plat_lcd_data *pd, \ unsigned int power) {

Re: [PATCH V2] ARM: EXYNOS4: Add machine support for 7" LCD on ORIGEN

2011-09-14 Thread Fabio Estevam
On Wed, Sep 14, 2011 at 9:07 AM, Tushar Behera wrote: ... > Will this be better? > > static void lcd_hv070wsa_set_power(struct plat_lcd_data *pd, \ >                                        unsigned int power) > { >        int ret; >        unsigned long flag = power ? GPIOF_OUT_INIT_HIGH : \ >  

Re: [PATCH V2] ARM: EXYNOS4: Add machine support for 7" LCD on ORIGEN

2011-09-14 Thread Tushar Behera
Hi Fabio, On Wednesday 14 September 2011 05:06 PM, Fabio Estevam wrote: On Wed, Sep 14, 2011 at 8:01 AM, Tushar Behera wrote: ... +static void lcd_hv070wsa_set_power(struct plat_lcd_data *pd, unsigned int power) +{ + int gpio = EXYNOS4_GPE3(4); + + gpio_request(gpio, "GPE3_4"); +

Re: [PATCH V2] ARM: EXYNOS4: Add machine support for 7" LCD on ORIGEN

2011-09-14 Thread Fabio Estevam
On Wed, Sep 14, 2011 at 8:01 AM, Tushar Behera wrote: ... > +static void lcd_hv070wsa_set_power(struct plat_lcd_data *pd, unsigned int > power) > +{ > +       int gpio = EXYNOS4_GPE3(4); > + > +       gpio_request(gpio, "GPE3_4"); > +       gpio_direction_output(gpio, power); You should check fo

[PATCH V2] ARM: EXYNOS4: Add machine support for 7" LCD on ORIGEN

2011-09-14 Thread Tushar Behera
ORIGEN board is fitted with 7" LCD panel HV070WSA. The pixel resolution of the LCD panel is 1024x600. Also power domain device for LCD0 is registered. Signed-off-by: Tushar Behera --- Changes for V2: * Added power domain device registration for LCD0 The patch is rebased on [1]. For prop