Hi Fabio,

On Wednesday 14 September 2011 05:06 PM, Fabio Estevam wrote:
On Wed, Sep 14, 2011 at 8:01 AM, Tushar Behera<tushar.beh...@linaro.org>  wrote:
...
+static void lcd_hv070wsa_set_power(struct plat_lcd_data *pd, unsigned int 
power)
+{
+       int gpio = EXYNOS4_GPE3(4);
+
+       gpio_request(gpio, "GPE3_4");
+       gpio_direction_output(gpio, power);

You should check for returned errors for these functions.

Ok.

Will this be better?

static void lcd_hv070wsa_set_power(struct plat_lcd_data *pd, \
                                        unsigned int power)
{
        int ret;
        unsigned long flag = power ? GPIOF_OUT_INIT_HIGH : \
                                        GPIOF_OUT_INIT_LOW;

        ret = gpio_request_one(EXYNOS4_GPE3(4), flag, "GPE3_4");

        if (ret)
                printk(KERN_ERR "Could not request gpio for LCD power");
}

Regards,

Fabio Estevam


--
Tushar Behera

_______________________________________________
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev

Reply via email to