Re: [PATCH 3/4] cpuidle: move enter_dead to the driver structure

2012-07-06 Thread Rafael J. Wysocki
On Friday, July 06, 2012, Daniel Lezcano wrote: > On 07/05/2012 10:40 PM, Rafael J. Wysocki wrote: > > On Thursday, July 05, 2012, Daniel Lezcano wrote: > >> The 'enter_dead' function is only used for processor_idle.c > >> and the same function is used several times. We fall into the > >> same abus

Re: [PATCH 3/4] cpuidle: move enter_dead to the driver structure

2012-07-06 Thread Daniel Lezcano
On 07/05/2012 10:40 PM, Rafael J. Wysocki wrote: > On Thursday, July 05, 2012, Daniel Lezcano wrote: >> The 'enter_dead' function is only used for processor_idle.c >> and the same function is used several times. We fall into the >> same abuse with the multiple callbacks for the same function. > >

Re: [PATCH 3/4] cpuidle: move enter_dead to the driver structure

2012-07-06 Thread Rafael J. Wysocki
On Thursday, July 05, 2012, Daniel Lezcano wrote: > The 'enter_dead' function is only used for processor_idle.c > and the same function is used several times. We fall into the > same abuse with the multiple callbacks for the same function. This isn't abuse, mind you. This is a normal practice. >

[PATCH 3/4] cpuidle: move enter_dead to the driver structure

2012-07-05 Thread Daniel Lezcano
The 'enter_dead' function is only used for processor_idle.c and the same function is used several times. We fall into the same abuse with the multiple callbacks for the same function. This patch fixes that by moving the 'enter_dead' function to the driver structure. A flag CPUIDLE_FLAG_DEAD_VALID