Re: [PATCH] merge_config.sh: Add option to specify output dir

2012-12-10 Thread Andrey Konovalov
On 12/10/2012 06:51 PM, Zhangfei Gao wrote: On 10 December 2012 01:22, Michal Marek mailto:mma...@suse.cz>> wrote: On Mon, Dec 03, 2012 at 09:05:26AM -0800, John Stultz wrote: > On 12/02/2012 11:36 PM, Zhangfei Gao wrote: >> Provide a -O option to specify dir to put generated .c

Re: [PATCH] merge_config.sh: Add option to specify output dir

2012-12-10 Thread Zhangfei Gao
On 10 December 2012 01:22, Michal Marek wrote: > On Mon, Dec 03, 2012 at 09:05:26AM -0800, John Stultz wrote: > > On 12/02/2012 11:36 PM, Zhangfei Gao wrote: > >> Provide a -O option to specify dir to put generated .config > >> Then merge_config.sh does not need to be copied to target dir, > >> f

Re: [PATCH] merge_config.sh: Add option to specify output dir

2012-12-09 Thread Michal Marek
On Mon, Dec 03, 2012 at 09:05:26AM -0800, John Stultz wrote: > On 12/02/2012 11:36 PM, Zhangfei Gao wrote: >> Provide a -O option to specify dir to put generated .config >> Then merge_config.sh does not need to be copied to target dir, >> for easy re-usage in other script >> >> Signed-off-by: Zhang

Re: [PATCH] merge_config.sh: Add option to specify output dir

2012-12-03 Thread John Stultz
On 12/02/2012 11:36 PM, Zhangfei Gao wrote: Provide a -O option to specify dir to put generated .config Then merge_config.sh does not need to be copied to target dir, for easy re-usage in other script Signed-off-by: Zhangfei Gao Tested-by: Jon Medhurst (Tixy) Acked-by: John Stultz thanks -j

[PATCH] merge_config.sh: Add option to specify output dir

2012-12-02 Thread Zhangfei Gao
Provide a -O option to specify dir to put generated .config Then merge_config.sh does not need to be copied to target dir, for easy re-usage in other script Signed-off-by: Zhangfei Gao Tested-by: Jon Medhurst (Tixy) --- scripts/kconfig/merge_config.sh | 20 1 file changed

Re: [PATCH] merge_config.sh: Add option to specify output dir

2012-11-29 Thread zhangfei
On 12-11-30 11:13 AM, John Stultz wrote: On 11/29/2012 06:04 PM, Zhangfei Gao wrote: Provide a -O option to specify dir to put generated .config This looks ok to me, although you might want to add some extra details in the commit log as to why this is useful. Thanks John for the quick revie

Re: [PATCH] merge_config.sh: Add option to specify output dir

2012-11-29 Thread John Stultz
On 11/29/2012 06:04 PM, Zhangfei Gao wrote: Provide a -O option to specify dir to put generated .config This looks ok to me, although you might want to add some extra details in the commit log as to why this is useful. And one minor nit below. thanks -john @@ -100,7 +112,7 @@ for MERGE_FI

[PATCH] merge_config.sh: Add option to specify output dir

2012-11-29 Thread Zhangfei Gao
Provide a -O option to specify dir to put generated .config Signed-off-by: Zhangfei Gao Tested-by: Jon Medhurst (Tixy) --- scripts/kconfig/merge_config.sh | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/