On 11/29/2012 06:04 PM, Zhangfei Gao wrote:
Provide a -O option to specify dir to put generated .config

This looks ok to me, although you might want to add some extra details in the commit log as to why this is useful.

And one minor nit below.

thanks
-john

@@ -100,7 +112,7 @@ for MERGE_FILE in $MERGE_LIST ; do
  done

  if [ "$MAKE" = "false" ]; then
-       cp $TMP_FILE .config
+       cp $TMP_FILE $OUTPUT/.config
        echo "#"
        echo "# merged configuration written to .config (needs make)"
Should this echo have $output/.config?

thanks
-john


_______________________________________________
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev

Reply via email to